scss-lint 0.12.0 → 0.12.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5efc8809d431b7de019112e2771839116d88df95
-  data.tar.gz: d54b6ba942585c4fbdc969c389af86e0da47088c
+  metadata.gz: 1649ab811a945a99099b9d000b14059532b28365
+  data.tar.gz: fae32ee4b1704070dd7a84f3a4b2a1e353d0c0ad
 SHA512:
-  metadata.gz: 406a4cd62baa39e5dc561c5cd84cedc7ef7b4d64a0b8813a693c22fb3192640f0382b3a839f317fdbe0f75738c6ed53b3f494bd5e9c32ed50f79833841e76f43
-  data.tar.gz: e0c8b74d3cf6bb80f592cfacc9ed25fe642b397e36ca9e965ee31a4889a8291ea2b88334aba45aae0c4eaf5cf52c610150bf6bc0b2ecd5b6af92aa4547ea21b5
+  metadata.gz: cbb264e07bd5c093f54bcd5dad3ff02e990441a734684bee27dbdf1404ea71e7b14d0234bf551ad48bc2ba050478b5fc9ee1feed028a55e01e1d9a08970b8d28
+  data.tar.gz: 9334e0f4b9bedfcdcfb02edb653fbd0d3136986815647047ca19b1607f5f569398473feb7efead4d62d19efb942bfe0b161440a48d2b184f43c74c2b370a4bd2

data/lib/scss_lint.rb

@@ -1,52 +1,27 @@
-require 'find'
-
-module SCSSLint
-  autoload :CLI, 'scss_lint/cli'
-  autoload :Engine, 'scss_lint/engine'
-  autoload :Lint, 'scss_lint/lint'
-  autoload :LinterRegistry, 'scss_lint/linter_registry'
-  autoload :Linter, 'scss_lint/linter'
-  autoload :Reporter, 'scss_lint/reporter'
-  autoload :Runner, 'scss_lint/runner'
-  autoload :SelectorVisitor, 'scss_lint/selector_visitor'
-  autoload :Utils, 'scss_lint/utils'
-
-  require 'scss_lint/constants'
-  require 'scss_lint/version'
-
-  # Preload Sass so we can monkey patch it
-  require 'sass'
-  require File.expand_path('scss_lint/sass/script', File.dirname(__FILE__))
-  require File.expand_path('scss_lint/sass/tree', File.dirname(__FILE__))
-
-  # Load all linters
-  Dir[File.expand_path('scss_lint/linter/*.rb', File.dirname(__FILE__))].each do |file|
-    require file
-  end
-
-  # Load all reporters
-  Dir[File.expand_path('scss_lint/reporter/*.rb', File.dirname(__FILE__))].each do |file|
-    require file
-  end
-
-  class << self
-    def extract_files_from(list)
-      files = []
-      list.each do |file|
-        Find.find(file) do |f|
-          files << f if scssish_file?(f)
-        end
-      end
-      files.uniq
-    end
-
-  private
-
-    VALID_EXTENSIONS = %w[.css .scss]
-    def scssish_file?(file)
-      return false unless FileTest.file?(file)
+require 'scss_lint/constants'
+require 'scss_lint/cli'
+require 'scss_lint/engine'
+require 'scss_lint/lint'
+require 'scss_lint/linter_registry'
+require 'scss_lint/runner'
+require 'scss_lint/selector_visitor'
+require 'scss_lint/version'
+require 'scss_lint/utils'
+
+# Preload Sass so we can monkey patch it
+require 'sass'
+require File.expand_path('scss_lint/sass/script', File.dirname(__FILE__))
+require File.expand_path('scss_lint/sass/tree', File.dirname(__FILE__))
+
+# Load all linters in sorted order, since ordering matters and some systems
+# return the files in an order which loads a child class before the parent.
+require 'scss_lint/linter'
+Dir[File.expand_path('scss_lint/linter/**/*.rb', File.dirname(__FILE__))].sort.each do |file|
+  require file
+end
 
-      VALID_EXTENSIONS.include?(File.extname(file))
-    end
-  end
+# Load all reporters
+require 'scss_lint/reporter'
+Dir[File.expand_path('scss_lint/reporter/*.rb', File.dirname(__FILE__))].sort.each do |file|
+  require file
 end

data/lib/scss_lint/cli.rb

@@ -1,3 +1,4 @@
+require 'find'
 require 'optparse'
 
 module SCSSLint
@@ -80,11 +81,28 @@ module SCSSLint
     def find_files
       excluded_files = options.fetch(:excluded_files, [])
 
-      SCSSLint.extract_files_from(options[:files]).reject do |file|
+      extract_files_from(options[:files]).reject do |file|
         excluded_files.include?(file)
       end
     end
 
+    def extract_files_from(list)
+      files = []
+      list.each do |file|
+        Find.find(file) do |f|
+          files << f if scssish_file?(f)
+        end
+      end
+      files.uniq
+    end
+
+    VALID_EXTENSIONS = %w[.css .scss]
+    def scssish_file?(file)
+      return false unless FileTest.file?(file)
+
+      VALID_EXTENSIONS.include?(File.extname(file))
+    end
+
     def report_lints(lints)
       sorted_lints = lints.sort_by { |l| [l.filename, l.line] }
       reporter = options.fetch(:reporter, Reporter::DefaultReporter).new(sorted_lints)

data/lib/scss_lint/linter/compass.rb

@@ -0,0 +1,7 @@
+module SCSSLint
+  # Superclass for linters that apply to codebases using the Compass framework.
+  #
+  # Any shared code/constants amongst Compass linters should be stored here.
+  class Linter::Compass < Linter
+  end
+end

data/lib/scss_lint/linter/compass/property_with_mixin.rb

@@ -0,0 +1,28 @@
+module SCSSLint
+  # Checks for uses of properties where a Compass mixin would be preferred.
+  class Linter::Compass::PropertyWithMixin < Linter::Compass
+    include LinterRegistry
+
+    def visit_prop(node)
+      prop_name = node.name.join
+
+      if PROPERTIES_WITH_MIXINS.include?(prop_name)
+        add_lint node, "Use the Compass `#{prop_name}` mixin instead of the property"
+      end
+    end
+
+  private
+
+    # Set of properties where the Compass mixin version is preferred
+    PROPERTIES_WITH_MIXINS = %w[
+      background-clip
+      background-origin
+      border-radius
+      box-shadow
+      box-sizing
+      opacity
+      text-shadow
+      transform
+    ].to_set
+  end
+end

data/lib/scss_lint/linter/shorthand.rb

@@ -10,10 +10,7 @@ module SCSSLint
 
       case node.value
       when Sass::Script::Tree::Literal
-        # HACK: node_parent may not be initialized at this point, so we need to
-        # set it ourselves
-        node.value.value.node_parent = node.value
-        check_script_string(property_name, node.value.value)
+        check_script_literal(property_name, node.value)
       when Sass::Script::Tree::ListLiteral
         check_script_list(property_name, node.value)
       end
@@ -34,6 +31,18 @@ module SCSSLint
       check_shorthand(prop, list, list.children.map(&:to_sass))
     end
 
+    def check_script_literal(prop, literal)
+      value = literal.value
+
+      # HACK: node_parent may not be initialized at this point, so we need to
+      # set it ourselves
+      value.node_parent = literal
+
+      if value.is_a?(Sass::Script::Value::String)
+        check_script_string(prop, value)
+      end
+    end
+
     def check_script_string(prop, script_string)
       return unless script_string.type == :identifier
 

data/lib/scss_lint/runner.rb

@@ -49,7 +49,8 @@ module SCSSLint
           linter.run(engine)
         rescue => error
           raise LinterError,
-                "#{linter.class} raised unexpected error: '#{error.message}'",
+                "#{linter.class} raised unexpected error linting file #{file}: " <<
+                "'#{error.message}'",
                 error.backtrace
         end
       end

data/lib/scss_lint/version.rb

@@ -1,3 +1,3 @@
 module SCSSLint
-  VERSION = '0.12.0'
+  VERSION = '0.12.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scss-lint
 version: !ruby/object:Gem::Version
-  version: 0.12.0
+  version: 0.12.1
 platform: ruby
 authors:
 - Causes Engineering
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-04 00:00:00.000000000 Z
+date: 2013-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: colorize
@@ -88,6 +88,7 @@ files:
 - lib/scss_lint/selector_visitor.rb
 - lib/scss_lint/sass/tree.rb
 - lib/scss_lint/sass/script.rb
+- lib/scss_lint/linter/compass.rb
 - lib/scss_lint/linter/space_after_comma.rb
 - lib/scss_lint/linter/space_before_brace.rb
 - lib/scss_lint/linter/capitalization_in_selector.rb
@@ -100,6 +101,7 @@ files:
 - lib/scss_lint/linter/declaration_order.rb
 - lib/scss_lint/linter/zero_unit.rb
 - lib/scss_lint/linter/placeholder_in_extend.rb
+- lib/scss_lint/linter/compass/property_with_mixin.rb
 - lib/scss_lint/linter/space_after_property_name.rb
 - lib/scss_lint/linter/usage_name.rb
 - lib/scss_lint/linter/border_zero.rb