scriptorium 0.6.1 → 0.7.2

data/test/unit/post.rb

@@ -10,11 +10,26 @@ class TestScriptoriumPost < Minitest::Test
   include Scriptorium::Helpers
 
   def setup
-    @test_dir = "test/post_test_files"
-    make_dir(@test_dir)
-    @repo = Scriptorium::Repo.create("test/scriptorium-TEST", testmode: true)
+    @test_dir = "test/scriptorium-TEST"
+    # Clean up any existing test repository
+    FileUtils.rm_rf(@test_dir) if Dir.exist?(@test_dir)
+    
+    # Create API and use it to create repo
+    @api = Scriptorium::API.new(testmode: true)
+    @api.create_repo(@test_dir)
+    
+    # Keep @repo available for constructor tests
+    @repo = @api.repo
+    
+    # Create a basic Post object for constructor tests (no directories yet)
     @post = Scriptorium::Post.new(@repo, 1)
   end
+  
+  # Helper method for tests that need a real post with directories
+  def create_real_post
+    @api.create_view("test_view", "Test View", "A test view")
+    @api.create_post("Test Post", "Test body", views: "test_view")
+  end
 
   def teardown
     FileUtils.rm_rf(@test_dir) if Dir.exist?(@test_dir)
@@ -29,53 +44,56 @@ class TestScriptoriumPost < Minitest::Test
   end
 
   def test_002_initialize_with_nil_repo
-    assert_raises(CannotCreatePostRepoNil) do
+    assert_raises(PostRepoNil) do
       Scriptorium::Post.new(nil, 1)
     end
   end
 
   def test_003_initialize_with_nil_num
-    assert_raises(CannotCreatePostNumNil) do
+    assert_raises(PostNumNil) do
       Scriptorium::Post.new(@repo, nil)
     end
   end
 
   def test_004_initialize_with_empty_num
-    assert_raises(CannotCreatePostNumEmpty) do
+    assert_raises(PostNumEmpty) do
       Scriptorium::Post.new(@repo, "")
     end
   end
 
   def test_005_initialize_with_whitespace_num
-    assert_raises(CannotCreatePostNumEmpty) do
+    assert_raises(PostNumEmpty) do
       Scriptorium::Post.new(@repo, "   ")
     end
   end
 
   def test_006_initialize_with_invalid_num_format
-    assert_raises(CannotCreatePostNumInvalid) do
+    assert_raises(PostNumInvalid) do
       Scriptorium::Post.new(@repo, "abc")
     end
   end
 
   def test_007_initialize_with_negative_num
-    assert_raises(CannotCreatePostNumInvalid) do
+    assert_raises(PostNumInvalid) do
       Scriptorium::Post.new(@repo, -1)
     end
   end
 
   # Basic property tests
   def test_008_dir
+    create_real_post
     expected_dir = @repo.root/:posts/"0001"
     assert_equal expected_dir, @post.dir
   end
 
   def test_009_meta_file
+    create_real_post
     expected_file = @repo.root/:posts/"0001"/"meta.txt"
     assert_equal expected_file, @post.meta_file
   end
 
   def test_010_id
+    create_real_post
     assert_equal 1, @post.id
   end
 
@@ -98,11 +116,17 @@ class TestScriptoriumPost < Minitest::Test
 
   # Metadata tests
   def test_014_meta_without_file
+    # Create a real post for this test
+    create_real_post
+    # Clear the metadata file to test empty case
+    File.delete(@post.meta_file) if File.exist?(@post.meta_file)
     # When meta file doesn't exist, should return empty hash
     assert_equal({}, @post.meta)
   end
 
   def test_015_meta_with_file
+    # Create a real post for this test
+    create_real_post
     # Create a meta file
     meta_content = "post.title       Test Post\npost.blurb       Test blurb\npost.slug        test-post\npost.pubdate     2023-01-01 12:00:00"
     write_file(@post.meta_file, meta_content)
@@ -116,37 +140,44 @@ class TestScriptoriumPost < Minitest::Test
 
   # Individual metadata field tests
   def test_016_title
+    create_real_post
     write_file(@post.meta_file, "post.title       Test Post")
     assert_equal "Test Post", @post.title
   end
 
   def test_017_blurb
+    create_real_post
     write_file(@post.meta_file, "post.blurb       Test blurb")
     assert_equal "Test blurb", @post.blurb
   end
 
   def test_018_slug
+    create_real_post
     write_file(@post.meta_file, "post.slug        test-post")
     assert_equal "test-post", @post.slug
   end
 
   def test_019_pubdate
+    create_real_post
     write_file(@post.meta_file, "post.pubdate      2023-01-01 12:00:00")
     assert_equal "2023-01-01 12:00:00", @post.pubdate
   end
 
   def test_020_views
+    create_real_post
     write_file(@post.meta_file, "post.views       view1 view2")
     assert_equal "view1 view2", @post.views
   end
 
   def test_021_tags
+    create_real_post
     write_file(@post.meta_file, "post.tags        tag1,tag2")
     assert_equal "tag1,tag2", @post.tags
   end
 
   # set_pubdate tests
   def test_022_set_pubdate_with_valid_date
+    create_real_post
     Scriptorium::Repo.testing = true
     @post.set_pubdate("2023-01-15")
     
@@ -159,21 +190,21 @@ class TestScriptoriumPost < Minitest::Test
 
   def test_023_set_pubdate_with_nil_date
     Scriptorium::Repo.testing = true
-    assert_raises(CannotSetPubdateYmdNil) do
+    assert_raises(PubdateYmdNil) do
       @post.set_pubdate(nil)
     end
   end
 
   def test_024_set_pubdate_with_empty_date
     Scriptorium::Repo.testing = true
-    assert_raises(CannotSetPubdateYmdEmpty) do
+    assert_raises(PubdateYmdEmpty) do
       @post.set_pubdate("")
     end
   end
 
   def test_025_set_pubdate_with_invalid_format
     Scriptorium::Repo.testing = true
-    assert_raises(CannotSetPubdateInvalidFormat) do
+    assert_raises(PubdateInvalidFormat) do
       @post.set_pubdate("2023/01/15")
     end
   end
@@ -193,52 +224,86 @@ class TestScriptoriumPost < Minitest::Test
     Scriptorium::Repo.testing = true
   end
 
-  # set_pubdate_with_seconds tests
   def test_028_set_pubdate_with_seconds
+    create_real_post
     Scriptorium::Repo.testing = true
     @post.set_pubdate_with_seconds("2023-01-15", 30)
     
     meta = @post.meta
     assert_equal "2023-01-15 12:00:30", meta["post.pubdate"]
+    assert_equal "January", meta["post.pubdate.month"]
+    assert_equal "15", meta["post.pubdate.day"]
+    assert_equal "2023", meta["post.pubdate.year"]
   end
 
   def test_029_pubdate_month_day_year
-    write_file(@post.meta_file, "post.pubdate.month January\npost.pubdate.day 15\npost.pubdate.year 2023")
+    create_real_post
+    # Write metadata with the specific fields this test expects
+    meta_content = "post.pubdate      2023-01-15 12:00:00\npost.pubdate.month January\npost.pubdate.day 15\npost.pubdate.year 2023"
+    write_file(@post.meta_file, meta_content)
     assert_equal ["January", "15", "2023"], @post.pubdate_month_day_year
   end
 
   # attrs tests
   def test_030_attrs_single
-    write_file(@post.meta_file, "post.title       Test Post")
-    assert_equal ["Test Post"], @post.attrs(:title)
+    create_real_post
+    result = @post.attrs(:title)
+    assert_equal ["Test Post"], result
   end
 
   def test_031_attrs_multiple
-    write_file(@post.meta_file, "post.title       Test Post\npost.blurb       Test blurb")
-    assert_equal ["Test Post", "Test blurb"], @post.attrs(:title, :blurb)
+    create_real_post
+    result = @post.attrs(:title, :blurb)
+    assert_equal ["Test Post", "ADD BLURB HERE"], result
   end
 
   # vars tests
   def test_032_vars
-    write_file(@post.meta_file, "post.title       Test Post\npost.blurb       Test blurb")
+    create_real_post
     vars = @post.vars
     assert_equal "Test Post", vars[:"post.title"]
-    assert_equal "Test blurb", vars[:"post.blurb"]
+    assert_equal "ADD BLURB HERE", vars[:"post.blurb"]
   end
 
   def test_033_vars_default_behavior
+    create_real_post
     vars = @post.vars
-    assert_equal "", vars[:nonexistent_key]
+    assert_equal "", vars[:nonexistent_field]
   end
 
   # Class method tests
   def test_034_read
-    # Create a meta file
-    meta_content = "post.title       Test Post\npost.blurb       Test blurb"
-    write_file(@post.meta_file, meta_content)
-    
+    create_real_post
     post = Scriptorium::Post.read(@repo, 1)
     assert_equal "Test Post", post.title
-    assert_equal "Test blurb", post.blurb
+    assert_equal "ADD BLURB HERE", post.blurb
+  end
+
+  # ========================================
+  # Post Validation Error Tests
+  # ========================================
+
+  def test_035_post_id_validation_exceptions
+    # Test that exception classes exist
+    assert PostIdNil
+    assert PostIdEmpty
+    assert PostIdInvalid
   end
+
+  def test_036_post_creation_exceptions
+    # Test that exception classes exist
+    assert CannotCreatePost
+    assert CannotGetPost
+    assert CannotSetPubdate
+  end
+
+  def test_037_post_id_validation_scenarios
+    # Test actual exception raising for post ID validation
+    # These would need methods that actually raise these exceptions
+    # For now, just verify the classes exist
+    assert PostIdNil
+    assert PostIdEmpty
+    assert PostIdInvalid
+  end
+
 end

data/test/unit/post_index_config_test.rb

@@ -0,0 +1,258 @@
+require 'minitest/autorun'
+
+require_relative '../../lib/scriptorium'
+require_relative '../test_helpers'
+
+class TestPostIndexConfig < Minitest::Test
+  include Scriptorium::Exceptions
+  include Scriptorium::Helpers
+  include TestHelpers
+  def setup
+    @repo = create_test_repo
+    @view = @repo.create_view("testview", "Test View")
+  end
+
+  def teardown
+    system("rm -rf test/scriptorium-TEST")
+  end
+
+  def test_001_post_index_config_defaults
+    # Test that default title size is used when no config file exists
+    dname = @repo.create_draft(title: "Test Post")
+    @repo.finish_draft(dname)
+    post = @repo.all_posts("testview").first
+    post.meta["post.pubdate"] = Date.today.to_s
+    entry = @view.post_index_entry(post)    
+    assert_match(/font-size: 1\.1em/, entry)
+  end
+
+  def test_002_post_index_config_override
+    # Test that custom title size from config file is used
+    config_file = @view.dir/:config/"post_index.txt"
+    write_file(config_file, "entry.title.size 1.5em")
+    
+    dname = @repo.create_draft(title: "Test Post")
+    @repo.finish_draft(dname)
+    post = @repo.all_posts("testview").first
+    post.meta["post.pubdate"] = Date.today.to_s
+    entry = @view.post_index_entry(post)
+    
+    assert_match(/font-size: 1\.5em/, entry)
+  end
+
+  def test_003_post_index_config_missing_key_falls_back
+    # Test that missing config key falls back to default
+    config_file = @view.dir/:config/"post_index.txt"
+    write_file(config_file, "posts.per.page 5")
+    
+    dname = @repo.create_draft(title: "Test Post")
+    @repo.finish_draft(dname)
+    post = @repo.all_posts("testview").first
+    post.meta["post.pubdate"] = Date.today.to_s
+    entry = @view.post_index_entry(post)
+    
+    assert_match(/font-size: 1\.1em/, entry)
+  end
+
+  def test_004_posts_per_page_uses_global_default
+    # Test that posts.per.page gets global default when no view config exists
+    config = @view.read_post_index_config
+    assert_equal 10, config[:"posts.per.page"].to_i
+  end
+
+  def test_005_posts_per_page_view_override
+    # Test that view config can override posts.per.page
+    config_file = @view.dir/:config/"post_index.txt"
+    write_file(config_file, "posts.per.page 5")
+    
+    config = @view.read_post_index_config
+    assert_equal 5, config[:"posts.per.page"].to_i
+  end
+
+  def test_006_entry_blurb_size_uses_global_default
+    # Test that entry.blurb.size gets global default when no view config exists
+    config = @view.read_post_index_config
+    assert_equal "0.75em", config[:"entry.blurb.size"]
+  end
+
+  def test_007_entry_blurb_size_view_override
+    # Test that view config can override entry.blurb.size
+    config_file = @view.dir/:config/"post_index.txt"
+    write_file(config_file, "entry.blurb.size 0.9em")
+    
+    dname = @repo.create_draft(title: "Test Post")
+    @repo.finish_draft(dname)
+    post = @repo.all_posts("testview").first
+    post.meta["post.pubdate"] = Date.today.to_s
+    entry = @view.post_index_entry(post)
+    
+    assert_match(/font-size: 0\.9em/, entry)
+  end
+
+  def test_008_entry_date_size_uses_global_default
+    # Test that entry.date.size gets global default when no view config exists
+    config = @view.read_post_index_config
+    assert_equal "0.7em", config[:"entry.date.size"]
+  end
+
+  def test_009_entry_date_width_uses_global_default
+    # Test that entry.date.width gets global default when no view config exists
+    config = @view.read_post_index_config
+    assert_equal "14%", config[:"entry.date.width"]
+  end
+
+  def test_010_entry_date_config_view_override
+    # Test that view config can override entry.date.size and entry.date.width
+    config_file = @view.dir/:config/"post_index.txt"
+    write_file(config_file, "entry.date.size 0.8em\nentry.date.width 16%")
+    
+    dname = @repo.create_draft(title: "Test Post")
+    @repo.finish_draft(dname)
+    post = @repo.all_posts("testview").first
+    post.meta["post.pubdate"] = Date.today.to_s
+    entry = @view.post_index_entry(post)
+    
+    assert_match(/width=16%/, entry)
+    assert_match(/font-size: 0\.8em/, entry)
+  end
+
+  def test_011_entry_cellpadding_uses_global_default
+    # Test that entry.cellpadding gets global default when no view config exists
+    config = @view.read_post_index_config
+    assert_equal "4", config[:"entry.cellpadding"]
+  end
+
+  def test_012_entry_margin_bottom_uses_global_default
+    # Test that entry.margin.bottom gets global default when no view config exists
+    config = @view.read_post_index_config
+    assert_equal "6px", config[:"entry.margin.bottom"]
+  end
+
+  def test_013_entry_spacing_config_view_override
+    # Test that view config can override entry.cellpadding and entry.margin.bottom
+    config_file = @view.dir/:config/"post_index.txt"
+    write_file(config_file, "entry.cellpadding 6\nentry.margin.bottom 8px")
+    
+    dname = @repo.create_draft(title: "Test Post")
+    @repo.finish_draft(dname)
+    post = @repo.all_posts("testview").first
+    post.meta["post.pubdate"] = Date.today.to_s
+    
+    # Test the full post index generation to see cellpadding on the table
+    @view.generate_post_index
+    full_index = File.read("test/scriptorium-TEST/views/testview/output/post_index.html")
+    assert_match(/cellpadding=6/, full_index)
+    
+    # Test individual entry for margin-bottom
+    entry = @view.post_index_entry(post)
+    assert_match(/margin-bottom: 8px/, entry)
+  end
+
+  def test_014_entry_title_color_uses_global_default
+    # Test that entry.title.color gets global default when no view config exists
+    config = @view.read_post_index_config
+    assert_equal "#000000", config[:"entry.title.color"]
+  end
+
+  def test_015_entry_blurb_color_uses_global_default
+    # Test that entry.blurb.color gets global default when no view config exists
+    config = @view.read_post_index_config
+    assert_equal "#666666", config[:"entry.blurb.color"]
+  end
+
+  def test_016_entry_date_color_uses_global_default
+    # Test that entry.date.color gets global default when no view config exists
+    config = @view.read_post_index_config
+    assert_equal "#888888", config[:"entry.date.color"]
+  end
+
+  def test_017_entry_colors_view_override
+    # Test that view config can override all color settings
+    config_file = @view.dir/:config/"post_index.txt"
+    write_file(config_file, "entry.title.color #ff0000\nentry.blurb.color #00ff00\nentry.date.color #0000ff")
+    
+    dname = @repo.create_draft(title: "Test Post")
+    @repo.finish_draft(dname)
+    post = @repo.all_posts("testview").first
+    post.meta["post.pubdate"] = Date.today.to_s
+    entry = @view.post_index_entry(post)
+    
+    assert_match(/color: #ff0000/, entry)
+    assert_match(/color: #00ff00/, entry)
+    assert_match(/color: #0000ff/, entry)
+  end
+
+  def test_018_entry_line_height_uses_global_default
+    # Test that entry.line.height gets global default when no view config exists
+    config = @view.read_post_index_config
+    assert_equal "1.1", config[:"entry.line.height"]
+  end
+
+  def test_019_entry_date_alignment_uses_global_default
+    # Test that entry.date.alignment gets global default when no view config exists
+    config = @view.read_post_index_config
+    assert_equal "right", config[:"entry.date.alignment"]
+  end
+
+  def test_020_entry_date_spacing_uses_global_default
+    # Test that entry.date.spacing gets global default when no view config exists
+    config = @view.read_post_index_config
+    assert_equal "0.1em", config[:"entry.date.spacing"]
+  end
+
+  def test_021_entry_layout_config_view_override
+    # Test that view config can override line height, date alignment, and date spacing
+    config_file = @view.dir/:config/"post_index.txt"
+    write_file(config_file, "entry.line.height 1.3\nentry.date.alignment center\nentry.date.spacing 0.2em")
+    
+    dname = @repo.create_draft(title: "Test Post")
+    @repo.finish_draft(dname)
+    post = @repo.all_posts("testview").first
+    post.meta["post.pubdate"] = Date.today.to_s
+    entry = @view.post_index_entry(post)
+    
+    assert_match(/line-height: 1\.3/, entry)
+    assert_match(/text-align: center/, entry)
+    assert_match(/height: 0\.2em/, entry)
+  end
+
+  def test_022_index_margin_top_uses_global_default
+    # Test that index.margin.top gets global default when no view config exists
+    config = @view.read_post_index_config
+    assert_equal "20px", config[:"index.margin.top"]
+  end
+
+  def test_023_index_margin_top_view_override
+    # Test that view config can override index.margin.top
+    config_file = @view.dir/:config/"post_index.txt"
+    write_file(config_file, "index.margin.top 10px")
+    
+    dname = @repo.create_draft(title: "Test Post")
+    @repo.finish_draft(dname)
+    
+    # Test the full post index generation to see margin-top on the table
+    @view.generate_post_index
+    full_index = File.read("test/scriptorium-TEST/views/testview/output/post_index.html")
+    assert_match(/margin-top: 10px/, full_index)
+  end
+
+  def test_024_date_format_uses_global_default
+    # Test that entry.date.format gets global default when no view config exists
+    config = @view.read_post_index_config
+    assert_equal "month dd, yyyy", config[:"entry.date.format"]
+  end
+
+  def test_025_date_format_view_override
+    # Test that view config can override entry.date.format
+    config_file = @view.dir/:config/"post_index.txt"
+    write_file(config_file, "entry.date.format dd month yyyy")
+    
+    dname = @repo.create_draft(title: "Test Post")
+    @repo.finish_draft(dname)
+    post = @repo.all_posts("testview").first
+    post.meta["post.pubdate"] = Date.new(2025, 2, 22).to_s
+    
+    entry = @view.post_index_entry(post)
+    assert_match(/22 February 2025/, entry)
+  end
+end

data/test/unit/post_state_helpers_test.rb

@@ -0,0 +1,137 @@
+#!/usr/bin/env ruby
+
+require 'minitest/autorun'
+require_relative '../../lib/scriptorium'
+require_relative '../test_helpers'
+
+class TestPostStateHelpers < Minitest::Test
+  include Scriptorium::Helpers
+  include TestHelpers
+
+  def setup
+    @test_dir = "test/post_state_helpers_test"
+    FileUtils.rm_rf(@test_dir) if Dir.exist?(@test_dir)
+    make_dir(@test_dir)
+    
+    @unpublished_file = @test_dir/"unpublished.txt"
+    @undeployed_file = @test_dir/"undeployed.txt"
+  end
+
+  def teardown
+    FileUtils.rm_rf(@test_dir) if Dir.exist?(@test_dir)
+  end
+
+  def test_001_read_post_state_file_empty
+    # Test reading empty file
+    result = read_post_state_file(@unpublished_file)
+    assert_equal [], result
+  end
+
+  def test_002_read_post_state_file_with_content
+    # Test reading file with post IDs
+    write_file(@unpublished_file, "1\n3\n7\n")
+    result = read_post_state_file(@unpublished_file)
+    assert_equal [1, 3, 7], result
+  end
+
+  def test_003_read_post_state_file_with_whitespace
+    # Test reading file with whitespace
+    write_file(@unpublished_file, "  1  \n  3  \n  7  \n")
+    result = read_post_state_file(@unpublished_file)
+    assert_equal [1, 3, 7], result
+  end
+
+  def test_004_read_post_state_file_with_empty_lines
+    # Test reading file with empty lines
+    write_file(@unpublished_file, "1\n\n3\n\n7\n")
+    result = read_post_state_file(@unpublished_file)
+    assert_equal [1, 3, 7], result
+  end
+
+  def test_005_write_post_state_file_empty
+    # Test writing empty array
+    write_post_state_file(@unpublished_file, [])
+    content = read_file(@unpublished_file)
+    assert_equal "\n", content  # Empty file with newline is correct
+  end
+
+  def test_006_write_post_state_file_with_content
+    # Test writing array with post IDs
+    write_post_state_file(@unpublished_file, [7, 1, 3])
+    content = read_file(@unpublished_file)
+    assert_equal "1\n3\n7\n", content  # Should be sorted
+  end
+
+  def test_007_add_post_to_state_file_new
+    # Test adding new post ID
+    write_file(@unpublished_file, "1\n3\n")
+    add_post_to_state_file(@unpublished_file, 5)
+    result = read_post_state_file(@unpublished_file)
+    assert_equal [1, 3, 5], result
+  end
+
+  def test_008_add_post_to_state_file_existing
+    # Test adding existing post ID (should not duplicate)
+    write_file(@unpublished_file, "1\n3\n")
+    add_post_to_state_file(@unpublished_file, 3)
+    result = read_post_state_file(@unpublished_file)
+    assert_equal [1, 3], result
+  end
+
+  def test_009_remove_post_from_state_file
+    # Test removing post ID
+    write_file(@unpublished_file, "1\n3\n5\n")
+    remove_post_from_state_file(@unpublished_file, 3)
+    result = read_post_state_file(@unpublished_file)
+    assert_equal [1, 5], result
+  end
+
+  def test_010_remove_post_from_state_file_nonexistent
+    # Test removing non-existent post ID
+    write_file(@unpublished_file, "1\n3\n")
+    remove_post_from_state_file(@unpublished_file, 5)
+    result = read_post_state_file(@unpublished_file)
+    assert_equal [1, 3], result
+  end
+
+  def test_011_post_in_state_file_true
+    # Test checking if post exists in file
+    write_file(@unpublished_file, "1\n3\n5\n")
+    assert post_in_state_file?(@unpublished_file, 3)
+  end
+
+  def test_012_post_in_state_file_false
+    # Test checking if post doesn't exist in file
+    write_file(@unpublished_file, "1\n3\n5\n")
+    refute post_in_state_file?(@unpublished_file, 7)
+  end
+
+  def test_013_post_in_state_file_empty
+    # Test checking empty file
+    refute post_in_state_file?(@unpublished_file, 1)
+  end
+
+  def test_014_integration_workflow
+    # Test complete workflow: add, check, remove
+    # Start with empty file
+    assert_equal [], read_post_state_file(@unpublished_file)
+    
+    # Add posts
+    add_post_to_state_file(@unpublished_file, 1)
+    add_post_to_state_file(@unpublished_file, 3)
+    add_post_to_state_file(@unpublished_file, 5)
+    
+    # Verify they're there
+    assert_equal [1, 3, 5], read_post_state_file(@unpublished_file)
+    assert post_in_state_file?(@unpublished_file, 1)
+    assert post_in_state_file?(@unpublished_file, 3)
+    assert post_in_state_file?(@unpublished_file, 5)
+    
+    # Remove one
+    remove_post_from_state_file(@unpublished_file, 3)
+    assert_equal [1, 5], read_post_state_file(@unpublished_file)
+    assert post_in_state_file?(@unpublished_file, 1)
+    refute post_in_state_file?(@unpublished_file, 3)
+    assert post_in_state_file?(@unpublished_file, 5)
+  end
+end