script_core 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ede1652ae58420a03a24ee7b0a0336663609539818ac5e78eefd1b44f559e79f
-  data.tar.gz: a89ceb1cfd340b55c57a031520f48f45e97f66d9177ca4f75800c5b23e9e3398
+  metadata.gz: 7d22fc6516b63706a508249edf80db433c0867bdce486c67f37f7a6e7554aee3
+  data.tar.gz: 38fa2692788d8d8da328b5658ed4a9b1229f7249658b414ed1737dd57f3e3af8
 SHA512:
-  metadata.gz: e4c1ab03a8ad1d0ac10c8910a9946093f086b6df33a3e41071c6d5c0ec0dc0c8446c1724ce9ab0f6525865183b93b9c471538d33fe283957f3f126984bd1e9d3
-  data.tar.gz: 07df21c99ee18cba6f3accffd8d9cfca55e203d7f0be33bdef56af267a8e1fbe3e091df7272db421f35b7879dbd2469c4a3cb89eb07307f1573a6f3e74ce054e
+  metadata.gz: e9ffbfa5ee5bfba957357126f5e07f4979fdde23c42e84371cd5ed346cdcc8da367559d876a1813cf95c21a289c390d0c0429ce904bbc2fc889e81f4ec106869
+  data.tar.gz: 57171be0b55234ccc9eafad9c019a158d8d7d5626619d5cb5f504e87139b2afb60c47345056b25876211a09f7163f09cdede9b12c99048b987f2b223a2c6f1a9

data/.rubocop.yml

@@ -13,13 +13,45 @@ AllCops:
     - spec/dummy/db/schema.rb
     - spec/dummy/bin/**/*
 
+Rails:
+  Enabled: true
+
 Metrics/LineLength:
   Max: 150
 
-# frozen_string_literal: true
-Style/FrozenStringLiteralComment:
-  Enabled: true
-  EnforcedStyle: when_needed
+Metrics/MethodLength:
+  Max: 100
+
+Metrics/BlockLength:
+  Max: 50
+
+Metrics/ClassLength:
+  Enabled: false
+
+Style/GuardClause:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Style/ClassAndModuleChildren:
+  Enabled: false
+
+Naming/AccessorMethodName:
+  Enabled: false
+
+Naming/MemoizedInstanceVariableName:
+  Enabled: false
+
+# Prefer assert_not over assert !
+Rails/AssertNot:
+  Include:
+    - 'test/**/*'
+
+# Prefer assert_not_x over refute_x
+Rails/RefuteMethods:
+  Include:
+    - 'test/**/*'
 
 # Prefer &&/|| over and/or.
 Style/AndOr:
@@ -29,6 +61,7 @@ Style/AndOr:
 # method call.
 Style/BracesAroundHashParameters:
   Enabled: true
+  EnforcedStyle: context_dependent
 
 # Align `when` with `case`.
 Layout/CaseIndentation:
@@ -38,8 +71,20 @@ Layout/CaseIndentation:
 Layout/CommentIndentation:
   Enabled: true
 
-# No extra empty lines.
-Layout/EmptyLines:
+Layout/ElseAlignment:
+  Enabled: true
+
+# Align `end` with the matching keyword or starting expression except for
+# assignments, where it should be aligned with the LHS.
+Layout/EndAlignment:
+  Enabled: true
+  EnforcedStyleAlignWith: variable
+  AutoCorrect: true
+
+Layout/EmptyLineAfterMagicComment:
+  Enabled: true
+
+Layout/EmptyLinesAroundBlockBody:
   Enabled: true
 
 # In a regular class definition, no empty lines around the body.
@@ -54,7 +99,10 @@ Layout/EmptyLinesAroundMethodBody:
 Layout/EmptyLinesAroundModuleBody:
   Enabled: true
 
-# Use Ruby >= 1.9 syntax for hashes. Prefer {a: :b} over { :a => :b }.
+Layout/IndentFirstArgument:
+  Enabled: true
+
+# Use Ruby >= 1.9 syntax for hashes. Prefer { a: :b } over { :a => :b }.
 Style/HashSyntax:
   Enabled: true
 
@@ -62,18 +110,24 @@ Style/HashSyntax:
 # extra level of indentation.
 Layout/IndentationConsistency:
   Enabled: true
-  EnforcedStyle: normal
+  EnforcedStyle: rails
 
 # Two spaces, no tabs (for indentation).
 Layout/IndentationWidth:
   Enabled: true
 
+Layout/LeadingCommentSpace:
+  Enabled: true
+
 Layout/SpaceAfterColon:
   Enabled: true
 
 Layout/SpaceAfterComma:
   Enabled: true
 
+Layout/SpaceAfterSemicolon:
+  Enabled: true
+
 Layout/SpaceAroundEqualsInParameterDefault:
   Enabled: true
 
@@ -83,13 +137,26 @@ Layout/SpaceAroundKeyword:
 Layout/SpaceAroundOperators:
   Enabled: true
 
+Layout/SpaceBeforeComma:
+  Enabled: true
+
 Layout/SpaceBeforeFirstArg:
   Enabled: true
 
+Style/DefWithParentheses:
+  Enabled: true
+
 # Defining a method with parameters needs parentheses.
 Style/MethodDefParentheses:
   Enabled: true
 
+Style/FrozenStringLiteralComment:
+  Enabled: true
+  EnforcedStyle: always
+
+Style/RedundantFreeze:
+  Enabled: true
+
 # Use `foo {}` not `foo{}`.
 Layout/SpaceBeforeBlockBraces:
   Enabled: true
@@ -97,10 +164,11 @@ Layout/SpaceBeforeBlockBraces:
 # Use `foo { bar }` not `foo {bar}`.
 Layout/SpaceInsideBlockBraces:
   Enabled: true
+  EnforcedStyleForEmptyBraces: space
 
-# Use `{a: 1}` not `{ a:1 }`.
+# Use `{ a: 1 }` not `{a:1}`.
 Layout/SpaceInsideHashLiteralBraces:
-  Enabled: false
+  Enabled: true
 
 Layout/SpaceInsideParens:
   Enabled: true
@@ -126,45 +194,72 @@ Layout/TrailingWhitespace:
 Style/UnneededPercentQ:
   Enabled: true
 
-# Align `end` with the matching keyword or starting expression except for
-# assignments, where it should be aligned with the LHS.
-Layout/EndAlignment:
+Lint/AmbiguousOperator:
+  Enabled: true
+
+Lint/AmbiguousRegexpLiteral:
+  Enabled: true
+
+Lint/ErbNewArguments:
   Enabled: true
-  EnforcedStyleAlignWith: variable
 
 # Use my_method(my_arg) not my_method( my_arg ) or my_method my_arg.
 Lint/RequireParentheses:
   Enabled: true
 
-Style/Documentation:
-  Enabled: false
+Lint/ShadowingOuterLocalVariable:
+  Enabled: true
 
-Metrics/MethodLength:
-  Enabled: false
+Lint/StringConversionInInterpolation:
+  Enabled: true
 
-Metrics/AbcSize:
-  Enabled: false
+Lint/UriEscapeUnescape:
+  Enabled: true
 
-Metrics/ParameterLists:
-  Enabled: false
+Lint/UselessAssignment:
+  Enabled: true
 
-Metrics/BlockLength:
-  Enabled: false
+Lint/DeprecatedClassMethods:
+  Enabled: true
 
-Lint/HandleExceptions:
-  Enabled: false
+Style/ParenthesesAroundCondition:
+  Enabled: true
 
-Metrics/ClassLength:
-  Enabled: false
+Style/RedundantBegin:
+  Enabled: true
 
-Layout/EmptyLinesAroundArguments:
-  Enabled: false
+Style/RedundantReturn:
+  Enabled: true
+  AllowMultipleReturnValues: true
 
-Style/ClassAndModuleChildren:
-  Enabled: false
+Style/Semicolon:
+  Enabled: true
+  AllowAsExpressionSeparator: true
 
-Naming/UncommunicativeMethodParamName:
-  Enabled: false
+# Prefer Foo.method over Foo::method
+Style/ColonMethodCall:
+  Enabled: true
 
-Style/IfUnlessModifier:
-  Enabled: false
+Style/TrivialAccessors:
+  Enabled: true
+
+Performance/FlatMap:
+  Enabled: true
+
+Performance/RedundantMerge:
+  Enabled: true
+
+Performance/StartWith:
+  Enabled: true
+
+Performance/EndWith:
+  Enabled: true
+
+Performance/RegexpMatch:
+  Enabled: true
+
+Performance/ReverseEach:
+  Enabled: true
+
+Performance/UnfreezeString:
+  Enabled: true

data/Gemfile

@@ -6,7 +6,7 @@ git_source(:github) { |repo| "https://github.com/#{repo}.git" }
 gemspec
 
 # Dummy app
-gem "rails", "~> 6.0.0.beta3"
+gem "rails", "~> 6.0.0.rc1"
 gem "sqlite3"
 
 # Use Puma as the app server
@@ -16,7 +16,7 @@ gem "pry-rails"
 
 gem "listen", ">= 3.0.5", "< 3.2"
 # Access an IRB console on exception pages or by using <%= console %> anywhere in the code.
-gem "web-console"
+gem "web-console", group: :development
 # Call "byebug" anywhere in the code to stop execution and get a debugger console
 gem "pry-byebug"
 

data/lib/script_core/executable.rb

@@ -17,7 +17,7 @@ def run(input: {}, sources:, instructions: nil,
             environment_variables: {})
       packer = ScriptCore::Protocol.packer_factory.packer
 
-      payload = {input: input, sources: sources}
+      payload = { input: input, sources: sources }
       payload[:library] = instructions if instructions
       encoded = packer.pack(payload)
 

data/lib/script_core/message_processor.rb

@@ -71,61 +71,61 @@ def to_result
 
     private
 
-    def read(raw_message)
-      type, data = raw_message
-      case type
-      when :output then read_output(data)
-      when :error then read_error(data)
-      when :measurement then read_measurement(data)
-      when :stat then read_stat(data)
+      def read(raw_message)
+        type, data = raw_message
+        case type
+        when :output then read_output(data)
+        when :error then read_error(data)
+        when :measurement then read_measurement(data)
+        when :stat then read_stat(data)
+        end
       end
-    end
 
-    def read_output(data)
-      @output = data[:extracted]
-      @stdout = data[:stdout]
-    end
+      def read_output(data)
+        @output = data[:extracted]
+        @stdout = data[:stdout]
+      end
 
-    def read_error(data)
-      @errors <<
-        case data[:__type]
-        when :runtime
-          EngineRuntimeError.new(
-            data[:message],
-            guest_backtrace: data[:backtrace]
-          )
-        when :syntax
-          EngineSyntaxError.new(
-            data[:message],
-            filename: data[:filename],
-            line_number: data[:line_number],
-            column: data[:column]
-          )
-        when :unknown_type
-          EngineUnknownTypeError.new(type: data[:type])
-        when :unknown_ext
-          EngineUnknownExtError.new(type: data[:type])
+      def read_error(data)
+        @errors <<
+          case data[:__type]
+          when :runtime
+            EngineRuntimeError.new(
+              data[:message],
+              guest_backtrace: data[:backtrace]
+            )
+          when :syntax
+            EngineSyntaxError.new(
+              data[:message],
+              filename: data[:filename],
+              line_number: data[:line_number],
+              column: data[:column]
+            )
+          when :unknown_type
+            EngineUnknownTypeError.new(type: data[:type])
+          when :unknown_ext
+            EngineUnknownExtError.new(type: data[:type])
+          else
+            EngineInternalError.new("unknown error: #{data}")
+          end
+      end
+
+      def read_measurement(data)
+        name, microseconds = *data
+        if @measurements.key?(name)
+          @measurements[name] += microseconds
         else
-          EngineInternalError.new("unknown error: #{data}")
+          @measurements[name] = microseconds
         end
-    end
-
-    def read_measurement(data)
-      name, microseconds = *data
-      if @measurements.key?(name)
-        @measurements[name] += microseconds
-      else
-        @measurements[name] = microseconds
       end
-    end
 
-    def read_stat(data)
-      unless @stat == ScriptCore::Stat::Null
-        @errors << ScriptCore::DuplicateMessageError.new(
-          "duplicate stat message"
-        )
+      def read_stat(data)
+        unless @stat == ScriptCore::Stat::Null
+          @errors << ScriptCore::DuplicateMessageError.new(
+            "duplicate stat message"
+          )
+        end
+        @stat = ScriptCore::Stat.new(data)
       end
-      @stat = ScriptCore::Stat.new(data)
-    end
   end
 end

data/lib/script_core/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ScriptCore
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/lib/tasks/script_core.rake

@@ -8,7 +8,7 @@
   namespace :engine do
     desc "Create a skeletal engine that can be customize at the path you specify"
     task :new do
-      ARGV.each { |a| task(a.to_sym) {} }
+      ARGV.each { |a| task(a.to_sym) { } }
 
       name = ARGV[1] || DEFAULT_ENGINE_NAME
       unless /\A[a-z_]+\Z/.match?(name)
@@ -27,18 +27,24 @@
 
     desc "Build engine executables"
     task :build do
-      ARGV.each { |a| task(a.to_sym) {} }
+      ARGV.each { |a| task(a.to_sym) { } }
+
+      path = Pathname.new(ENV["ENGINE_PATH"]).realpath rescue nil if ENV["ENGINE_PATH"].present?
+      engine_root =
+        if path
+          path
+        else
+          name = ARGV[1] || DEFAULT_ENGINE_NAME
+          unless /\A[a-z_]+\Z/.match?(name)
+            puts "Must provide a valid engine name."
+            exit 1
+          end
+          Rails.root.join(name)
+        end
 
-      name = ARGV[1] || DEFAULT_ENGINE_NAME
-      unless /\A[a-z_]+\Z/.match?(name)
-        puts "Must provide a valid engine name."
-        exit 1
-      end
-
-      engine_root = Rails.root.join(name)
       unless Dir.exist?(engine_root)
         puts "Engine home `#{engine_root}` doesn't exists."
-        puts "You should run `rake script_core:engine:new #{name}` to create it first."
+        puts "You should run `rake script_core:engine:new` to create it first."
         exit 1
       end
 
@@ -51,24 +57,30 @@
       end
 
       Dir.chdir(SCRIPT_CORE_ROOT.join("ext/enterprise_script_service")) do
-        sh("#{env_vars} #{Rails.root.join('bin/bundle')} exec rake")
+        sh("#{env_vars} #{Rails.root.join('bin', 'bundle')} exec rake")
       end
     end
 
     desc "Compile engine lib"
     task :compile_lib do
-      ARGV.each { |a| task(a.to_sym) {} }
-
-      name = ARGV[1] || DEFAULT_ENGINE_NAME
-      unless /\A[a-z_]+\Z/.match?(name)
-        puts "Must provide a valid engine name."
-        exit 1
-      end
+      ARGV.each { |a| task(a.to_sym) { } }
+
+      path = Pathname.new(ENV["ENGINE_PATH"]).realpath rescue nil if ENV["ENGINE_PATH"].present?
+      engine_root =
+        if path
+          path
+        else
+          name = ARGV[1] || DEFAULT_ENGINE_NAME
+          unless /\A[a-z_]+\Z/.match?(name)
+            puts "Must provide a valid engine name."
+            exit 1
+          end
+          Rails.root.join(name)
+        end
 
-      engine_root = Rails.root.join(name)
       unless Dir.exist?(engine_root)
         puts "Engine home `#{engine_root}` doesn't exists."
-        puts "You should run `rake script_core:engine:new #{name}` to create it first."
+        puts "You should run `rake script_core:engine:new` to create it first."
         exit 1
       end
 
@@ -91,24 +103,28 @@
 
     desc "Clean engine compiled files"
     task :clean do
-      ARGV.each { |a| task(a.to_sym) {} }
-
-      name = ARGV[1] || DEFAULT_ENGINE_NAME
-      unless /\A[a-z_]+\Z/.match?(name)
-        puts "Must provide a valid engine name."
-        exit 1
-      end
+      ARGV.each { |a| task(a.to_sym) { } }
+
+      path = Pathname.new(ENV["ENGINE_PATH"]).realpath rescue nil if ENV["ENGINE_PATH"].present?
+      engine_root =
+        if path
+          path
+        else
+          name = ARGV[1] || DEFAULT_ENGINE_NAME
+          unless /\A[a-z_]+\Z/.match?(name)
+            puts "Must provide a valid engine name."
+            exit 1
+          end
+          Rails.root.join(name)
+        end
 
-      engine_root = Rails.root.join(name)
       unless Dir.exist?(engine_root)
         puts "Engine home `#{engine_root}` doesn't exists."
         exit 1
       end
 
       bin_path = engine_root.join("bin")
-      if Dir.exist?(bin_path)
-        FileUtils.remove_dir engine_root.join("bin")
-      end
+      FileUtils.remove_dir engine_root.join("bin") if Dir.exist?(bin_path)
     end
   end
 end