screengem 0.9.1 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b6fdea9053a69b15255d54d9a1a3ae9cf34fe0973ef857dd17c12d023ba00eb4
-  data.tar.gz: bff48e6b9db7aa91e0beaf5400002f82f797fa6246d926c769ecdcc697ab06a5
+  metadata.gz: 4be583b646f741befec6d480f450c93a0313ab4a17abf7743437627614398456
+  data.tar.gz: 90fee795ae2efcbfeeb3d9fd206a7d2d38ead7f92dd298b228b25b63e743343c
 SHA512:
-  metadata.gz: 1477cd2253855d1ddcf5d2e820c0419f5d2726b44c464507ea77557c4c73ecf5be8229921a79d44dece85883aea1a5c14a88f16ed647737516d7cfa35127af81
-  data.tar.gz: 7609872a5856218b3717f336d2bd9c3e92e9d087598d363eb8142def96067a4e42eb39f3aebfd30bb50e6b3fa3aff96c3d3ea143c359d64eabee1e42f4d9fbc3
+  metadata.gz: 005ad3ce9f9e6b657a3fd75f3fabe18d55b76767bad464ba2d6c6c0f81c744c7bf0f02fe16d4ac724f443b3a419b64aea3f0e162877a787ca72d208b24b586e1
+  data.tar.gz: 90497ca01f2134a764dc77e5f665459a340a66d5c7e2e130a97e5f98b36d893b0573445e34e7f2a2e6bc98706395c48dcbb7212352f78ba038a07e17ac5c3f27

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## master (unreleased)
 
+## 0.10.0 (2020-01-11)
+
+* Remove action abstraction
+* Latest development dependencies
+
 ## 0.9.1 (2019-10-22)
 
 * Relax the require_all dependency

data/README.md

@@ -24,7 +24,7 @@ An Actor is able to remember and recall key-value pairs.
 
 A Question responds to answer.
 
-A Task responds to perform and may execute one or more actions.
+A Task responds to perform.
 
 ![Core Domain Model](/images/ScreengemCore.png)
 

data/lib/screengem.rb

@@ -18,15 +18,12 @@ require "screengem/primitive_key"
 require "screengem/dampen_configuration"
 require "screengem/dampen_configuration_generator"
 
-require "screengem/concerns/actionable"
 require "screengem/concerns/configurable"
 require "screengem/concerns/dampenable"
 require "screengem/concerns/executable"
 
 require "screengem/dsl"
 
-require "screengem/action"
-require "screengem/browser_action"
 require "screengem/question"
 require "screengem/task"
 
@@ -35,9 +32,6 @@ require "screengem/actor"
 
 require "screengem/factories/factory_creation_error"
 
-require "screengem/factories/action_factory"
-require "screengem/factories/browser_action_factory"
-require "screengem/factories/standard_action_factory"
 require "screengem/factories/question_factory"
 require "screengem/factories/task_factory"
 

data/lib/screengem/actor.rb

@@ -1,14 +1,14 @@
 module Screengem
   #
-  # Mixin that allows an actor to perform tasks, ask questions, take actions, and
-  # to remember and recall tagged values.
+  # Mixin that allows an actor to perform tasks, ask questions, and to remember and
+  # recall tagged values.
   #
   # Return self for those methods that may be chained in the step definition DSL.
   #
   # The ability to remember and recall values is used to carry state forward from one
   # step definition to another (as the preferred alternative to instance variables).
   #
-  # Action, question, and task instances (aka primitives) are configured with:
+  # Question and task instances (aka primitives) are configured with:
   #   (1) a reference to the actor that is interacting with the primitive
   #   (2) a reference to the screen instance that hosts accessors to the screen elements.
   #
@@ -66,19 +66,6 @@ module Screengem
       self
     end
 
-    #
-    # Used by an actor to take one or more actions.
-    #
-    # Used to implement tasks. Actions do not appear in step definitions.
-    #
-    def takes_action(*actions)
-      actions.each do |action|
-        action.configure(self, screen)
-
-        action.execute
-      end
-    end
-
     private
 
     def incorrect_answer(question)

data/lib/screengem/configuration.rb

@@ -25,12 +25,6 @@ module Screengem
     # A boolean that specifies that dampening is to be applied.
     attr_accessor :apply_dampening
 
-    # A boolean that specifies that browser actions are created (used by the ActionFactory).
-    attr_accessor :browser_actions
-
-    # A string that namespaces action classes (used by the ActionFactory).
-    attr_accessor :action_scope
-
     # A string that namespaces questions classes (used by the QuestionFactory).
     attr_accessor :question_scope
 
@@ -39,11 +33,9 @@ module Screengem
 
     def initialize
       self.apply_dampening = false
-      self.browser_actions = false
 
       self.dampen_configuration_root = "default"
 
-      self.action_scope = "Actions"
       self.question_scope = "Questions"
       self.task_scope = "Tasks"
     end
@@ -52,10 +44,6 @@ module Screengem
       apply_dampening
     end
 
-    def browser_actions?
-      browser_actions
-    end
-
     def dampen_configuration_sample_filename
       "#{dampen_configuration_filename}.sample"
     end

data/lib/screengem/task.rb

@@ -5,7 +5,6 @@ module Screengem
   class Task
     include RSpec::Matchers
 
-    include Screengem::Actionable
     include Screengem::Configurable
     include Screengem::Dampenable
     include Screengem::Executable

data/lib/screengem/version.rb

@@ -1,3 +1,3 @@
 module Screengem
-  VERSION = "0.9.1"
+  VERSION = "0.10.0"
 end

data/screengem.gemspec

@@ -27,16 +27,18 @@ Gem::Specification.new do |spec|
   spec.bindir = "exe"
   spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
+  spec.required_ruby_version = "~> 2.5"
 
   spec.add_runtime_dependency "activesupport", ">= 4.2", "< 6.1"
   spec.add_runtime_dependency "capybara", ">= 2.18", "< 4.0"
   spec.add_runtime_dependency "require_all", ">= 2.0", "< 4.0"
   spec.add_runtime_dependency "rspec-expectations", "~> 3.8"
-  spec.add_runtime_dependency "thor", "~> 0.20"
+  spec.add_runtime_dependency "thor", "~> 1.0"
 
   spec.add_development_dependency "rake", "~> 13.0"
-  spec.add_development_dependency "rspec", "~> 3.8"
-  spec.add_development_dependency "rubocop", "~> 0.75"
-  spec.add_development_dependency "rubocop-rspec", "~> 1.36"
+  spec.add_development_dependency "rspec", "~> 3.9"
+  spec.add_development_dependency "rubocop", "~> 0.79"
+  spec.add_development_dependency "rubocop-performance", "~> 1.5"
+  spec.add_development_dependency "rubocop-rspec", "~> 1.37"
   spec.add_development_dependency "simplecov", "~> 0.17"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: screengem
 version: !ruby/object:Gem::Version
-  version: 0.9.1
+  version: 0.10.0
 platform: ruby
 authors:
 - Alistair McKinnell
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-10-22 00:00:00.000000000 Z
+date: 2020-01-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -90,14 +90,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.20'
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.20'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -118,42 +118,56 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.8'
+        version: '3.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.8'
+        version: '3.9'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.75'
+        version: '0.79'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.75'
+        version: '0.79'
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.5'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.36'
+        version: '1.37'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.36'
+        version: '1.37'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -193,13 +207,10 @@ files:
 - exe/screengem
 - images/ScreengemCore.png
 - lib/screengem.rb
-- lib/screengem/action.rb
 - lib/screengem/actor.rb
 - lib/screengem/actor_memory.rb
 - lib/screengem/automatic_visit.rb
-- lib/screengem/browser_action.rb
 - lib/screengem/cli.rb
-- lib/screengem/concerns/actionable.rb
 - lib/screengem/concerns/configurable.rb
 - lib/screengem/concerns/dampenable.rb
 - lib/screengem/concerns/executable.rb
@@ -207,11 +218,8 @@ files:
 - lib/screengem/dampen_configuration.rb
 - lib/screengem/dampen_configuration_generator.rb
 - lib/screengem/dsl.rb
-- lib/screengem/factories/action_factory.rb
-- lib/screengem/factories/browser_action_factory.rb
 - lib/screengem/factories/factory_creation_error.rb
 - lib/screengem/factories/question_factory.rb
-- lib/screengem/factories/standard_action_factory.rb
 - lib/screengem/factories/task_factory.rb
 - lib/screengem/incorrect_answer.rb
 - lib/screengem/primitive_key.rb
@@ -237,16 +245,16 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - "~>"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Ruby implementation of the Screengem Pattern.

data/lib/screengem/action.rb

@@ -1,11 +0,0 @@
-module Screengem
-  #
-  # Base class for all actions.
-  #
-  class Action
-    include RSpec::Matchers
-
-    include Screengem::Configurable
-    include Screengem::Executable
-  end
-end

data/lib/screengem/browser_action.rb

@@ -1,7 +0,0 @@
-module Screengem
-  #
-  # Base class for all browser actions.
-  #
-  class BrowserAction < Screengem::Action
-  end
-end

data/lib/screengem/concerns/actionable.rb

@@ -1,29 +0,0 @@
-module Screengem
-  #
-  # Concern that adds the ability to create actions.
-  #
-  module Actionable
-    extend ActiveSupport::Concern
-
-    def action
-      @action ||= action_factory
-    end
-
-    private
-
-    #
-    # Choose the specified action factory. Default to the standard action factory.
-    #
-    def action_factory
-      if browser_factory?
-        Screengem::Factories::BrowserActionFactory.instance
-      else
-        Screengem::Factories::StandardActionFactory.instance
-      end
-    end
-
-    def browser_factory?
-      Screengem.configuration.browser_actions?
-    end
-  end
-end

data/lib/screengem/factories/action_factory.rb

@@ -1,34 +0,0 @@
-module Screengem
-  module Factories
-    #
-    # Makes actions available to tasks.
-    #
-    class ActionFactory < BasicObject
-      def method_missing(action_name, *args) # rubocop:disable Style/MethodMissingSuper
-        action_class_name = raw_action_class_name(action_name).camelize
-        action_class = "#{action_scope}::#{action_class_name}".constantize
-
-        action_class.new(*args)
-      rescue => e
-        ActionError.new(<<~MSG)
-          Unable to create action: '#{action_class_name}'.
-            Details: #{e.message}
-        MSG
-      end
-
-      def respond_to_missing?(_action_name, *)
-        true
-      end
-
-      class ActionError < ::Screengem::Action
-        include FactoryCreationError
-      end
-
-      private
-
-      def action_scope
-        @action_scope ||= ::Screengem.configuration.action_scope
-      end
-    end
-  end
-end

data/lib/screengem/factories/browser_action_factory.rb

@@ -1,14 +0,0 @@
-module Screengem
-  module Factories
-    #
-    # Makes browser actions available.
-    #
-    class BrowserActionFactory < Screengem::Factories::ActionFactory
-      include ::Singleton
-
-      def raw_action_class_name(action_name)
-        "#{action_name}_action_browser"
-      end
-    end
-  end
-end

data/lib/screengem/factories/standard_action_factory.rb

@@ -1,14 +0,0 @@
-module Screengem
-  module Factories
-    #
-    # Makes standard actions available.
-    #
-    class StandardActionFactory < Screengem::Factories::ActionFactory
-      include ::Singleton
-
-      def raw_action_class_name(action_name)
-        "#{action_name}_action"
-      end
-    end
-  end
-end