screengem 0.21.1 → 0.21.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5464d440db28cb87d4fa76d99665b1968bb1bdbc23cc0c11b2168fa742077bca
-  data.tar.gz: fb950e13e56aaa784a816a4cae95c8900570750b6f552eccb3ddcee513687e89
+  metadata.gz: 9321ae3c6f518999057e3cd9b38a62503563e07d7452e44a95c0afa5ac19f454
+  data.tar.gz: 84297d6336c9f0a2622dbdc7df87f9be41a6f46087c39558f34b20a0a596cb1e
 SHA512:
-  metadata.gz: bcdd9360d156b170dd79e0f4d3939e18114421bbea55dfb9785f14d0fd4e2c6ecdbd138a2c90ec6189fcb5bd94b1bcccf60b8f200072df37cc3ec17020fe81d9
-  data.tar.gz: 82b16d9a29012e8302fdb1ec5f6552b5891c0f367dca33ed3a05b890930fc18ebb114b3e3480a07fa22aa5d11083e3037a7421851cefc4e204b556c6e76854ac
+  metadata.gz: 05e0ad92dd7d719e60ca00dcefeb68d820ddff726c63914ca3c833747fd623c400b6f7add86debe127aa09206a226ffb6c6453b71c8f986a7dfa25690dde503b
+  data.tar.gz: a1bb6537e3987f1881bd1ce73556411d88e1c9b4596fae3afb3f982ac17e3b37ae52fbd8273fab06b4834a0fd4b82702c51b2328f3155e93407a3c222024283e

data/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 ## main (unreleased)
 
+## 0.21.2 (2024-10-03)
+
+### Bug fixes
+
+* Restore behaviour of URI auto visit for screen elements
+  that define a visit_path that contains a query
+
 ## 0.21.1 (2024-10-03)
 
 ### Bug fixes

data/lib/screengem/screen_element.rb

@@ -25,14 +25,17 @@ module Screengem
 
     #
     # Screen elements may define a visit_path that includes these elements
-    # of a URI: the path, a query string, and a fragment. When deciding to
-    # skip the page.visit we have to consider all of these elements.
+    # of a URI: the path, a query string, and a fragment. We consider only
+    # the path and the fragment when building the current_uri.
+    #
+    # This has the somewhat surprising consequence that a visit_path that contains
+    # a query string will never match the current_uri meaning that we will always
+    # auto visit. This preserves the behaviour in versions prior to 0.21.x.
     #
     def current_uri
       uri = URI(page.current_url)
 
       current_uri = uri.path
-      current_uri += "?#{uri.query}" if uri.query.present?
       current_uri += "##{uri.fragment}" if uri.fragment.present?
 
       current_uri

data/lib/screengem/version.rb

@@ -1,3 +1,3 @@
 module Screengem
-  VERSION = "0.21.1"
+  VERSION = "0.21.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: screengem
 version: !ruby/object:Gem::Version
-  version: 0.21.1
+  version: 0.21.2
 platform: ruby
 authors:
 - Alistair McKinnell