screengem 0.10.1 → 0.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5ec41ff74a250109543e742c6ecd2a0ca79d1d1e9f3f7bdb14eca7ffc8c992d0
-  data.tar.gz: deb4e91553f86e93053b00cd4e9563ca6b33fd9615c4786958e2c18edbb1cd19
+  metadata.gz: 2bb54d35b1502539350c3381b79da394fd82e2eb2857f034d2434491f2c4e61b
+  data.tar.gz: 4afaca0e2dd7978acb5b8eae44fb94e8d9e875a7fb543d4a6cead41ddf65330b
 SHA512:
-  metadata.gz: 5ee82906dcdec034c242ed77982d894ce7f03c3981566871be379d6259a8b63eff0bc4386976d27c41633314b66e254393eb463d6a4c80b5e08192ef51552027
-  data.tar.gz: 90723b078fe87cb3a4ce29bd744b8337c5e6eb6724b0ce6cbee143cab6fb85969720f760211e1f838a298688150019c84f356686786a9ce966d7520a1a415e21
+  metadata.gz: 66ba5384906e5346b9bf60a60499a0f0813adc4a686c3033dbb88cea7ac5ca0c385b77fac58e25451ef1ff53df0c89701b9e50ed74f62947e7ca5e883603418d
+  data.tar.gz: 3042e522c6dd5474e3802cbdba1a3fadde37478b52ce2251640848ed4b5c2d5e65b41d7a8b67cd7f901b12ed7ffccc5ef70c549a8c946016f6242141d4327a99

data/.rubocop.yml

@@ -1,20 +1,44 @@
 require: rubocop-rspec
 
+AllCops:
+  NewCops: enable
+  TargetRubyVersion: 2.7
+
+Gemspec/RequireMFA:
+  Enabled: false
+
+Lint/ConstantDefinitionInBlock:
+  Exclude:
+    - spec/**/*_spec.rb
+
+Layout/LineLength:
+  Max: 120
+
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: false
+
+Lint/RaiseException:
+  Enabled: false
+
+Lint/StructNewOverride:
+  Enabled: false
+
 Metrics/AbcSize:
   Enabled: false
 
 Metrics/BlockLength:
   Enabled: false
 
-Metrics/LineLength:
-  Max: 120
-
 Metrics/MethodLength:
   Enabled: false
 
 Metrics/ModuleLength:
   Enabled: false
 
+Naming/VariableNumber:
+  Enabled: true
+  EnforcedStyle: snake_case
+
 RSpec/AnyInstance:
   Enabled: false
 
@@ -24,6 +48,9 @@ RSpec/DescribedClass:
 RSpec/ExampleLength:
   Max: 20
 
+RSpec/MultipleMemoizedHelpers:
+  Max: 8
+
 RSpec/MultipleExpectations:
   Max: 5
 
@@ -36,9 +63,24 @@ RSpec/MessageSpies:
 RSpec/NotToNot:
   EnforcedStyle: to_not
 
+Style/ExponentialNotation:
+  Enabled: false
+
+Style/HashEachMethods:
+  Enabled: false
+
+Style/HashTransformKeys:
+  Enabled: false
+
+Style/HashTransformValues:
+  Enabled: false
+
 Style/Documentation:
   Enabled: false
 
+Style/DocumentDynamicEvalDefinition:
+  Enabled: false
+
 Style/EmptyMethod:
   Enabled: false
 

data/.ruby-version

@@ -1 +1 @@
-2.5.3
+2.7.4

data/CHANGELOG.md

@@ -2,6 +2,31 @@
 
 ## master (unreleased)
 
+## 0.14.0 (2022-01-06)
+
+* Update the thor dependency
+* Latest development dependencies
+
+## 0.13.0 (2021-06-13)
+
+* Relax the ActiveSupport dependency
+* Latest development dependencies
+
+## 0.12.0 (2021-01-27)
+
+* Relax the thor dependency
+* Latest development dependencies
+
+## 0.11.0 (2020-04-26)
+
+### Breaking Changes
+
+* Questions answer negatively by throwing an exception rather than returning false
+
+## 0.10.1 (2020-01-11)
+
+* Relax the thor dependency
+
 ## 0.10.0 (2020-01-11)
 
 * Remove action abstraction

data/README.md

@@ -30,9 +30,8 @@ A Task responds to perform.
 
 ## Actor Memory
 
-Actors are able to remember and recall facts. This is the recommended way to
-pass state between steps. To clear all actor's memory before each scenario
-add a hook: 
+Actors are able to remember and recall facts. This is the recommended way to pass state
+between steps. To clear every actor's memory before each scenario add a hook:
 
 ```
 Before do
@@ -40,6 +39,20 @@ Before do
 end
 ```
 
+## Performing Tasks
+
+Actors are able to perform tasks. A task may be implemented by interacting with domain services,
+domain models, application databases, and the application via screen elements.
+
+Capybara is available to all screen elements and is the recommended way to interact with a browser.
+
+## Answering Questions
+
+Actors are able to answer questions. A question is considered to be answered affirmatively
+when no exception is thrown and negatively when an exception is thrown.
+
+[RSpec expectations](https://github.com/rspec/rspec-expectations) are available in all questions and are the recommended way to implement a question.
+
 ## Dampening
 
 It sometimes makes sense to slow down the automation. This is known as dampening.

data/lib/screengem/actor.rb

@@ -18,11 +18,7 @@ module Screengem
     #
     def asks(*questions)
       questions.each do |question|
-        question.configure(self, screen)
-
-        next if question.answer
-
-        raise incorrect_answer(question)
+        question.configure(self, screen).answer
       end
 
       self
@@ -33,9 +29,7 @@ module Screengem
     #
     def performs(*tasks)
       tasks.each do |task|
-        task.configure(self, screen)
-
-        task.perform
+        task.configure(self, screen).perform
       end
 
       self
@@ -68,10 +62,6 @@ module Screengem
 
     private
 
-    def incorrect_answer(question)
-      Screengem::IncorrectAnswer.new(question)
-    end
-
     def recollections
       ActorMemory.instance.recollections(self)
     end

data/lib/screengem/factories/question_factory.rb

@@ -6,7 +6,7 @@ module Screengem
     class QuestionFactory < BasicObject
       include ::Singleton
 
-      def method_missing(question_name, *args) # rubocop:disable Style/MethodMissingSuper
+      def method_missing(question_name, *args)
         question_class_name = "#{question_name}_question".camelize
         question_class = "#{question_scope}::#{question_class_name}".constantize
 

data/lib/screengem/factories/task_factory.rb

@@ -6,7 +6,7 @@ module Screengem
     class TaskFactory < BasicObject
       include ::Singleton
 
-      def method_missing(task_name, *args) # rubocop:disable Style/MethodMissingSuper
+      def method_missing(task_name, *args)
         task_class_name = "#{task_name}_task".camelize
         task_class = "#{task_scope}::#{task_class_name}".constantize
 

data/lib/screengem/screen_elements.rb

@@ -22,11 +22,10 @@ module Screengem
       generated_method_names = []
 
       Screengem::ScreenElement.descendants.each do |screen_element_class|
-        class_name = screen_element_class.name
-
         # Skip any anonymous classes. We can't do anything with them. Probably they're from testing.
-        next if class_name.blank?
+        next if screen_element_class.anonymous?
 
+        class_name = screen_element_class.name
         method_name = class_name.demodulize.underscore
 
         # Create some safety by detecting and failing fast for duplicate creation method names.

data/lib/screengem/version.rb

@@ -1,3 +1,3 @@
 module Screengem
-  VERSION = "0.10.1"
+  VERSION = "0.14.0"
 end

data/lib/screengem.rb

@@ -8,7 +8,6 @@ require "capybara/dsl"
 require "rspec/expectations"
 
 require "screengem/automatic_visit"
-require "screengem/incorrect_answer"
 require "screengem/rails_routes"
 require "screengem/screen_element"
 require "screengem/screengem_error"

data/screengem.gemspec

@@ -27,18 +27,19 @@ Gem::Specification.new do |spec|
   spec.bindir = "exe"
   spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
-  spec.required_ruby_version = "~> 2.5"
+  spec.required_ruby_version = ">= 2.7"
 
-  spec.add_runtime_dependency "activesupport", ">= 4.2", "< 6.1"
+  spec.add_runtime_dependency "activesupport", ">= 5.2", "< 6.2"
   spec.add_runtime_dependency "capybara", ">= 2.18", "< 4.0"
-  spec.add_runtime_dependency "require_all", ">= 2.0", "< 4.0"
-  spec.add_runtime_dependency "rspec-expectations", "~> 3.8"
-  spec.add_runtime_dependency "thor", ">= 0.20", "< 1.1"
+  spec.add_runtime_dependency "require_all", ">= 3.0", "< 4.0"
+  spec.add_runtime_dependency "rspec-expectations", "~> 3.10"
+  spec.add_runtime_dependency "thor", "~> 1.2"
 
   spec.add_development_dependency "rake", "~> 13.0"
   spec.add_development_dependency "rspec", "~> 3.9"
-  spec.add_development_dependency "rubocop", "~> 0.79"
-  spec.add_development_dependency "rubocop-performance", "~> 1.5"
-  spec.add_development_dependency "rubocop-rspec", "~> 1.37"
-  spec.add_development_dependency "simplecov", "~> 0.17"
+  spec.add_development_dependency "rubocop", "~> 1.24"
+  spec.add_development_dependency "rubocop-performance", "~> 1.13"
+  spec.add_development_dependency "rubocop-rake", "~> 0.6"
+  spec.add_development_dependency "rubocop-rspec", "~> 2.7"
+  spec.add_development_dependency "simplecov", "~> 0.21"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: screengem
 version: !ruby/object:Gem::Version
-  version: 0.10.1
+  version: 0.14.0
 platform: ruby
 authors:
 - Alistair McKinnell
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-01-12 00:00:00.000000000 Z
+date: 2022-01-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -16,20 +16,20 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.2'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6.1'
+        version: '6.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.2'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6.1'
+        version: '6.2'
 - !ruby/object:Gem::Dependency
   name: capybara
   requirement: !ruby/object:Gem::Requirement
@@ -56,7 +56,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.0'
     - - "<"
       - !ruby/object:Gem::Version
         version: '4.0'
@@ -66,7 +66,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.0'
     - - "<"
       - !ruby/object:Gem::Version
         version: '4.0'
@@ -76,34 +76,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.8'
+        version: '3.10'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.8'
+        version: '3.10'
 - !ruby/object:Gem::Dependency
   name: thor
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0.20'
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '1.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0.20'
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '1.2'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -138,57 +132,71 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.79'
+        version: '1.24'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.79'
+        version: '1.24'
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '1.13'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.13'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '0.6'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.37'
+        version: '2.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.37'
+        version: '2.7'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.17'
+        version: '0.21'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.17'
-description: 
+        version: '0.21'
+description:
 email:
 - alistairm@nulogy.com
 executables:
@@ -201,7 +209,6 @@ files:
 - ".rubocop"
 - ".rubocop.yml"
 - ".ruby-version"
-- ".travis.yml"
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
@@ -227,7 +234,6 @@ files:
 - lib/screengem/factories/factory_creation_error.rb
 - lib/screengem/factories/question_factory.rb
 - lib/screengem/factories/task_factory.rb
-- lib/screengem/incorrect_answer.rb
 - lib/screengem/primitive_key.rb
 - lib/screengem/question.rb
 - lib/screengem/rails_routes.rb
@@ -245,23 +251,23 @@ metadata:
   changelog_uri: https://github.com/nulogy/screengem/blob/master/CHANGELOG.md
   source_code_uri: https://github.com/nulogy/screengem
   bug_tracker_uri: https://github.com/nulogy/screengem/issues
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - "~>"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: '2.5'
+      version: '2.7'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.1.6
+signing_key:
 specification_version: 4
 summary: Ruby implementation of the Screengem Pattern.
 test_files: []

data/.travis.yml

@@ -1,5 +0,0 @@
-sudo: false
-language: ruby
-rvm:
-  - 2.3.3
-before_install: gem install bundler -v 1.16.2

data/lib/screengem/incorrect_answer.rb

@@ -1,23 +0,0 @@
-module Screengem
-  #
-  # Common error to signal a question that was answered incorrectly.
-  #
-  class IncorrectAnswer < RuntimeError
-    def initialize(question)
-      super(extract_question_text(question))
-    end
-
-    private
-
-    #
-    # Transforms question class name into a text message.
-    #
-    # Example:
-    #
-    #   Questions::SignatureCapturedQuestion is transformed to 'Signature captured?'.
-    #
-    def extract_question_text(question)
-      question.class.name.demodulize.underscore.humanize.gsub(" question", "?")
-    end
-  end
-end