screengem 0.10.1 → 0.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5ec41ff74a250109543e742c6ecd2a0ca79d1d1e9f3f7bdb14eca7ffc8c992d0
-  data.tar.gz: deb4e91553f86e93053b00cd4e9563ca6b33fd9615c4786958e2c18edbb1cd19
+  metadata.gz: cd011339a587030b0f8c3e17df9684755b66025d6728228be0e4333c716cb71c
+  data.tar.gz: aa205821d3e4a36495f5d2614807c2f85189cd0c053218e926c055bab8ee90ff
 SHA512:
-  metadata.gz: 5ee82906dcdec034c242ed77982d894ce7f03c3981566871be379d6259a8b63eff0bc4386976d27c41633314b66e254393eb463d6a4c80b5e08192ef51552027
-  data.tar.gz: 90723b078fe87cb3a4ce29bd744b8337c5e6eb6724b0ce6cbee143cab6fb85969720f760211e1f838a298688150019c84f356686786a9ce966d7520a1a415e21
+  metadata.gz: 78ee26817bdf61174c260f6e8d9ec4b2108c595671a7cad0a79dfadf6355d283126196d124f08704a5e28579ca3c7e7b12cdab5232aa62a82998644e35bf117b
+  data.tar.gz: 4761eea85f9258e23b9b34efd5eb271c3e84738615e347bc0fe694fc257e7156deee4f11f16aed9f451c37ee0e13e5c0bfa2521efbe8a2fec34f0666630b0d80

data/.rubocop.yml

@@ -1,5 +1,17 @@
 require: rubocop-rspec
 
+AllCops:
+  TargetRubyVersion: 2.5
+
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: false
+
+Lint/RaiseException:
+  Enabled: false
+
+Lint/StructNewOverride:
+  Enabled: false
+
 Metrics/AbcSize:
   Enabled: false
 
@@ -36,6 +48,18 @@ RSpec/MessageSpies:
 RSpec/NotToNot:
   EnforcedStyle: to_not
 
+Style/ExponentialNotation:
+  Enabled: false
+
+Style/HashEachMethods:
+  Enabled: false
+
+Style/HashTransformKeys:
+  Enabled: false
+
+Style/HashTransformValues:
+  Enabled: false
+
 Style/Documentation:
   Enabled: false
 

data/.ruby-version

@@ -1 +1 @@
-2.5.3
+2.6.6

data/CHANGELOG.md

@@ -2,6 +2,16 @@
 
 ## master (unreleased)
 
+## 0.11.0 (2020-04-26)
+
+### Breaking Changes
+
+* Questions answer negatively by throwing an exception rather than returning false
+
+## 0.10.1 (2020-01-11)
+
+* Relax the thor dependency
+
 ## 0.10.0 (2020-01-11)
 
 * Remove action abstraction

data/README.md

@@ -30,9 +30,8 @@ A Task responds to perform.
 
 ## Actor Memory
 
-Actors are able to remember and recall facts. This is the recommended way to
-pass state between steps. To clear all actor's memory before each scenario
-add a hook: 
+Actors are able to remember and recall facts. This is the recommended way to pass state
+between steps. To clear every actor's memory before each scenario add a hook:
 
 ```
 Before do
@@ -40,6 +39,20 @@ Before do
 end
 ```
 
+## Performing Tasks
+
+Actors are able to perform tasks. A task may be implemented by interacting with domain services,
+domain models, application databases, and the application via screen elements.
+
+Capybara is available to all screen elements and is the recommended way to interact with a browser.
+
+## Answering Questions
+
+Actors are able to answer questions. A question is considered to be answered affirmatively
+when no exception is thrown and negatively when an exception is thrown.
+
+RSpec matchers are available to all questions and are the recommended way to implement a question.
+
 ## Dampening
 
 It sometimes makes sense to slow down the automation. This is known as dampening.

data/lib/screengem.rb

@@ -8,7 +8,6 @@ require "capybara/dsl"
 require "rspec/expectations"
 
 require "screengem/automatic_visit"
-require "screengem/incorrect_answer"
 require "screengem/rails_routes"
 require "screengem/screen_element"
 require "screengem/screengem_error"

data/lib/screengem/actor.rb

@@ -18,11 +18,7 @@ module Screengem
     #
     def asks(*questions)
       questions.each do |question|
-        question.configure(self, screen)
-
-        next if question.answer
-
-        raise incorrect_answer(question)
+        question.configure(self, screen).answer
       end
 
       self
@@ -33,9 +29,7 @@ module Screengem
     #
     def performs(*tasks)
       tasks.each do |task|
-        task.configure(self, screen)
-
-        task.perform
+        task.configure(self, screen).perform
       end
 
       self
@@ -68,10 +62,6 @@ module Screengem
 
     private
 
-    def incorrect_answer(question)
-      Screengem::IncorrectAnswer.new(question)
-    end
-
     def recollections
       ActorMemory.instance.recollections(self)
     end

data/lib/screengem/screen_elements.rb

@@ -22,11 +22,10 @@ module Screengem
       generated_method_names = []
 
       Screengem::ScreenElement.descendants.each do |screen_element_class|
-        class_name = screen_element_class.name
-
         # Skip any anonymous classes. We can't do anything with them. Probably they're from testing.
-        next if class_name.blank?
+        next if screen_element_class.anonymous?
 
+        class_name = screen_element_class.name
         method_name = class_name.demodulize.underscore
 
         # Create some safety by detecting and failing fast for duplicate creation method names.

data/lib/screengem/version.rb

@@ -1,3 +1,3 @@
 module Screengem
-  VERSION = "0.10.1"
+  VERSION = "0.11.0"
 end

data/screengem.gemspec

@@ -27,7 +27,7 @@ Gem::Specification.new do |spec|
   spec.bindir = "exe"
   spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
-  spec.required_ruby_version = "~> 2.5"
+  spec.required_ruby_version = ">= 2.5"
 
   spec.add_runtime_dependency "activesupport", ">= 4.2", "< 6.1"
   spec.add_runtime_dependency "capybara", ">= 2.18", "< 4.0"
@@ -37,8 +37,8 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "rake", "~> 13.0"
   spec.add_development_dependency "rspec", "~> 3.9"
-  spec.add_development_dependency "rubocop", "~> 0.79"
+  spec.add_development_dependency "rubocop", "~> 0.82"
   spec.add_development_dependency "rubocop-performance", "~> 1.5"
-  spec.add_development_dependency "rubocop-rspec", "~> 1.37"
-  spec.add_development_dependency "simplecov", "~> 0.17"
+  spec.add_development_dependency "rubocop-rspec", "~> 1.38"
+  spec.add_development_dependency "simplecov", "~> 0.18"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: screengem
 version: !ruby/object:Gem::Version
-  version: 0.10.1
+  version: 0.11.0
 platform: ruby
 authors:
 - Alistair McKinnell
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-01-12 00:00:00.000000000 Z
+date: 2020-04-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -138,14 +138,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.79'
+        version: '0.82'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.79'
+        version: '0.82'
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -166,28 +166,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.37'
+        version: '1.38'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.37'
+        version: '1.38'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.17'
+        version: '0.18'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.17'
+        version: '0.18'
 description: 
 email:
 - alistairm@nulogy.com
@@ -227,7 +227,6 @@ files:
 - lib/screengem/factories/factory_creation_error.rb
 - lib/screengem/factories/question_factory.rb
 - lib/screengem/factories/task_factory.rb
-- lib/screengem/incorrect_answer.rb
 - lib/screengem/primitive_key.rb
 - lib/screengem/question.rb
 - lib/screengem/rails_routes.rb
@@ -251,7 +250,7 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - "~>"
+  - - ">="
     - !ruby/object:Gem::Version
       version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
@@ -260,7 +259,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Ruby implementation of the Screengem Pattern.

data/lib/screengem/incorrect_answer.rb

@@ -1,23 +0,0 @@
-module Screengem
-  #
-  # Common error to signal a question that was answered incorrectly.
-  #
-  class IncorrectAnswer < RuntimeError
-    def initialize(question)
-      super(extract_question_text(question))
-    end
-
-    private
-
-    #
-    # Transforms question class name into a text message.
-    #
-    # Example:
-    #
-    #   Questions::SignatureCapturedQuestion is transformed to 'Signature captured?'.
-    #
-    def extract_question_text(question)
-      question.class.name.demodulize.underscore.humanize.gsub(" question", "?")
-    end
-  end
-end