screen-recorder 1.0.0 → 1.1.0

data/lib/screen-recorder/errors.rb

@@ -1,10 +1,10 @@
-module ScreenRecorder
-  # @since 1.0.0-beta5
-  module Errors
-    # @since 1.0.0-beta3
-    class ApplicationNotFound < StandardError; end
-
-    # @since 1.0.0-beta5
-    class DependencyNotFound < StandardError; end
-  end
+module ScreenRecorder
+  # @since 1.0.0-beta5
+  module Errors
+    # @since 1.0.0-beta3
+    class ApplicationNotFound < StandardError; end
+
+    # @since 1.0.0-beta5
+    class DependencyNotFound < StandardError; end
+  end
 end

data/lib/screen-recorder/options.rb

@@ -1,148 +1,151 @@
-# @since 1.0.0-beta11
-module ScreenRecorder
-  # @since 1.0.0-beta11
-  class Options
-    DEFAULT_LOG_FILE = 'ffmpeg.log'.freeze
-    DEFAULT_FPS      = 15.0
-
-    def initialize(options)
-      TypeChecker.check options, Hash
-      TypeChecker.check options[:advanced], Hash if options[:advanced]
-      @options = verify_options options
-
-      unless advanced[:framerate]
-        advanced[:framerate] = DEFAULT_FPS
-      end
-
-      unless advanced[:log]
-        advanced[:log] = DEFAULT_LOG_FILE
-      end
-    end
-
-    #
-    # Returns given input file or input
-    #
-    def input
-      @options[:input]
-    end
-
-    #
-    # Returns capture device in use
-    #
-    def capture_device
-      determine_capture_device
-    end
-
-    #
-    # Returns given output filepath
-    #
-    def output
-      @options[:output]
-    end
-
-    #
-    # Returns given values that are optional
-    #
-    def advanced
-      @options[:advanced] ||= {}
-    end
-
-    #
-    # Returns given framerate
-    #
-    def framerate
-      advanced[:framerate]
-    end
-
-    #
-    # Returns given log filename
-    #
-    def log
-      advanced[:log]
-    end
-
-    #
-    # Returns all given options
-    #
-    def all
-      @options
-    end
-
-    #
-    # Returns a String with all options parsed and
-    # ready for the ffmpeg process to use
-    #
-    def parsed
-      vals = "-f #{capture_device} "
-      vals << advanced_options unless advanced.empty?
-      vals << "-i #{input} "
-      vals << output
-      vals << ffmpeg_log_to(log) # If provided
-    end
-
-    private
-
-    #
-    # Verifies the required options are provided and returns
-    # the given options Hash. Raises ArgumentError if all required
-    # options are not present in the given Hash.
-    #
-    def verify_options(options)
-      missing_options = required_options.select { |req| options[req].nil? }
-      err             = "Required options are missing: #{missing_options}"
-      raise(ArgumentError, err) unless missing_options.empty?
-
-      options
-    end
-
-    #
-    # Returns Array of required options as Symbols
-    #
-    def required_options
-      %i[input output]
-    end
-
-    #
-    # Returns advanced options parsed and ready for ffmpeg to receive.
-    #
-    def advanced_options
-      arr = []
-
-      # Log file is handled separately at the end of the command
-      advanced.select { |k, _| k != :log }
-        .each do |k, v|
-        arr.push "-#{k} #{v}"
-      end
-      arr.join(' ') + ' '
-    end
-
-    #
-    # Returns logging command with user given log file
-    # from options or the default file.
-    #
-    def ffmpeg_log_to(file)
-      file ||= DEFAULT_LOG_FILE
-      " 2> #{file}"
-    end
-
-    #
-    # Returns input capture device based on user given value or the current OS.
-    #
-    def determine_capture_device
-      # User given capture device or format
-      # @see https://www.ffmpeg.org/ffmpeg.html#Main-options
-      return advanced[:f] if advanced[:f]
-      return advanced[:fmt] if advanced[:fmt]
-
-      if OS.windows?
-        'gdigrab'
-      elsif OS.linux?
-        'x11grab'
-      elsif OS.mac?
-        'avfoundation'
-      else
-        raise NotImplementedError, 'Your OS is not supported.'
-      end
-    end
-  end
-end
+# @since 1.0.0-beta11
+module ScreenRecorder
+  # @since 1.0.0-beta11
+  class Options
+    DEFAULT_LOG_FILE       = 'ffmpeg.log'.freeze
+    DEFAULT_FPS            = 15.0
+    DEFAULT_INPUT_PIX_FMT  = 'uyvy422'.freeze # For macOS / avfoundation
+    DEFAULT_OUTPUT_PIX_FMT = 'yuv420p'.freeze
+
+    def initialize(options)
+      TypeChecker.check options, Hash
+      TypeChecker.check options[:advanced], Hash if options[:advanced]
+      @options = verify_options options
+      advanced[:framerate] ||= DEFAULT_FPS
+      advanced[:log]       ||= DEFAULT_LOG_FILE
+      advanced[:pix_fmt]   ||= DEFAULT_OUTPUT_PIX_FMT
+    end
+
+    #
+    # Returns given input file or input
+    #
+    def input
+      @options[:input]
+    end
+
+    #
+    # Returns capture device in use
+    #
+    def capture_device
+      determine_capture_device
+    end
+
+    #
+    # Returns given output filepath
+    #
+    def output
+      @options[:output]
+    end
+
+    #
+    # Returns given values that are optional
+    #
+    def advanced
+      @options[:advanced] ||= {}
+    end
+
+    #
+    # Returns given framerate
+    #
+    def framerate
+      advanced[:framerate]
+    end
+
+    #
+    # Returns given log filename
+    #
+    def log
+      advanced[:log]
+    end
+
+    #
+    # Returns all given options
+    #
+    def all
+      @options
+    end
+
+    #
+    # Returns a String with all options parsed and
+    # ready for the ffmpeg process to use
+    #
+    def parsed
+      vals = "-f #{capture_device} "
+      vals << "-pix_fmt #{DEFAULT_INPUT_PIX_FMT} " if OS.mac? # Input pixel format
+      vals << advanced_options unless advanced.empty?
+      vals << "-i #{input} "
+      vals << "-pix_fmt #{advanced[:pix_fmt]} " if advanced[:pix_fmt] # Output pixel format
+      # Fix for using yuv420p
+      # @see https://www.reck.dk/ffmpeg-libx264-height-not-divisible-by-2/
+      vals << '-vf "scale=trunc(iw/2)*2:trunc(ih/2)*2" ' if advanced[:pix_fmt] == 'yuv420p'
+      vals << output
+      vals << ffmpeg_log_to(log)
+    end
+
+    private
+
+    #
+    # Verifies the required options are provided and returns
+    # the given options Hash. Raises ArgumentError if all required
+    # options are not present in the given Hash.
+    #
+    def verify_options(options)
+      missing_options = required_options.select { |req| options[req].nil? }
+      err             = "Required options are missing: #{missing_options}"
+      raise(ArgumentError, err) unless missing_options.empty?
+
+      options
+    end
+
+    #
+    # Returns Array of required options as Symbols
+    #
+    def required_options
+      %i[input output]
+    end
+
+    #
+    # Returns advanced options parsed and ready for ffmpeg to receive.
+    #
+    def advanced_options
+      arr = []
+
+      # Log file and output pixel format is handled separately
+      # at the end of the command
+      advanced.reject { |k, _| %i[log pix_fmt].include? k }
+        .each do |k, v|
+        arr.push "-#{k} #{v}"
+      end
+      arr.join(' ') + ' '
+    end
+
+    #
+    # Returns logging command with user given log file
+    # from options or the default file.
+    #
+    def ffmpeg_log_to(file)
+      file ||= DEFAULT_LOG_FILE
+      " 2> #{file}"
+    end
+
+    #
+    # Returns input capture device based on user given value or the current OS.
+    #
+    def determine_capture_device
+      # User given capture device or format
+      # @see https://www.ffmpeg.org/ffmpeg.html#Main-options
+      return advanced[:f] if advanced[:f]
+      return advanced[:fmt] if advanced[:fmt]
+
+      if OS.windows?
+        'gdigrab'
+      elsif OS.linux?
+        'x11grab'
+      elsif OS.mac?
+        'avfoundation'
+      else
+        raise NotImplementedError, 'Your OS is not supported.'
+      end
+    end
+  end
+end

data/lib/screen-recorder/titles.rb

@@ -1,82 +1,50 @@
-module ScreenRecorder
-  # @since 1.0.0-beta4
-  module Titles
-    # Regex to filter out "Window Title: N/A" from Chrome extensions and "Window Title: ".
-    # This is done to remove unusable titles and to match the Ffmpeg expected input format
-    # for capturing specific windows.
-    # For example, "Window Title: Google - Mozilla Firefox" becomes "Google - Mozilla Firefox".
-    FILTERED_TITLES = %r{^Window Title:( N/A|\s+)?}
-
-    #
-    # Returns a list of available window titles for the given application (process) name.
-    #
-    def self.fetch(application)
-      ScreenRecorder.logger.debug "Retrieving available windows for: #{application}"
-      WindowGrabber.new.available_windows_for application
-    end
-
-    # @since 1.0.0-beta4
-    class WindowGrabber
-      #
-      # Returns a cleaned up list of available window titles
-      # for the given application (process) name.
-      #
-      def available_windows_for(application)
-        return windows_os_window(application) if OS.windows?
-        return linux_os_window(application) if OS.linux?
-
-        raise NotImplementedError, 'Your OS is not supported.'
-      end
-
-      private
-
-      #
-      # Returns list of window titles in FFmpeg expected format when using Microsoft Windows
-      #
-      def windows_os_window(application)
-        titles = `tasklist /v /fi "imagename eq #{application}.exe" /fo list | findstr  Window`
-                   .split("\n")
-                   .map { |i| i.gsub(FILTERED_TITLES, '') }
-                   .reject(&:empty?)
-        raise Errors::ApplicationNotFound, "No open windows found for: #{application}.exe" if titles.empty?
-
-        warn_on_mismatch(titles, application)
-        titles
-      end
-
-      #
-      # Returns list of window titles in FFmpeg expected format when using Linux
-      #
-      def linux_os_window(application)
-        ScreenRecorder.logger.warn 'Default capture device on Linux (x11grab) does not support window recording.'
-        raise DependencyNotFound, 'wmctrl is not installed. Run: sudo apt install wmctrl.' unless wmctrl_installed?
-
-        titles = `wmctrl -l | awk '{$3=""; $2=""; $1=""; print $0}'` # Returns all open windows
-                   .split("\n")
-                   .map(&:strip)
-                   .select { |t| t.match?(/#{application}/i) } # Narrow down to given application
-        raise Errors::ApplicationNotFound, "No open windows found for: #{application}" if titles.empty?
-
-        titles
-      end
-
-      #
-      # Returns true if wmctrl is installed
-      #
-      def wmctrl_installed?
-        !`which wmctrl`.empty? # "" when not found
-      end
-
-      #
-      # Prints a warning if the retrieved list of window titles does no include
-      # the given application process name, which applications commonly do.
-      #
-      def warn_on_mismatch(titles, application)
-        unless titles.map(&:downcase).join(',').include? application.to_s
-          ScreenRecorder.logger.warn "Process name and window title(s) do not match: #{titles}"
-          ScreenRecorder.logger.warn "Please manually provide the displayed window title."
-        end
-      end
-    end # class WindowGrabber
-  end # module Windows
+module ScreenRecorder
+  # @since 1.0.0-beta4
+  module Titles
+    # Regex to filter out "Window Title: N/A" from Chrome extensions and "Window Title: ".
+    # This is done to remove unusable titles and to match the Ffmpeg expected input format
+    # for capturing specific windows.
+    # For example, "Window Title: Google - Mozilla Firefox" becomes "Google - Mozilla Firefox".
+    FILTERED_TITLES = %r{^Window Title:( N/A|\s+)?}.freeze
+
+    #
+    # Returns a list of available window titles for the given application (process) name.
+    #
+    def self.fetch(application)
+      ScreenRecorder.logger.debug "Retrieving available windows for: #{application}"
+      WindowGrabber.new.available_windows_for application
+    end
+
+    # @since 1.0.0-beta4
+    class WindowGrabber
+      #
+      # Returns a list of available window titles for the given application (process) name.
+      #
+      def available_windows_for(application)
+        raise NotImplementedError, 'Only Microsoft Windows (gdigrab) supports window capture.' unless OS.windows?
+
+        titles = `tasklist /v /fi "imagename eq #{application}.exe" /fo list | findstr  Window`
+                   .split("\n")
+                   .map { |i| i.gsub(FILTERED_TITLES, '') }
+                   .reject(&:empty?)
+        raise Errors::ApplicationNotFound, "No open windows found for: #{application}.exe" if titles.empty?
+
+        warn_on_mismatch(titles, application)
+        titles
+      end
+
+      private
+
+      #
+      # Prints a warning if the retrieved list of window titles does no include
+      # the given application process name, which applications commonly do.
+      #
+      def warn_on_mismatch(titles, application)
+        return if titles.map(&:downcase).join(',').include? application.to_s
+
+        ScreenRecorder.logger.warn "Process name and window title(s) do not match: #{titles}"
+        ScreenRecorder.logger.warn 'Please manually provide the displayed window title.'
+      end
+    end # class WindowGrabber
+  end # module Windows
 end # module FFMPEG