scout_apm_logging 0.0.7 → 0.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 820ef17ae470e00a8860d6cb25ba09fb908c5c1c2396a564144e8336be787c0f
-  data.tar.gz: 3338d6fbdc74aa519db27e0017b23af3ede6f6bf7a1e3df4c10ca798e6bc6331
+  metadata.gz: b613ee5835fad514e57720ba9349bb90bc2eea19821891998655353d50447f3c
+  data.tar.gz: 29a0dda4469c4a4a2465816cc3cacfd332ae545af37f0b694c7aa3b6afb83ca6
 SHA512:
-  metadata.gz: 2e2e011988efb53ed021f0003efab939181af9df79f5ac7b90eea773c0cbf87641f410ea34b4904022bce5ab37f310287e4a04293bee53c66d9d16d988b0aa20
-  data.tar.gz: '086fd228d639e53c693e05d9cd43f6200cd38f3df7dfa087e1f609fc51dec9b1621e51f06bf1c68eddaed19188c0772250b7249fa550e7a3f5d96a45519cd8f6'
+  metadata.gz: 991c4af38d8027255b65a0e1225f0b3f295a3f6e76f2dbcb46a13b91644420b684f8c9ab343eb04708ed3dc499a46e38ea1ee8b2924e78361ea469a033d63d22
+  data.tar.gz: 667b91726ad60e9415d90db45fcef50f73f317308d42d1b17686bb1ae2de791ba75903e4bd5d9fbbcbe7009809b187fc468d6ebf18945edc5c6fa2f6e637b674

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 0.0.8
+* Fix internal method names for proxy logger to prevent accidental overriding.
+* Re-broadcast to console in development for the proxy logger.
+* Fix tags not being removed when yielded contents throw an exception.
+* Fix missing return statement, where tagged logging patches were being added to unintended loggers.
+
 ## 0.0.7
 * Fix determined logger level comparison
 

data/lib/scout_apm/logging/loggers/logger.rb

@@ -3,7 +3,9 @@
 module ScoutApm
   module Logging
     module Loggers
+      # The actual instance of the logger.
       class FileLogger < ::Logger
+        include ::ActiveSupport::LoggerSilence if const_defined?('::ActiveSupport::LoggerSilence')
       end
 
       # The newly created logger which we can configure, and will log to a filepath.

data/lib/scout_apm/logging/loggers/patches/tagged_logging.rb

@@ -11,8 +11,8 @@ module ScoutApm
         # Patches TaggedLogging to work with our loggers.
         module TaggedLogging
           def tagged(*tags) # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
-            super(*tags) unless (self == ::Rails.logger && is_a?(ScoutApm::Logging::Loggers::Proxy)) ||
-                                (::Rails.logger.respond_to?(:broadcasts) && ::Rails.logger.broadcasts.include?(self))
+            return super(*tags) unless (self == ::Rails.logger && is_a?(ScoutApm::Logging::Loggers::Proxy)) ||
+                                       (::Rails.logger.respond_to?(:broadcasts) && ::Rails.logger.broadcasts.include?(self))
 
             if is_a?(ScoutApm::Logging::Loggers::Proxy)
               if block_given?
@@ -20,8 +20,13 @@ module ScoutApm
                 loggers = @loggers[1..]
                 pushed_counts = extend_and_push_tags(loggers, *tags)
 
-                formatter.tagged(*tags) { yield self }.tap do
+                begin
+                  formatter.tagged(*tags) { yield self }.tap do
+                    logger_pop_tags(loggers, pushed_counts)
+                  end
+                rescue StandardError => e
                   logger_pop_tags(loggers, pushed_counts)
+                  raise e
                 end
               else
                 loggers = instance_variable_get(:@loggers)
@@ -36,9 +41,13 @@ module ScoutApm
               # We skip the first logger to prevent double tagging when calling formatter.tagged
               loggers = ::Rails.logger.broadcasts[1..]
               pushed_counts = extend_and_push_tags(loggers, *tags)
-
-              formatter.tagged(*tags) { yield self }.tap do
+              begin
+                formatter.tagged(*tags) { yield self }.tap do
+                  logger_pop_tags(loggers, pushed_counts)
+                end
+              rescue StandardError => e
                 logger_pop_tags(loggers, pushed_counts)
+                raise e
               end
             else
               broadcasts = ::Rails.logger.broadcasts

data/lib/scout_apm/logging/loggers/proxy.rb

@@ -7,7 +7,7 @@ module ScoutApm
       class Proxy
         def self.create_with_loggers(*loggers)
           new.tap do |proxy_logger|
-            loggers.each { |logger| proxy_logger.add(logger) }
+            loggers.each { |logger| proxy_logger.add_scout_loggers(logger) }
           end
         end
 
@@ -15,11 +15,11 @@ module ScoutApm
           @loggers = []
         end
 
-        def add(logger)
+        def add_scout_loggers(logger)
           @loggers << logger
         end
 
-        def remove(logger)
+        def remove_scout_loggers(logger)
           @loggers.reject! { |inst_log| inst_log == logger }
 
           @loggers

data/lib/scout_apm/logging/loggers/swaps/rails.rb

@@ -38,7 +38,7 @@ module ScoutApm
           end
 
           # Eseentially creates the original logger.
-          def original_logger
+          def original_logger # rubocop:disable Metrics/AbcSize
             # We can use the previous logdev. log_device will continuously call write
             # through the devices until the logdev (@dev) is an IO device other than logdev:
             # https://github.com/ruby/ruby/blob/master/lib/logger/log_device.rb#L42
@@ -48,6 +48,14 @@ module ScoutApm
             ::Logger.new(original_logdevice).tap do |logger|
               logger.level = log_instance.level
               logger.formatter = log_instance.formatter
+
+              if ::Rails.env.development? && $stdout.tty? && $stderr.tty?
+                next if ActiveSupport::Logger.respond_to?(:logger_outputs_to?) && ActiveSupport::Logger.logger_outputs_to?(
+                  logger, $stdout, $stderr
+                )
+
+                logger.extend(ActiveSupport::Logger.broadcast(ActiveSupport::Logger.new($stdout)))
+              end
             end
           end
 

data/lib/scout_apm/logging/version.rb

@@ -2,6 +2,6 @@
 
 module ScoutApm
   module Logging
-    VERSION = '0.0.7'
+    VERSION = '0.0.8'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: scout_apm_logging
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
 platform: ruby
 authors:
 - Scout APM
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-08-20 00:00:00.000000000 Z
+date: 2024-08-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: scout_apm