scout_apm_logging 0.0.5 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a74ddd478e8429ef76315b9bdb23557583719b0ed241f0fecb1c0a6658b4efe7
-  data.tar.gz: 72bc063672bff254e893c196662c69cc06934297379e21ee3482e15974b4f465
+  metadata.gz: 820ef17ae470e00a8860d6cb25ba09fb908c5c1c2396a564144e8336be787c0f
+  data.tar.gz: 3338d6fbdc74aa519db27e0017b23af3ede6f6bf7a1e3df4c10ca798e6bc6331
 SHA512:
-  metadata.gz: 4f5ba120cff4d9087ce213736477eebb687159b126f415bf7e6ea2c3ddbf7b6058aa48b605f91031d4883af1b20019010a4f01ee6871b1fda79b5ff02cf29111
-  data.tar.gz: f029117cdc4d4b83d26dd5cbb67a9ac7f64fac72c67763d97bb6a712b3f566a0d9661a463c6f563b86aa18369e69188f6251e3c791035e6c737bc6155e5c2ae8
+  metadata.gz: 2e2e011988efb53ed021f0003efab939181af9df79f5ac7b90eea773c0cbf87641f410ea34b4904022bce5ab37f310287e4a04293bee53c66d9d16d988b0aa20
+  data.tar.gz: '086fd228d639e53c693e05d9cd43f6200cd38f3df7dfa087e1f609fc51dec9b1621e51f06bf1c68eddaed19188c0772250b7249fa550e7a3f5d96a45519cd8f6'

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 0.0.7
+* Fix determined logger level comparison
+
+## 0.0.6
+* Ensure logger level is set back to the original.
+
 ## 0.0.5
 * Remove `msg` attribute after it has been moved to the log body to prevent duplication.
 

data/lib/scout_apm/logging/loggers/logger.rb

@@ -25,7 +25,7 @@ module ScoutApm
 
           FileLogger.new(determine_file_path, LOG_AGE, log_size).tap do |logger|
             # Ruby's Logger handles a lot of the coercion itself.
-            logger.level = context.config.value('logs_capture_level')
+            logger.level = determined_log_level
             # Add our custom formatter to the logger.
             logger.formatter = Formatter.new
           end
@@ -55,6 +55,22 @@ module ScoutApm
 
         private
 
+        # This makes the assumption that the logs we capture should be
+        # at least that of the original logger level, and not lower, but can be
+        # configured to be a higher cutoff.
+        def determined_log_level
+          capture_level = context.config.value('logs_capture_level')
+          capture_value = ::Logger::Severity.const_get(capture_level.upcase)
+
+          log_instance_value = if log_instance.level.is_a?(Integer)
+                                 log_instance.level
+                               else
+                                 ::Logger::Severity.const_get(log_instance.level.to_s.upcase)
+                               end
+
+          [capture_value, log_instance_value].max
+        end
+
         def find_log_destination(logdev)
           dev = try(logdev, :filename) || try(logdev, :dev)
           if dev.is_a?(String)

data/lib/scout_apm/logging/loggers/swaps/rails.rb

@@ -46,6 +46,7 @@ module ScoutApm
             original_logdevice = log_instance.instance_variable_get(:@logdev)
 
             ::Logger.new(original_logdevice).tap do |logger|
+              logger.level = log_instance.level
               logger.formatter = log_instance.formatter
             end
           end

data/lib/scout_apm/logging/loggers/swaps/scout.rb

@@ -41,6 +41,7 @@ module ScoutApm
             original_logdevice = log_instance.instance_variable_get(:@logdev)
 
             ::Logger.new(original_logdevice).tap do |logger|
+              logger.level = log_instance.level
               logger.formatter = log_instance.formatter
             end
           end

data/lib/scout_apm/logging/loggers/swaps/sidekiq.rb

@@ -41,6 +41,7 @@ module ScoutApm
             original_logdevice = log_instance.instance_variable_get(:@logdev)
 
             ::Logger.new(original_logdevice).tap do |logger|
+              logger.level = log_instance.level
               logger.formatter = log_instance.formatter
             end
           end

data/lib/scout_apm/logging/version.rb

@@ -2,6 +2,6 @@
 
 module ScoutApm
   module Logging
-    VERSION = '0.0.5'
+    VERSION = '0.0.7'
   end
 end

data/spec/integration/rails/lifecycle_spec.rb

@@ -47,6 +47,7 @@ describe ScoutApm::Logging do
     expect(messages.count('[TEST] Some log')).to eq(1)
     expect(messages.count('[YIELD] Yield Test')).to eq(1)
     expect(messages.count('Another Log')).to eq(1)
+    expect(messages.count('Should not be captured')).to eq(0)
 
     log_locations = lines.map { |item| item['log_location'] }.compact
 

data/spec/rails/app.rb

@@ -12,6 +12,7 @@ Rails.logger = ActiveSupport::TaggedLogging.new(Logger.new($stdout))
 
 class App < ::Rails::Application
   config.eager_load = false
+  config.log_level = :info
 
   routes.append do
     root to: 'root#index'
@@ -24,6 +25,8 @@ class RootController < ActionController::Base
     Rails.logger.tagged('TEST').info('Some log')
     Rails.logger.tagged('YIELD') { logger.info('Yield Test') }
     Rails.logger.info('Another Log')
+    Rails.logger.debug('Should not be captured')
+
     render plain: Rails.version
   end
 end

data/spec/unit/loggers/capture_spec.rb

@@ -19,6 +19,7 @@ describe ScoutApm::Logging::Loggers::Capture do
     ENV['SCOUT_MONITOR_INTERVAL'] = '10'
     ENV['SCOUT_MONITOR_INTERVAL_DELAY'] = '10'
     ENV['SCOUT_LOGS_MONITOR'] = 'true'
+    ENV['SCOUT_LOGS_CAPTURE_LEVEL'] = 'debug'
 
     output_from_log = capture_stdout do
       context = ScoutApm::Logging::Context.new
@@ -26,7 +27,10 @@ describe ScoutApm::Logging::Loggers::Capture do
       conf = ScoutApm::Logging::Config.with_file(context, conf_file)
       context.config = conf
 
-      TestLoggerWrapper.logger = ScoutTestLogger.new($stdout)
+      test_logger = ScoutTestLogger.new($stdout)
+      test_logger.level = 'INFO'
+
+      TestLoggerWrapper.logger = test_logger
 
       capture = ScoutApm::Logging::Loggers::Capture.new(context)
       capture.setup!
@@ -34,16 +38,22 @@ describe ScoutApm::Logging::Loggers::Capture do
       expect(TestLoggerWrapper.logger.class).to eq(ScoutApm::Logging::Loggers::Proxy)
 
       TestLoggerWrapper.logger.info('TEST')
+      TestLoggerWrapper.logger.debug('SHOULD NOT CAPTURE')
 
       log_path = File.join(context.config.value('logs_proxy_log_dir'), 'test.log')
       content = File.read(log_path)
       expect(content).to include('TEST')
 
+      # Shouldn't capture. While the log_capture_level was set to debug,
+      # the original logger instance had a higher log level of info.
+      expect(content).not_to include('SHOULD NOT CAPTURE')
+
       state_file = File.read(context.config.value('monitor_state_file'))
       state_data = JSON.parse(state_file)
       expect(state_data['logs_monitored']).to eq([log_path])
     end
 
     expect(output_from_log).to include('TEST')
+    expect(output_from_log).not_to include('SHOULD NOT CAPTURE')
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: scout_apm_logging
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.7
 platform: ruby
 authors:
 - Scout APM
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-08-14 00:00:00.000000000 Z
+date: 2024-08-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: scout_apm
@@ -146,7 +146,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.0.8
 signing_key:
 specification_version: 4
 summary: Ruby Logging Support