scout_apm 5.3.3 → 5.6.4

data/lib/scout_apm/environment.rb

@@ -31,6 +31,8 @@ module ScoutApm
       ScoutApm::BackgroundJobIntegrations::DelayedJob.new,
       ScoutApm::BackgroundJobIntegrations::Que.new,
       ScoutApm::BackgroundJobIntegrations::Faktory.new,
+      ScoutApm::BackgroundJobIntegrations::GoodJob.new,
+      ScoutApm::BackgroundJobIntegrations::SolidQueue.new,
     ]
 
     FRAMEWORK_INTEGRATIONS = [

data/lib/scout_apm/error_service/sidekiq.rb

@@ -28,7 +28,7 @@ module ScoutApm
 
       def install_sidekiq_with_error_handler
         ::Sidekiq.configure_server do |config|
-          config.error_handlers << proc { |exception, job_info|
+          config.error_handlers << proc { |exception, job_info, sidekiq_config|
             context = ScoutApm::Agent.instance.context
 
             # Bail out early, and reraise if the error is not interesting.

data/lib/scout_apm/git_revision.rb

@@ -20,6 +20,7 @@ module ScoutApm
       detect_from_config     ||
       detect_from_heroku     ||
       detect_from_capistrano ||
+      detect_from_kamal ||
       detect_from_mina ||
       detect_from_git
     end
@@ -44,8 +45,13 @@ module ScoutApm
       nil
     end
 
+    # https://github.com/basecamp/kamal
+    def detect_from_kamal
+      ENV['KAMAL_VERSION']
+    end
+
     # https://github.com/mina-deploy/mina
-    def detect_from_mina 
+    def detect_from_mina
       File.read(File.join(app_root, '.mina_git_revision')).strip
     rescue
       logger.debug "Unable to detect Git Revision from Mina: #{$!.message}"

data/lib/scout_apm/instruments/action_view.rb

@@ -72,9 +72,67 @@ module ScoutApm
 
         logger.info "Instrumenting ActionView::TemplateRenderer"
         ::ActionView::TemplateRenderer.prepend(ActionViewTemplateRendererInstruments)
+
+        if defined?(::ActionView::CollectionRenderer)
+          logger.info "Instrumenting ActionView::CollectionRenderer"
+          ::ActionView::CollectionRenderer.prepend(ActionViewCollectionRendererInstruments)
+        end
+      end
+
+      # In Rails 6.1 collection was moved to CollectionRenderer.
+      module ActionViewCollectionRendererInstruments
+        def render_collection(*args, **kwargs)
+          req = ScoutApm::RequestManager.lookup
+
+          maybe_template = args[3]
+
+          template_name ||= maybe_template.virtual_path rescue nil
+          template_name ||= "Unknown Collection"
+          layer_name = template_name + "/Rendering"
+
+          layer = ScoutApm::Layer.new("View", layer_name)
+          layer.subscopable!
+
+          begin
+            req.start_layer(layer)
+            if ScoutApm::Agent.instance.context.environment.supports_kwarg_delegation?
+              super(*args, **kwargs)
+            else
+              super(*args)
+            end
+          ensure
+            req.stop_layer
+          end
+        end
       end
 
       module ActionViewPartialRendererInstruments
+        # In Rails 6.1, render_partial was renamed to render_partial_template
+        def render_partial_template(*args, **kwargs)
+          req = ScoutApm::RequestManager.lookup
+
+          # Template was moved to the third argument in Rails 6.1.
+          maybe_template = args[2]
+
+          template_name ||= maybe_template.virtual_path rescue nil
+          template_name ||= "Unknown Partial"
+
+          layer_name = template_name + "/Rendering"
+          layer = ScoutApm::Layer.new("View", layer_name)
+          layer.subscopable!
+
+          begin
+            req.start_layer(layer)
+            if ScoutApm::Agent.instance.context.environment.supports_kwarg_delegation?
+              super(*args, **kwargs)
+            else
+              super(*args)
+            end
+          ensure
+            req.stop_layer
+          end
+        end
+
         # In Rails 6, the signature changed to pass the view & template args directly, as opposed to through the instance var
         # New signature is: def render_partial(view, template)
         def render_partial(*args, **kwargs)
@@ -83,7 +141,7 @@ module ScoutApm
           maybe_template = args[1]
 
           template_name = @template.virtual_path rescue nil        # Works on Rails 3.2 -> end of Rails 5 series
-          template_name ||= maybe_template.virtual_path rescue nil # Works on Rails 6 -> 6.0.3.5
+          template_name ||= maybe_template.virtual_path rescue nil # Works on Rails 6 -> 6.0.6
           template_name ||= "Unknown Partial"
 
           layer_name = template_name + "/Rendering"
@@ -102,13 +160,14 @@ module ScoutApm
           end
         end
 
+        # This method was moved in Rails 6.1 to CollectionRender. 
         def collection_with_template(*args, **kwargs)
           req = ScoutApm::RequestManager.lookup
 
           maybe_template = args[1]
 
           template_name = @template.virtual_path rescue nil # Works on Rails 3.2 -> end of Rails 5 series
-          template_name ||= maybe_template.virtual_path rescue nil # Works on Rails 6 -> 6.0.3.5
+          template_name ||= maybe_template.virtual_path rescue nil # Works on Rails 6 -> 6.0.6
           template_name ||= "Unknown Collection"
           layer_name = template_name + "/Rendering"
 
@@ -137,7 +196,7 @@ module ScoutApm
           maybe_template = args[1]
 
           template_name = args[0].virtual_path rescue nil # Works on Rails 3.2 -> end of Rails 5 series
-          template_name ||= maybe_template.virtual_path rescue nil # Works on Rails 6 -> 6.1.3
+          template_name ||= maybe_template.virtual_path rescue nil # Works on Rails 6 -> 7.1.3
           template_name ||= "Unknown"
           layer_name = template_name + "/Rendering"
 

data/lib/scout_apm/instruments/active_record.rb

@@ -66,7 +66,7 @@ module ScoutApm
         defined?(::Rails) &&
           defined?(::Rails::VERSION) &&
           defined?(::Rails::VERSION::MAJOR) &&
-          ::Rails::VERSION::MAJOR.to_i == 3 &&
+          ::Rails::VERSION::MAJOR.to_i >= 3 &&
           ::Rails.respond_to?(:configuration)
       end
 

data/lib/scout_apm/instruments/grape.rb

@@ -53,7 +53,7 @@ module ScoutApm
                   self.options[:path].first,
           ].compact.map{ |n| n.to_s }.join("/")
         rescue => e
-          logger.info("Error getting Grape Endpoint Name. Error: #{e.message}. Options: #{self.options.inspect}")
+          ScoutApm::Agent.instance.context.logger.info("Error getting Grape Endpoint Name. Error: #{e.message}. Options: #{self.options.inspect}")
           name = "Grape/Unknown"
         end
 

data/lib/scout_apm/instruments/mongoid.rb

@@ -20,25 +20,12 @@ module ScoutApm
         @installed = true
 
         # Mongoid versions that use Moped should instrument Moped.
+        ### See moped instrument for Moped driven deploys
         if defined?(::Mongoid) and !defined?(::Moped)
-          logger.info "Instrumenting Mongoid 2.x"
           @installed = true
 
-          ### OLD (2.x) mongoids
-          if defined?(::Mongoid::Collection)
-            ::Mongoid::Collection.class_eval do
-              include ScoutApm::Tracer
-              (::Mongoid::Collections::Operations::ALL - [:<<, :[]]).each do |method|
-                instrument_method method, :type => "MongoDB", :name => '#{@klass}/' + method.to_s
-              end
-            end
-          end
-
-          ### See moped instrument for Moped driven deploys
-
-          ### 5.x Mongoid
-          if (mongoid_v5? || mongoid_v6? || mongoid_v7?) && defined?(::Mongoid::Contextual::Mongo)
-            logger.info "Instrumenting Mongoid 5.x/6.x/7.x"
+          if (mongoid_at_least_5?) && defined?(::Mongoid::Contextual::Mongo)
+            logger.info "Instrumenting Mongoid"
             # All the public methods from Mongoid::Contextual::Mongo.
             # TODO: Geo and MapReduce support (?). They are in other Contextual::* classes
             methods = [
@@ -88,31 +75,17 @@ module ScoutApm
                 ]
 
                 ::Mongoid::Contextual::Mongo.class_eval(with_scout_instruments)
+              else
+                logger.warn "Expected method #{method} not defined in Mongoid::Contextual::Mongo."
               end
             end
           end
         end
       end
 
-      def mongoid_v5?
-        if defined?(::Mongoid::VERSION)
-          ::Mongoid::VERSION =~ /\A5/
-        else
-          false
-        end
-      end
-
-      def mongoid_v6?
+      def mongoid_at_least_5?
         if defined?(::Mongoid::VERSION)
-          ::Mongoid::VERSION =~ /\A6/
-        else
-          false
-        end
-      end
-
-      def mongoid_v7?
-        if defined?(::Mongoid::VERSION)
-          ::Mongoid::VERSION =~ /\A7/
+          ::Mongoid::VERSION =~ /\A[56789]/
         else
           false
         end
@@ -134,4 +107,3 @@ module ScoutApm
     end
   end
 end
-

data/lib/scout_apm/instruments/net_http.rb

@@ -60,7 +60,7 @@ module ScoutApm
 
     module NetHttpInstrumentationPrepend
       def request(request, *args, &block)
-        self.class.instrument("HTTP", "request", :ignore_children => true, :desc => request_scout_description(args.first)) do
+        self.class.instrument("HTTP", "request", :ignore_children => true, :desc => request_scout_description(request)) do
           super(request, *args, &block)
         end
       end

data/lib/scout_apm/instruments/resque.rb

@@ -1,6 +1,15 @@
 module ScoutApm
   module Instruments
     module Resque
+      def before_perform_become_client(*args)
+        # Don't become remote client if explicitly disabled or if forking is disabled to force synchronous recording.
+        if config.value('start_resque_server_instrument') && forking?
+          ScoutApm::Agent.instance.context.become_remote_client!(bind, port)
+        else
+          logger.debug("Not becoming remote client due to 'start_resque_server_instrument' setting or 'fork_per_job' setting")
+        end
+      end
+
       def around_perform_with_scout_instruments(*args)
         job_name = self.to_s
         queue = find_queue
@@ -17,7 +26,6 @@ module ScoutApm
           started_queue = true
           req.start_layer(ScoutApm::Layer.new('Job', job_name))
           started_job = true
-
           yield
         rescue => e
           req.error!
@@ -33,7 +41,28 @@ module ScoutApm
         return queue if self.respond_to?(:queue)
         return "unknown"
       end
+
+      private
+
+      def bind
+        config.value("remote_agent_host")
+      end
+
+      def port
+        config.value("remote_agent_port")
+      end
+
+      def config
+        @config ||= ScoutApm::Agent.instance.context.config
+      end
+
+      def logger
+        @logger ||= ScoutApm::Agent.instance.context.logger
+      end
+
+      def forking?
+        @forking ||= ENV["FORK_PER_JOB"] != "false"
+      end
     end
   end
 end
-

data/lib/scout_apm/layer_converters/external_service_converter.rb

@@ -53,7 +53,7 @@ module ScoutApm
       rescue
         # Do nothing
       ensure
-        domain = DEFAULT_DOMAIN if domain.to_s.blank?
+        domain = DEFAULT_DOMAIN if (domain.nil? || domain.empty?)
         domain
       end
 

data/lib/scout_apm/layer_converters/request_queue_time_converter.rb

@@ -15,6 +15,9 @@ module ScoutApm
 
         return unless headers
 
+        # When an application uses Turbo Streams, we capture very innaccurate queue times.
+        return if request_over_websocket?
+
         raw_start = locate_timestamp
         return unless raw_start
 
@@ -38,6 +41,10 @@ module ScoutApm
 
       private
 
+      def request_over_websocket?
+        headers["Upgrade"] == "websocket"
+      end
+
       # Looks through the possible headers with this data, and extracts the raw
       # value of the header
       # Returns nil if not found

data/lib/scout_apm/sampling.rb

@@ -0,0 +1,104 @@
+module ScoutApm
+  class Sampling
+    attr_reader :global_sample_rate, :sample_endpoints, :sample_uri_regex, :sample_jobs, :ignore_uri_regex, :ignore_jobs
+
+    def initialize(config)
+      @global_sample_rate = config.value('sample_rate')
+      # web endpoints matched prefix by regex
+      # jobs matched explicitly by name
+
+      # for now still support old config key ('ignore') for backwards compatibility
+      @ignore_endpoints = config.value('ignore').present? ? config.value('ignore') : config.value('ignore_endpoints')
+      @sample_endpoints = individual_sample_to_hash(config.value('sample_endpoints'))
+      @endpoint_sample_rate = config.value('endpoint_sample_rate')
+
+      @ignore_jobs = config.value('ignore_jobs')
+      @sample_jobs = individual_sample_to_hash(config.value('sample_jobs'))
+      @job_sample_rate = config.value('job_sample_rate')
+
+      log_string = "Sampling initialized with config: "
+      log_string += "global_sample_rate: #{@global_sample_rate.inspect}, "
+      log_string += "endpoint_sample_rate: #{@endpoint_sample_rate.inspect}, "
+      log_string += "sample_endpoints: #{@sample_endpoints.inspect}, "
+      log_string += "ignore_endpoints: #{@ignore_endpoints.inspect}, "
+      log_string += "job_sample_rate: #{@job_sample_rate.inspect}, "
+      log_string += "sample_jobs: #{@sample_jobs.inspect}, "
+      log_string += "ignore_jobs: #{@ignore_jobs.inspect}"
+      logger.info(log_string)
+    end
+
+    def drop_request?(transaction)
+      # Individual endpoint/job sampling takes precedence over ignoring.
+      # Individual endpoint/job sample rate always takes precedence over general endpoint/job rate.
+      # General endpoint/job rate always takes precedence over global sample rate
+      if transaction.job?
+        job_name = transaction.layer_finder.job.name
+        rate = job_sample_rate(job_name)
+        return sample?(rate) unless rate.nil?
+        return true if ignore_job?(job_name)
+        return sample?(@job_sample_rate) unless @job_sample_rate.nil?
+      elsif transaction.web?
+        uri = transaction.annotations[:uri]
+        rate = web_sample_rate(uri)
+        return sample?(rate) unless rate.nil?
+        return true if ignore_uri?(uri)
+        return sample?(@endpoint_sample_rate) unless @endpoint_sample_rate.nil?
+      end
+
+      # global sample check
+      if @global_sample_rate
+        return sample?(@global_sample_rate)
+      end
+
+      false # don't drop the request
+    end
+
+    def individual_sample_to_hash(sampling_config)
+      return nil if sampling_config.blank?
+      # config looks like ['/foo:50','/bar:100']. parse it into hash of string: integer
+      sample_hash = {}
+      sampling_config.each do |sample|
+        path, rate = sample.split(':')
+        sample_hash[path] = rate.to_i
+      end
+      sample_hash
+    end
+
+    def ignore_uri?(uri)
+      return false if @ignore_endpoints.blank?
+      @ignore_endpoints.each do |prefix|
+        return true if uri.start_with?(prefix)
+      end
+      false
+    end
+
+    def web_sample_rate(uri)
+      return nil if @sample_endpoints.blank?
+      @sample_endpoints.each do |prefix, rate|
+        return rate if uri.start_with?(prefix)
+      end
+      nil
+    end
+
+    def ignore_job?(job_name)
+      return false if @ignore_jobs.blank?
+      @ignore_jobs.include?(job_name)
+    end
+
+    def job_sample_rate(job_name)
+      return nil if @sample_jobs.blank?
+      @sample_jobs.fetch(job_name, nil)
+    end
+
+    def sample?(rate)
+      rand * 100 > rate
+    end
+
+    private
+
+    def logger
+      ScoutApm::Agent.instance.logger
+    end
+
+  end
+end

data/lib/scout_apm/slow_request_policy.rb

@@ -14,7 +14,7 @@ module ScoutApm
 
     def add_default_policies
       add(SlowPolicy::SpeedPolicy.new(context))
-      add(SlowPolicy::PercentilePolicy.new(context))
+      add(SlowPolicy::PercentPolicy.new(context))
       add(SlowPolicy::AgePolicy.new(context))
       add(SlowPolicy::PercentilePolicy.new(context))
     end

data/lib/scout_apm/tracked_request.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # A TrackedRequest is a stack of layers, where completed layers (go into, then
 # come out of a layer) are forgotten as they finish. Layers are attached to
 # their children as the process goes, building a tree structure within the
@@ -303,7 +305,11 @@ module ScoutApm
       restore_from_dump! if @agent_context.nil?
 
       # Bail out early if the user asked us to ignore this uri
-      return if @agent_context.ignored_uris.ignore?(annotations[:uri])
+      # return if @agent_context.ignored_uris.ignore?(annotations[:uri])
+      if @agent_context.sampling.drop_request?(self)
+        logger.debug("Dropping request due to sampling")
+        return
+      end
 
       apply_name_override
 

data/lib/scout_apm/utils/installed_gems.rb

@@ -12,7 +12,8 @@ module ScoutApm
       end
 
       def run
-        Bundler.rubygems.all_specs.map {|spec| [spec.name, spec.version.to_s] }
+        specs = Bundler.rubygems.public_send(Bundler.rubygems.respond_to?(:installed_specs) ? :installed_specs : :all_specs)
+        specs.map { |spec| [spec.name, spec.version.to_s] }
       rescue => e
         logger.warn("Couldn't fetch Gem information: #{e.message}")
         []

data/lib/scout_apm/version.rb

@@ -1,3 +1,3 @@
 module ScoutApm
-  VERSION = "5.3.3"
+  VERSION = "5.6.4"
 end

data/lib/scout_apm.rb

@@ -67,6 +67,8 @@ require 'scout_apm/background_job_integrations/shoryuken'
 require 'scout_apm/background_job_integrations/sneakers'
 require 'scout_apm/background_job_integrations/que'
 require 'scout_apm/background_job_integrations/legacy_sneakers'
+require 'scout_apm/background_job_integrations/good_job'
+require 'scout_apm/background_job_integrations/solid_queue'
 
 require 'scout_apm/framework_integrations/rails_2'
 require 'scout_apm/framework_integrations/rails_3_or_4'
@@ -109,6 +111,7 @@ require 'scout_apm/instruments/samplers'
 require 'scout_apm/app_server_load'
 
 require 'scout_apm/ignored_uris.rb'
+require 'scout_apm/sampling.rb'
 require 'scout_apm/utils/active_record_metric_name'
 require 'scout_apm/utils/backtrace_parser'
 require 'scout_apm/utils/installed_gems'

data/scout_apm.gemspec

@@ -31,10 +31,10 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency "parser"
 
   # These are general development dependencies which are used in instrumentation
-  # tests. Specific versions are pulled in using specific gemfiles, e.g. 
+  # tests. Specific versions are pulled in using specific gemfiles, e.g.
   # `gems/rails3.gemfile`.
   s.add_development_dependency "activerecord"
-  s.add_development_dependency "sqlite3"
+  s.add_development_dependency "sqlite3",  "~> 1.4"
 
   s.add_development_dependency "rubocop"
   s.add_development_dependency "guard"

data/test/test_helper.rb

@@ -38,6 +38,10 @@ class FakeConfigOverlay
     @values[key]
   end
 
+  def values
+    @values
+  end
+
   def has_key?(key)
     @values.has_key?(key)
   end
@@ -65,6 +69,38 @@ class FakeEnvironment
   end
 end
 
+def remove_rails_namespace
+  Object.send(:remove_const, "Rails") if defined?(Rails)
+end
+
+def fake_rails(version)
+  remove_rails_namespace if (ENV["SCOUT_TEST_FEATURES"] || "").include?("instruments")
+
+  Kernel.const_set("Rails", Module.new)
+  Kernel.const_set("ActionController", Module.new)
+  r = Kernel.const_get("Rails")
+  r.const_set("VERSION", Module.new)
+  v = r.const_get("VERSION")
+  v.const_set("MAJOR", version)
+
+  assert_equal version, Rails::VERSION::MAJOR
+end
+
+def clean_fake_rails
+  Kernel.send(:remove_const, "Rails") if defined?(Kernel::Rails)
+  Kernel.send(:remove_const, "ActionController") if defined?(Kernel::ActionController)
+end
+
+def fake_sinatra
+  Kernel.const_set("Sinatra", Module.new)
+  s = Kernel.const_get("Sinatra")
+  s.const_set("Base", Module.new)
+end
+
+def clean_fake_sinatra
+  Kernel.const_unset("Sinatra") if defined?(Kernel::Sinatra)
+end
+
 # Helpers available to all tests
 class Minitest::Test
   def setup
@@ -137,3 +173,28 @@ end
 class Minitest::Test
   include CustomAsserts
 end
+
+class FakeTrackedRequest
+  def self.new_web_request(uri)
+    context = ScoutApm::Agent.instance.context
+    fake_store = ScoutApm::FakeStore.new
+    req = ScoutApm::TrackedRequest.new(context, fake_store)
+
+    first_layer = ScoutApm::Layer.new("Controller", "index")
+    req.start_layer(first_layer)
+    req.annotate_request(:uri => uri)
+
+    req
+  end
+
+  def self.new_job_request(job_name)
+    context = ScoutApm::Agent.instance.context
+    fake_store = ScoutApm::FakeStore.new
+    req = ScoutApm::TrackedRequest.new(context, fake_store)
+
+    first_layer = ScoutApm::Layer.new("Job", job_name)
+    req.start_layer(first_layer)
+
+    req
+  end
+end

data/test/unit/auto_instrument/hash_shorthand_controller-instrumented.rb

@@ -0,0 +1,41 @@
+
+class HashShorthandController < ApplicationController
+  def hash
+    json = {
+      static: "static",
+      shorthand: ::ScoutApm::AutoInstrument("shorthand:",["ROOT/test/unit/auto_instrument/hash_shorthand_controller.rb:6:in `hash'"]){shorthand},
+      longhand: ::ScoutApm::AutoInstrument("longhand: longhand",["ROOT/test/unit/auto_instrument/hash_shorthand_controller.rb:7:in `hash'"]){longhand},
+      longhand_different_key: ::ScoutApm::AutoInstrument("longhand",["ROOT/test/unit/auto_instrument/hash_shorthand_controller.rb:8:in `hash'"]){longhand},
+      hash_rocket: ::ScoutApm::AutoInstrument(":hash_rocket => hash_rocket",["ROOT/test/unit/auto_instrument/hash_shorthand_controller.rb:9:in `hash'"]){hash_rocket},
+      :hash_rocket_different_key => ::ScoutApm::AutoInstrument("hash_rocket",["ROOT/test/unit/auto_instrument/hash_shorthand_controller.rb:10:in `hash'"]){hash_rocket},
+      non_nil_receiver: ::ScoutApm::AutoInstrument("non_nil_receiver.value",["ROOT/test/unit/auto_instrument/hash_shorthand_controller.rb:11:in `hash'"]){non_nil_receiver.value},
+      nested: {
+        shorthand: ::ScoutApm::AutoInstrument("shorthand:",["ROOT/test/unit/auto_instrument/hash_shorthand_controller.rb:13:in `hash'"]){shorthand},
+      },
+      nested_call: ::ScoutApm::AutoInstrument("nested_call(params[\"timestamp\"])",["ROOT/test/unit/auto_instrument/hash_shorthand_controller.rb:15:in `hash'"]){nested_call(params["timestamp"])}
+    }
+    ::ScoutApm::AutoInstrument("render json:",["ROOT/test/unit/auto_instrument/hash_shorthand_controller.rb:17:in `hash'"]){render json:}
+  end
+
+  private
+
+  def nested_call(noop)
+    noop
+  end
+
+  def shorthand
+    "shorthand"
+  end
+
+  def longhand
+    "longhand"
+  end
+
+  def hash_rocket
+    "hash_rocket"
+  end
+
+  def non_nil_receiver
+    ::ScoutApm::AutoInstrument("OpenStruct.new(value: \"value\")",["ROOT/test/unit/auto_instrument/hash_shorthand_controller.rb:39:in `non_nil_receiver'"]){OpenStruct.new(value: "value")}
+  end
+end

data/test/unit/auto_instrument/hash_shorthand_controller.rb

@@ -0,0 +1,41 @@
+
+class HashShorthandController < ApplicationController
+  def hash
+    json = {
+      static: "static",
+      shorthand:,
+      longhand: longhand,
+      longhand_different_key: longhand,
+      :hash_rocket => hash_rocket,
+      :hash_rocket_different_key => hash_rocket,
+      non_nil_receiver: non_nil_receiver.value,
+      nested: {
+        shorthand:,
+      },
+      nested_call: nested_call(params["timestamp"])
+    }
+    render json:
+  end
+
+  private
+
+  def nested_call(noop)
+    noop
+  end
+
+  def shorthand
+    "shorthand"
+  end
+
+  def longhand
+    "longhand"
+  end
+
+  def hash_rocket
+    "hash_rocket"
+  end
+
+  def non_nil_receiver
+    OpenStruct.new(value: "value")
+  end
+end