scout_apm 3.0.0.pre18 → 3.0.0.pre19

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cbd90a42f996c3061f49d47dab8030bd68da59bd
-  data.tar.gz: 05dd5875bc492ce4e8bcca1f590c20b0c39a7f03
+  metadata.gz: 0393ebae36fc959586f76135f0772c9353b2fb82
+  data.tar.gz: d64a6fc7477a274b1a4712895ad62066b2653e4d
 SHA512:
-  metadata.gz: 62b89c1e2b9220e5e3e3f5ae008e2b858deaafce0b5119eff73ade0dd3b5c5f1447092057605819314dfef7fffd755b3e4a646b11ee5858e4ecaac090f6e2183
-  data.tar.gz: 9fc7f24849744a01258da4e8927e1bc0804d42b6dcb5d5b467a33042e7c89df245d8b67b75a2c03cb91d02a93a9b6566e6e3b1a5d2d006e90e77a5768209ff6f
+  metadata.gz: c9281d472ab3df97780f5518a28c7e059c2e031693a47f91ad96d61b955a07678eb5960ee108a18a1b95d09355bd01f70f9aef3d9a9cbea09468c51ea77812ca
+  data.tar.gz: ff8d0ea6114d2de8052780d029dc2c7451ff2e8ee40248e4912959f9fca0308fa0719066ec2e93e391d2c98dfb2ec3353b1883dd0854f084c89f6d6531554b25

data/CHANGELOG.markdown

@@ -2,6 +2,11 @@
 
 * ScoutProf BETA
 
+# 2.4.5
+
+* More robust installation of instruments at startup
+* Several (very) minor bug fixes
+
 # 2.4.4
 
 * Prevent agent from starting when monitor=false

data/lib/scout_apm.rb

@@ -204,5 +204,5 @@ if defined?(Rails) && defined?(Rails::VERSION) && defined?(Rails::VERSION::MAJOR
     end
   end
 else
-  ScoutApm::Agent.instance.start
+  ScoutApm::Agent.instance.install
 end

data/lib/scout_apm/agent.rb

@@ -35,15 +35,14 @@ module ScoutApm
     def install(force=false)
       context.config = ScoutApm::Config.with_file(context, context.config.value("config_file"))
 
-      context.logger.info "Scout Agent [#{ScoutApm::VERSION}] Initialized"
+      logger.info "Scout Agent [#{ScoutApm::VERSION}] Initialized"
 
-      @instrument_manager = ScoutApm::InstrumentManager.new(context)
-      @instrument_manager.install! if should_load_instruments? || force
+      instrument_manager.install! if should_load_instruments? || force
 
       install_background_job_integrations
       install_app_server_integration
 
-      logger.info "Scout Agent [#{ScoutApm::VERSION}] installed"
+      logger.info "Scout Agent [#{ScoutApm::VERSION}] Installed"
 
       context.installed!
 
@@ -69,6 +68,8 @@ module ScoutApm
 
       install unless context.installed?
 
+      instrument_manager.install! if should_load_instruments?
+
       context.started!
 
       log_environment
@@ -79,6 +80,10 @@ module ScoutApm
       start_background_worker
     end
 
+    def instrument_manager
+      @instrument_manager ||= ScoutApm::InstrumentManager.new(context)
+    end
+
     def log_environment
       bg_names = context.environment.background_job_integrations.map{|bg| bg.name }.join(", ")
 
@@ -123,10 +128,13 @@ module ScoutApm
       return !context.environment.forking?
     end
 
+    # monitor is the key configuration here. If it is true, then we want the
+    # instruments. If it is false, we mostly don't want them, unless you're
+    # asking for devtrace (ie. not reporting to apm servers as a real app, but
+    # only for local browsers).
     def should_load_instruments?
       return true if context.config.value('dev_trace')
-      return false unless context.config.value('monitor')
-      context.environment.app_server_integration.found? || context.environment.background_job_integrations.any?
+      context.config.value('monitor')
     end
 
     #################################

data/lib/scout_apm/fake_store.rb

@@ -37,5 +37,8 @@ module ScoutApm
 
     def add_sampler(sampler)
     end
+
+    def tick!
+    end
   end
 end

data/lib/scout_apm/layaway.rb

@@ -52,12 +52,16 @@ module ScoutApm
     def write_reporting_period(reporting_period, files_limit = MAX_FILES_LIMIT)
       if at_layaway_file_limit?(files_limit)
         # This will happen constantly once we hit this case, so only log the first time
-        @wrote_layaway_limit_error_message ||= logger.error("Hit layaway file limit. Not writing to layaway file")
+        @wrote_layaway_limit_error_message ||= logger.error("Layaway: Hit layaway file limit. Not writing to layaway file")
         return false
       end
+      logger.debug("Layaway: wrote time period: #{reporting_period.timestamp}")
       filename = file_for(reporting_period.timestamp)
       layaway_file = LayawayFile.new(context, filename)
       layaway_file.write(reporting_period)
+    rescue => e
+      logger.debug("Layaway: error writing: #{e.message}, #{e.backtrace.inspect}")
+      raise e
     end
 
     # Claims a given timestamp by getting an exclusive lock on a timestamped
@@ -98,19 +102,19 @@ module ScoutApm
             if rps.any?
               yield rps
 
-              logger.debug("Deleting the now-reported layaway files for #{timestamp.to_s}")
+              logger.debug("Layaway: Deleting the now-reported files for #{timestamp.to_s}")
               delete_files_for(timestamp) # also removes the coodinator_file
             else
               File.unlink(coordinator_file)
-              logger.debug("No layaway files to report")
+              logger.debug("Layaway: No files to report")
             end
 
-            logger.debug("Checking for any Stale layaway files")
+            logger.debug("Layaway: Checking for any stale files")
             delete_stale_files(timestamp.to_time - STALE_AGE)
 
             true
           rescue Exception => e
-            logger.debug("Caught an exception in with_claim, with the coordination file locked: #{e.message}, #{e.backtrace.inspect}")
+            logger.debug("Layaway: Caught an exception in with_claim, with the coordination file locked: #{e.message}, #{e.backtrace.inspect}")
             raise
           ensure
             # Unlock the file when done!
@@ -126,7 +130,7 @@ module ScoutApm
 
     def delete_files_for(timestamp)
       all_files_for(timestamp).each { |layaway|
-        logger.debug("Deleting layaway file: #{layaway}")
+        logger.debug("Layaway: Deleting file: #{layaway}")
         File.unlink(layaway)
       }
     end
@@ -137,10 +141,10 @@ module ScoutApm
         compact.
         uniq.
         select { |timestamp| timestamp.to_i < older_than.strftime(TIME_FORMAT).to_i }.
-          tap  { |timestamps| logger.debug("Deleting stale layaway files with timestamps: #{timestamps.inspect}") }.
+          tap  { |timestamps| logger.debug("Layaway: Deleting stale files with timestamps: #{timestamps.inspect}") }.
         map    { |timestamp| delete_files_for(timestamp) }
     rescue => e
-      logger.debug("Problem deleting stale files: #{e.message}, #{e.backtrace.inspect}")
+      logger.debug("Layaway: Problem deleting stale files: #{e.message}, #{e.backtrace.inspect}")
     end
 
     private
@@ -206,8 +210,7 @@ module ScoutApm
         map{ |timestamp, list| [timestamp, list.length] }
       ]
 
-
-      logger.debug("Total in #{directory}: #{files_in_temp}. Total Layaway Files: #{all_filenames.size}.  By Timestamp: #{count_per_timestamp.inspect}")
+      logger.debug("Layaway: Total Files in #{directory}: #{files_in_temp}. Total Layaway Files: #{all_filenames.size}.  By Timestamp: #{count_per_timestamp.inspect}")
     end
   end
 end

data/lib/scout_apm/layaway_file.rb

@@ -6,6 +6,7 @@ module ScoutApm
 
     def initialize(context, path)
       @path = path
+      @context = context
     end
 
     def logger
@@ -17,7 +18,7 @@ module ScoutApm
       deserialize(data)
     rescue NameError, ArgumentError, TypeError => e
       # Marshal error
-      logger.info("Unable to load data from Layaway file, resetting.")
+      logger.info("LayawayFile: Unable to load data")
       logger.debug("#{e.message}, #{e.backtrace.join("\n\t")}")
       nil
     end

data/lib/scout_apm/reporting.rb

@@ -24,6 +24,9 @@ module ScoutApm
     #
     # At any given point, there is data in each of those steps, moving its way through the process
     def process_metrics
+      # Do any per-minute work necessary for the store
+      context.store.tick!
+
       # Write the previous minute's data to the shared-across-process layaway file.
       context.store.write_to_layaway(context.layaway)
 

data/lib/scout_apm/store.rb

@@ -88,10 +88,15 @@ module ScoutApm
       logger.debug("Writing to layaway#{" (Forced)" if force}")
 
       @reporting_periods.select { |time, rp| force || (time.timestamp < current_timestamp.timestamp) }.
-                         each   { |time, rp| collect_samplers(rp) }.
                          each   { |time, rp| write_reporting_period(layaway, time, rp) }
     end
 
+    # For each tick (minute), be sure we have a reporting period, and that samplers are run for it.
+    def tick!
+      rp = current_period
+      collect_samplers(rp)
+    end
+
     def write_reporting_period(layaway, time, rp)
       @mutex.synchronize {
         layaway.write_reporting_period(rp)

data/lib/scout_apm/tracked_request.rb

@@ -326,10 +326,6 @@ module ScoutApm
     def ensure_background_worker
       agent = ScoutApm::Agent.instance
       agent.start
-
-      if agent.start_background_worker(:quiet)
-        agent.logger.info("Force Started BG Worker")
-      end
     rescue => e
       true
     end

data/lib/scout_apm/version.rb

@@ -1,3 +1,3 @@
 module ScoutApm
-  VERSION = "3.0.0.pre18"
+  VERSION = "3.0.0.pre19"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scout_apm
 version: !ruby/object:Gem::Version
-  version: 3.0.0.pre18
+  version: 3.0.0.pre19
 platform: ruby
 authors:
 - Derek Haynes
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-23 00:00:00.000000000 Z
+date: 2018-01-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -373,8 +373,46 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.1
 requirements: []
 rubyforge_project: scout_apm
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5.2
 signing_key: 
 specification_version: 4
 summary: Ruby application performance monitoring
-test_files: []
+test_files:
+- test/data/config_test_1.yml
+- test/test_helper.rb
+- test/unit/agent_test.rb
+- test/unit/background_job_integrations/sidekiq_test.rb
+- test/unit/config_test.rb
+- test/unit/context_test.rb
+- test/unit/db_query_metric_set_test.rb
+- test/unit/db_query_metric_stats_test.rb
+- test/unit/environment_test.rb
+- test/unit/fake_store_test.rb
+- test/unit/git_revision_test.rb
+- test/unit/histogram_test.rb
+- test/unit/ignored_uris_test.rb
+- test/unit/instruments/active_record_instruments_test.rb
+- test/unit/instruments/net_http_test.rb
+- test/unit/instruments/percentile_sampler_test.rb
+- test/unit/layaway_test.rb
+- test/unit/layer_children_set_test.rb
+- test/unit/layer_converters/depth_first_walker_test.rb
+- test/unit/layer_converters/metric_converter_test.rb
+- test/unit/layer_converters/stubs.rb
+- test/unit/limited_layer_test.rb
+- test/unit/logger_test.rb
+- test/unit/metric_set_test.rb
+- test/unit/remote/test_message.rb
+- test/unit/remote/test_router.rb
+- test/unit/remote/test_server.rb
+- test/unit/scored_item_set_test.rb
+- test/unit/serializers/payload_serializer_test.rb
+- test/unit/slow_job_policy_test.rb
+- test/unit/slow_request_policy_test.rb
+- test/unit/sql_sanitizer_test.rb
+- test/unit/store_test.rb
+- test/unit/test_tracked_request.rb
+- test/unit/utils/active_record_metric_name_test.rb
+- test/unit/utils/backtrace_parser_test.rb
+- test/unit/utils/numbers_test.rb
+- test/unit/utils/scm.rb