scout_apm 2.1.0 → 2.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bf1eaf130d67f52fcfcf414c6db4347fa4b94521
-  data.tar.gz: 0386d415a40a707645a65662237f0d44b9bbbdd8
+  metadata.gz: 18409ba68d80eefddd0a94c5c8f47f7e8061d921
+  data.tar.gz: 7ab7791459924188b16c1551bf3682defd268937
 SHA512:
-  metadata.gz: 71d5d59042427c3bf1afbd753fb8646e012c6187c940a0f6a2854a6123cbc5259b8297ca168a5d91793d6722b6082cd0a7c5da520399a13085b4ca7fc274cf3a
-  data.tar.gz: a2ca63e84f57dd17828072076d0c1bd1b757caf1ef3f82a7954ca928b4d09c973ebbda094cb6a5d1ecbbf1c28c3813838239ca55be7c2b1c24c50f430fe49559
+  metadata.gz: a586e1f036a81decca9bdda9d15735174e1676157af56c78cd1c8251b44046872811bfd2fcb4b017c7c973bd6e7daf8e608169c6958f33542a5b32cf16b29d3f
+  data.tar.gz: fb8e623a8f354686a3c3a37ba7e3b9a16db3e17cbefe58b2f7fad198ce5c70b187e33b0d487fcb3f7f71860e8e9b76d2648f81728d6923fdd71bc8e4efee2b7e

data/CHANGELOG.markdown

@@ -1,3 +1,9 @@
+# 2.1.1
+
+* Fix an issue with AR instrumentation and complex queries
+* Fix use of configuration option `data_file`
+* Update unit tests
+
 # 2.1.0
 
 * Added ignore key to configuration to entirely ignore an endpoint. No traces

data/lib/scout_apm.rb

@@ -120,7 +120,6 @@ require 'scout_apm/metric_meta'
 require 'scout_apm/metric_stats'
 require 'scout_apm/slow_transaction'
 require 'scout_apm/slow_job_record'
-require 'scout_apm/slow_item_set'
 require 'scout_apm/scored_item_set'
 require 'scout_apm/slow_request_policy'
 require 'scout_apm/slow_job_policy'

data/lib/scout_apm/agent.rb

@@ -55,7 +55,7 @@ module ScoutApm
       @request_histograms_by_time = Hash.new { |h, k| h[k] = ScoutApm::RequestHistograms.new }
 
       @store          = ScoutApm::Store.new
-      @layaway        = ScoutApm::Layaway.new
+      @layaway        = ScoutApm::Layaway.new(config, environment)
       @metric_lookup  = Hash.new
 
       @capacity       = ScoutApm::Capacity.new

data/lib/scout_apm/config.rb

@@ -137,11 +137,17 @@ module ScoutApm
     end
 
     def initialize(overlays)
-      @overlays = overlays
+      @overlays = Array(overlays)
     end
 
     def value(key)
-      raw_value = @overlays.detect{ |overlay| overlay.has_key?(key) }.value(key)
+      o = @overlays.detect{ |overlay| overlay.has_key?(key) }
+      raw_value = if o
+                    o.value(key)
+                  else
+                    # No overlay said it could handle this key, bail out with nil.
+                    nil
+                  end
 
       coercion = SETTING_COERCIONS[key] || NullCoercion.new
       coercion.coerce(raw_value)

data/lib/scout_apm/instant/middleware.rb

@@ -61,7 +61,7 @@ module ScoutApm
                   :platform      => "ruby",
               }
               hash = ScoutApm::Serializers::PayloadSerializerToJson.rearrange_slow_transaction(trace)
-              hash.merge!(metadata:metadata)
+              hash.merge!(:metadata => metadata)
               payload = ScoutApm::Serializers::PayloadSerializerToJson.jsonify_hash(hash)
 
               if env['HTTP_X_REQUESTED_WITH'] == 'XMLHttpRequest' || content_type.include?("application/json")
@@ -105,4 +105,4 @@ module ScoutApm
       end
     end
   end
-end
+end

data/lib/scout_apm/instruments/active_record.rb

@@ -173,7 +173,7 @@ module ScoutApm
         req.start_layer(layer)
         req.ignore_children!
         begin
-          find_by_sql_without_scout_instruments(*args)
+          find_by_sql_without_scout_instruments(*args, &block)
         ensure
           req.acknowledge_children!
           req.stop_layer
@@ -199,7 +199,7 @@ module ScoutApm
         req.start_layer(layer)
         req.ignore_children!
         begin
-          find_with_associations_without_scout_instruments(*args)
+          find_with_associations_without_scout_instruments(*args, &block)
         ensure
           req.acknowledge_children!
           req.stop_layer

data/lib/scout_apm/layaway.rb

@@ -18,8 +18,12 @@ module ScoutApm
     # Must be sortable as an integer
     TIME_FORMAT = "%Y%m%d%H%M"
 
-    def initialize(directory=nil)
-      @directory = directory
+    attr_reader :config
+    attr_reader :environment
+
+    def initialize(config, environment)
+      @config = config
+      @environment = environment
     end
 
     # Returns a Pathname object with the fully qualified directory where the layaway files can be placed.
@@ -30,12 +34,12 @@ module ScoutApm
     def directory
       return @directory if @directory
 
-      data_file = ScoutApm::Agent.instance.config.value("data_file")
-      data_file = File.dirname(data_file) if data_file && !File.directory?
+      data_file = config.value("data_file")
+      data_file = File.dirname(data_file) if data_file && !File.directory?(data_file)
 
       candidates = [
         data_file,
-        "#{ScoutApm::Agent.instance.environment.root}/tmp",
+        "#{environment.root}/tmp",
         "/tmp"
       ].compact
 

data/lib/scout_apm/version.rb

@@ -1,4 +1,4 @@
 module ScoutApm
-  VERSION = "2.1.0"
+  VERSION = "2.1.1"
 end
 

data/test/test_helper.rb

@@ -17,6 +17,34 @@ Kernel.module_eval do
   end
 end
 
+# A test helper class to create a temporary "configuration" we can control entirely purposes
+class FakeConfigOverlay
+  def initialize(values)
+    @values = values
+  end
+
+  def value(key)
+    @values[key]
+  end
+
+  def has_key?(key)
+    @values.has_key?(key)
+  end
+end
+
+class FakeEnvironment
+  def initialize(values)
+    @values = values
+  end
+
+  def method_missing(sym)
+    if @values.has_key?(sym)
+      @values[sym]
+    else
+      raise "#{sym} not found in FakeEnvironment"
+    end
+  end
+end
 
 # Helpers available to all tests
 class Minitest::Test
@@ -42,6 +70,16 @@ class Minitest::Test
     ScoutApm::Agent.instance.instance_variable_set("@logger", @logger)
   end
 
+  def make_fake_environment(values)
+    FakeEnvironment.new(values)
+  end
+
+  def make_fake_config(values)
+    ScoutApm::Config.new(FakeConfigOverlay.new(values))
+  end
+
   DATA_FILE_DIR = File.dirname(__FILE__) + '/tmp'
   DATA_FILE_PATH = "#{DATA_FILE_DIR}/scout_apm.db"
 end
+
+

data/test/unit/config_test.rb

@@ -4,7 +4,7 @@ require 'scout_apm/config'
 
 class ConfigTest < Minitest::Test
   def test_initalize_without_a_config
-    conf = ScoutApm::Config.new(nil)
+    conf = ScoutApm::Config.without_file
 
     # nil for random keys
     assert_nil conf.value("log_file_path")
@@ -21,7 +21,7 @@ class ConfigTest < Minitest::Test
     set_rack_env("production")
 
     conf_file = File.expand_path("../../data/config_test_1.yml", __FILE__)
-    conf = ScoutApm::Config.new(conf_file)
+    conf = ScoutApm::Config.with_file(conf_file)
 
     assert_equal "debug", conf.value('log_level')
     assert_equal "APM Test Conf (Production)", conf.value('name')

data/test/unit/layaway_test.rb

@@ -5,25 +5,20 @@ require 'scout_apm/metric_stats'
 require 'scout_apm/context'
 require 'scout_apm/store'
 
+require 'fileutils'
 class LayawayTest < Minitest::Test
-  def test_add_reporting_period
-    File.open(DATA_FILE_PATH, 'w') { |file| file.write(Marshal.dump(NEW_FORMAT)) }
-    ScoutApm::Agent.instance.start
+  def test_directory_uses_DATA_FILE_option
+    FileUtils.mkdir_p '/tmp/scout_apm_test/data_file_option'
+    config = make_fake_config("data_file" => "/tmp/scout_apm_test/data_file_option")
 
-    data = ScoutApm::Layaway.new
-    t = ScoutApm::StoreReportingPeriodTimestamp.new
-    data.add_reporting_period(t,ScoutApm::StoreReportingPeriod.new(t))
-    assert_equal [TIMESTAMP,t].sort_by(&:timestamp), Marshal.load(File.read(DATA_FILE_PATH)).keys.sort_by(&:timestamp)
+    assert_equal Pathname.new("/tmp/scout_apm_test/data_file_option"), ScoutApm::Layaway.new(config, ScoutApm::Agent.instance.environment).directory
   end
 
-  def test_merge_reporting_period
-    File.open(DATA_FILE_PATH, 'w') { |file| file.write(Marshal.dump(NEW_FORMAT)) }
-    layaway = ScoutApm::Layaway.new
-    layaway.add_reporting_period(TIMESTAMP, ScoutApm::StoreReportingPeriod.new(TIMESTAMP))
-    unmarshalled = Marshal.load(File.read(DATA_FILE_PATH))
-    assert_equal [TIMESTAMP], unmarshalled.keys
-  end
+  def test_directory_looks_for_root_slash_tmp
+    FileUtils.mkdir_p '/tmp/scout_apm_test/tmp'
+    config = make_fake_config({})
+    env = make_fake_environment(:root => "/tmp/scout_apm_test")
 
-  TIMESTAMP = ScoutApm::StoreReportingPeriodTimestamp.new(Time.parse("2015-01-01"))
-  NEW_FORMAT = {TIMESTAMP => ScoutApm::StoreReportingPeriod.new(TIMESTAMP)} # Format for 1.2+ agents
+    assert_equal Pathname.new("/tmp/scout_apm_test/tmp"), ScoutApm::Layaway.new(config, env).directory
+  end
 end

data/test/unit/serializers/payload_serializer_test.rb

@@ -6,26 +6,11 @@ require 'scout_apm/serializers/payload_serializer_to_json'
 require 'scout_apm/slow_transaction'
 require 'scout_apm/metric_meta'
 require 'scout_apm/metric_stats'
-require 'scout_apm/utils/fake_stack_prof'
 require 'scout_apm/context'
 require 'ostruct'
 require 'json' # to deserialize what has been manually serialized by the production code
 
-# stub the report_format value
-# class ScoutApm::Agent
-  # module Config
-    # def self.value(key)
-      # 'json'
-    # end
-  # end
-
-  # def self.instance
-    # OpenStruct.new(:config => Config)
-  # end
-# end
-
 class PayloadSerializerTest < Minitest::Test
-
   def test_serializes_metadata_as_json
     metadata = {
       :app_root => "/srv/app/rootz",
@@ -112,93 +97,6 @@ class PayloadSerializerTest < Minitest::Test
     assert_equal formatted_metrics, JSON.parse(payload)["metrics"]
   end
 
-  def test_serializes_slow_transactions_as_json
-    slow_transaction_metrics = {
-      ScoutApm::MetricMeta.new('ActiveRecord/all').tap { |meta|
-        meta.desc = "SELECT *\nfrom users where filter=?"
-        meta.extra = {:user => 'cooluser'}
-        meta.metric_id = nil
-        meta.scope = "Controller/apps/checkin"
-      } => ScoutApm::MetricStats.new.tap { |stats|
-        stats.call_count = 16
-        stats.max_call_time = 0.005338062
-        stats.min_call_time = 0.000613518
-        stats.sum_of_squares = 9.8040860751126e-05
-        stats.total_call_time = 0.033245704
-        stats.total_exclusive_time = 0.033245704
-      },
-      ScoutApm::MetricMeta.new("Controller/apps/checkin").tap { |meta|
-        meta.desc = nil
-        meta.extra = {}
-        meta.metric_id = nil
-        meta.scope = nil
-      } => ScoutApm::MetricStats.new.tap { |stats|
-        stats.call_count = 2
-        stats.max_call_time = 0.078521419
-        stats.min_call_time = 0.034881757
-        stats.sum_of_squares = 0.007382350213180609
-        stats.total_call_time = 0.113403176
-        stats.total_exclusive_time = 0.07813208899999999
-      }
-    }
-    context = ScoutApm::Context.new
-    context.add({"this" => "that"})
-    context.add_user({"hello" => "goodbye"})
-    slow_t = ScoutApm::SlowTransaction.new("http://example.com/blabla", "Buckethead/something/else", 1.23, slow_transaction_metrics, context, Time.at(1448198788), [], 10)
-    payload = ScoutApm::Serializers::PayloadSerializerToJson.serialize({}, {}, [slow_t], [], [])
-    formatted_slow_transactions = [
-      {
-        "key" => {
-          "bucket" => "Buckethead",
-          "name" => "something/else"
-        },
-        "time" => "2015-11-22 06:26:28 -0700",
-        "total_call_time" => 1.23,
-        "uri" => "http://example.com/blabla",
-        "context" => {"this"=>"that", "user"=>{"hello"=>"goodbye"}},
-        "prof" => [],
-        "score" => 10,
-        "metrics" => [
-          {
-            "key" => {
-              "bucket" => "ActiveRecord",
-              "name" => "all",
-              "desc" => "SELECT *\nfrom users where filter=?",
-              "extra" => {
-                "user" => "cooluser",
-              },
-              "scope" => {
-                "bucket" => "Controller",
-                "name" => "apps/checkin",
-              },
-            },
-            "call_count" => 16,
-            "max_call_time" => 0.005338062,
-            "min_call_time" => 0.000613518,
-            "total_call_time" => 0.033245704,
-            "total_exclusive_time" => 0.033245704,
-          },
-          {
-            "key" => {
-              "bucket" => "Controller",
-              "name" => "apps/checkin",
-              "desc" => nil,
-              "extra" => {},
-              "scope" => nil,
-            },
-            "call_count" => 2,
-            "max_call_time" => 0.078521419,
-            "min_call_time" => 0.034881757,
-            "total_call_time" => 0.113403176,
-            "total_exclusive_time" => 0.07813208899999999,
-          }
-        ]
-      }
-    ]
-
-    assert_equal formatted_slow_transactions, JSON.parse(payload)["slow_transactions"]
-  end
-
   def test_escapes_json_quotes
     metadata = {
       :quotie => "here are some \"quotes\"",

data/test/unit/slow_job_policy_test.rb

@@ -3,53 +3,4 @@ require 'test_helper'
 require 'scout_apm/slow_job_policy'
 
 class SlowJobPolicyTest < Minitest::Test
-  def test_first_call_is_not_slow
-    policy = ScoutApm::SlowJobPolicy.new
-    assert !policy.slow?("TestWorker", 10)
-  end
-
-  # All of these get faster and faster, so none are marked as slow.
-  def test_fast_calls_are_not_slow
-    policy = ScoutApm::SlowJobPolicy.new
-    assert !policy.slow?("TestWorker", 10)
-    assert !policy.slow?("TestWorker", 8)
-    assert !policy.slow?("TestWorker", 6)
-    assert !policy.slow?("TestWorker", 4)
-    assert !policy.slow?("TestWorker", 2)
-  end
-
-  def test_slow_calls_are_marked_as_slow
-    policy = ScoutApm::SlowJobPolicy.new
-    policy.slow?("TestWorker", 10) # Prime it with a not-slow
-
-    assert policy.slow?("TestWorker", 12)
-    assert policy.slow?("TestWorker", 14)
-    assert policy.slow?("TestWorker", 16)
-    assert policy.slow?("TestWorker", 18)
-  end
-
-  def test_mix_of_fast_and_slow
-    policy = ScoutApm::SlowJobPolicy.new
-    policy.slow?("TestWorker", 10) # Prime it with a not-slow
-
-    assert  policy.slow?("TestWorker", 12)
-    assert !policy.slow?("TestWorker", 8)
-    assert  policy.slow?("TestWorker", 13)
-    assert !policy.slow?("TestWorker", 6)
-  end
-
-  def test_different_workers_dont_interfere
-    policy = ScoutApm::SlowJobPolicy.new
-    policy.slow?("TestWorker", 10) # Prime it with a not-slow
-    policy.slow?("OtherWorker", 1.0) # Prime it with a not-slow
-
-    assert !policy.slow?("TestWorker", 8)
-    assert  policy.slow?("OtherWorker", 2)
-    assert !policy.slow?("TestWorker", 1)
-    assert  policy.slow?("OtherWorker", 3)
-    assert  policy.slow?("TestWorker", 12)
-    assert !policy.slow?("OtherWorker", 1)
-    assert  policy.slow?("TestWorker", 12)
-    assert  policy.slow?("OtherWorker", 4)
-  end
 end

data/test/unit/slow_request_policy_test.rb

@@ -32,11 +32,10 @@ class SlowRequestPolicyTest < Minitest::Test
 
     request.set_duration(10) # 10 seconds
     policy.last_seen[request.unique_name] = Time.now - 120 # 2 minutes since last seen
-    agent.request_histograms.add(request.unique_name, 1)
-
-    # Actual value I have in console is 1.599
-    assert policy.score(request) > 1.5
-    assert policy.score(request) < 2.0
+    ScoutApm::Agent.instance.request_histograms.add(request.unique_name, 1)
 
+    # Actual value I have in console is 1.499
+    assert policy.score(request) > 1.45
+    assert policy.score(request) < 1.55
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scout_apm
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
 platform: ruby
 authors:
 - Derek Haynes
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-12 00:00:00.000000000 Z
+date: 2016-08-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rusage
@@ -200,7 +200,6 @@ files:
 - lib/scout_apm/server_integrations/thin.rb
 - lib/scout_apm/server_integrations/unicorn.rb
 - lib/scout_apm/server_integrations/webrick.rb
-- lib/scout_apm/slow_item_set.rb
 - lib/scout_apm/slow_job_policy.rb
 - lib/scout_apm/slow_job_record.rb
 - lib/scout_apm/slow_request_policy.rb
@@ -233,7 +232,6 @@ files:
 - test/unit/metric_set_test.rb
 - test/unit/scored_item_set_test.rb
 - test/unit/serializers/payload_serializer_test.rb
-- test/unit/slow_item_set_test.rb
 - test/unit/slow_job_policy_test.rb
 - test/unit/slow_request_policy_test.rb
 - test/unit/sql_sanitizer_test.rb
@@ -277,7 +275,6 @@ test_files:
 - test/unit/metric_set_test.rb
 - test/unit/scored_item_set_test.rb
 - test/unit/serializers/payload_serializer_test.rb
-- test/unit/slow_item_set_test.rb
 - test/unit/slow_job_policy_test.rb
 - test/unit/slow_request_policy_test.rb
 - test/unit/sql_sanitizer_test.rb

data/lib/scout_apm/slow_item_set.rb

@@ -1,80 +0,0 @@
-# In order to keep load down, only record a sample of Slow Items (Transactions
-# or Jobs).  In order to make that sampling as fair as possible, follow a basic
-# algorithm:
-#
-# When adding a new Slow Item:
-#  * Just add it if there is an open spot
-#  * If there isn't an open spot, attempt to remove an over-represented
-#    item instead ("attempt_to_evict"). Overrepresented is simply "has more
-#    than @fair number of Matching Items in the set". The fastest of the
-#    overrepresented items is removed.
-#  * If there isn't an open spot, and no Item is valid to evict, drop the
-#    incoming Item without adding.
-#
-# There is no way to remove Items from this set, create a new object
-# for each reporting period.
-#
-# Item must respond to:
-#   #metric_name - string - grouping key to see if one kind of thing is overrepresented
-#   #total_call_time - float - duration of the item
-
-module ScoutApm
-  class SlowItemSet
-    include Enumerable
-
-    DEFAULT_TOTAL = 10
-    DEFAULT_FAIR = 1
-
-    attr_reader :total
-    attr_reader :fair
-
-    def initialize(total=DEFAULT_TOTAL, fair=DEFAULT_FAIR)
-      @total = total
-      @fair = fair
-      @items = []
-    end
-
-    def each
-      @items.each { |s| yield s }
-    end
-
-    def <<(item)
-      return if attempt_append(item)
-      attempt_to_evict
-      attempt_append(item)
-    end
-
-    def empty_slot?
-      @items.length < total
-    end
-
-    def attempt_append(item)
-      if empty_slot?
-        @items.push(item)
-        true
-      else
-        false
-      end
-    end
-
-    def attempt_to_evict
-      return if @items.length == 0
-
-      overrepresented = @items.
-        group_by { |item| unique_name_for(item) }.
-        to_a.
-        sort_by { |(_, items)| items.length }.
-        last
-
-      if overrepresented[1].length > fair
-        fastest = overrepresented[1].sort_by { |item| item.total_call_time }.first
-        @items.delete(fastest)
-      end
-    end
-
-    # Determine this items' "hash key"
-    def unique_name_for(item)
-      item.metric_name
-    end
-  end
-end

data/test/unit/slow_item_set_test.rb

@@ -1,94 +0,0 @@
-require 'test_helper'
-
-require 'scout_apm/slow_item_set'
-require 'scout_apm/slow_transaction'
-
-class SlowItemSetTest < Minitest::Test
-  def test_adding_to_empty_set
-    set = ScoutApm::SlowItemSet.new(3, 1)
-    set << make_slow("Controller/Foo")
-    assert_equal 1, set.count
-  end
-
-  def test_adding_to_partially_full_set
-    set = ScoutApm::SlowItemSet.new(3, 1)
-    set << make_slow("Controller/Foo")
-    set << make_slow("Controller/Foo")
-    assert_equal 2, set.count
-  end
-
-  def test_overflow_of_one_type
-    max_size = 3
-    set = ScoutApm::SlowItemSet.new(max_size, 1)
-    set << make_slow("Controller/Foo")
-    set << make_slow("Controller/Foo")
-    set << make_slow("Controller/Foo")
-    set << make_slow("Controller/Foo")
-    set << make_slow("Controller/Foo")
-    set << make_slow("Controller/Foo")
-    assert_equal max_size, set.count
-  end
-
-  def test_eviction_of_overrepresented
-    max_size = 3
-    set = ScoutApm::SlowItemSet.new(max_size, 1)
-    set << make_slow("Controller/Foo")
-    set << make_slow("Controller/Foo")
-    set << make_slow("Controller/Foo")
-    set << make_slow("Controller/Foo")
-    set << make_slow("Controller/Foo")
-    set << make_slow("Controller/Bar")
-
-    # 3 total
-    assert_equal max_size, set.count
-    assert_equal 1, set.select{|sl| sl.metric_name == "Controller/Bar"}.length
-    assert_equal 2, set.select{|sl| sl.metric_name == "Controller/Foo"}.length
-  end
-
-  # Fill the set with /Foo records, then add a /Bar to evict. Check that the
-  # evicted one was the fastest of the Foos
-  def test_eviction_of_fastest
-    max_size = 3
-    set = ScoutApm::SlowItemSet.new(max_size, 1)
-
-    [1,2,3].shuffle.each do |seconds| # Shuffle to remove any assumptions on order
-      set << make_slow("Controller/Foo", seconds)
-    end
-    set << make_slow("Controller/Bar", 8)
-
-    # The foo taking 1 second should be evicted
-    assert_equal 2, set.select{|sl| sl.metric_name == "Controller/Foo"}.map{ |sl| sl.total_call_time}.min
-  end
-
-  def test_eviction_when_no_overrepresented
-    max_size = 4
-    fair = 2
-    set = ScoutApm::SlowItemSet.new(max_size, fair)
-
-    # Full, but each is at fair level
-    set << make_slow("Controller/Bar")
-    set << make_slow("Controller/Bar")
-    set << make_slow("Controller/Foo")
-    set << make_slow("Controller/Foo")
-
-    set << make_slow("Controller/Quux")
-    assert_equal max_size, set.count
-    assert_equal 0, set.select{|sl| sl.metric_name == "Controller/Quux" }.length
-  end
-
-  ##############
-  #### Helpers
-  ##############
-
-  def make_slow(metric, time=5)
-    ScoutApm::SlowTransaction.new(
-      "http://foo.app/#{metric}",
-      metric,
-      time,
-      {}, # metrics
-      {}, # context
-      Time.now, # end time
-      [], # stackprof
-      0)
-  end
-end