scout_apm 1.6.8 → 2.0.0.pre

data/test/unit/metric_set_test.rb

@@ -1,101 +0,0 @@
-require 'test_helper'
-
-require 'scout_apm/metric_set'
-
-module ScoutApm
-  class MetricSetTest < Minitest::Test
-    def setup
-      @metric_set = ScoutApm::MetricSet.new
-    end
-
-    def test_absorb_one_passthrough_metric
-      @metric_set.absorb(make_fake_stat("Controller/Foo", 1))
-
-      assert_equal 1, @metric_set.metrics.length
-      assert_equal "Controller/Foo", @metric_set.metrics.first.first.metric_name
-    end
-
-    def test_absorb_one_aggregate_metric
-      @metric_set.absorb(make_fake_stat("ActiveRecord/Foo", 1))
-
-      assert_equal 1, @metric_set.metrics.length
-      assert_equal "ActiveRecord/all", @metric_set.metrics.first.first.metric_name
-    end
-
-    def test_absorb_many_aggregate_metric
-      @metric_set.absorb(make_fake_stat("ActiveRecord/Foo", 1))
-      @metric_set.absorb(make_fake_stat("ActiveRecord/Bar", 1))
-      @metric_set.absorb(make_fake_stat("ActiveRecord/Baz", 1))
-      @metric_set.absorb(make_fake_stat("HTTP/Get", 1))
-      @metric_set.absorb(make_fake_stat("HTTP/Post", 1))
-
-      metrics = @metric_set.metrics.to_a.sort_by { |m| m.first.metric_name }
-      assert_equal 2, metrics.length
-      assert_equal "ActiveRecord/all", metrics[0][0].metric_name
-      assert_equal "HTTP/all", metrics[1][0].metric_name
-      assert_equal 3, metrics[0][1].call_count
-      assert_equal 2, metrics[1][1].call_count
-    end
-
-    def test_absorb_one_error
-      @metric_set.absorb(make_fake_stat("Errors/Controller/public/index", 1))
-
-      metrics = @metric_set.metrics.to_a.sort_by { |m| m.first.metric_name }
-      assert_equal 2, metrics.length
-      assert_equal "Errors/Controller/public/index", metrics[0].first.metric_name
-      assert_equal "Errors/Request",  metrics[1].first.metric_name
-    end
-
-    def test_absorb_many_metrics
-      @metric_set.absorb_all([
-        make_fake_stat("ActiveRecord/Foo", 1),
-        make_fake_stat("Controller/Bar", 1)
-      ])
-
-      metrics = @metric_set.metrics.to_a.sort_by { |m| m.first.metric_name }
-      assert_equal 2, metrics.length
-      assert_equal "ActiveRecord/all", metrics[0].first.metric_name
-      assert_equal "Controller/Bar",  metrics[1].first.metric_name
-    end
-
-    def test_combine
-      @other_set = ScoutApm::MetricSet.new
-
-      @metric_set.absorb_all([
-        make_fake_stat("ActiveRecord/Foo", 1),
-        make_fake_stat("Controller/Bar", 1),
-        make_fake_stat("Errors/Controller/public/index", 1),
-      ])
-
-      @other_set.absorb_all([
-        make_fake_stat("ActiveRecord/Foo", 1),
-        make_fake_stat("Controller/Bar", 1),
-        make_fake_stat("Errors/Controller/public/index", 1),
-      ])
-
-      @metric_set.combine!(@other_set)
-
-      metrics = @metric_set.metrics.to_a.sort_by { |m| m.first.metric_name }
-      assert_equal 4, metrics.length
-      assert_equal "ActiveRecord/all", metrics[0][0].metric_name
-      assert_equal "Controller/Bar",  metrics[1][0].metric_name
-      assert_equal "Errors/Controller/public/index", metrics[2][0].metric_name
-      assert_equal "Errors/Request",  metrics[3][0].metric_name
-
-      assert_equal 2, metrics[0][1].call_count
-      assert_equal 2, metrics[1][1].call_count
-      assert_equal 2, metrics[2][1].call_count
-      assert_equal 2, metrics[3][1].call_count
-    end
-
-    ############################################################
-    # Test helper functions
-    ############################################################
-    def make_fake_stat(name, count)
-      meta = MetricMeta.new(name)
-      stat = MetricStats.new
-      stat.update!(count)
-      [meta, stat]
-    end
-  end
-end

data/test/unit/scored_item_set_test.rb

@@ -1,65 +0,0 @@
-require 'test_helper'
-
-require 'scout_apm/scored_item_set'
-
-class FakeScoredItem
-  def initialize(name, score)
-    @name = name
-    @score = score
-  end
-  def name; @name; end
-  def score; @score; end
-  def call; "called_#{@score}_#{@name}"; end
-end
-
-class ScoredItemSetTest < Minitest::Test
-  def test_empty_set_always_adds_item
-    set = ScoutApm::ScoredItemSet.new
-    set << FakeScoredItem.new("users/index", 10)
-
-    assert_equal set.to_a.first, "called_10_users/index"
-    assert_equal set.count, 1
-  end
-
-  def test_repeated_additions_chooses_most_expensive
-    set = ScoutApm::ScoredItemSet.new
-
-    [ FakeScoredItem.new("users/index", 10),
-      FakeScoredItem.new("users/index", 11),
-      FakeScoredItem.new("users/index", 12)
-    ].shuffle.each { |fsi| set << fsi }
-
-    assert_equal set.to_a.first, "called_12_users/index"
-    assert_equal set.count, 1
-  end
-
-  def test_multiple_items_occupy_different_buckets
-    set = ScoutApm::ScoredItemSet.new
-
-    [ FakeScoredItem.new("users/index", 10),
-      FakeScoredItem.new("users/index", 11),
-      FakeScoredItem.new("users/show", 12),
-      FakeScoredItem.new("users/show", 10)
-    ].shuffle.each { |fsi| set << fsi }
-
-    assert_equal set.count, 2
-    assert set.to_a.include?("called_11_users/index")
-    assert set.to_a.include?("called_12_users/show")
-  end
-
-  def test_evicts_at_capacity
-    set = ScoutApm::ScoredItemSet.new(3) # Force max_size to 3
-
-    [ FakeScoredItem.new("users/index", 10),
-      FakeScoredItem.new("users/show", 11),
-      FakeScoredItem.new("posts/index", 12),
-      FakeScoredItem.new("posts/move", 13)
-    ].shuffle.each { |fsi| set << fsi }
-
-    assert_equal set.count, 3
-    assert !set.to_a.include?("called_10_users/index"), "Did not Expect to see users/index in #{set.to_a.inspect}"
-    assert set.to_a.include?("called_11_users/show"),   "Expected to see users/show in #{set.to_a.inspect}"
-    assert set.to_a.include?("called_12_posts/index"),  "Expected to see posts/index in #{set.to_a.inspect}"
-    assert set.to_a.include?("called_13_posts/move"),   "Expected to see posts/move in #{set.to_a.inspect}"
-  end
-end

data/test/unit/slow_request_policy_test.rb

@@ -1,42 +0,0 @@
-require 'test_helper'
-
-require 'scout_apm/slow_request_policy'
-require 'scout_apm/layer'
-
-class FakeRequest
-  def initialize(name)
-    @name = name
-    @root_layer = ScoutApm::Layer.new("Controller", name)
-    @root_layer.instance_variable_set("@stop_time", Time.now)
-  end
-  def unique_name; "Controller/foo/bar"; end
-  def root_layer; @root_layer; end
-  def set_duration(seconds)
-    @root_layer.instance_variable_set("@start_time", Time.now - seconds)
-  end
-end
-
-class SlowRequestPolicyTest < Minitest::Test
-  def test_stored_records_current_time
-    test_start = Time.now
-    policy = ScoutApm::SlowRequestPolicy.new
-    request = FakeRequest.new("users/index")
-
-    policy.stored!(request)
-    assert policy.last_seen[request.unique_name] > test_start
-  end
-
-  def test_score
-    policy = ScoutApm::SlowRequestPolicy.new
-    request = FakeRequest.new("users/index")
-
-    request.set_duration(10) # 10 seconds
-    policy.last_seen[request.unique_name] = Time.now - 120 # 2 minutes since last seen
-    agent.request_histograms.add(request.unique_name, 1)
-
-    # Actual value I have in console is 1.599
-    assert policy.score(request) > 1.5
-    assert policy.score(request) < 2.0
-
-  end
-end