scorpion-ioc 0.6.2 → 1.0.0

data/spec/lib/scorpion/rack/middleware_spec.rb

@@ -2,10 +2,10 @@ require "spec_helper"
 require "scorpion/rack/middleware"
 
 describe Scorpion::Rack::Middleware do
-  let(:app)      { proc{ [ 200, {}, [ 'Sting!' ] ] } }
+  let(:app)      { proc { [ 200, {}, [ "Sting!" ] ] } }
   let(:stack)    { Scorpion::Rack::Middleware.new( app ) }
   let(:request)  { Rack::MockRequest.new( stack ) }
-  let(:response) { request.get('/') }
+  let(:response) { request.get("/") }
 
   it "creates a scorpion" do
     expect( stack ).to receive( :prepare_scorpion ).and_call_original
@@ -19,8 +19,8 @@ describe Scorpion::Rack::Middleware do
       app.call( env )
     }
 
-    request  = Rack::MockRequest::new( Scorpion::Rack::Middleware.new( proc ) )
-    request.get '/'
+    request = Rack::MockRequest.new( Scorpion::Rack::Middleware.new( proc ) )
+    request.get "/"
   end
 
   it "frees the scorpion on return" do

data/spec/lib/scorpion/rack_spec.rb

@@ -12,7 +12,7 @@ describe Scorpion::Rack do
     end
 
     expect do
-      request = Rack::MockRequest.new( klass.new() )
+      request = Rack::MockRequest.new( klass.new )
       request.get "/"
     end.to raise_error Scorpion::Rack::MissingScorpionError
   end

data/spec/lib/scorpion/rails/active_record/association_spec.rb

@@ -1,11 +1,11 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Scorpion::Rails::ActiveRecord::Association, type: :model do
   include Scorpion::Rspec::Helper
 
   before( :each ) do
     author = Author.create! name: "Pitbull"
-    todo   = Todo.create! name: "Be even more awesome", author: author
+    Todo.create! name: "Be even more awesome", author: author
   end
 
   it "shares scorpion with associations" do
@@ -23,4 +23,4 @@ describe Scorpion::Rails::ActiveRecord::Association, type: :model do
     expect( todo.author.scorpion ).to be scorpion
   end
 
-end
+end

data/spec/lib/scorpion/rails/active_record/model_spec.rb

@@ -1,11 +1,11 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Scorpion::Rails::ActiveRecord::Model, type: :model do
   include Scorpion::Rspec::Helper
 
   before( :each ) do
     author = Author.create! name: "Pitbull"
-    todo   = Todo.create! name: "Be even more awesome", author: author
+    Todo.create! name: "Be even more awesome", author: author
   end
 
   it "shares scorpion with associations" do
@@ -30,4 +30,4 @@ describe Scorpion::Rails::ActiveRecord::Model, type: :model do
     expect( Author.with_scorpion( scorpion ).named( "Pitbull" ).alphabetical.first.scorpion ).to be scorpion
   end
 
-end
+end

data/spec/lib/scorpion/rails/active_record/relation_spec.rb

@@ -1,5 +1,5 @@
-require 'spec_helper'
-require 'scorpion/rails'
+require "spec_helper"
+require "scorpion/rails"
 
 describe Scorpion::Rails::ActiveRecord::Relation, type: :model do
   include Scorpion::Rspec::Helper
@@ -48,7 +48,7 @@ describe Scorpion::Rails::ActiveRecord::Relation, type: :model do
   end
 
   context "find methods" do
-    let!( :todo ){ Todo.create! name: "Bill" }
+    let!( :todo ) { Todo.create! name: "Bill" }
 
     it "shares scorpion with found records" do
       expect( criteria.find( todo.id ).scorpion ).to be scorpion

data/spec/lib/scorpion/rails/controller_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Test
   module Nest
@@ -21,7 +21,7 @@ describe Scorpion::Rails::Controller, type: :controller do
       scorpion.new Test::Nest::Provided
     end
 
-    hunt_for String do |scorpion|
+    hunt_for String do |_scorpion|
       instance_value
     end
 
@@ -45,7 +45,7 @@ describe Scorpion::Rails::Controller, type: :controller do
         capture   Test::Nest::Service # Once per request
 
         share do
-          capture   Test::Nest::Cache   # Once for all requests
+          capture Test::Nest::Cache # Once for all requests
         end
       end
 
@@ -70,9 +70,9 @@ describe Scorpion::Rails::Controller, type: :controller do
     it "stores the scorpion in `env`" do
       expect( subject ).to receive( :assign_scorpion ).and_wrap_original do |method, *args|
         expect( subject.request.env ).to receive( :[]= )
-            .with( Scorpion::Rails::Controller::ENV_KEY, kind_of( Scorpion ) )
-            .at_least( :once )
-            .and_call_original
+          .with( Scorpion::Rails::Controller::ENV_KEY, kind_of( Scorpion ) )
+          .at_least( :once )
+          .and_call_original
 
         method.call( *args )
       end
@@ -114,7 +114,7 @@ describe Scorpion::Rails::Controller, type: :controller do
     it "spawns the same service during the same request" do
       allow( subject ).to receive( :index ) do
         service = subject.scorpion.fetch Test::Nest::Service
-        expect( subject.scorpion.fetch Test::Nest::Service ).to be service
+        expect( subject.scorpion.fetch(Test::Nest::Service) ).to be service
         controller.render nothing: true
       end
 
@@ -125,7 +125,7 @@ describe Scorpion::Rails::Controller, type: :controller do
       service = subject.service
 
       allow( subject ).to receive( :index ) do
-        expect( subject.scorpion.fetch Test::Nest::Service ).not_to be service
+        expect( subject.scorpion.fetch(Test::Nest::Service) ).not_to be service
         controller.render nothing: true
       end
 

data/spec/lib/scorpion/rails/job_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Test
   module Job

data/spec/lib/scorpion/rspec/helper_spec.rb

@@ -1,6 +1,6 @@
-require 'spec_helper'
-require 'scorpion/rspec'
-load 'scorpion/rspec/helper.rb'
+require "spec_helper"
+require "scorpion/rspec"
+load "scorpion/rspec/helper.rb"
 
 Scorpion::Rspec.prepare do
   hunt_for Numeric, return: 42
@@ -24,11 +24,11 @@ describe Scorpion::Rspec::Helper do
   end
 
   it "is configurable" do
-    expect( scorpion.fetch String ).to eq "Shazam!"
+    expect( scorpion.fetch(String) ).to eq "Shazam!"
   end
 
   it "inherits global config" do
-    expect( scorpion.fetch Numeric ).to eq 42
+    expect( scorpion.fetch(Numeric) ).to eq 42
   end
 
   context "hunting" do
@@ -37,15 +37,15 @@ describe Scorpion::Rspec::Helper do
     hunt( :double, Regexp )
     capture( :food, ScorpionRspecHelperSpec::Food )
 
-    specify{ expect( scorpion.fetch Numeric ).to eq 5 }
-    specify{ expect( scorpion.fetch String  ).to eq "hello" }
-    specify{ expect( scorpion.fetch Regexp  ).to be_a RSpec::Mocks::TestDouble }
-    specify{ expect( scorpion.fetch ScorpionRspecHelperSpec::Food ).to be food }
+    specify { expect( scorpion.fetch(Numeric) ).to eq 5 }
+    specify { expect( scorpion.fetch(String)  ).to eq "hello" }
+    specify { expect( scorpion.fetch(Regexp)  ).to be_a RSpec::Mocks::TestDouble }
+    specify { expect( scorpion.fetch(ScorpionRspecHelperSpec::Food) ).to be food }
   end
 
   context "child context" do
     it "inherits" do
-      expect( scorpion.fetch String ).to eq "Shazam!"
+      expect( scorpion.fetch(String) ).to eq "Shazam!"
     end
 
     context "overrides" do
@@ -55,7 +55,7 @@ describe Scorpion::Rspec::Helper do
       end
 
       it "overrides" do
-        expect( scorpion.fetch String ).to eq "KaPow"
+        expect( scorpion.fetch(String) ).to eq "KaPow"
       end
     end
   end

data/spec/lib/scorpion_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 describe Scorpion do
 
 

data/spec/spec_helper.rb

@@ -1,15 +1,15 @@
-require 'simplecov'
+require "simplecov"
 SimpleCov.start
 
-require 'pry'
-require 'bundler/setup'
-require 'combustion'
+require "pry"
+require "bundler/setup"
+require "combustion"
 
 Combustion.initialize! :all
 
-require 'rspec/rails'
-require 'scorpion'
-require 'scorpion/rspec'
+require "rspec/rails"
+require "scorpion"
+require "scorpion/rspec"
 
 root_path = File.expand_path( "../..", __FILE__ )
 
@@ -29,8 +29,6 @@ RSpec.configure do |config|
   config.after(:each)   { GC.enable }
 
   config.before( :each, type: :model ) do
-    [ Todo, Author ].each do |model|
-      model.destroy_all
-    end
+    [ Todo, Author ].each(&:destroy_all)
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: scorpion-ioc
 version: !ruby/object:Gem::Version
-  version: 0.6.2
+  version: 1.0.0
 platform: ruby
 authors:
 - Paul Alexander
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-28 00:00:00.000000000 Z
+date: 2017-10-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -125,13 +125,16 @@ files:
 - ".yardopts"
 - CHANGELOG.md
 - Gemfile
+- Gemfile.lock
 - Guardfile
 - LICENSE
 - README.md
 - Rakefile
+- app/README
 - bin/rspec
 - circle.yml
 - config.ru
+- config/environment.rb
 - lib/scorpion-ioc.rb
 - lib/scorpion.rb
 - lib/scorpion/attribute.rb
@@ -151,7 +154,6 @@ files:
 - lib/scorpion/method.rb
 - lib/scorpion/nest.rb
 - lib/scorpion/object.rb
-- lib/scorpion/object_constructor.rb
 - lib/scorpion/rack.rb
 - lib/scorpion/rack/env.rb
 - lib/scorpion/rack/middleware.rb
@@ -190,7 +192,6 @@ files:
 - spec/lib/scorpion/error_spec.rb
 - spec/lib/scorpion/hunt_spec.rb
 - spec/lib/scorpion/hunter_spec.rb
-- spec/lib/scorpion/object_constructor_spec.rb
 - spec/lib/scorpion/object_spec.rb
 - spec/lib/scorpion/rack/middleware_spec.rb
 - spec/lib/scorpion/rack_spec.rb
@@ -222,7 +223,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.10
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Add IoC to rails with minimal fuss and ceremony
@@ -246,7 +247,6 @@ test_files:
 - spec/lib/scorpion/error_spec.rb
 - spec/lib/scorpion/hunt_spec.rb
 - spec/lib/scorpion/hunter_spec.rb
-- spec/lib/scorpion/object_constructor_spec.rb
 - spec/lib/scorpion/object_spec.rb
 - spec/lib/scorpion/rack/middleware_spec.rb
 - spec/lib/scorpion/rack_spec.rb

data/lib/scorpion/object_constructor.rb

@@ -1,79 +0,0 @@
-module Scorpion
-  # Builds an injectable constructor for a Scorpion::Object.
-  class ObjectConstructor
-
-    def initialize( base, arguments, &block )
-      @base      = base
-      @arguments = arguments
-      @block     = block
-    end
-
-    def define
-      @signature       = []
-      @block_signature = []
-      @body            = []
-
-      define_dependencies
-      build_body
-
-      add_initialize_block
-      add_super
-
-      assemble
-    end
-
-    private
-      attr_reader :base, :arguments, :block, :body
-
-      def define_dependencies
-        # Override the inherited injections cause we're about to define a new
-        # initializer.
-        base.instance_variable_set :@initializer_injections, AttributeSet.new
-
-        arguments.each do |key,expectation|
-          base.initializer_injections.define_attribute key, *Array( expectation )
-          base.attr_dependency key, *Array( expectation )
-        end
-      end
-
-      def build_body
-        if arguments.present?
-          body << "injections = dependencies.slice( :#{ arguments.keys.join(', :') } )"
-          body << "inject_from( dependencies )"
-        else
-          body << "injections = {}"
-        end
-      end
-
-      def add_super
-        body << "super" if base.superclass < Scorpion::Object
-      end
-
-      def add_initialize_block
-        if block
-          base_name = base.name || base.object_id.to_s
-          base_name = base_name.gsub /::/, '_'
-          name = "__initialize_with_block_#{ base_name }"
-          if block.arity != 0 || block.parameters.any?
-            body << "#{ name }( *args, **injections, &block )"
-          else
-            body << "#{ name }"
-          end
-          base.send :define_method, :"#{ name }", &block
-        end
-      end
-
-      def assemble
-        source = %Q|def initialize( *args, **dependencies, &block )\n\t#{ body.join( "\n\t" ) }\nend|
-
-        # puts "=" * 50
-        # puts base.name
-        # puts source
-        # puts "=" * 50
-
-        base.class_eval <<-RUBY, __FILE__, __LINE__ + 1
-#{ source }
-        RUBY
-      end
-  end
-end

data/spec/lib/scorpion/object_constructor_spec.rb

@@ -1,124 +0,0 @@
-require 'spec_helper'
-
-describe Scorpion::ObjectConstructor do
-
-   it 'defines an initializer' do
-      klass = Class.new do
-        include Scorpion::Object
-
-        initialize logger: String
-      end
-
-      expect( klass.instance_method(:initialize).arity ).to eq -1
-    end
-
-    it "executes initializer code" do
-      expect do |b|
-        klass = Class.new do
-          include Scorpion::Object
-
-          initialize label: String, &b
-        end
-
-        klass.new label: "home"
-      end.to yield_control
-    end
-
-    it "creates an initializer that accepts a block" do
-      klass = Class.new do
-        include Scorpion::Object
-
-        initialize label: String do |label, &block|
-          block.call
-        end
-      end
-
-      expect do |b|
-        klass.new label: "apples", &b
-      end.to yield_control
-    end
-
-    it "it defines matching attributes" do
-      klass = Class.new do
-        include Scorpion::Object
-
-        initialize label: String
-      end
-
-      expect( klass.new( label: "apples" ).label ).to eq "apples"
-    end
-
-    it "invokes all initializers" do
-      klass = Class.new do
-        include Scorpion::Object
-
-        initialize label: String do |label:|
-          @label = label.reverse
-        end
-      end
-
-      derived = Class.new( klass ) do
-        initialize logger: Logger do |logger:|
-          @logger = logger.to_s.reverse.to_sym
-        end
-      end
-
-      expect( derived.new( logger: :unset, label: "Super" ).label ).to eq "repuS"
-      expect( derived.new( logger: :unset, label: "Super" ).logger ).to eq :tesnu
-    end
-
-
-    context "inheritance" do
-      let( :klass ) do
-        Class.new do
-          include Scorpion::Object
-
-          initialize label: String do |label:|
-            @label = label.reverse
-          end
-        end
-      end
-
-      let( :derived ) do
-        Class.new( klass )
-      end
-
-      it "inherits super initializer block" do
-        expect( derived.new( label: "Super" ).label ).to eq "repuS"
-      end
-
-      it "inherits initializer_injections" do
-        expect( klass.initializer_injections.count ).to eq 1
-        expect( klass.initializer_injections ).to eq derived.initializer_injections
-      end
-
-      it "can override initializer_injections" do
-        more_derived = Class.new( derived ) do
-          initialize do
-          end
-        end
-
-        expect( more_derived.initializer_injections.count ).to eq 0
-      end
-
-      it "fails if changing attribute without changing initializer" do
-        expect do
-          overriden = Class.new( klass ) do
-            attr_dependency :label, Integer
-          end
-        end.to raise_exception Scorpion::ContractMismatchError
-      end
-
-      it "works if changing attribute and changing initializer" do
-        expect do
-          overriden = Class.new( klass ) do
-
-            initialize label: Integer
-            attr_dependency :label, Integer
-          end
-        end.not_to raise_exception
-      end
-
-    end
-
-end