scorm_engine 0.8.1 → 0.8.2

data/spec/scorm_engine/api/endpoints/destinations_spec.rb

@@ -48,7 +48,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Destinations do
           expect(destinations.success?).to eq false
           expect(destinations.status).to eq 400
           expect(destinations.results.to_a).to eq []
-          expect(destinations.message).to match(/'invalid' is either not a timestamp or seems to be not formatted according to ISO 8601/)
+          expect(destinations.message).to match(/'invalid'/)
         end
       end
     end
@@ -63,7 +63,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Destinations do
       end
 
       it "returns the :more key in the raw response" do
-        expect(subject.get_destinations.raw_response.body["more"]).to match(%r{https?://.*&more=.+})
+        expect(subject.get_destinations.raw_response.body["more"]).to match(%r{(https?://)?.*&more=.+})
       end
 
       it "returns all the destinations" do

data/spec/scorm_engine/api/endpoints/dispatches_spec.rb

@@ -85,7 +85,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Dispatches do
       end
 
       it "returns the :more key in the raw response" do
-        expect(subject.get_dispatches.raw_response.body["more"]).to match(%r{https?://.*&more=.+})
+        expect(subject.get_dispatches.raw_response.body["more"]).to match(%r{(https?://)?.*&more=.+})
       end
 
       it "returns all the dispatches" do

data/spec/scorm_engine/api/endpoints/registrations/configuration_spec.rb

@@ -40,7 +40,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Registrations::Configuration do
       response = subject.get_registration_configuration(registration_id: "nonexistent-registration", settings: {})
       expect(response.success?).to eq false
       expect(response.status).to eq 404
-      expect(response.message).to match(/External Registration ID 'nonexistent-registration'/)
+      expect(response.message).to match(/Registration ID 'nonexistent-registration'/)
       expect(response.result).to eq nil
     end
   end
@@ -79,7 +79,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Registrations::Configuration do
       response = subject.post_registration_configuration(registration_id: "nonexistent-registration", settings: {})
       expect(response.success?).to eq false
       expect(response.status).to eq 404
-      expect(response.message).to match(/External Registration ID 'nonexistent-registration'/)
+      expect(response.message).to match(/Registration ID 'nonexistent-registration'/)
       expect(response.result).to eq nil
     end
 
@@ -87,7 +87,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Registrations::Configuration do
       response = subject.post_registration_configuration(registration_id: registration_options[:registration_id], settings: { "NonExistentSettingTotesBogus" => "YES" })
       expect(response.success?).to eq false
       expect(response.status).to eq 400
-      expect(response.message).to match(/No configuration setting found with id.*NonExistentSettingTotesBogus/)
+      expect(response.message).to match(/NonExistentSettingTotesBogus/)
     end
   end
 
@@ -111,7 +111,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Registrations::Configuration do
       response = subject.get_registration_configuration_setting(registration_id: "nonexistent-registration", setting_id: "PlayerStatusRollupModeThresholdScore")
       expect(response.success?).to eq false
       expect(response.status).to eq 404
-      expect(response.message).to match(/External Registration ID 'nonexistent-registration'/)
+      expect(response.message).to match(/Registration ID 'nonexistent-registration'/)
       expect(response.result).to eq nil
     end
 
@@ -144,7 +144,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Registrations::Configuration do
       response = subject.put_registration_configuration_setting(registration_id: "nonexistent-registration", setting_id: "PlayerStatusRollupModeThresholdScore", value: "42")
       expect(response.success?).to eq false
       expect(response.status).to eq 404
-      expect(response.message).to match(/External Registration ID 'nonexistent-registration'/)
+      expect(response.message).to match(/Registration ID 'nonexistent-registration'/)
       expect(response.result).to eq nil
     end
 

data/spec/scorm_engine/api/endpoints/registrations_spec.rb

@@ -183,7 +183,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Registrations do
       aggregate_failures do
         expect(response.success?).to eq false
         expect(response.status).to eq 400
-        expect(response.message).to match(/External Package ID 'invalid-bogus'/)
+        expect(response.message).to match(/'invalid-bogus'/)
       end
     end
 
@@ -215,7 +215,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Registrations do
       response = subject.get_registration_launch_link(registration_id: "nonexistent-registration")
       expect(response.success?).to eq false
       expect(response.status).to eq 404
-      expect(response.message).to match(/External Registration ID 'nonexistent-registration'/)
+      expect(response.message).to match(/'nonexistent-registration'/)
       expect(response.result).to eq nil
     end
   end

data/spec/scorm_engine/api/endpoints/tenants/configuration_spec.rb

@@ -70,7 +70,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Tenants::Configuration do
       response = subject.post_tenant_configuration(settings: { "NonExistentSettingTotesBogus" => "YES" })
       expect(response.success?).to eq false
       expect(response.status).to eq 400
-      expect(response.message).to match(/No configuration setting found with id.*NonExistentSettingTotesBogus/)
+      expect(response.message).to match(/NonExistentSettingTotesBogus/)
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scorm_engine
 version: !ruby/object:Gem::Version
-  version: 0.8.1
+  version: 0.8.2
 platform: ruby
 authors:
 - Philip Hallstrom
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-09-18 00:00:00.000000000 Z
+date: 2020-09-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -233,6 +233,7 @@ files:
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Courses/_get_course_preview/fails_when_id_is_invalid.yml
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Courses/_get_course_preview/is_successful.yml
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Courses/_get_course_preview/results/returns_a_URL_string.yml
+- spec/fixtures/vcr/ScormEngine_Api_Endpoints_Courses/_get_course_preview/results/returns_a_URL_string_containing_a_signed_jwt.yml
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Courses/_get_courses/_course_id_option/fetches_a_single_course_but_perhaps_multiple_versions.yml
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Courses/_get_courses/_course_id_option/returns_404_when_ID_is_invalid.yml
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Courses/_get_courses/_more_option_pagination_/returns_all_the_courses.yml
@@ -260,7 +261,6 @@ files:
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Courses_Import/_get_course_import/successful_imports/works.yml
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Courses_Import/_get_course_import/unsuccessful_imports/fails_to_import_given_an_invalid_url.yml
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Courses_Import/_post_course_import/unsuccessful_imports/fails_to_import_a_previously_existing_course.yml
-- spec/fixtures/vcr/ScormEngine_Api_Endpoints_Destinations/_delete_destination/raises_ArgumentError_when_destination_id_is_missing.yml
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Destinations/_delete_destination/returns_success_even_when_id_is_invalid.yml
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Destinations/_delete_destination/works.yml
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Destinations/_get_destination/fails_when_id_is_invalid.yml
@@ -297,7 +297,6 @@ files:
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Dispatches/_get_dispatch_registration_count/fails_when_id_is_invalid.yml
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Dispatches/_get_dispatch_registration_count/is_successful.yml
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Dispatches/_get_dispatch_registration_count/results/sucessfully_creates_the_dispatch_attributes.yml
-- spec/fixtures/vcr/ScormEngine_Api_Endpoints_Dispatches/_get_dispatch_registration_count/when_dispatch_has_registrations/knows_it_s_registration_count.yml
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Dispatches/_get_dispatch_zip/fails_given_an_invalid_id.yml
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Dispatches/_get_dispatch_zip/fails_given_an_invalid_type.yml
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Dispatches/_get_dispatch_zip/works.yml

data/spec/fixtures/vcr/ScormEngine_Api_Endpoints_Destinations/_delete_destination/raises_ArgumentError_when_destination_id_is_missing.yml

@@ -1,32 +0,0 @@
----
-http_interactions:
-- request:
-    method: delete
-    uri: https://<SCORM_ENGINE_HOST>/ScormEngineInterface/api/v1/ScormEngineGemTesting-default/destinations/
-    body:
-      encoding: US-ASCII
-      string: ''
-    headers:
-      Content-Type:
-      - application/json
-      User-Agent:
-      - ScormEngine Ruby Gem 0.3.0
-      Authorization:
-      - Basic <BASIC_AUTH>
-  response:
-    status:
-      code: 204
-      message: ''
-    headers:
-      date:
-      - Mon, 20 Aug 2018 21:19:13 GMT
-      server:
-      - nginx
-      connection:
-      - Close
-    body:
-      encoding: UTF-8
-      string: ''
-    http_version: 
-  recorded_at: Mon, 20 Aug 2018 21:19:13 GMT
-recorded_with: VCR 4.0.0

data/spec/fixtures/vcr/ScormEngine_Api_Endpoints_Dispatches/_get_dispatch_registration_count/when_dispatch_has_registrations/knows_it_s_registration_count.yml

@@ -1,63 +0,0 @@
----
-http_interactions:
-- request:
-    method: delete
-    uri: https://<SCORM_ENGINE_HOST>/ScormEngineInterface/api/v1/ScormEngineGemTesting-default/dispatches/testing-dispatch-id-2/registrationCount
-    body:
-      encoding: US-ASCII
-      string: ''
-    headers:
-      User-Agent:
-      - ScormEngine Ruby Gem 0.7.1
-      Authorization:
-      - Basic <BASIC_AUTH>
-  response:
-    status:
-      code: 204
-      message: ''
-    headers:
-      date:
-      - Fri, 15 Feb 2019 22:00:40 GMT
-      server:
-      - nginx
-      connection:
-      - Close
-    body:
-      encoding: UTF-8
-      string: ''
-    http_version: 
-  recorded_at: Fri, 15 Feb 2019 22:00:40 GMT
-- request:
-    method: get
-    uri: https://<SCORM_ENGINE_HOST>/ScormEngineInterface/api/v1/ScormEngineGemTesting-default/dispatches/testing-dispatch-id-2/registrationCount
-    body:
-      encoding: US-ASCII
-      string: ''
-    headers:
-      User-Agent:
-      - ScormEngine Ruby Gem 0.7.1
-      Authorization:
-      - Basic <BASIC_AUTH>
-  response:
-    status:
-      code: 200
-      message: ''
-    headers:
-      content-type:
-      - application/json
-      date:
-      - Fri, 15 Feb 2019 22:00:40 GMT
-      server:
-      - nginx
-      vary:
-      - Accept-Encoding
-      content-length:
-      - '86'
-      connection:
-      - Close
-    body:
-      encoding: ASCII-8BIT
-      string: '{"registrationCount":0,"lastResetTime":"2019-02-15T22:00:40.000Z"}'
-    http_version: 
-  recorded_at: Fri, 15 Feb 2019 22:00:40 GMT
-recorded_with: VCR 4.0.0