scorm_engine 0.6.6 → 0.6.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4c507da57a7a18d0c058187941df270ff46ef49adf40a3014e5db7634e171966
-  data.tar.gz: fcfdde88f3edc1626bb5d8706baf44e57e435a3261a7c97b82db9fbd79f0a9f4
+  metadata.gz: 2323920f6cad4a17b64952bcedfc10cc2bf479ece620202fe9556e104c2d89fb
+  data.tar.gz: 0f15942cf9e9f71d50d086ba98865295b2e18e3157961bae5698b2ccd3b57bd3
 SHA512:
-  metadata.gz: e879b2fa7079cf528999dbc8858b2a6e7ce4ae2e98e956981ccc4febb08bfe1386978ba4d4a0378224d57c64f4d1f892c2fe41ef7dfd05b7f786917af1b58491
-  data.tar.gz: 1f008d07e1816cb3e908b2329c613d5bb08b8e368c1e7a1519f248ded21b4cd96c836e4050a70289924f1ad1e40c7acd042ece0304b3557bf9e918adcd09a813
+  metadata.gz: 8ed8f4351b49ece62eb448c101c73f798c410345a6ec4e02a86404879320fe72cfc3e5d986f2bff2d3c04ea35b5d8321911133c2d354d4ba671c8853c3854ed7
+  data.tar.gz: 623b7900eddf5b066158e1da192255ad46bc0564acff6b3773f394ab9f5ce173e82d757e3efa8422bb89e3ccc0e326c6c0b9dc026aa98ab92c9232a9725c2d71

data/lib/scorm_engine/api/endpoints/dispatches.rb

@@ -130,7 +130,8 @@ module ScormEngine
 
           response = get("dispatches/#{options[:dispatch_id]}")
 
-          result = response.success? ? ScormEngine::Models::Dispatch.new_from_api(response.body) : nil
+          # merge options to pick up dispatch_id which isn't passed back in the response
+          result = response.success? ? ScormEngine::Models::Dispatch.new_from_api({ "id" => options[:dispatch_id] }.merge(response.body)) : nil
 
           Response.new(raw_response: response, result: result)
         end

data/lib/scorm_engine/version.rb

@@ -1,3 +1,3 @@
 module ScormEngine
-  VERSION = "0.6.6".freeze
+  VERSION = "0.6.7".freeze
 end

data/spec/fixtures/vcr/ScormEngine_Api_Endpoints_Dispatches/_post_dispatch/is_updates_if_same_dispatch_id.yml

@@ -0,0 +1,98 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: https://<SCORM_ENGINE_HOST>/ScormEngineInterface/api/v1/ScormEngineGemTesting-default/dispatches/testing-dispatch-id
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - ScormEngine Ruby Gem 0.6.6
+      Authorization:
+      - Basic <BASIC_AUTH>
+  response:
+    status:
+      code: 200
+      message: ''
+    headers:
+      content-type:
+      - application/json
+      date:
+      - Mon, 17 Sep 2018 22:04:10 GMT
+      server:
+      - nginx
+      vary:
+      - Accept-Encoding
+      content-length:
+      - '178'
+      connection:
+      - Close
+    body:
+      encoding: ASCII-8BIT
+      string: '{"destinationId":"testing-golf-club","courseId":"testing-golf-explained","allowNewRegistrations":false,"instanced":false,"registrationCap":0,"expirationDate":"none","externalConfig":"scormenginegemtesting-default","enabled":true,"registrationCount":0,"registrationResetDate":"none"}'
+    http_version: 
+  recorded_at: Mon, 17 Sep 2018 22:04:10 GMT
+- request:
+    method: post
+    uri: https://<SCORM_ENGINE_HOST>/ScormEngineInterface/api/v1/ScormEngineGemTesting-default/dispatches
+    body:
+      encoding: UTF-8
+      string: '{"dispatches":[{"id":"testing-dispatch-id","data":{"destinationId":"testing-golf-club","courseId":"testing-golf-explained","allowNewRegistrations":false,"instanced":false,"registrationCap":0,"expirationDate":"2030-01-01","externalConfig":null}}]}'
+    headers:
+      User-Agent:
+      - ScormEngine Ruby Gem 0.6.6
+      Authorization:
+      - Basic <BASIC_AUTH>
+      Content-Type:
+      - application/json
+  response:
+    status:
+      code: 204
+      message: ''
+    headers:
+      date:
+      - Mon, 17 Sep 2018 22:04:11 GMT
+      server:
+      - nginx
+      connection:
+      - Close
+    body:
+      encoding: UTF-8
+      string: ''
+    http_version: 
+  recorded_at: Mon, 17 Sep 2018 22:04:11 GMT
+- request:
+    method: get
+    uri: https://<SCORM_ENGINE_HOST>/ScormEngineInterface/api/v1/ScormEngineGemTesting-default/dispatches/testing-dispatch-id
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - ScormEngine Ruby Gem 0.6.6
+      Authorization:
+      - Basic <BASIC_AUTH>
+  response:
+    status:
+      code: 200
+      message: ''
+    headers:
+      content-type:
+      - application/json
+      date:
+      - Mon, 17 Sep 2018 22:04:11 GMT
+      server:
+      - nginx
+      vary:
+      - Accept-Encoding
+      content-length:
+      - '196'
+      connection:
+      - Close
+    body:
+      encoding: ASCII-8BIT
+      string: '{"destinationId":"testing-golf-club","courseId":"testing-golf-explained","allowNewRegistrations":false,"instanced":false,"registrationCap":0,"expirationDate":"2030-01-01T00:00:00Z","externalConfig":"scormenginegemtesting-default","enabled":true,"registrationCount":0,"registrationResetDate":"none"}'
+    http_version: 
+  recorded_at: Mon, 17 Sep 2018 22:04:11 GMT
+recorded_with: VCR 4.0.0

data/spec/scorm_engine/api/endpoints/dispatches_spec.rb

@@ -96,6 +96,20 @@ RSpec.describe ScormEngine::Api::Endpoints::Dispatches do
         expect(response.status).to eq 204
       end
     end
+
+    it "is updates if same dispatch_id" do
+      response = subject.get_dispatch(dispatch_id: dispatch_options[:dispatch_id])
+      expect(response.result.expiration_date).to eq nil
+
+      response = subject.post_dispatch(dispatch_options.merge(expiration_date: Date.new(2030, 1, 1)))
+      aggregate_failures do
+        expect(response.success?).to eq true
+        expect(response.status).to eq 204
+      end
+
+      response = subject.get_dispatch(dispatch_id: dispatch_options[:dispatch_id])
+      expect(response.result.expiration_date).to be_a Time
+    end
   end
 
   describe "#get_dispatch" do
@@ -109,6 +123,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Dispatches do
       it "sucessfully creates the dispatch attributes" do
         dispatch = response.result
         aggregate_failures do
+          expect(dispatch.id).to eq dispatch_options[:dispatch_id]
           expect(dispatch.destination_id).to eq dispatch_options[:destination_id]
           expect(dispatch.course_id).to eq dispatch_options[:course_id]
         end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scorm_engine
 version: !ruby/object:Gem::Version
-  version: 0.6.6
+  version: 0.6.7
 platform: ruby
 authors:
 - Philip Hallstrom
@@ -297,6 +297,7 @@ files:
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Dispatches/_get_dispatches/results/is_an_enumerator_of_dispatch_models.yml
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Dispatches/_get_dispatches/results/sucessfully_creates_the_dispatch_attributes.yml
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Dispatches/_post_dispatch/is_successful.yml
+- spec/fixtures/vcr/ScormEngine_Api_Endpoints_Dispatches/_post_dispatch/is_updates_if_same_dispatch_id.yml
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Dispatches/_put_dispatch/is_successful.yml
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Dispatches/_put_dispatch/results/sucessfully_creates_the_dispatch_attributes.yml
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Dispatches/_put_dispatch_enabled/fails_when_invalid.yml