scorm_engine 0.2.0 → 0.3.0

data/spec/scorm_engine/api/endpoints/about_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe ScormEngine::Api::Endpoints::About do
     end
 
     it "knows the version" do
-      expect(subject.result.version).to eq "2017.1.44.1251"
+      expect(subject.result.version).to eq "2017.1.47.1282"
     end
 
     it "knows the platform" do

data/spec/scorm_engine/api/endpoints/courses/configuration_spec.rb

@@ -30,6 +30,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Courses::Configuration do
       expect(response.success?).to eq false
       expect(response.status).to eq 404
       expect(response.message).to match(/External Package ID 'nonexistent-course'/)
+      expect(response.result).to eq nil
     end
   end
 
@@ -99,6 +100,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Courses::Configuration do
       expect(response.success?).to eq false
       expect(response.status).to eq 404
       expect(response.message).to match(/External Package ID 'nonexistent-course'/)
+      expect(response.result).to eq nil
     end
 
     it "fails when setting_id is invalid" do
@@ -106,6 +108,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Courses::Configuration do
       expect(response.success?).to eq false
       expect(response.status).to eq 400
       expect(response.message).to match(/No configuration setting found with id.*NonExistentSettingTotesBogus/)
+      expect(response.result).to eq nil
     end
   end
 

data/spec/scorm_engine/api/endpoints/courses/import_spec.rb

@@ -54,7 +54,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Courses::Import do
 
         aggregate_failures do
           expect(import.success?).to eq false
-          expect(import.result).to be_falsey
+          expect(import.result).to eq nil
           expect(import.message).to match(/A course already exists with the specified id: .*\|a-previously-existing-course!/)
         end
       end

data/spec/scorm_engine/api/endpoints/courses_spec.rb

@@ -129,6 +129,14 @@ RSpec.describe ScormEngine::Api::Endpoints::Courses do
         end
       end
     end
+
+    it "fails when id is invalid" do
+      response = subject.get_course_preview(course_id: "nonexistent-course")
+      expect(response.success?).to eq false
+      expect(response.status).to eq 404
+      expect(response.message).to match(/External Package ID 'nonexistent-course'/)
+      expect(response.result).to eq nil
+    end
   end
 
   describe "#get_course_preview" do
@@ -150,6 +158,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Courses do
       expect(response.success?).to eq false
       expect(response.status).to eq 404
       expect(response.message).to match(/External Package ID 'nonexistent-course'/)
+      expect(response.result).to eq nil
     end
   end
 end

data/spec/scorm_engine/api/endpoints/registrations/configuration_spec.rb

@@ -41,6 +41,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Registrations::Configuration do
       expect(response.success?).to eq false
       expect(response.status).to eq 404
       expect(response.message).to match(/External Registration ID 'nonexistent-registration'/)
+      expect(response.result).to eq nil
     end
   end
 
@@ -79,6 +80,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Registrations::Configuration do
       expect(response.success?).to eq false
       expect(response.status).to eq 404
       expect(response.message).to match(/External Registration ID 'nonexistent-registration'/)
+      expect(response.result).to eq nil
     end
 
     it "fails when settings are invalid" do
@@ -110,6 +112,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Registrations::Configuration do
       expect(response.success?).to eq false
       expect(response.status).to eq 404
       expect(response.message).to match(/External Registration ID 'nonexistent-registration'/)
+      expect(response.result).to eq nil
     end
 
     it "fails when setting_id is invalid" do
@@ -142,6 +145,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Registrations::Configuration do
       expect(response.success?).to eq false
       expect(response.status).to eq 404
       expect(response.message).to match(/External Registration ID 'nonexistent-registration'/)
+      expect(response.result).to eq nil
     end
 
     it "fails when setting_id is invalid" do

data/spec/scorm_engine/api/endpoints/registrations/launch_history_spec.rb

@@ -40,6 +40,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Registrations::LaunchHistory do
       aggregate_failures do
         expect(response.success?).to eq false
         expect(response.status).to eq 404
+        expect(response.result).to eq nil
       end
     end
   end

data/spec/scorm_engine/api/endpoints/registrations_spec.rb

@@ -93,7 +93,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Registrations do
     it "is false when registration does not exist" do
       response = subject.get_registration_exists(registration_id: "reg-does-not-exist")
       aggregate_failures do
-        expect(response.result).to eq false
+        expect(response.result).to eq nil
         expect(response.status).to eq 404
       end
     end
@@ -114,7 +114,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Registrations do
       aggregate_failures do
         expect(response.success?).to eq false
         expect(response.status).to eq 404
-        expect(response.result).to be_falsey
+        expect(response.result).to eq nil
       end
     end
 
@@ -144,6 +144,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Registrations do
       aggregate_failures do
         expect(response.success?).to eq false
         expect(response.status).to eq 404
+        expect(response.result).to eq nil
       end
     end
   end
@@ -196,6 +197,7 @@ RSpec.describe ScormEngine::Api::Endpoints::Registrations do
       expect(response.success?).to eq false
       expect(response.status).to eq 404
       expect(response.message).to match(/External Registration ID 'nonexistent-registration'/)
+      expect(response.result).to eq nil
     end
   end
 end

data/spec/scorm_engine/models/course_spec.rb

@@ -88,5 +88,14 @@ RSpec.describe ScormEngine::Models::Course do
         end
       end
     end
+
+    describe ":course_learning_standard" do
+      it "is set properly" do
+        course = described_class.new_from_api(
+          "courseLearningStandard" => "SCORM_2004_4TH_EDITION"
+        )
+        expect(course.course_learning_standard).to eq "SCORM_2004_4TH_EDITION"
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: scorm_engine
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Philip Hallstrom
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-08-08 00:00:00.000000000 Z
+date: 2018-08-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -196,6 +196,7 @@ files:
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_About/_get_about_user_count/tracks_per_tenantcounts.yml
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Courses/_delete_course/fails_when_id_is_invalid.yml
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Courses/_delete_course/works.yml
+- spec/fixtures/vcr/ScormEngine_Api_Endpoints_Courses/_get_course_detail/fails_when_id_is_invalid.yml
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Courses/_get_course_detail/is_successful.yml
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Courses/_get_course_detail/results/sucessfully_creates_the_Course_attributes.yml
 - spec/fixtures/vcr/ScormEngine_Api_Endpoints_Courses/_get_course_preview/fails_when_id_is_invalid.yml