scientist 1.6.2 → 1.6.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1e623b9acbede185a6ee8ca0ae2227a52707499c28bdf04e4fe8a2afcbd0f051
-  data.tar.gz: 560b1d3353829f6be217229546297fcd4102e6c47dc87fc12ffa963c5e2fa3f7
+  metadata.gz: 53663e0ed4b522336c69b73073aa144a4b6c8178e3fcd716c0e4519a66e308ba
+  data.tar.gz: b60d0c55dce9e1e9a23eb7e6ce4c445bf01340dcfd459d50716d7cd85e405b93
 SHA512:
-  metadata.gz: 593c2807ff16f1381a0189e4babdad3ab366ad66057e4af1b083611fb204d55ae9434bf989550f8371de7586be55fe4f8a760f84f2424323a9189803583e9243
-  data.tar.gz: 1239bb86dfad9fcee2b0dc4dc2fc8458306e877afd2aa1e722b9e4db7072b71658469bf48b425959c52111fac2cc8bb5dbbb11435263a199f036ad2ee4697228
+  metadata.gz: 6e1baf64882c857abdd3fd02b77785a783a8694854358c78a9da3be213b42ac88e36805ebf7f10f0d87fb14d7808302e1afffd2793c5ffc21addec5326e5f969
+  data.tar.gz: e5a65140ca8704c7443f88404cfb9e971f4a2925d756eed18d7482be74aab3243315fda727dfe8fed13d0732d76ca442a12cb7af200ca6ae3e4de4b0f1bab1a2

data/lib/scientist/experiment.rb

@@ -84,7 +84,6 @@ module Scientist::Experiment
   #
   # Returns the configured block.
   def before_run(&block)
-    marshalize(block)
     @_scientist_before_run = block
   end
 
@@ -100,7 +99,6 @@ module Scientist::Experiment
   #
   # Returns the configured block.
   def clean(&block)
-    marshalize(block)
     @_scientist_cleaner = block
   end
 
@@ -133,7 +131,6 @@ module Scientist::Experiment
   #
   # Returns the block.
   def compare(*args, &block)
-    marshalize(block)
     @_scientist_comparator = block
   end
 
@@ -144,7 +141,6 @@ module Scientist::Experiment
   #
   # Returns the block.
   def compare_errors(*args, &block)
-    marshalize(block)
     @_scientist_error_comparator = block
   end
 
@@ -163,7 +159,6 @@ module Scientist::Experiment
   #
   # This can be called more than once with different blocks to use.
   def ignore(&block)
-    marshalize(block)
     @_scientist_ignores ||= []
     @_scientist_ignores << block
   end
@@ -256,7 +251,6 @@ module Scientist::Experiment
 
   # Define a block that determines whether or not the experiment should run.
   def run_if(&block)
-    marshalize(block)
     @_scientist_run_if_block = block
   end
 
@@ -282,7 +276,6 @@ module Scientist::Experiment
 
   # Register a named behavior for this experiment, default "candidate".
   def try(name = nil, &block)
-    marshalize(block)
     name = (name || "candidate").to_s
 
     if behaviors.include?(name)
@@ -294,7 +287,6 @@ module Scientist::Experiment
 
   # Register the control behavior for this experiment.
   def use(&block)
-    marshalize(block)
     try "control", &block
   end
 
@@ -332,13 +324,14 @@ module Scientist::Experiment
   # In order to support marshaling, we have to make the procs marshalable. Some
   # CI providers attempt to marshal Scientist mismatch errors so that they can
   # be sent out to different places (logs, etc.) The mismatch errors contain
-  # code from the experiment. This code contains Procs - which can't be
-  # marshaled until we run the following code.
-  def marshalize(block)
-    unless block.respond_to?(:_dump) || block.respond_to?(:_dump_data)
-      def block._dump(_)
-        to_s
-      end
-    end
+  # code from the experiment. This code contains procs. These procs prevent the
+  # error from being marshaled. To fix this, we simple exclude the procs from
+  # the data that we marshal.
+  def marshal_dump
+    [@name, @result, @raise_on_mismatches]
+  end
+
+  def marshal_load
+    @name, @result, @raise_on_mismatches = array
   end
 end

data/lib/scientist/version.rb

@@ -1,3 +1,3 @@
 module Scientist
-  VERSION = "1.6.2"
+  VERSION = "1.6.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scientist
 version: !ruby/object:Gem::Version
-  version: 1.6.2
+  version: 1.6.3
 platform: ruby
 authors:
 - GitHub Open Source
@@ -12,7 +12,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-11-04 00:00:00.000000000 Z
+date: 2021-12-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -95,7 +95,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.22
+rubygems_version: 3.2.32
 signing_key:
 specification_version: 4
 summary: Carefully test, measure, and track refactored code.