scidea-schools 1.0.5 → 1.0.6

data/CHANGELOG

@@ -1,3 +1,6 @@
+1.0.6
+  - PHX-313: will not allow school to be destroyed if there are users associated with it
+
 1.0.4
   - override core styles for alert message on profile form so that messages stays within the form div
 

data/README.md

@@ -8,7 +8,7 @@ Adds school association and lookup to users of Scitent's Scidea LMS platform. Th
 
     ```
     # Gemfile
-    gem 'requirejs-rails'
+    gem 'scidea-schools'
     ```
 
 2. Add the installation migrations to your ``db/migrate/`` folder:
@@ -32,7 +32,7 @@ To set up your environment for testing, perform the following:
     gem 'scidea-schools', :path => 'LOCAL_PATH_TO_SCIDEA-SCHOOLS'
     ```
 
-2. Copy the contents of the Scidea core Gemfile *after* ``gemspec``, and paste it to the end of the Gemfile in the scidea-schools code. When you run rspec/cucumber, they require this Gemfile, thus you need all of the gems that Scidea core requires as well.
+2. Add the scidea gem to the scidea-schools Gemfile and add the path to your Scidea core instance. Then, copy the contents of the Scidea core Gemfile *after* ``gemspec``, and paste it to the end of the Gemfile in the scidea-schools code. When you run rspec/cucumber, they require this Gemfile, thus you need all of the gems that Scidea core requires as well.
 
     ```
     source 'http://rubygems.org'
@@ -41,26 +41,15 @@ To set up your environment for testing, perform the following:
 
     gem 'scidea', :path => 'LOCAL_PATH_TO_SCIDEA-CORE'
 
-    #from scidea core Gemfile:
-    gem 'rails', '= 3.1.3'
+    # contents of scidea core Gemfile here....
 
-    # db
-    gem 'mysql2', '>= 0.3'
-
-    # authentication and authorization
-    gem 'devise', '< 2.0'
-    gem 'cancan'
-    
-    ... and so on
     ```
 
 From scidea-schools, you can run ``rspec`` and ``cucumber``. Note that FactoryGirl factories from the Scidea core are included in the testing runtime and added to whatever you include in ``spec/factories``. The database configuration from the Scidea core will also be used. You must run all rake operations for that database in the context of the Scidea core folder. They will not work in the scidea-schools folder.
 
 ## Compiling CSS and Inclusion in the Asset Pipeline
 
-[SASS](https://github.com/nex3/sass) and [Compass](https://github.com/chriseppstein/compass) are configured such that SASS files under the ``app/themes/scidea`` directory are compiled to ``app/assets/stylesheets/scidea`` when you run ``compass compile``.
-
-Because these stylesheets are added to the ``app/assets/stylesheets`` directory, they will be included in the Scidea core asset pipeline. However, because they are not ``scss`` files, Rails won't pick them up during the assets compile task. Therefore, any ``css`` file you add to ``app/assets/stylesheets`` must be included in the assets initializer: ``config/initializers/schools_assets.rb``.
+Stylesheets from ``app/themes/scidea`` are added to the ``app/assets/stylesheets`` directory as a part of the asset pipeline. However, because they are not ``scss`` files, Rails won't pick them up during the assets compile task. Therefore, any ``css`` file you add to ``app/assets/stylesheets`` must be included in the assets initializer: ``config/initializers/schools_assets.rb``.
 
 ## JS Modules
 

data/app/controllers/admin/schools_controller.rb

@@ -68,9 +68,16 @@ module Admin
     # DELETE /schools/1
     def destroy
       @school = School.where("id = ?", params[:id]).first
-      @school.destroy
-
-      redirect_to(admin_schools_path, :flash => { :success => "Educational institution was successfully deleted." }) 
+      if @school.destroy
+        flash_message = { :success => "Educational institution was successfully deleted." }
+      else
+        if @school && @school.errors[:base] && @school.errors[:base].count > 0
+          flash_message = { :failure => @school.errors[:base].first }
+        else
+          flash_message = { :failure => "Educational Insitution could not be deleted" }
+        end
+      end
+      redirect_to(admin_schools_path, :flash => flash_message)
     end
 
     # GET /schools/1/migration/new

data/app/models/school.rb

@@ -14,6 +14,8 @@ class School < ActiveRecord::Base
 
   validate :zipcode_formatting
   validate :phone_formatting
+  
+  before_destroy :do_not_delete_if_dependencies
 
   ZIPCODE_PATTERN = /^[\d]{5}$/
 
@@ -89,5 +91,13 @@ class School < ActiveRecord::Base
   def zipcode_formatting
     errors.add(:zipcode, "must be five numbers") unless zipcode && zipcode.match(ZIPCODE_PATTERN)
   end
+  
+  def do_not_delete_if_dependencies
+    # if any users have this school, do not delete it
+    if self.profiles.count > 0
+      self.errors.add(:base, "Educational institution #{self.name} was not deleted because it is tied to user profiles. Before deleting #{self.name} use the migration feature to migrate these users to other educational institutions.")
+      return false
+    end
+  end
 
 end

data/features/step_definitions/registration_steps.rb

@@ -10,8 +10,4 @@ Given /^I fill in the core registration fields$/ do
   step %{I fill in "user_password_confirmation" with "password"}
   step %{I fill in "user_profile_attributes_first_name" with "Test"}
   step %{I fill in "user_profile_attributes_last_name" with "Learner"}
-  step %{I select "Ms." from "user_profile_attributes_salutation"}
-  step %{I select "1980" from "user_profile_attributes_birthdate_1i"}
-  step %{I select "January" from "user_profile_attributes_birthdate_2i"}
-  step %{I select "1" from "user_profile_attributes_birthdate_3i"}
 end

data/lib/scidea/schools/version.rb

@@ -1,5 +1,5 @@
 module Scidea
   module Schools
-    VERSION = "1.0.5"
+    VERSION = "1.0.6"
   end
 end

data/spec/controllers/admin/schools_controller_spec.rb

@@ -0,0 +1,30 @@
+require 'spec_helper'
+
+describe Admin::SchoolsController do
+  let(:admin) { Factory.create(:user_user_admin) }
+  let(:school) { Factory.create :school }
+  
+  describe "DELETE :destroy" do
+    context "school has a user" do
+      login_scitent_admin
+
+      before do
+        Factory :profile, :school => school
+      end
+
+      it "does not delete the school when it is tied to a profile" do
+        delete :destroy, :id => school.id
+        assigns(:school).should_not be_destroyed
+      end
+    end
+    
+    context "school has no user" do
+      login_scitent_admin
+
+      it "does delete the school when it is not tied to a profile" do
+        delete :destroy, :id => school.id
+        assigns(:school).should be_destroyed
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scidea-schools
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 1.0.6
   prerelease: 
 platform: ruby
 authors:
@@ -99,6 +99,7 @@ files:
 - qunit/tests/backbone_apps/school_selector.js
 - qunit/test_runner.html.erb
 - qunit/html_fixtures/backbone_apps/_school_selector.html.erb
+- spec/controllers/admin/schools_controller_spec.rb
 - spec/controllers/schools_controller_spec.rb
 - spec/routing/admin/admin_schools_routing_spec.rb
 - spec/routing/schools_routing_spec.rb