schwab_rb 1.0.4 → 1.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 80e57e5f4da3062980fd00cfbce3661185d36a6ccd34a87d51c3d6cd8c3400f8
-  data.tar.gz: 1f2ec23196743009009fda3942719b680e474a25dbf54cb5d412f25203140abf
+  metadata.gz: 931dc11bd7c59a66e180069c36ab7f6dd44cc068db8aa3c5b58ece0aaf830a6e
+  data.tar.gz: e9abc3aa0cce142ffe3ac9af5cca9ee9fa1e5d1fac7209e9f39c929c1f6f8f1c
 SHA512:
-  metadata.gz: cd23d7763c0ee77ec39a45bb653d4c65f4a19ae1962b12c9c3c51cd1b7035114158fb77f36e090a3909d2d08dd88f32b6626d92fa5f038b3a563ff369dbfce49
-  data.tar.gz: 17bab9ddddca12ed8e69b580936c4f166088cd8e919d530ad690375d0bf674fc4eab539cfd5b7c241f56358c2182cca59e9d3f4b4b3e6db15dcfa8efbe67ae52
+  metadata.gz: 53af08e726ae79f7b672df90cab4486b88b1ffaedc19ebc7b666bde8362f4fe49667f78f8ffd390be215b0c975895f21b7b4a7ae34addbb41d94bbe4c3030807
+  data.tar.gz: 1ce70df60193ac32c02b50eb978c96a640ff75bf2715504824341daf4e51ec8a6c2e466a2598509a66195cfbba21a7724bba6f6b6a901946c5b5352df595f934

data/CHANGELOG.md

@@ -1,5 +1,24 @@
 ## [Unreleased]
 
+## [1.0.6] - 2026-11-13
+
+### Changed
+- Stream services now retain one callback; registering another block for the same service replaces the previous callback.
+- `Stream::AsyncClient` supports dynamic `add` and `unsub` operations.
+
+### Fixed
+- Prevent duplicate callback invocation on repeated subscription additions and preserve callbacks when symbols are unsubscribed.
+- Allow callback registration before symbols are supplied without sending an empty subscription.
+
+## [1.0.5] - 2026-10-19
+
+### Added
+- Sanitized stream subscription logging (`SUBS`, `ADD`, `UNSUBS`) at INFO level with service, command, request ID, and keys.
+- Stream subscription acknowledgement response logging at INFO level with service, command, response code, message, and request ID.
+
+### Security
+- Redacted `Authorization` access tokens in WebSocket outbound debug logging.
+
 ## [1.0.4] - 2026-09-21
 
 ### Added

data/README.md

@@ -205,6 +205,12 @@ stream.unsub(:level_one_equities, symbols: ["SPY", "QQQ"])
 stream.stop
 ```
 
+Each service has one callback. Passing a block to `on` or `add` replaces its
+callback; calls without a block preserve it, including after all symbols are
+unsubscribed. You can register a callback with `on` before supplying symbols;
+fields specified there are used when symbols are later added without fields.
+Both `Stream::Client` and `Stream::AsyncClient` support `on`, `add`, and `unsub`.
+
 ## Data Objects
 
 The gem includes structured data objects for better handling of API responses. Most API methods support a `return_data_objects` parameter (defaults to `true`) which returns parsed Ruby objects instead of raw JSON responses:

data/lib/schwab_rb/stream/async_client.rb

@@ -13,6 +13,12 @@ module SchwabRb
         @stream.on(service_symbol, symbols: symbols, fields: fields, &block)
         self
       end
+      alias add on
+
+      def unsub(service_symbol, symbols: nil)
+        @stream.unsub(service_symbol, symbols: symbols)
+        self
+      end
 
       def start
         @stream.start

data/lib/schwab_rb/stream/base.rb

@@ -19,6 +19,7 @@ module SchwabRb
       def initialize(client)
         @client = client
         @handlers = {}
+        @service_fields = {}
         @subscriptions = {}
         @connection = nil
         @message_builder = nil
@@ -34,16 +35,18 @@ module SchwabRb
         service_name = Services.lookup(service_symbol)
         resolved_fields = fields ? Fields.resolve(service_name, fields) : nil
 
-        handler = { symbols: Array(symbols).map(&:to_s), fields: resolved_fields, callback: block }
-        @handlers[service_name] ||= []
-        @handlers[service_name] << handler
+        @handlers[service_name] = block if block
+        @service_fields[service_name] = resolved_fields unless fields.nil?
+        symbol_list = Array(symbols).map(&:to_s)
+        return self if symbol_list.empty?
 
+        subscription = { symbols: symbol_list, fields: resolved_fields || @service_fields[service_name] }
         @subscriptions[service_name] = merge_subscription(
           @subscriptions[service_name],
-          handler
+          subscription
         )
 
-        send_subscription(service_name, handler) if @connected
+        send_subscription(service_name, subscription) if @connected
 
         self
       end
@@ -59,19 +62,12 @@ module SchwabRb
           @subscriptions.delete(service_name) if @subscriptions[service_name][:symbols].empty?
         end
 
-        if @handlers[service_name]
-          @handlers[service_name].each do |h|
-            h[:symbols] -= symbols_to_remove
-          end
-          @handlers[service_name].reject! { |h| h[:symbols].empty? }
-          @handlers.delete(service_name) if @handlers[service_name].empty?
-        end
-
         if @connected
           request = @message_builder.build_request(
             service_name, Commands::UNSUBS,
             keys: symbols_to_remove
           )
+          log_subscription_request(request)
           send_message(@message_builder.wrap_requests(request))
         end
 
@@ -176,6 +172,7 @@ module SchwabRb
             keys: sub[:symbols],
             fields: sub[:fields]
           )
+          log_subscription_request(request)
           send_message(@message_builder.wrap_requests(request))
         end
       end
@@ -186,6 +183,7 @@ module SchwabRb
           keys: handler[:symbols],
           fields: handler[:fields]
         )
+        log_subscription_request(request)
         send_message(@message_builder.wrap_requests(request))
       end
 
@@ -203,20 +201,43 @@ module SchwabRb
         if parsed.key?("data")
           parsed["data"].each do |data_entry|
             service = data_entry["service"]
-            handlers = @handlers[service]
-            next unless handlers
-
-            handlers.each { |h| h[:callback]&.call(data_entry) }
+            @handlers[service]&.call(data_entry)
           end
         end
 
         return unless parsed.key?("response")
 
         parsed["response"].each do |resp|
-          SchwabRb::Logger.logger.debug("Stream response: #{resp}")
+          log_stream_response(resp)
         end
       end
 
+      def log_subscription_request(request)
+        service = request["service"]
+        command = request["command"]
+        request_id = request["requestid"]
+        keys = request.dig("parameters", "keys")
+        SchwabRb::Logger.logger.info(
+          "Stream subscription request: service=#{service} command=#{command} " \
+          "request_id=#{request_id} keys=#{keys}"
+        )
+      end
+
+      def log_stream_response(resp)
+        service = resp["service"]
+        command = resp["command"]
+        request_id = resp["requestid"]
+        content = resp["content"] || {}
+        code = content["code"]
+        msg = content["msg"]
+
+        SchwabRb::Logger.logger.info(
+          "Stream response: service=#{service} command=#{command} " \
+          "code=#{code} msg=#{msg.inspect} request_id=#{request_id}"
+        )
+        SchwabRb::Logger.logger.debug("Raw stream response: #{resp}")
+      end
+
       def handle_disconnect(error)
         @connected = false
         begin
@@ -255,7 +276,10 @@ module SchwabRb
         @write_mutex.synchronize do
           return unless @connection
 
-          SchwabRb::Logger.logger.debug("Stream sending: #{json_string}")
+          if SchwabRb::Logger.logger.debug?
+            sanitized = json_string.gsub(/"Authorization"\s*:\s*"[^"]*"/, '"Authorization":"[REDACTED]"')
+            SchwabRb::Logger.logger.debug("Stream sending: #{sanitized}")
+          end
           @connection.write(json_string)
           @connection.flush
         end

data/lib/schwab_rb/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SchwabRb
-  VERSION = "1.0.4"
+  VERSION = "1.0.6"
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: schwab_rb
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.0.6
 platform: ruby
 authors:
 - Joseph Platta
 bindir: exe
 cert_chain: []
-date: 2026-09-21 00:00:00.000000000 Z
+date: 2026-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: async