schwab_rb 0.2.0 → 0.3.0

data/lib/schwab_rb/data_objects/order.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative 'order_leg'
+require_relative "order_leg"
 
 module SchwabRb
   module DataObjects
@@ -57,7 +57,8 @@ module SchwabRb
         end
       end
 
-      def initialize(activity_type:, activity_id:, execution_type:, quantity:, order_remaining_quantity:, execution_legs:)
+      def initialize(activity_type:, activity_id:, execution_type:, quantity:, order_remaining_quantity:,
+                     execution_legs:)
         @activity_type = activity_type
         @activity_id = activity_id
         @execution_type = execution_type
@@ -147,20 +148,20 @@ module SchwabRb
 
       def strategy
         if %w[VERTICAL CUSTOM].include?(complex_order_strategy_type) && order_leg_collection.all?(&:call?)
-          'CALL_SPREAD'
+          "CALL_SPREAD"
         elsif %w[VERTICAL CUSTOM].include?(complex_order_strategy_type) && order_leg_collection.all?(&:put?)
-          'PUT_SPREAD'
+          "PUT_SPREAD"
         else
           order_strategy_type
         end
       end
 
       def close?
-        order_leg_collection.all? { |leg| leg.position_effect == 'CLOSING' }
+        order_leg_collection.all? { |leg| leg.position_effect == "CLOSING" }
       end
 
       def open?
-        order_leg_collection.all? { |leg| leg.position_effect == 'OPENING' }
+        order_leg_collection.all? { |leg| leg.position_effect == "OPENING" }
       end
 
       def to_h

data/lib/schwab_rb/data_objects/order_leg.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative 'instrument'
+require_relative "instrument"
 
 module SchwabRb
   module DataObjects
@@ -30,19 +30,19 @@ module SchwabRb
       end
 
       def call?
-        put_call == 'CALL'
+        put_call == "CALL"
       end
 
       def close?
-        position_effect == 'CLOSING'
+        position_effect == "CLOSING"
       end
 
       def open?
-        position_effect == 'OPENING'
+        position_effect == "OPENING"
       end
 
       def put?
-        put_call == 'PUT'
+        put_call == "PUT"
       end
 
       def put_call

data/lib/schwab_rb/data_objects/order_preview.rb

@@ -1,11 +1,12 @@
 # frozen_string_literal: true
 
-require_relative 'order_leg'
+require_relative "order_leg"
 
 module SchwabRb
   module DataObjects
     class OrderPreview
-      attr_reader :order_id, :order_value, :order_strategy, :order_balance, :order_validation_result, :projected_commission
+      attr_reader :order_id, :order_value, :order_strategy, :order_balance, :order_validation_result,
+                  :projected_commission
 
       class << self
         def build(data)
@@ -35,7 +36,7 @@ module SchwabRb
       end
 
       def accepted?
-        status == 'ACCEPTED'
+        status == "ACCEPTED"
       end
 
       def commission
@@ -167,32 +168,30 @@ module SchwabRb
         end
 
         def commission_total
-          calculate_total_from_legs(@commission_data, 'COMMISSION')
+          calculate_total_from_legs(@commission_data, "COMMISSION")
         end
 
         def commission
-          @direct_commission || sprintf("%.2f", commission_total)
+          @direct_commission || format("%.2f", commission_total)
         end
 
         def fee_total
-          calculate_total_from_legs(@fee_data, ['OPT_REG_FEE', 'INDEX_OPTION_FEE'])
+          calculate_total_from_legs(@fee_data, %w[OPT_REG_FEE INDEX_OPTION_FEE])
         end
 
         def fee
-          @direct_fee || sprintf("%.2f", fee_total)
+          @direct_fee || format("%.2f", fee_total)
         end
 
         def true_commission
           if @direct_true_commission
             @direct_true_commission
-          else
+          elsif @true_commission_data.any?
             # For nested structure, calculate from true commission legs
-            if @true_commission_data.any?
-              true_commission_total = calculate_total_from_legs(@true_commission_data, 'COMMISSION')
-              sprintf("%.2f", true_commission_total * 2)
+            true_commission_total = calculate_total_from_legs(@true_commission_data, "COMMISSION")
+            format("%.2f", true_commission_total * 2)
             else
-              sprintf("%.2f", commission_total * 2)
-            end
+              format("%.2f", commission_total * 2)
           end
         end
 
@@ -223,9 +222,7 @@ module SchwabRb
           legs.each do |leg|
             values = leg[:commissionValues] || leg[:feeValues] || []
             values.each do |value_item|
-              if types.include?(value_item[:type])
-                total += (value_item[:value] || 0.0)
-              end
+              total += value_item[:value] || 0.0 if types.include?(value_item[:type])
             end
           end
 

data/lib/schwab_rb/data_objects/position.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative 'instrument'
+require_relative "instrument"
 
 module SchwabRb
   module DataObjects
@@ -73,11 +73,11 @@ module SchwabRb
 
       def long_short
         if long?
-          'LONG'
+          "LONG"
         elsif short?
-          'SHORT'
+          "SHORT"
         else
-          'NONE'
+          "NONE"
         end
       end
 

data/lib/schwab_rb/data_objects/price_history.rb

@@ -12,16 +12,16 @@ module SchwabRb
       end
 
       def initialize(data)
-        @symbol = data['symbol']
-        @empty = data['empty']
-        @candles = data['candles']&.map { |candle_data| Candle.new(candle_data) } || []
+        @symbol = data["symbol"]
+        @empty = data["empty"]
+        @candles = data["candles"]&.map { |candle_data| Candle.new(candle_data) } || []
       end
 
       def to_h
         {
-          'symbol' => @symbol,
-          'empty' => @empty,
-          'candles' => @candles.map(&:to_h)
+          "symbol" => @symbol,
+          "empty" => @empty,
+          "candles" => @candles.map(&:to_h)
         }
       end
 
@@ -46,7 +46,7 @@ module SchwabRb
       def candles_for_date_range(start_date, end_date)
         start_timestamp = start_date.to_time.to_i * 1000
         end_timestamp = end_date.to_time.to_i * 1000
-        
+
         @candles.select do |candle|
           candle.datetime >= start_timestamp && candle.datetime <= end_timestamp
         end
@@ -54,32 +54,38 @@ module SchwabRb
 
       def highest_price
         return nil if @candles.empty?
+
         @candles.map(&:high).max
       end
 
       def lowest_price
         return nil if @candles.empty?
+
         @candles.map(&:low).min
       end
 
       def highest_volume
         return nil if @candles.empty?
+
         @candles.map(&:volume).max
       end
 
       def total_volume
         return 0 if @candles.empty?
+
         @candles.map(&:volume).sum
       end
 
       def average_price
         return nil if @candles.empty?
+
         total_price = @candles.map(&:close).sum
         total_price / @candles.length.to_f
       end
 
       def price_range
         return nil if @candles.empty?
+
         {
           high: highest_price,
           low: lowest_price,
@@ -89,6 +95,7 @@ module SchwabRb
 
       def each(&block)
         return enum_for(:each) unless block_given?
+
         @candles.each(&block)
       end
 
@@ -98,22 +105,22 @@ module SchwabRb
         attr_reader :open, :high, :low, :close, :volume, :datetime
 
         def initialize(data)
-          @open = data['open']
-          @high = data['high']
-          @low = data['low']
-          @close = data['close']
-          @volume = data['volume']
-          @datetime = data['datetime']
+          @open = data["open"]
+          @high = data["high"]
+          @low = data["low"]
+          @close = data["close"]
+          @volume = data["volume"]
+          @datetime = data["datetime"]
         end
 
         def to_h
           {
-            'open' => @open,
-            'high' => @high,
-            'low' => @low,
-            'close' => @close,
-            'volume' => @volume,
-            'datetime' => @datetime
+            "open" => @open,
+            "high" => @high,
+            "low" => @low,
+            "close" => @close,
+            "volume" => @volume,
+            "datetime" => @datetime
           }
         end
 
@@ -131,6 +138,7 @@ module SchwabRb
 
         def price_change_percent
           return 0 if @open == 0
+
           ((price_change / @open) * 100).round(4)
         end
 

data/lib/schwab_rb/data_objects/quote.rb

@@ -10,11 +10,11 @@ module SchwabRb
         data[:symbol] ||= symbol
 
         case data[:assetMainType]
-        when 'OPTION'
+        when "OPTION"
           OptionQuote.new(data)
-        when 'INDEX'
+        when "INDEX"
           IndexQuote.new(data)
-        when 'EQUITY'
+        when "EQUITY"
           EquityQuote.new(data)
         else
           raise "Unknown assetMainType: #{data[:assetMainType]}"
@@ -89,11 +89,11 @@ module SchwabRb
 
       def zone
         if quote_delta.abs > 0.3
-          'DANGER'
+          "DANGER"
         elsif quote_delta.abs > 0.15
-          'AT_RISK'
+          "AT_RISK"
         else
-          'SAFE'
+          "SAFE"
         end
       end
     end

data/lib/schwab_rb/data_objects/transaction.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative 'instrument'
+require_relative "instrument"
 
 module SchwabRb
   module DataObjects
@@ -28,15 +28,15 @@ module SchwabRb
       end
 
       def symbol
-        option? ? instrument.symbol : ''
+        option? ? instrument.symbol : ""
       end
 
       def underlying_symbol
-        option? ? instrument.underlying_symbol : ''
+        option? ? instrument.underlying_symbol : ""
       end
 
       def description
-        option? ? instrument.description : ''
+        option? ? instrument.description : ""
       end
 
       def option?
@@ -52,7 +52,7 @@ module SchwabRb
       end
 
       def commission?
-        fee_type == 'COMMISSION'
+        fee_type == "COMMISSION"
       end
 
       def to_h
@@ -102,7 +102,7 @@ module SchwabRb
                   :transfer_items
 
       def trade?
-        type == 'TRADE'
+        type == "TRADE"
       end
 
       def symbols

data/lib/schwab_rb/data_objects/user_preferences.rb

@@ -38,7 +38,7 @@ module SchwabRb
       end
 
       def brokerage_accounts
-        @accounts.select { |account| account.type == 'BROKERAGE' }
+        @accounts.select { |account| account.type == "BROKERAGE" }
       end
 
       def has_level2_permissions?
@@ -46,7 +46,7 @@ module SchwabRb
       end
 
       class UserAccount
-        attr_reader :account_number, :primary_account, :type, :nick_name, :display_acct_id, 
+        attr_reader :account_number, :primary_account, :type, :nick_name, :display_acct_id,
                     :auto_position_effect, :account_color, :lot_selection_method
 
         def initialize(data)
@@ -83,7 +83,7 @@ module SchwabRb
       end
 
       class StreamerInfo
-        attr_reader :streamer_socket_url, :schwab_client_customer_id, :schwab_client_correl_id, 
+        attr_reader :streamer_socket_url, :schwab_client_customer_id, :schwab_client_correl_id,
                     :schwab_client_channel, :schwab_client_function_id
 
         def initialize(data)

data/lib/schwab_rb/market_hours.rb

@@ -3,11 +3,11 @@
 module SchwabRb
   class MarketHours
     module Markets
-      EQUITY = 'equity'
-      OPTION = 'option'
-      BOND = 'bond'
-      FUTURE = 'future'
-      FOREX = 'forex'
+      EQUITY = "equity"
+      OPTION = "option"
+      BOND = "bond"
+      FUTURE = "future"
+      FOREX = "forex"
     end
   end
 end

data/lib/schwab_rb/movers.rb

@@ -3,24 +3,24 @@
 module SchwabRb
   class Movers
     module Indexes
-      DJI = '$DJI'
-      COMPX = '$COMPX'
-      SPX = '$SPX'
-      NYSE = 'NYSE'
-      NASDAQ = 'NASDAQ'
-      OTCBB = 'OTCBB'
-      INDEX_ALL = 'INDEX_ALL'
-      EQUITY_ALL = 'EQUITY_ALL'
-      OPTION_ALL = 'OPTION_ALL'
-      OPTION_PUT = 'OPTION_PUT'
-      OPTION_CALL = 'OPTION_CALL'
+      DJI = "$DJI"
+      COMPX = "$COMPX"
+      SPX = "$SPX"
+      NYSE = "NYSE"
+      NASDAQ = "NASDAQ"
+      OTCBB = "OTCBB"
+      INDEX_ALL = "INDEX_ALL"
+      EQUITY_ALL = "EQUITY_ALL"
+      OPTION_ALL = "OPTION_ALL"
+      OPTION_PUT = "OPTION_PUT"
+      OPTION_CALL = "OPTION_CALL"
     end
 
     module SortOrders
-      VOLUME = 'VOLUME'
-      TRADES = 'TRADES'
-      PERCENT_CHANGE_UP = 'PERCENT_CHANGE_UP'
-      PERCENT_CHANGE_DOWN = 'PERCENT_CHANGE_DOWN'
+      VOLUME = "VOLUME"
+      TRADES = "TRADES"
+      PERCENT_CHANGE_UP = "PERCENT_CHANGE_UP"
+      PERCENT_CHANGE_DOWN = "PERCENT_CHANGE_DOWN"
     end
 
     module Frequencies
@@ -32,4 +32,4 @@ module SchwabRb
       SIXTY = 60
     end
   end
-end
+end

data/lib/schwab_rb/orders/builder.rb

@@ -1,4 +1,4 @@
-require_relative '../utils/enum_enforcer'
+require_relative "../utils/enum_enforcer"
 
 module SchwabRb::Orders
   class Builder
@@ -36,7 +36,7 @@ module SchwabRb::Orders
       end
 
       def camel_case(snake_str)
-        camel_case_str = snake_str.split('_').map(&:capitalize).join
+        camel_case_str = snake_str.split("_").map(&:capitalize).join
         camel_case_str[0].downcase + camel_case_str[1..]
       end
     end
@@ -165,7 +165,7 @@ module SchwabRb::Orders
       @order_leg_collection << {
         "instruction" => convert_enum(instruction, SchwabRb::Orders::OptionInstructions),
         "instrument" => SchwabRb::Orders::OptionInstrument.new(symbol),
-        "quantity" => quantity,
+        "quantity" => quantity
       }
     end
 
@@ -193,9 +193,9 @@ module SchwabRb::Orders
 
     def truncate_float(flt)
       if flt.abs < 1 && flt != 0.0
-        format('%.4f', (flt * 10000).to_i / 10000.0)
+        format("%.4f", (flt * 10_000).to_i / 10_000.0)
       else
-        format('%.2f', (flt * 100).to_i / 100.0)
+        format("%.2f", (flt * 100).to_i / 100.0)
       end
     end
   end

data/lib/schwab_rb/orders/destination.rb

@@ -2,18 +2,18 @@ module SchwabRb
   module Orders
     module Destination
       # Destinations for when you want to request a specific destination for your order.
-      INET = 'INET'
-      ECN_ARCA = 'ECN_ARCA'
-      CBOE = 'CBOE'
-      AMEX = 'AMEX'
-      PHLX = 'PHLX'
-      ISE = 'ISE'
-      BOX = 'BOX'
-      NYSE = 'NYSE'
-      NASDAQ = 'NASDAQ'
-      BATS = 'BATS'
-      C2 = 'C2'
-      AUTO = 'AUTO'
+      INET = "INET"
+      ECN_ARCA = "ECN_ARCA"
+      CBOE = "CBOE"
+      AMEX = "AMEX"
+      PHLX = "PHLX"
+      ISE = "ISE"
+      BOX = "BOX"
+      NYSE = "NYSE"
+      NASDAQ = "NASDAQ"
+      BATS = "BATS"
+      C2 = "C2"
+      AUTO = "AUTO"
     end
   end
 end

data/lib/schwab_rb/orders/duration.rb

@@ -1,9 +1,9 @@
 module SchwabRb::Orders::Duration
-  DAY = 'DAY'
-  GOOD_TILL_CANCEL = 'GOOD_TILL_CANCEL'
-  FILL_OR_KILL = 'FILL_OR_KILL'
-  IMMEDIATE_OR_CANCEL = 'IMMEDIATE_OR_CANCEL'
-  END_OF_WEEK = 'END_OF_WEEK'
-  END_OF_MONTH = 'END_OF_MONTH'
-  NEXT_END_OF_MONTH = 'NEXT_END_OF_MONTH'
+  DAY = "DAY"
+  GOOD_TILL_CANCEL = "GOOD_TILL_CANCEL"
+  FILL_OR_KILL = "FILL_OR_KILL"
+  IMMEDIATE_OR_CANCEL = "IMMEDIATE_OR_CANCEL"
+  END_OF_WEEK = "END_OF_WEEK"
+  END_OF_MONTH = "END_OF_MONTH"
+  NEXT_END_OF_MONTH = "NEXT_END_OF_MONTH"
 end

data/lib/schwab_rb/orders/equity_instructions.rb

@@ -1,10 +1,10 @@
 module SchwabRb
   module Orders
     module EquityInstructions
-      BUY = 'BUY'
-      SELL = 'SELL'
-      SELL_SHORT = 'SELL_SHORT'
-      BUY_TO_COVER = 'BUY_TO_COVER'
+      BUY = "BUY"
+      SELL = "SELL"
+      SELL_SHORT = "SELL_SHORT"
+      BUY_TO_COVER = "BUY_TO_COVER"
     end
   end
 end

data/lib/schwab_rb/orders/instruments.rb

@@ -2,12 +2,12 @@ module SchwabRb
   module Orders
     class Instrument
       module Projections
-        SYMBOL_SEARCH = 'symbol-search'
-        SYMBOL_REGEX = 'symbol-regex'
-        DESCRIPTION_SEARCH = 'desc-search'
-        DESCRIPTION_REGEX = 'desc-regex'
-        SEARCH = 'search'
-        FUNDAMENTAL = 'fundamental'
+        SYMBOL_SEARCH = "symbol-search"
+        SYMBOL_REGEX = "symbol-regex"
+        DESCRIPTION_SEARCH = "desc-search"
+        DESCRIPTION_REGEX = "desc-regex"
+        SEARCH = "search"
+        FUNDAMENTAL = "fundamental"
       end
     end
 
@@ -22,13 +22,13 @@ module SchwabRb
 
     class EquityInstrument < BaseInstrument
       def initialize(symbol)
-        super('EQUITY', symbol)
+        super("EQUITY", symbol)
       end
     end
 
     class OptionInstrument < BaseInstrument
       def initialize(symbol)
-        super('OPTION', symbol)
+        super("OPTION", symbol)
       end
     end
   end

data/lib/schwab_rb/orders/price_link_basis.rb

@@ -1,15 +1,15 @@
 module SchwabRb
   module Orders
     module PriceLinkBasis
-      MANUAL = 'MANUAL'
-      BASE = 'BASE'
-      TRIGGER = 'TRIGGER'
-      LAST = 'LAST'
-      BID = 'BID'
-      ASK = 'ASK'
-      ASK_BID = 'ASK_BID'
-      MARK = 'MARK'
-      AVERAGE = 'AVERAGE'
+      MANUAL = "MANUAL"
+      BASE = "BASE"
+      TRIGGER = "TRIGGER"
+      LAST = "LAST"
+      BID = "BID"
+      ASK = "ASK"
+      ASK_BID = "ASK_BID"
+      MARK = "MARK"
+      AVERAGE = "AVERAGE"
     end
   end
 end

data/lib/schwab_rb/orders/price_link_type.rb

@@ -1,9 +1,9 @@
 module SchwabRb
   module Orders
     module PriceLinkType
-      VALUE = 'VALUE'
-      PERCENT = 'PERCENT'
-      TICK = 'TICK'
+      VALUE = "VALUE"
+      PERCENT = "PERCENT"
+      TICK = "TICK"
     end
   end
 end

data/lib/schwab_rb/orders/session.rb

@@ -1,14 +1,14 @@
 module SchwabRb::Orders::Session
   # Normal market hours, from 9:30am to 4:00pm Eastern.
-  NORMAL = 'NORMAL'
+  NORMAL = "NORMAL"
 
   # Premarket session, from 8:00am to 9:30am Eastern.
-  AM = 'AM'
+  AM = "AM"
 
   # After-market session, from 4:00pm to 8:00pm Eastern.
-  PM = 'PM'
+  PM = "PM"
 
   # Orders are active during all trading sessions except the overnight
   # session. This is the union of ``NORMAL``, ``AM``, and ``PM``.
-  SEAMLESS = 'SEAMLESS'
+  SEAMLESS = "SEAMLESS"
 end