schemad 1.2.1 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 23e65c36347ae253cb19476c6e1e71d8780b7892
-  data.tar.gz: f82fe69db0ce5d3dac0ce47f3fb6a00c608af520
+  metadata.gz: 591b51216e927a53f322119b2c11659e905d14fd
+  data.tar.gz: 8c3d791c8bb7ee3c74c2726a8cfb99c363850b86
 SHA512:
-  metadata.gz: e6a0355d4d8c535bb22e84ba47d35103b547a5b2e29d14919c29d4a4db394ba9cd6f8a8aed5be844bf2ada7f0a84e7e5f7d4b5c5e89eb907fe1f1db760d78de9
-  data.tar.gz: ecaa21a31b82dc5a063b621ae4aa4588e2753906f14ebfa75e928690bd55722ec40e2ca6601231148c0011172ef42cfa5a670d74e476fa8c2299c927fdff6ee2
+  metadata.gz: f425f6ab0594c9a3a9152f47ab05974c0648d3e6185795423d38fe6737d93b12350364d6af9dd9605d86e52d7991d157a445b876c9fadf76a3a621d53a4e740c
+  data.tar.gz: b59de05f895f35cae43e727240ab9fe069035258715efea8501eabf1bc9a97edc5bf48f30f4020993b2603cc8963f388c7f333affef38e7eed2124a0ab3b3bc6

data/Gemfile

@@ -4,9 +4,11 @@ source 'https://rubygems.org'
 gemspec
 
 group :test do
+  gem "codeclimate-test-reporter", require: nil
   gem 'rspec-given'
   gem 'flexmock'
   gem 'timecop'
 
+
   gem 'pry'
-end
+end

data/README.md

@@ -311,9 +311,9 @@ commit.comment        # "Your Mom"
 
 ## Notes
 
-[Hashie](https://github.com/intridea/hashie) is probably a better idea than this gem. But I couldn't find a decent way to combine the [DeepFetch](https://github.com/intridea/hashie#deepfetch) functionality with the [Dash](https://github.com/intridea/hashie#dash)/[Trash](https://github.com/intridea/hashie#trash) functionality. This is also likely much ligher weight and therefore about half as meta.
+[Hashie](https://github.com/intridea/hashie) is probably a better fit for most people, but I couldn't find a decent way to combine the [DeepFetch](https://github.com/intridea/hashie#deepfetch) functionality with the [Dash](https://github.com/intridea/hashie#dash)/[Trash](https://github.com/intridea/hashie#trash) functionality. However, this gem is also likely much ligher weight and therefore about half as meta.
 
-Be warned, this is a lot of crazy metacode and it's _mostly_ recommended you don't use this for real. Mostly. But it is awesome.
+Be warned, this is a lot of crazy metacode, but it does work well for most of my use-cases (as seen in the examples above).
 
 ## Installation
 

data/lib/schemad/entity.rb

@@ -6,7 +6,7 @@ module Schemad
     extend Schemad::Extensions
 
     def self.inherited(subclass)
-      subclass.instance_variable_set(:@attributes, [])
+      subclass.instance_variable_set(:@attributes, inherited_attrs)
     end
 
     def self.attribute(name, args={}, &block)
@@ -45,6 +45,10 @@ module Schemad
     alias_method :attributes, :to_hash
 
     private
+    def self.inherited_attrs
+      parent_attrs = self.instance_variable_get(:@attributes)
+      default_attrs = (parent_attrs ? parent_attrs.dup : [])
+    end
 
     def self.define_parser_for(name, args, &block)
       define_method "parse_#{name}" do |data|

data/lib/schemad/version.rb

@@ -1,3 +1,3 @@
 module Schemad
-  VERSION = "1.2.1"
+  VERSION = "1.2.2"
 end

data/spec/entity_spec.rb

@@ -1,5 +1,6 @@
 require 'spec_helper'
 require 'timecop'
+require 'schemad/default_types'
 require 'schemad/entity'
 
 require_relative 'fixtures/demo_class'
@@ -53,4 +54,57 @@ describe Schemad::Entity do
       }}
     end
   end
+
+  context "inherited entities" do
+    class Base < Schemad::Entity
+      attribute :name
+    end
+
+    class Sub < Base
+      attribute :place
+    end
+
+    context "via setters" do
+      Given(:parent) { Base.new }
+      Given(:child) { Sub.new }
+
+      context "parent has top-level attributes" do
+        When { parent.name = "Whil Wheaton" }
+        Then { parent.name.should == "Whil Wheaton" }
+      end
+
+      context "parent does not get child attributes" do
+        When(:result) { parent.place }
+        Then { expect(result).to have_failed(NoMethodError) }
+      end
+
+      context "child has all attributes" do
+        Given do
+          child.name = "Bill Cosby"
+          child.place = "NY, NY"
+        end
+        Then { child.name.should == "Bill Cosby" }
+        And { child.place.should == "NY, NY" }
+      end
+    end
+
+    context 'via #from_data' do
+      Given(:parent) { Base.from_data({ name: "Whil Wheaton", place: "Burt's Bees" }) }
+
+      context "parent has top-level attributes" do
+        Then { parent.name.should == "Whil Wheaton" }
+      end
+
+      context "parent does not get child attributes" do
+        When(:result) { parent.place }
+        Then { expect(result).to have_failed(NoMethodError) }
+      end
+
+      context "child has all attributes" do
+        Given(:child) { Sub.from_data({ name: "Jim Beam", place: "Black, Not" }) }
+        Then { child.name.should == "Jim Beam" }
+        And { child.place.should == "Black, Not" }
+      end
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -1,4 +1,5 @@
-# $LOAD_PATH.unshift "../lib"
+require "codeclimate-test-reporter"
+CodeClimate::TestReporter.start
 
 require 'rspec/given'
-require 'pry'
+require 'pry'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: schemad
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.2.2
 platform: ruby
 authors:
 - Luke van der Hoeven
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-22 00:00:00.000000000 Z
+date: 2015-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport