schema_validations 2.1.0 → 2.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b3cbc2903e74311d8f505bf1886d34893d917560
-  data.tar.gz: 2343ae4917d6c5ab9e5c2ac40d36accdb6d1bf82
+  metadata.gz: a5d849122ca6f0e6f08d91e2cb391407fc7fc227
+  data.tar.gz: f8645f3bc0d1fcb7da740dc1e2f28e86570f0b01
 SHA512:
-  metadata.gz: 874b8960af4dcfdca8aba841ac4e127911602b507a4ccd627ab3f3f68a79a54f2204d08e5273c3de5e278b8a36e7758e0c8578c94cb2d67f5c91798967cbfc29
-  data.tar.gz: 4831460cb621f41c72df57fb422954d6a9a2b95e6e3473625296a7353117ab3adacc560423a2da73ae19a0c1686c38a6d85ac2a792410a9ed1f51cd9818fe86d
+  metadata.gz: 09ac9381a024e6a9f82ffe2e619217d5eb0c13dce2c83cedb5feb001faccf6ad65c7cd2d51a5291d20e969aad15adcadb4e880ebb6e55054291748b7cb30bdc1
+  data.tar.gz: d6359451dc9673a2cff5fdd768a0c5e42fe6df3acecf20412c769070f052d70da2f748b583363f1c7a0c5cb656b5884cf1848ab75ed41bf0efd19e025cf98084

data/README.md

@@ -71,7 +71,7 @@ Data types:
 | `:boolean`         | `:validates ... inclusion: { in: [true, false] }`                                                    |
 | `:float`           | `:validates ... numericality: true`                                                                  |
 | `:integer`         | `:validates ... numericality: { only_integer: true, greater_than_or_equal_to: ..., less_than: ... }` |
-| `:decimal`         | `:validates ... numericality: { greater_than: ..., less_than: ... }`                                 |
+| `:decimal, precision: ...`         | `:validates ... numericality: { greater_than: ..., less_than: ... }`                                |
 
 
 ## What if I want something special?
@@ -186,9 +186,13 @@ Earlier versions of SchemaValidations supported:
 
 ## Release Notes
 
+### 2.1.1
+
+* Bug fix for `:decimal` when `precision` is nil (#37)
+
 ### 2.1.0
 
-* Added :decimal range validation.  Thanks to [@felixbuenemann](https://github.com/felixbuenemann)
+* Added `:decimal` range validation.  Thanks to [@felixbuenemann](https://github.com/felixbuenemann)
 
 ### 2.0.2
 

data/lib/schema_validations/active_record/validations.rb

@@ -108,8 +108,10 @@ module SchemaValidations
             when :integer
               load_integer_column_validations(name, column)
             when :decimal
-              limit = 10 ** (column.precision - column.scale)
-              validate_logged :validates_numericality_of, name, :allow_nil => true, :greater_than => -limit, :less_than => limit
+              if column.precision
+                limit = 10 ** (column.precision - (column.scale || 0))
+                validate_logged :validates_numericality_of, name, :allow_nil => true, :greater_than => -limit, :less_than => limit
+              end
             when :numeric
               validate_logged :validates_numericality_of, name, :allow_nil => true
             when :text

data/lib/schema_validations/version.rb

@@ -1,3 +1,3 @@
 module SchemaValidations
-  VERSION = "2.1.0"
+  VERSION = "2.1.1"
 end

data/spec/validations_spec.rb

@@ -12,7 +12,9 @@ describe "Validations" do
         t.integer :votes
         t.float   :average_mark, :null => false
         t.boolean :active, :null => false
-        t.decimal :rating, :precision => 2, :scale => 1
+        t.decimal :max10, :precision => 2, :scale => 1
+        t.decimal :arbitrary, :precision => nil, :scale => nil
+        t.decimal :max100, :precision => 2, :scale => nil
       end
       add_index :articles, :title, :unique => true
       add_index :articles, [:state, :active], :unique => true
@@ -95,9 +97,20 @@ describe "Validations" do
       expect(Article.new(votes: -2147483649).error_on(:votes).size).to eq(1)
     end
 
-    it "should validate the range of rating" do
-      expect(Article.new(rating: 10).error_on(:rating).size).to eq(1)
-      expect(Article.new(rating: -10).error_on(:rating).size).to eq(1)
+    it "should validate the range of decimal precision with scale" do
+      expect(Article.new(max10: 10).error_on(:max10).size).to eq(1)
+      expect(Article.new(max10: 5).error_on(:max10).size).to eq(0)
+      expect(Article.new(max10: -10).error_on(:max10).size).to eq(1)
+    end
+    
+    it "should validate the range of decimal precision without scale" do
+      expect(Article.new(max100: 100).error_on(:max100).size).to eq(1)
+      expect(Article.new(max100: 50).error_on(:max100).size).to eq(0)
+      expect(Article.new(max100: -100).error_on(:max100).size).to eq(1)
+    end
+
+    it "should not validate the range of arbitrary decimal" do
+      expect(Article.new(arbitrary: Float::MAX).error_on(:arbitrary).size).to eq(0)
     end
 
     it "should validate average_mark numericality" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: schema_validations
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
 platform: ruby
 authors:
 - Ronen Barzel
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-23 00:00:00.000000000 Z
+date: 2016-04-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: schema_plus_columns