schema_reaper 1.0.4 → 1.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ac78c6af3c6c9b2551d136e276c4f258e312e6fef60945ee1507b916a11349f4
-  data.tar.gz: 63e813aba8d386a01a39c72aa46c6464c4b5af37268718ca14ed0da0ae6fbd30
+  metadata.gz: 1c56279086faa2b6772a769f586f78a0f3e332973b25ad2f347c7e2533740358
+  data.tar.gz: 95e06e2cbb13f0887ff773e1c0fcde931e9f97bc3c3de6a4739eecf7ff7d8990
 SHA512:
-  metadata.gz: c72f7ba4b88d4848cc993745ee7e7abec08a5333ff1a3c58504789e981821c48143d905235addc74655d7e57278e2d412b17914a6e19c626770edf2e7250a26a
-  data.tar.gz: 1e519017f31e2bdf150beb98889b980fe6d7d3de3e43a06800635955a8d2adfb1c469928eb1d9186aa720e3c8cfda12543487b93da5c772bd1370751d6ee4842
+  metadata.gz: c235d143cc6d32736a64f9e425c8fe1ffc3f0585f55716c1284bbb6896fbcf54fbc30361fbee92c3f8e280aca9a909b6c020d3d563c0df9b8ab67653e77d5dde
+  data.tar.gz: de7f08b01afeebd5c0638ccc15f2be1a077e151b9cd69525788da091af411087716a20c8fe36dde49bfb5432bb77b5cf7b5c90827fe38ababc6e882563d91675

data/CHANGELOG.md

@@ -1,5 +1,33 @@
 # Changelog
 
+## [1.0.6] - 2026-09-04
+
+### Changed
+- Added `mitkush` (mitanshukushwah@gmail.com) as a gemspec author.
+
+## [1.0.5] - 2026-09-04
+
+Fixes found by running the gem against a live PostgreSQL database.
+
+### Fixed
+- **Duplicate findings for one object.** When several analyzers flagged the
+  same physical column (e.g. `dead_column` + `always_null_column`) or index
+  (`unused_index` + `duplicate_index`), each was reported separately *and* its
+  reclaimable bytes were counted more than once, inflating the run total.
+  Findings are now collapsed to the highest-confidence one per target; the
+  others are noted as `also flagged by: ...` in its evidence.
+- **`generate-migration` output.** The generated STEP 1 migration contained a
+  fragile multi-line string (heredoc line-continuation) that rendered with a
+  stray gap. It is now a single clean string. Both files are verified valid
+  Ruby.
+- **Migration schema version.** Generated migrations now inherit the host
+  app's Rails minor version (`ActiveRecord::Migration[X.Y]`) when ActiveRecord
+  is loaded, instead of a hard-coded `7.1`.
+
+### Added
+- Specs covering target collapsing and migration generation, exercised end to
+  end through `Runner` with an injected schema.
+
 ## [1.0.4] - 2026-09-04
 
 ### Changed

data/lib/schema_reaper/finding.rb

@@ -19,6 +19,19 @@ module SchemaReaper
       [type, table, column, index].compact.join("/")
     end
 
+    # The physical object this finding is about, ignoring which analyzer raised
+    # it. Two findings with the same target_key are the same underlying problem
+    # (e.g. dead_column + always_null_column on one column) -- keep the strongest.
+    def target_key
+      if index
+        ["index", table, index]
+      elsif column
+        ["column", table, column]
+      else
+        ["table", table]
+      end
+    end
+
     def reclaimable_bytes
       self[:reclaimable_bytes] || 0
     end

data/lib/schema_reaper/migration_generator.rb

@@ -19,35 +19,38 @@ module SchemaReaper
     private
 
     def stage_one
+      note = "Add `self.ignored_columns += %w[#{@column}]` to the #{model} model, " \
+             "then deploy STEP 2 after a soak period."
       write "ignore_#{@table}_#{@column}", <<~RUBY
         # frozen_string_literal: true
 
         # STEP 1 of 2. Deploy this alone and let it soak. It only tells
         # ActiveRecord to stop selecting the column; nothing is dropped.
-        class Ignore#{camel}Column < ActiveRecord::Migration[7.1]
+        class Ignore#{camel}Column < ActiveRecord::Migration[#{migration_version}]
           def up
-            say "Add `self.ignored_columns += %w[#{@column}]` to the #{model} model, " \
-                "then deploy STEP 2 after a soak period."
+            say #{note.inspect}
           end
 
-          def down; end
+          def down
+          end
         end
       RUBY
     end
 
     def stage_two
+      down_msg = "recreate :#{@column} on :#{@table} manually if you need it back"
       write "drop_#{@table}_#{@column}", <<~RUBY
         # frozen_string_literal: true
 
-        # STEP 2 of 2. Run only after STEP 1 has been deployed and verified.
-        class Drop#{camel}Column < ActiveRecord::Migration[7.1]
+        # STEP 2 of 2. Run only after STEP 1 has been deployed and verified in
+        # production (nothing reads the column, no errors).
+        class Drop#{camel}Column < ActiveRecord::Migration[#{migration_version}]
           def up
             remove_column :#{@table}, :#{@column}
           end
 
           def down
-            raise ActiveRecord::IrreversibleMigration,
-                  "recreate :#{@column} on :#{@table} manually if you need it back"
+            raise ActiveRecord::IrreversibleMigration, #{down_msg.inspect}
           end
         end
       RUBY
@@ -61,6 +64,14 @@ module SchemaReaper
       path
     end
 
+    # Match the host app's Rails minor version when ActiveRecord is loaded,
+    # otherwise a sane recent default the developer can edit.
+    def migration_version
+      return "7.1" unless defined?(ActiveRecord::VERSION::STRING)
+
+      ActiveRecord::VERSION::STRING.split(".").first(2).join(".")
+    end
+
     def camel
       "#{@table}_#{@column}".split("_").map(&:capitalize).join
     end

data/lib/schema_reaper/runner.rb

@@ -5,6 +5,8 @@ require "set"
 module SchemaReaper
   # Ties introspection + scanning + runtime data + analyzers together.
   class Runner
+    SEVERITY_RANK = { high: 0, medium: 1, low: 2 }.freeze
+
     def initialize(config: Config.load, root: Dir.pwd, introspector: nil, runtime: nil)
       @config = config
       @root = root
@@ -29,13 +31,30 @@ module SchemaReaper
 
     private
 
+    def dedupe(findings)
+      collapse_targets(drop_findings_on_dead_tables(findings))
+    end
+
     # When a whole table is dead, its per-column and per-index findings are
     # noise -- keep only the table-level finding for that table.
-    def dedupe(findings)
+    def drop_findings_on_dead_tables(findings)
       dead_tables = findings.select { |f| f.type == :dead_table }.to_set(&:table)
       findings.reject { |f| f.type != :dead_table && dead_tables.include?(f.table) }
     end
 
+    # Several analyzers can flag the same physical column or index (e.g.
+    # dead_column + always_null_column). Keep the highest-confidence finding per
+    # target so it is reported -- and its bytes counted -- exactly once, but note
+    # the other analyzers that agreed.
+    def collapse_targets(findings)
+      findings.group_by(&:target_key).map do |_key, group|
+        winner = group.max_by { |f| [f.confidence, -SEVERITY_RANK.fetch(f.severity, 9)] }
+        also = group.map(&:type).uniq - [winner.type]
+        winner.evidence += ["also flagged by: #{also.join(", ")}"] if also.any?
+        winner
+      end
+    end
+
     def schema
       return @introspector.call if @introspector
 

data/lib/schema_reaper/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SchemaReaper
-  VERSION = "1.0.4"
+  VERSION = "1.0.6"
 end

data/schema_reaper.gemspec

@@ -5,8 +5,8 @@ require_relative "lib/schema_reaper/version"
 Gem::Specification.new do |spec|
   spec.name = "schema_reaper"
   spec.version = SchemaReaper::VERSION
-  spec.authors = ["aksshatt"]
-  spec.email = ["akshatpegwar5@gmail.com"]
+  spec.authors = %w[aksshatt mitkush]
+  spec.email = ["akshatpegwar5@gmail.com", "mitanshukushwah@gmail.com"]
 
   spec.summary = "Find and safely remove schema dead-weight in Rails + PostgreSQL apps."
   spec.description =

metadata

@@ -1,10 +1,11 @@
 --- !ruby/object:Gem::Specification
 name: schema_reaper
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.0.6
 platform: ruby
 authors:
 - aksshatt
+- mitkush
 autorequire: 
 bindir: exe
 cert_chain: []
@@ -88,6 +89,7 @@ description: 'schema_reaper finds schema dead-weight in Rails/ActiveRecord + Pos
   only for now; Ruby >= 2.7. See the README for full usage.'
 email:
 - akshatpegwar5@gmail.com
+- mitanshukushwah@gmail.com
 executables:
 - schema_reaper
 extensions: []