schema_plus 2.0.0.pre5 → 2.0.0.pre6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 024ef569211e48b3ced76fe41a1cfca18fd22dc2
-  data.tar.gz: 1c72275c9cf049c750fc7304e9e3d597a08bd7cb
+  metadata.gz: f00ceb73134fe17d30d0eea3cc3c4d1176a790e9
+  data.tar.gz: 009e690b13ef1abb8633048f8b791588934ecf40
 SHA512:
-  metadata.gz: 2819f118b3f9ef1254b62be21cf2052da8498ab74f235c8784a33e36455b096b6fcaa9e42a4d6e36573c3def094b16e52031ee83e2f856786e5d6bf0981e1bfe
-  data.tar.gz: 5b797d46390e0b26a9db544024ab029c4105ebc3230a6de0101c7294966a8996b9f4cede86be400598342c878b10b4ef63d81c101a85d0be39d2f80a8039673c
+  metadata.gz: a4824b1d4d83099b03c1e1b053cc49f65083851080292a4d186575f970ebfca6a98e89b5485dc1f4f2c6ceaca7df43b277d808c4f88e1c98f3299a46b317d3c6
+  data.tar.gz: 9fed9ef9efc18014d2f0315245f2af09a1654f8b2d3db048ffa40eb408703a12ecce328989a8b6289a93f3598614cd1c021d24c877b6049e031585c778162db3

data/README.md

@@ -9,40 +9,48 @@
 [![Coverage Status](https://img.shields.io/coveralls/SchemaPlus/schema_plus.svg)](https://coveralls.io/r/SchemaPlus/schema_plus)
 [![Dependency Status](https://gemnasium.com/lomba/schema_plus.svg)](https://gemnasium.com/SchemaPlus/schema_plus)
 
-# SchemaPlus 2.x
+# SchemaPlus
 
-Starting with version 2.0.0, schema_plus is a wrapper that pulls in a collection of individual feature gems:
+The SchemaPlus family of gems provide various extensions and enhancements to ActiveRecord.  Listed alphabetically:
 
-* [schema_plus_indexes](https://github.com/SchemaPlus/schema_plus_indexes) -- Convenience and consistency in defining and manipulating indexes
-* [schema_plus_pg_indexes](https://github.com/SchemaPlus/schema_plus_pg_indexes) -- Support for PostgreSQL index features: `case_insenstive`, `expression` and `operator_class`
-* [schema_plus_views](https://github.com/SchemaPlus/schema_plus_views) -- Support for creating and dropping views in migrations, and querying views
+Gem | Description | Included In `schema_plus` gem?
+----| ----------- |:------------------------------:
+[schema_associations](https://github.com/SchemaPlus/schema_associations) | Automatically defines model associations based on foreign key relations |
+<p style="color:grey">schema_auto_foreign_keys</p> | Automatically creates foreign keys on referencing columns | Y
+[schema_plus_columns](https://github.com/SchemaPlus/schema_plus_columns) | Column attributes including `column.indexes` and `column.unique?` | Y
+<p style="color:grey">schema_plus_db_default</p> | Use `ActiveRecord::DB_DEFAULT` to set an attribute to the database default | Y
+<p style="color:grey">schema_plus_default_expr</p> | Use SQL expressions for database default values | Y
+<p style="color:grey">schema_plus_enums</p> | Use enum types in migrations | Y
+<p style="color:grey">schema_plus_foreign_keys | Extended support for foreign keys, including creation as column options, `:deferrable`, and SQLite3 support | Y
+[schema_plus_indexes](https://github.com/SchemaPlus/schema_plus_indexes) | Convenience and consistency in using indexes | Y
+[schema_plus_pg_indexes](https://github.com/SchemaPlus/schema_plus_pg_indexes) |PostgreSQL index features: `case_insenstive`, `expression` and `operator_class` | Y
+<p style="color:grey">schema_plus_tables</p> | Convenience and consistency in using tables | Y
+[schema_plus_views](https://github.com/SchemaPlus/schema_plus_views) | Create and drop views in migrations | Y
+[schema_validations](https://github.com/SchemaPlus/schema_validations) | Automatically defines ActiveRecord validations based on database constraints |
 
-See detailed documentation in each feature gem's README.  You can of course just use whichever of those gems you want individually, rather than this wrapper.
+See detailed documentation in each gem's README.
 
-> **IN PROGRESS:** In the prerelease versions of SchemaPlus 2.0, more feature gems have yet to be cleaned up and stripped out, and their code is still in the body of schema_plus.  Anticipated features gems include:
-> 
-> * schema_plus_columns -- Extra Column features, including `column.indexes` and `column.unique?`
-> * schema_plus_db_default -- Supports `update_attributes!(my_attr: ActiveRecord::DB_DEFAULT)` to set a column back to the default in the database schema. 
-> * schema_plus_default_expr -- Supports using SQL expressions for database default values
-> * schema_plus_enums -- Support for enum types
-> * schema_plus_foreign_keys -- Extends support for foreign keys
-> * schema_plus_tables -- Convenience and consistency in defining and manipulating tables
-> * schema_auto_foreign_keys -- Automatic foreign key creation
+*Is there some other capability you wish SchemaPlus had a gem for?*  Open an issue here. Or try implementing it yourself -- creating ActiveRecord extensions is easy and fun using SchemaPlus's tools [schema_monkey](https://github.com/SchemaPlus/schema_monkey) and [schema_plus_core](https://github.com/SchemaPlus/schema_plus_core)!!
 
->
-> The documentation for these features is at the end of this README
->
-> If you'd like to follow or contribute to the discussion of this refactoring, take a look at issue SchemaPlus/schema_plus/197
 
+## The `schema_plus` gem
 
-## Upgrading from SchemaPlus 1.8.x
+The `schema_plus` gem is a wrapper that pulls in a common collection of those gems.   But you can feel free to mix and match to get just the gems you want.
 
-SchemaPlus 2.0.x intends to be a completely backwards-compatible drop-in replacement for SchemaPlus 1.8.x, for projects using rails 4.2.
+Note: Prior to version 2.0, `schema_plus` was a single monolothic gem that implemented in itself all the features that are now included by the wrapper.
+
+
+> **IN PROGRESS:** In the prerelease versions of SchemaPlus 2.0, some features have yet to be migrated out to their own gems, and their code is still in the body of schema_plus.  Those gems are greyed out in the list above.  The documentation for their features is at the end of this README.
+
+
+### Upgrading from `schema_plus` 1.8.x
+
+`schema_plus` 2.0 intends to be a completely backwards-compatible drop-in replacement for SchemaPlus 1.8.x, through restricted to ActiveRecord >= 4.2 and Ruby >= 2.1
 
 If you find any incompatibilities, please report an issue!
 
-### Deprecations
-In cases where rails 4.2 has introduced features previously supported only by SchemaPlus, but using different names, the SchemaPlus 2.0 family of gems now issue deprecation warnings in favor of the rails form.  The complete list of deprecations:
+#### Deprecations
+In cases where ActiveRecord 4.2 has introduced features previously supported only by SchemaPlus, but using different names, the SchemaPlus 2.0 family of gems now issue deprecation warnings in favor of the rails form.  The complete list of deprecations:
 
 * Index definition deprecates these options:
   * `:conditions` => `:where`
@@ -54,13 +62,13 @@ In cases where rails 4.2 has introduced features previously supported only by Sc
 * `add_foreign_key` and `remove_foreign_key` deprecate the method signature:
   * `(from_table, columns, to_table, primary_keys, options)` => `(from_table, to_table, options)`
 
-* `ForeignKeyDefinition` deprecates accessors: 
+* `ForeignKeyDefinition` deprecates accessors:
   * `#table_name` in favor of `#from_table`
   * `#column_names` in favor of `Array.wrap(#column)`
   * `#references_column_names` in favor of `#primary_key`
   * `#references_table_name in favor of `#to_table`
 
-* `IndexDefinition` deprecates accessors: 
+* `IndexDefinition` deprecates accessors:
   * `#conditions` in favor of `#where`
   * `#kind` in favor of `#using.to_s`
 
@@ -83,44 +91,26 @@ Install from http://rubygems.org via
 or in a Gemfile
 
     gem "schema_plus"
-    
+
+`schema_plus` includes [schema_monkey_rails](https://github.com/SchemaPlus/schema_monkey_rails) so it will automatically be inserted in Rails apps.  To use with Padrino, see [schema_monkey_padrino](https://github.com/SchemaPlus/schema_monkey_padrino)
+
 ## History
 
 *   See [CHANGELOG](CHANGELOG.md) for per-version release notes.
 
-*   SchemaPlus is derived from several "Red Hill On Rails" plugins originally
-    created by [@harukizaemon](https://github.com/harukizaemon)
+*   SchemaPlus was originally derived from several "Red Hill On Rails" plugins created by [@harukizaemon](https://github.com/harukizaemon)
 
 *   SchemaPlus was created in 2011 by [@mlomnicki](https://github.com/mlomnicki) and [@ronen](https://github.com/ronen)
 
 *   And [lots of contributors](https://github.com/SchemaPlus/schema_plus/graphs/contributors) since then.
 
-## Development & Testing
-
-Are you interested in contributing to schema_plus?  Thanks!
-
-Schema_plus has a full set of rspec tests.  [travis-ci](http://travis-ci.org/SchemaPlus/schema_plus) runs the tests on the full matrix of supported versions of ruby, rails, and db adapters.  But you can also test all or some part of the matrix locally before you push your changes, using
-
-    $ schema_dev rspec
-
-
-For more details, see the [schema_dev](https://github.com/SchemaPlus/schema_dev) README.
-
----    
+---
 ---
 
 # Prerelease:  Documentation of features still be moved into separate feature gems
 
-    
-> **NOTE** The documentation in this README is leftover from the 1.x branch; the functionality is the same, but some of the core features of schema_plus (such as foreign keys & inline index definition) are now provided by ActiveRecord 4.2.  schema_plus still provides extra functionality beyond AR 4.2, but the documentation needs to be updated to be clear what's an enhancement of AR 4.2 capabilities rather than completely new features.
-
-### Columns
 
-
-When you query column information using ActiveRecord::Base#columns, SchemaPlus
-analogously provides index information relevant to each column: which indexes
-reference the column, whether the column must be unique, etc.  See doc for
-[SchemaPlus::ActiveRecord::ConnectionAdapters::Column](http://rubydoc.info/gems/schema_plus/SchemaPlus/ActiveRecord/ConnectionAdapters/Column).
+> **NOTE** The documentation in this README is leftover from the 1.x branch; the functionality is the same, but some of the core features of schema_plus (such as foreign keys & inline index definition) are now provided by ActiveRecord 4.2.  schema_plus still provides extra functionality beyond AR 4.2, but the documentation needs to be updated to be clear what's an enhancement of AR 4.2 capabilities rather than completely new features.
 
 ### Foreign Key Constraints
 
@@ -288,8 +278,8 @@ your schema.rb file by hand, and would like to take advantage of auto-creation
 of foreign key constraints, you can re-enable it:
 
     ActiveRecord::Schema.define do
-        SchemaPlusForeignKeys.config.auto_create = true
-        SchemaPlusForeignKeys.config.auto_index = true
+        SchemaPlus::ForeignKeys.config.auto_create = true
+        SchemaPlus::ForeignKeys.config.auto_index = true
 
         create_table ...etc...
     end

data/lib/schema_plus.rb

@@ -1,25 +1,25 @@
 require 'schema_monkey_rails'
-require 'schema_plus_columns'
-require 'schema_plus_db_default'
-require 'schema_plus_default_expr'
-require 'schema_plus_enums'
-require 'schema_plus_foreign_keys'
-require 'schema_plus_indexes'
-require 'schema_plus_pg_indexes'
-require 'schema_plus_tables'
+require 'schema_plus/columns'
+require 'schema_plus/db_default'
+require 'schema_plus/default_expr'
+require 'schema_plus/enums'
+require 'schema_plus/foreign_keys'
+require 'schema_plus/indexes'
+require 'schema_plus/tables'
 require 'schema_plus/views'
+require 'schema_plus_pg_indexes'
 
 require_relative 'schema_plus/version'
 
 module SchemaPlus
   class DeprecatedConfig
     def foreign_keys
-      SchemaPlusForeignKeys.config
+      SchemaPlus::ForeignKeys.config
     end
   end
 
   def self.setup # :yields: config
-    ActiveSupport::Deprecation.warning "SchemaPlus.setup is deprecated.  Use SchemaPlusForeignKeys.setup instead"
+    ActiveSupport::Deprecation.warn "SchemaPlus.setup is deprecated.  Use SchemaPlus::ForeignKeys.setup instead"
     yield DeprecatedConfig.new
   end
 end

data/lib/schema_plus/db_default.rb

@@ -0,0 +1,7 @@
+require 'schema_plus/core'
+
+require_relative 'db_default/active_record/attribute'
+require_relative 'db_default/db_default'
+require_relative 'db_default/middleware'
+
+SchemaMonkey.register SchemaPlus::DbDefault

data/lib/{schema_plus_db_default → schema_plus/db_default}/active_record/attribute.rb

@@ -1,4 +1,4 @@
-module SchemaPlusDbDefault
+module SchemaPlus::DbDefault
   module ActiveRecord
     module Attribute
 

data/lib/{schema_plus_db_default → schema_plus/db_default}/db_default.rb

@@ -1,6 +1,6 @@
 require 'singleton'
 
-module SchemaPlusDbDefault
+module SchemaPlus::DbDefault
   class DbDefault
     include Singleton
     def to_s
@@ -16,4 +16,4 @@ module SchemaPlusDbDefault
   DB_DEFAULT = DbDefault.instance
 end
 
-::ActiveRecord.const_set :DB_DEFAULT, SchemaPlusDbDefault::DB_DEFAULT
+::ActiveRecord.const_set :DB_DEFAULT, SchemaPlus::DbDefault::DB_DEFAULT

data/lib/{schema_plus_db_default → schema_plus/db_default}/middleware.rb

@@ -1,4 +1,4 @@
-module SchemaPlusDbDefault
+module SchemaPlus::DbDefault
   module Middleware
 
     module Query

data/lib/{schema_plus_default_expr.rb → schema_plus/default_expr.rb}

@@ -1,9 +1,9 @@
-require 'schema_monkey'
+require 'schema_plus/core'
 
-require_relative 'schema_plus_default_expr/middleware'
-require_relative 'schema_plus_default_expr/active_record/connection_adapters/column'
+require_relative 'default_expr/middleware'
+require_relative 'default_expr/active_record/connection_adapters/column'
 
-module SchemaPlusDefaultExpr
+module SchemaPlus::DefaultExpr
   module ActiveRecord
     module ConnectionAdapters
       #
@@ -23,11 +23,11 @@ module SchemaPlusDefaultExpr
       # Currently, the only function to support is :now, which should
       # return a DATETIME object for the current time.
       #
-      autoload :Mysql2Adapter, 'schema_plus_default_expr/active_record/connection_adapters/mysql2_adapter'
-      autoload :PostgresqlAdapter, 'schema_plus_default_expr/active_record/connection_adapters/postgresql_adapter'
-      autoload :Sqlite3Adapter, 'schema_plus_default_expr/active_record/connection_adapters/sqlite3_adapter'
+      autoload :Mysql2Adapter, 'schema_plus/default_expr/active_record/connection_adapters/mysql2_adapter'
+      autoload :PostgresqlAdapter, 'schema_plus/default_expr/active_record/connection_adapters/postgresql_adapter'
+      autoload :Sqlite3Adapter, 'schema_plus/default_expr/active_record/connection_adapters/sqlite3_adapter'
     end
   end
 end
 
-SchemaMonkey.register(SchemaPlusDefaultExpr)
+SchemaMonkey.register SchemaPlus::DefaultExpr

data/lib/{schema_plus_default_expr → schema_plus/default_expr}/active_record/connection_adapters/column.rb

@@ -1,4 +1,4 @@
-module SchemaPlusDefaultExpr
+module SchemaPlus::DefaultExpr
   module ActiveRecord
     module ConnectionAdapters
       module Column

data/lib/{schema_plus_default_expr → schema_plus/default_expr}/active_record/connection_adapters/mysql2_adapter.rb

@@ -1,4 +1,4 @@
-module SchemaPlusDefaultExpr
+module SchemaPlus::DefaultExpr
   module ActiveRecord
     module ConnectionAdapters
       module Mysql2Adapter

data/lib/{schema_plus_default_expr → schema_plus/default_expr}/active_record/connection_adapters/postgresql_adapter.rb

@@ -1,4 +1,4 @@
-module SchemaPlusDefaultExpr
+module SchemaPlus::DefaultExpr
   module ActiveRecord
     module ConnectionAdapters
       module PostgresqlAdapter

data/lib/{schema_plus_default_expr → schema_plus/default_expr}/active_record/connection_adapters/sqlite3_adapter.rb

@@ -1,4 +1,4 @@
-module SchemaPlusDefaultExpr
+module SchemaPlus::DefaultExpr
   module ActiveRecord
     module ConnectionAdapters
       module Sqlite3Adapter

data/lib/{schema_plus_default_expr → schema_plus/default_expr}/middleware.rb

@@ -1,4 +1,4 @@
-module SchemaPlusDefaultExpr
+module SchemaPlus::DefaultExpr
   module Middleware
 
     module Sql

data/lib/schema_plus/enums.rb

@@ -0,0 +1,6 @@
+require 'schema_plus/core'
+
+require_relative 'enums/active_record'
+require_relative 'enums/middleware'
+
+SchemaMonkey.register SchemaPlus::Enums

data/lib/{schema_plus_enums → schema_plus/enums}/active_record.rb

@@ -1,4 +1,4 @@
-module SchemaPlusEnums
+module SchemaPlus::Enums
   module ActiveRecord
     module ConnectionAdapters
       module PostgresqlAdapter

data/lib/{schema_plus_enums → schema_plus/enums}/middleware.rb

@@ -1,4 +1,4 @@
-module SchemaPlusEnums
+module SchemaPlus::Enums
   module Middleware
 
     module Dumper

data/lib/{schema_plus_foreign_keys.rb → schema_plus/foreign_keys.rb}

@@ -1,31 +1,31 @@
-require 'active_record'
+require 'schema_plus/core'
 require 'valuable'
 
-require 'schema_plus_foreign_keys/version'
-require 'schema_plus_foreign_keys/active_record/base'
-require 'schema_plus_foreign_keys/active_record/connection_adapters/abstract_adapter'
-require 'schema_plus_foreign_keys/active_record/connection_adapters/table_definition'
-require 'schema_plus_foreign_keys/active_record/schema'
-require 'schema_plus_foreign_keys/active_record/connection_adapters/foreign_key_definition'
-require 'schema_plus_foreign_keys/active_record/migration/command_recorder'
-require 'schema_plus_foreign_keys/middleware/dumper'
-require 'schema_plus_foreign_keys/middleware/migration'
-require 'schema_plus_foreign_keys/middleware/model'
-require 'schema_plus_foreign_keys/middleware/sql'
+require_relative 'foreign_keys/version'
+require_relative 'foreign_keys/active_record/base'
+require_relative 'foreign_keys/active_record/connection_adapters/abstract_adapter'
+require_relative 'foreign_keys/active_record/connection_adapters/table_definition'
+require_relative 'foreign_keys/active_record/schema'
+require_relative 'foreign_keys/active_record/connection_adapters/foreign_key_definition'
+require_relative 'foreign_keys/active_record/migration/command_recorder'
+require_relative 'foreign_keys/middleware/dumper'
+require_relative 'foreign_keys/middleware/migration'
+require_relative 'foreign_keys/middleware/model'
+require_relative 'foreign_keys/middleware/sql'
 
-module SchemaPlusForeignKeys
+module SchemaPlus::ForeignKeys
   module ActiveRecord
     module ConnectionAdapters
-      autoload :Mysql2Adapter, 'schema_plus_foreign_keys/active_record/connection_adapters/mysql2_adapter'
-      autoload :PostgresqlAdapter, 'schema_plus_foreign_keys/active_record/connection_adapters/postgresql_adapter'
-      autoload :Sqlite3Adapter, 'schema_plus_foreign_keys/active_record/connection_adapters/sqlite3_adapter'
+      autoload :Mysql2Adapter, 'schema_plus/foreign_keys/active_record/connection_adapters/mysql2_adapter'
+      autoload :PostgresqlAdapter, 'schema_plus/foreign_keys/active_record/connection_adapters/postgresql_adapter'
+      autoload :Sqlite3Adapter, 'schema_plus/foreign_keys/active_record/connection_adapters/sqlite3_adapter'
     end
   end
 
-  # This global configuation options for SchemaPlusForeignKeys.
+  # This global configuation options for SchemaPlus::ForeignKeys.
   # Set them in +config/initializers/schema_plus_foreign_keys.rb+ using:
   #
-  #    SchemaPlusForeignKeys.setup do |config|
+  #    SchemaPlus::ForeignKeys.setup do |config|
   #       ...
   #    end
   #
@@ -75,11 +75,11 @@ module SchemaPlusForeignKeys
   end
 
   # Initialization block is passed a global Config instance that can be
-  # used to configure SchemaPlusForeignKeys behavior.  E.g., if you want to disable
+  # used to configure SchemaPlus::ForeignKeys behavior.  E.g., if you want to disable
   # automation creation of foreign key constraints for columns name *_id,
   # put the following in config/initializers/schema_plus_foreign_keys.rb :
   #
-  #    SchemaPlusForeignKeys.setup do |config|
+  #    SchemaPlus::ForeignKeys.setup do |config|
   #       config.auto_create = false
   #    end
   #
@@ -89,4 +89,4 @@ module SchemaPlusForeignKeys
 
 end
 
-SchemaMonkey.register(SchemaPlusForeignKeys)
+SchemaMonkey.register SchemaPlus::ForeignKeys

data/lib/{schema_plus_foreign_keys → schema_plus/foreign_keys}/active_record/base.rb

@@ -1,8 +1,8 @@
-module SchemaPlusForeignKeys
+module SchemaPlus::ForeignKeys
   module ActiveRecord
 
     #
-    # SchemaPlusForeignKeys adds several methods to ActiveRecord::Base
+    # SchemaPlus::ForeignKeys adds several methods to ActiveRecord::Base
     #
     module Base
       module ClassMethods #:nodoc:

data/lib/{schema_plus_foreign_keys → schema_plus/foreign_keys}/active_record/connection_adapters/abstract_adapter.rb

@@ -1,10 +1,10 @@
-module SchemaPlusForeignKeys
+module SchemaPlus::ForeignKeys
   module ActiveRecord
-    # SchemaPlusForeignKeys adds several methods to the connection adapter (as returned by ActiveRecordBase#connection).  See AbstractAdapter for details.
+    # SchemaPlus::ForeignKeys adds several methods to the connection adapter (as returned by ActiveRecordBase#connection).  See AbstractAdapter for details.
     module ConnectionAdapters
 
       #
-      # SchemaPlusForeignKeys adds several methods to
+      # SchemaPlus::ForeignKeys adds several methods to
       # ActiveRecord::ConnectionAdapters::AbstractAdapter.  In most cases
       # you don't call these directly, but rather the methods that define
       # things are called by schema statements, and methods that query
@@ -20,7 +20,7 @@ module SchemaPlusForeignKeys
           drop_table(table, if_exists: true, cascade: true) if options.delete(:force)
 
           super(table, options) do |table_definition|
-            table_definition.schema_plus_config = SchemaPlusForeignKeys.config.merge(config_options)
+            table_definition.schema_plus_config = SchemaPlus::ForeignKeys.config.merge(config_options)
             yield table_definition if block_given?
           end
         end
@@ -126,7 +126,7 @@ module SchemaPlusForeignKeys
           if fk = fks.detect { |fk| fk.match(test_fk) }
             fk.name
           else
-            raise "SchemaPlusForeignKeys: no foreign key constraint found on #{from_table.inspect} matching #{[to_table, options].inspect}" unless options[:if_exists]
+            raise "SchemaPlus::ForeignKeys: no foreign key constraint found on #{from_table.inspect} matching #{[to_table, options].inspect}" unless options[:if_exists]
             nil
           end
         end

data/lib/{schema_plus_foreign_keys → schema_plus/foreign_keys}/active_record/connection_adapters/foreign_key_definition.rb

@@ -1,6 +1,6 @@
 require 'active_record/connection_adapters/abstract/schema_definitions'
 
-module SchemaPlusForeignKeys
+module SchemaPlus::ForeignKeys
   module ActiveRecord
     module ConnectionAdapters
       # Instances of this class are returned by the queries ActiveRecord::Base#foreign_keys and ActiveRecord::Base#reverse_foreign_keys (via AbstractAdapter#foreign_keys and AbstractAdapter#reverse_foreign_keys)
@@ -73,7 +73,7 @@ module SchemaPlusForeignKeys
 
         # Dumps a definition of foreign key.
         def to_dump(column: nil, inline: nil)
-          dump = case 
+          dump = case
                  when column then "foreign_key: {references:"
                  when inline then "t.foreign_key"
                  else "add_foreign_key #{from_table.inspect},"