schema_expectations 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bd5eeeafd64927fadc0781314d97e9c104efcc63
-  data.tar.gz: 67ea5f0dec0ac25d66dadc768a233e3446f961a1
+  metadata.gz: de04e4a86866e356d2225b0b4236407b34a0795c
+  data.tar.gz: 5127ab4ef41da535ff54de06928081ca9c887e63
 SHA512:
-  metadata.gz: 746d0312374307e14a451bd7186d6561c99de12d7247728fcdec00e8bda23976ee330046c33b90ef90fdd24ae03c09733a9933d0e62be52e0e79ef18512e20cc
-  data.tar.gz: 1cec0c037a5ea1fbb5dd6fa0b21c5f6914f104b55cb9a38a45dde97895247c501ba3acd269f20a635cfd8b1958819c0a282b9c474e385803ed00641e6ab422bd
+  metadata.gz: 35aa646038fd59a9e88c76d6f8698a5669a0c602f37eaad56e95c772059bfe1de37087253726f15c7301c5b8f5abec6ba00fcedbb620dfe1480995008975d129
+  data.tar.gz: 71f5edb70e04ea2ab32c47c09ffd2132798ee8f57be0454481c2a7d0559a883051bb747a4ea65d9098fffbf495f22242deb3527410446ca1df583a1207988f49

data/CHANGELOG.md

@@ -1,6 +1,15 @@
 # Schema Expectations Changelog
 
 ### git master
+
+### 0.4.0 (Febuary 20, 2015)
+
+- include matchers in non-model specs as well
+- include model names in failure messages
+- fixed a bug in column reflector (test class name was used directly)
+
+### 0.3.0 (Febuary 20, 2015)
+
 - added `validate_schema_uniqueness`
 
 ### 0.2.0 (Febuary 18, 2015)

data/TODO.md

@@ -0,0 +1,2 @@
+- `validates :attribute, if: :attribute_changed?` should have an exception as not conditional
+- `:absence` validation should absolve a model of needing uniqueness validation on the relevant column

data/lib/schema_expectations/active_record/column_reflector.rb

@@ -89,7 +89,7 @@ module SchemaExpectations
       end
 
       def all_timestamp_attributes
-        @all_timestamp_attributes ||= Record.new.send(:all_timestamp_attributes).map(&:to_sym)
+        @all_timestamp_attributes ||= @model.new.send(:all_timestamp_attributes).map(&:to_sym)
       end
 
       def unique_indexes

data/lib/schema_expectations/rspec.rb

@@ -2,5 +2,5 @@ require 'rspec/core'
 require 'schema_expectations/rspec_matchers'
 
 RSpec.configure do |config|
-  config.include SchemaExpectations::RSpecMatchers, type: :model
+  config.include SchemaExpectations::RSpecMatchers
 end

data/lib/schema_expectations/rspec_matchers/validate_schema_nullable.rb

@@ -53,16 +53,16 @@ module SchemaExpectations
         errors = []
 
         (@present_column_names - @not_null_column_names).each do |column_name|
-          errors << "#{column_name} has unconditional presence validation but is missing NOT NULL"
+          errors << "#{@model.name} #{column_name} has unconditional presence validation but is missing NOT NULL"
         end
 
         (@not_null_column_names - @present_column_names).each do |column_name|
           conditions = validator_allow_nil_conditions_for_column_name(column_name) ||
             validator_conditions_for_column_name(column_name)
           if conditions
-            errors << "#{column_name} is NOT NULL but its presence validator was conditional: #{conditions.inspect}"
+            errors << "#{@model.name} #{column_name} is NOT NULL but its presence validator was conditional: #{conditions.inspect}"
           else
-            errors << "#{column_name} is NOT NULL but has no presence validation"
+            errors << "#{@model.name} #{column_name} is NOT NULL but has no presence validation"
           end
         end
 
@@ -70,7 +70,7 @@ module SchemaExpectations
       end
 
       def failure_message_when_negated
-        'should not match NOT NULL with its presence validation but does'
+        "#{@model.name} should not match NOT NULL with its presence validation but does"
       end
 
       def description

data/lib/schema_expectations/rspec_matchers/validate_schema_uniqueness.rb

@@ -57,16 +57,16 @@ module SchemaExpectations
         errors = []
 
         (@validator_unique_scopes - @schema_unique_scopes).each do |scope|
-          errors << "scope #{scope.inspect} has unconditional uniqueness validation but is missing a unique database index"
+          errors << "#{@model.name} scope #{scope.inspect} has unconditional uniqueness validation but is missing a unique database index"
         end
 
         (@schema_unique_scopes - @validator_unique_scopes).each do |scope|
           conditions = validator_conditions_for_scope(scope) ||
             validator_allow_empty_conditions_for_scope(scope)
           if conditions
-            errors << "scope #{scope.inspect} has a unique index but its uniqueness validator was conditional: #{conditions.inspect}"
+            errors << "#{@model.name} scope #{scope.inspect} has a unique index but its uniqueness validator was conditional: #{conditions.inspect}"
           else
-            errors << "scope #{scope.inspect} has a unique index but no uniqueness validation"
+            errors << "#{@model.name} scope #{scope.inspect} has a unique index but no uniqueness validation"
           end
         end
 
@@ -74,7 +74,7 @@ module SchemaExpectations
       end
 
       def failure_message_when_negated
-        'should not match unique indexes with its uniqueness validation but does'
+        "#{@model.name} should not match unique indexes with its uniqueness validation but does"
       end
 
       def description

data/lib/schema_expectations/version.rb

@@ -1,3 +1,3 @@
 module SchemaExpectations
-  VERSION = '0.3.0'
+  VERSION = '0.4.0'
 end

data/spec/lib/schema_expectations/rspec_matchers/validate_schema_nullable_spec.rb

@@ -37,7 +37,7 @@ describe SchemaExpectations::RSpecMatchers::ValidateSchemaNullableMatcher, :acti
         end.to raise_error do |error|
           expect(error).to be_a RSpec::Expectations::ExpectationNotMetError
           not_null_columns.sort.zip(error.message.split(', ')) do |column, message|
-            expect(message).to eq "#{column} is NOT NULL but has no presence validation"
+            expect(message).to eq "Record #{column} is NOT NULL but has no presence validation"
           end
         end
       end
@@ -86,11 +86,11 @@ describe SchemaExpectations::RSpecMatchers::ValidateSchemaNullableMatcher, :acti
           errors = error.message.split(', ')
 
           nullable_columns.sort.zip(errors.take(nullable_columns.size)) do |column, message|
-            expect(message).to eq "#{column} has unconditional presence validation but is missing NOT NULL"
+            expect(message).to eq "Record #{column} has unconditional presence validation but is missing NOT NULL"
           end
 
           not_null_columns.sort.zip(errors.drop(nullable_columns.size)) do |column, message|
-            expect(message).to eq "#{column} is NOT NULL but has no presence validation"
+            expect(message).to eq "Record #{column} is NOT NULL but has no presence validation"
           end
         end
       end
@@ -122,7 +122,7 @@ describe SchemaExpectations::RSpecMatchers::ValidateSchemaNullableMatcher, :acti
         end.to raise_error do |error|
           expect(error).to be_a RSpec::Expectations::ExpectationNotMetError
           nullable_columns.sort.zip(error.message.split(', ')) do |column, message|
-            expect(message).to eq "#{column} has unconditional presence validation but is missing NOT NULL"
+            expect(message).to eq "Record #{column} has unconditional presence validation but is missing NOT NULL"
           end
         end
       end
@@ -145,7 +145,7 @@ describe SchemaExpectations::RSpecMatchers::ValidateSchemaNullableMatcher, :acti
 
       expect do
         is_expected.to_not validate_schema_nullable
-      end.to raise_error 'should not match NOT NULL with its presence validation but does'
+      end.to raise_error 'Record should not match NOT NULL with its presence validation but does'
     end
 
     specify 'when primary_key is not id' do
@@ -180,7 +180,7 @@ describe SchemaExpectations::RSpecMatchers::ValidateSchemaNullableMatcher, :acti
         end.to raise_error do |error|
           expect(error).to be_a RSpec::Expectations::ExpectationNotMetError
           not_null_columns.sort.zip(error.message.split(', ')) do |column, message|
-            expect(message).to eq "#{column} is NOT NULL but its presence validator was conditional: {:on=>:create}"
+            expect(message).to eq "Record #{column} is NOT NULL but its presence validator was conditional: {:on=>:create}"
           end
         end
       end
@@ -193,7 +193,7 @@ describe SchemaExpectations::RSpecMatchers::ValidateSchemaNullableMatcher, :acti
         end.to raise_error do |error|
           expect(error).to be_a RSpec::Expectations::ExpectationNotMetError
           not_null_columns.sort.zip(error.message.split(', ')) do |column, message|
-            expect(message).to match /\A#{column} is NOT NULL but its presence validator was conditional: {:if=>\#<Proc:.*>}\z/
+            expect(message).to match /\ARecord #{column} is NOT NULL but its presence validator was conditional: {:if=>\#<Proc:.*>}\z/
           end
         end
       end
@@ -206,7 +206,7 @@ describe SchemaExpectations::RSpecMatchers::ValidateSchemaNullableMatcher, :acti
         end.to raise_error do |error|
           expect(error).to be_a RSpec::Expectations::ExpectationNotMetError
           not_null_columns.sort.zip(error.message.split(', ')) do |column, message|
-            expect(message).to match /\A#{column} is NOT NULL but its presence validator was conditional: {:unless=>\#<Proc:.*>}\z/
+            expect(message).to match /\ARecord #{column} is NOT NULL but its presence validator was conditional: {:unless=>\#<Proc:.*>}\z/
           end
         end
       end
@@ -219,7 +219,7 @@ describe SchemaExpectations::RSpecMatchers::ValidateSchemaNullableMatcher, :acti
         end.to raise_error do |error|
           expect(error).to be_a RSpec::Expectations::ExpectationNotMetError
           not_null_columns.sort.zip(error.message.split(', ')) do |column, message|
-            expect(message).to eq "#{column} is NOT NULL but its presence validator was conditional: {:allow_nil=>true}"
+            expect(message).to eq "Record #{column} is NOT NULL but its presence validator was conditional: {:allow_nil=>true}"
           end
         end
       end
@@ -232,7 +232,7 @@ describe SchemaExpectations::RSpecMatchers::ValidateSchemaNullableMatcher, :acti
         end.to raise_error do |error|
           expect(error).to be_a RSpec::Expectations::ExpectationNotMetError
           not_null_columns.sort.zip(error.message.split(', ')) do |column, message|
-            expect(message).to eq "#{column} is NOT NULL but its presence validator was conditional: {:allow_blank=>true}"
+            expect(message).to eq "Record #{column} is NOT NULL but its presence validator was conditional: {:allow_blank=>true}"
           end
         end
       end

data/spec/lib/schema_expectations/rspec_matchers/validate_schema_uniqueness_spec.rb

@@ -34,7 +34,7 @@ describe SchemaExpectations::RSpecMatchers::ValidateSchemaUniquenessMatcher, :ac
       specify 'error messages' do
         expect { is_expected.to validate_schema_uniqueness }.to(
           raise_error(RSpec::Expectations::ExpectationNotMetError,
-            "scope #{unique_scope.inspect} has a unique index but no uniqueness validation")
+            "Record scope #{unique_scope.inspect} has a unique index but no uniqueness validation")
         )
       end
 
@@ -81,7 +81,7 @@ describe SchemaExpectations::RSpecMatchers::ValidateSchemaUniquenessMatcher, :ac
       specify 'error messages' do
         expect { is_expected.to validate_schema_uniqueness }.to(
           raise_error(RSpec::Expectations::ExpectationNotMetError,
-            "scope [:index_not_unique] has unconditional uniqueness validation but is missing a unique database index")
+            "Record scope [:index_not_unique] has unconditional uniqueness validation but is missing a unique database index")
         )
       end
 
@@ -107,7 +107,7 @@ describe SchemaExpectations::RSpecMatchers::ValidateSchemaUniquenessMatcher, :ac
       specify 'error messages' do
         expect { is_expected.to validate_schema_uniqueness }.to(
           raise_error(RSpec::Expectations::ExpectationNotMetError,
-            "scope [:no_index] has unconditional uniqueness validation but is missing a unique database index")
+            "Record scope [:no_index] has unconditional uniqueness validation but is missing a unique database index")
         )
       end
 
@@ -127,7 +127,7 @@ describe SchemaExpectations::RSpecMatchers::ValidateSchemaUniquenessMatcher, :ac
 
       expect do
         is_expected.to_not validate_schema_uniqueness
-      end.to raise_error 'should not match unique indexes with its uniqueness validation but does'
+      end.to raise_error 'Record should not match unique indexes with its uniqueness validation but does'
     end
 
     specify 'allows validators with allow_nil: true' do
@@ -142,7 +142,7 @@ describe SchemaExpectations::RSpecMatchers::ValidateSchemaUniquenessMatcher, :ac
 
         expect { is_expected.to validate_schema_uniqueness }.to(
           raise_error(RSpec::Expectations::ExpectationNotMetError,
-            "scope #{unique_scope.inspect} has a unique index but its uniqueness validator was conditional: {:on=>:create}")
+            "Record scope #{unique_scope.inspect} has a unique index but its uniqueness validator was conditional: {:on=>:create}")
         )
       end
 
@@ -151,7 +151,7 @@ describe SchemaExpectations::RSpecMatchers::ValidateSchemaUniquenessMatcher, :ac
 
         expect { is_expected.to validate_schema_uniqueness }.to(
           raise_error(RSpec::Expectations::ExpectationNotMetError,
-            /\Ascope #{Regexp.escape(unique_scope.inspect)} has a unique index but its uniqueness validator was conditional: {:if=>\#<Proc:.*>}\z/)
+            /\ARecord scope #{Regexp.escape(unique_scope.inspect)} has a unique index but its uniqueness validator was conditional: {:if=>\#<Proc:.*>}\z/)
         )
       end
 
@@ -160,7 +160,7 @@ describe SchemaExpectations::RSpecMatchers::ValidateSchemaUniquenessMatcher, :ac
 
         expect { is_expected.to validate_schema_uniqueness }.to(
           raise_error(RSpec::Expectations::ExpectationNotMetError,
-            /\Ascope #{Regexp.escape(unique_scope.inspect)} has a unique index but its uniqueness validator was conditional: {:unless=>\#<Proc:.*>}\z/)
+            /\ARecord scope #{Regexp.escape(unique_scope.inspect)} has a unique index but its uniqueness validator was conditional: {:unless=>\#<Proc:.*>}\z/)
         )
       end
 
@@ -169,7 +169,7 @@ describe SchemaExpectations::RSpecMatchers::ValidateSchemaUniquenessMatcher, :ac
 
         expect { is_expected.to validate_schema_uniqueness }.to(
           raise_error(RSpec::Expectations::ExpectationNotMetError,
-            "scope #{unique_scope.inspect} has a unique index but its uniqueness validator was conditional: {:allow_blank=>true}")
+            "Record scope #{unique_scope.inspect} has a unique index but its uniqueness validator was conditional: {:allow_blank=>true}")
         )
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: schema_expectations
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Emma Borhanian
@@ -262,6 +262,7 @@ files:
 - MIT-LICENSE
 - README.md
 - Rakefile
+- TODO.md
 - gemfiles/activerecord_3.1.gemfile
 - gemfiles/activerecord_3.2.gemfile
 - gemfiles/activerecord_4.0.gemfile