schema_dev 4.0.0 → 4.1.0

data/lib/schema_dev/runner.rb

@@ -1,38 +1,42 @@
+# frozen_string_literal: true
+
 require 'shellwords'
 
 require_relative 'matrix_executor'
-require_relative 'travis'
+require_relative 'github_actions'
 require_relative 'gemfiles'
 require_relative 'readme'
 
 module SchemaDev
   class Runner
+    attr_reader :config
+
     def initialize(config)
       @config = config
     end
 
-    def travis(quiet: false)
-      if Travis.update(@config)
-        puts "* Updated #{Travis::TRAVIS_FILE}" unless quiet
+    def github_actions(quiet: false)
+      if GithubActions.update(@config)
+        puts "* Updated #{GithubActions::WORKFLOW_FILE}" unless quiet
       end
     end
 
     def gemfiles(quiet: false)
       if Gemfiles.build(@config)
-        puts "* Updated gemfiles" unless quiet
+        puts '* Updated gemfiles' unless quiet
       end
     end
 
     def readme(quiet: false)
       if Readme.update(@config)
-        puts "* Updated README" unless quiet
+        puts '* Updated README' unless quiet
       end
     end
 
     def freshen(quiet: false)
-      self.travis(quiet: quiet)
-      self.gemfiles(quiet: quiet)
-      self.readme(quiet: quiet)
+      github_actions(quiet: quiet)
+      gemfiles(quiet: quiet)
+      readme(quiet: quiet)
     end
 
     def run(*args, dry_run: false, quick: false, ruby: nil, activerecord: nil, db: nil, freshen: true)
@@ -43,7 +47,7 @@ module SchemaDev
       return true if matrix.run(Shellwords.join(args.flatten), dry_run: dry_run)
 
       puts "\n*** #{matrix.errors.size} failures:\n\t#{matrix.errors.join("\n\t")}"
-      return false
+      false
     end
   end
 end

data/lib/schema_dev/tasks/dbms.rb

@@ -1,49 +1,57 @@
-require 'schema_dev/config'
+# frozen_string_literal: true
 
-dbms = SchemaDev::Config.load.dbms
+require 'schema_dev/config'
+require 'schema_dev/rspec'
 
-DATABASES = %w[schema_plus_test]
+dbms = SchemaDev::Config.load.db
 
 if dbms.any?
-  {
-    postgresql: { uservar: 'POSTGRESQL_DB_USER', defaultuser: 'schema_plus', create: "createdb -U '%{user}' %{dbname}", drop: "dropdb -U '%{user}' %{dbname}" },
-    mysql:      { uservar: 'MYSQL_DB_USER', defaultuser: 'schema_plus', create: "mysqladmin -u '%{user}' create %{dbname}", drop: "mysqladmin -u '%{user}' -f drop %{dbname}" }
-  }.slice(*dbms).each do |dbm, info|
+  (%w[postgresql mysql2] & dbms).each do |dbm|
     namespace dbm do
-      user = ENV.fetch info[:uservar], info[:defaultuser]
-      task :create_databases do
-        DATABASES.each do |dbname|
-          system(info[:create] % {user: user, dbname: dbname})
-        end
+      task :create_database do
+        require 'active_record'
+
+        config = SchemaDev::Rspec.db_configuration(dbm)
+
+        ActiveRecord::Tasks::DatabaseTasks.create(config)
       end
       task :drop_databases do
-        DATABASES.each do |dbname|
-          system(info[:drop] % {user: user, dbname: dbname})
-        end
+        require 'active_record'
+
+        config = SchemaDev::Rspec.db_configuration(dbm)
+
+        ActiveRecord::Tasks::DatabaseTasks.drop(config)
       end
     end
   end
 
+  desc 'Create database for CI run'
+  task :create_ci_database do
+    require 'active_record'
+
+    config = SchemaDev::Rspec.db_configuration
+
+    ActiveRecord::Tasks::DatabaseTasks.create(config) unless config['adapter'] == 'sqlite3'
+  end
+
   desc 'Create test databases'
   task :create_databases do
-    invoke_multiple(dbms, "create_databases")
+    invoke_multiple(dbms, 'create_database')
   end
 
   desc 'Drop test databases'
   task :drop_databases do
-    invoke_multiple(dbms, "drop_databases")
+    invoke_multiple(dbms, 'drop_database')
   end
 
   def invoke_multiple(namespaces, task)
-    failed = namespaces.reject { |adapter|
-      begin
-        Rake::Task["#{adapter}:#{task}"].invoke
-        true
-      rescue => e
-        warn "\n#{e}\n"
-        false
-      end
-    }
+    failed = namespaces.reject do |adapter|
+      Rake::Task["#{adapter}:#{task}"].invoke
+      true
+    rescue => e
+      warn "\n#{e}\n"
+      false
+    end
     fail "Failure in: #{failed.join(', ')}" if failed.any?
   end
 end

data/lib/schema_dev/tasks.rb

@@ -1,4 +1,3 @@
-require_relative 'tasks/dbms'
-require_relative 'tasks/coveralls'
+# frozen_string_literal: true
 
-task :travis => :spec_with_coveralls
+require_relative 'tasks/dbms'

data/lib/schema_dev/templates.rb

@@ -1,14 +1,16 @@
+# frozen_string_literal: true
+
 require 'pathname'
 
 module SchemaDev
   module Templates
     def self.root
-      @root ||= Pathname.new(__FILE__).dirname.parent.parent + "templates"
+      @root ||= Pathname.new(__FILE__).dirname.parent.parent + 'templates'
     end
 
     def self.install_subtree(src:, dst:, bound: nil)
       src = root + src
-      Pathname.glob(src + "**/*").select(&:file?).each do |p|
+      Pathname.glob(src + '**/*').select(&:file?).each do |p|
         _install(p, dst + p.relative_path_from(src).sub_ext(''), bound)
       end
     end
@@ -20,7 +22,7 @@ module SchemaDev
     end
 
     def self._install(src, dst, bound)
-      src = Pathname(src.to_s + ".erb") unless src.file?
+      src = Pathname(src.to_s + '.erb') unless src.file?
       dst.sub_ext '' if dst.extname == '.erb'
       dst.dirname.mkpath
       dst.write process(src.read, bound: bound)
@@ -29,7 +31,5 @@ module SchemaDev
     def self.process(text, bound: nil)
       ERB.new(text).result(bound)
     end
-
-
   end
 end

data/lib/schema_dev/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SchemaDev
-  VERSION = "4.0.0"
+  VERSION = '4.1.0'
 end

data/lib/schema_dev.rb

@@ -1 +1,3 @@
-require "schema_dev/version"
+# frozen_string_literal: true
+
+require 'schema_dev/version'

data/schema_dev.gemspec

@@ -1,39 +1,36 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'schema_dev/version'
 
 Gem::Specification.new do |gem|
-  gem.name          = "schema_dev"
+  gem.name          = 'schema_dev'
   gem.version       = SchemaDev::VERSION
-  gem.authors       = ["ronen barzel"]
-  gem.email         = ["ronen@barzel.org"]
-  gem.summary       = %q{SchemaPlus development tools}
-  gem.description   = %q{SchemaPlus development tools}
-  gem.homepage      = "https://github.com/SchemaPlus/schema_dev"
-  gem.license       = "MIT"
+  gem.authors       = ['ronen barzel']
+  gem.email         = ['ronen@barzel.org']
+  gem.summary       = 'SchemaPlus development tools'
+  gem.description   = 'SchemaPlus development tools'
+  gem.homepage      = 'https://github.com/SchemaPlus/schema_dev'
+  gem.license       = 'MIT'
 
   gem.files         = `git ls-files -z`.split("\x0")
   gem.executables   = gem.files.grep(%r{^bin/}) { |f| File.basename(f) }
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
-  gem.require_paths = ["lib"]
+  gem.require_paths = ['lib']
 
-  gem.required_ruby_version = ">= 2.5.0"
+  gem.required_ruby_version = '>= 2.5.0'
 
-  gem.add_dependency "activesupport", ">= 5.2", "< 6.2"
-  gem.add_dependency "coveralls_reborn", "~> 0.23"
-  gem.add_dependency "faraday", "~> 0.9"
-  gem.add_dependency "fastandand", "~> 1.0"
-  gem.add_dependency "hash_keyword_args", "~> 0.1"
-  gem.add_dependency "its-it", "~> 1.3"
-  gem.add_dependency "key_struct", "~> 0.4"
-  gem.add_dependency "thor", "~> 0.19"
-  gem.add_dependency "which_works", "~> 1.0"
+  gem.add_dependency 'activesupport', '>= 5.2', '< 6.2'
+  gem.add_dependency 'faraday', '~> 1.0'
+  gem.add_dependency 'simplecov'
+  gem.add_dependency 'simplecov-lcov', '~> 0.8.0'
+  gem.add_dependency 'thor', '>= 0.19', '< 2.0'
+  gem.add_dependency 'which_works', '~> 1.0'
 
-  gem.add_development_dependency "bundler"
-  gem.add_development_dependency "rake", "~> 10.0"
-  gem.add_development_dependency "rspec", "~> 3.0"
-  gem.add_development_dependency "rspec-given", "~> 3.8"
-  gem.add_development_dependency "simplecov"
-  gem.add_development_dependency "webmock", "~> 2.1"
+  gem.add_development_dependency 'bundler'
+  gem.add_development_dependency 'rake', '~> 13.0'
+  gem.add_development_dependency 'rspec', '~> 3.0'
+  gem.add_development_dependency 'rspec-given', '~> 3.8'
+  gem.add_development_dependency 'webmock', '~> 3.0'
 end

data/spec/schema_dev/config_spec.rb

@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+
+describe SchemaDev::Config do
+  it 'computes matrix' do
+    config = get_config(ruby: %w[1.9.3 2.1.5], activerecord: %w[4.0 4.1], db: %w[sqlite3 postgresql])
+    expect(config.matrix).to match_array [
+      { ruby: '1.9.3', activerecord: '4.0', db: 'sqlite3' },
+      { ruby: '1.9.3', activerecord: '4.0', db: 'postgresql' },
+      { ruby: '1.9.3', activerecord: '4.1', db: 'sqlite3' },
+      { ruby: '1.9.3', activerecord: '4.1', db: 'postgresql' },
+      { ruby: '2.1.5', activerecord: '4.0', db: 'sqlite3' },
+      { ruby: '2.1.5', activerecord: '4.0', db: 'postgresql' },
+      { ruby: '2.1.5', activerecord: '4.1', db: 'sqlite3' },
+      { ruby: '2.1.5', activerecord: '4.1', db: 'postgresql' },
+    ]
+  end
+
+  it 'excludes explicit elements from matrix' do
+    config = get_config(ruby: %w[1.9.3 2.1.5], activerecord: %w[4.0 4.1], db: %w[sqlite3 postgresql],
+                        exclude: [
+                          { ruby: '1.9.3', activerecord: '4.1', db: 'postgresql' },
+                          { ruby: '2.1.5', activerecord: '4.0', db: 'sqlite3' }
+])
+    expect(config.matrix).to match_array [
+      { ruby: '1.9.3', activerecord: '4.0', db: 'sqlite3' },
+      { ruby: '1.9.3', activerecord: '4.0', db: 'postgresql' },
+      { ruby: '1.9.3', activerecord: '4.1', db: 'sqlite3' },
+      # { ruby: "1.9.3", activerecord: "4.1", db: "postgresql" },
+      # { ruby: "2.1.5", activerecord: "4.0", db: "sqlite3" },
+      { ruby: '2.1.5', activerecord: '4.0', db: 'postgresql' },
+      { ruby: '2.1.5', activerecord: '4.1', db: 'sqlite3' },
+      { ruby: '2.1.5', activerecord: '4.1', db: 'postgresql' },
+    ]
+  end
+
+  it 'excludes slices from matrix' do
+    config = get_config(ruby: %w[1.9.3 2.1.5], activerecord: %w[4.0 4.1], db: %w[sqlite3 postgresql],
+                        exclude: [
+                          { ruby: '1.9.3', activerecord: '4.1' },
+                          { ruby: '2.1.5', db: 'sqlite3' }
+])
+    expect(config.matrix).to match_array [
+      { ruby: '1.9.3', activerecord: '4.0', db: 'sqlite3' },
+      { ruby: '1.9.3', activerecord: '4.0', db: 'postgresql' },
+      #{ ruby: "1.9.3", activerecord: "4.1", db: "sqlite3" },
+      #{ ruby: "1.9.3", activerecord: "4.1", db: "postgresql" },
+      #{ ruby: "2.1.5", activerecord: "4.0", db: "sqlite3" },
+      { ruby: '2.1.5', activerecord: '4.0', db: 'postgresql' },
+      #{ ruby: "2.1.5", activerecord: "4.1", db: "sqlite3" },
+      { ruby: '2.1.5', activerecord: '4.1', db: 'postgresql' },
+    ]
+  end
+
+  it 'uses last cell for --quick' do
+    config = get_config(ruby: %w[1.9.3 2.1.5], activerecord: %w[4.0 4.1], db: %w[sqlite3 postgresql])
+    expect(config.matrix(quick: true)).to match_array [
+      { ruby: '2.1.5', activerecord: '4.1', db: 'postgresql' },
+    ]
+  end
+end

data/spec/schema_dev/gem_spec.rb

@@ -0,0 +1,74 @@
+# frozen_string_literal: true
+
+require 'schema_dev/gem'
+
+describe SchemaDev::Gem do
+  around(:each) do |example|
+    in_tmpdir do
+      suppress_stdout_stderr do
+        example.run
+      end
+    end
+  end
+
+  Given(:user_name) { 'My Name' }
+  Given(:user_email) { 'my_name@example.com' }
+
+  Given do
+    allow_any_instance_of(described_class).to receive(:`).with('git config user.name').and_return user_name
+    allow_any_instance_of(described_class).to receive(:`).with('git config user.email').and_return user_email
+  end
+
+  describe 'builds' do
+    Given do
+      stub_request(:get, 'https://rubygems.org/api/v1/versions/schema_plus_core.json').to_return body: JSON.generate([
+        { number: '1.0.0.pre', prerelease: true },
+        { number: '0.2.1' },
+        { number: '0.1.2' },
+        { number: '0.1.1' },
+      ])
+    end
+
+    When { described_class.build gem_name }
+
+    When(:gemspec) { File.read "#{gem_name}/#{gem_name}.gemspec" }
+    When(:readme) { File.read "#{gem_name}/README.md" }
+
+    Invariant { expect(readme).to include '<!-- These lines are auto-generated by schema_dev based on schema_dev.yml -->' }
+    Invariant { expect(readme).to include '<!-- These lines are auto-inserted from a schema_dev template -->' }
+
+    Invariant { expect(gemspec).to include "'schema_plus_core', '~> 0.2', '>= 0.2.1'" }
+    Invariant { expect(gemspec).to match %r{authors.*#{user_name}} }
+    Invariant { expect(gemspec).to match %r{email.*#{user_email}} }
+
+    context 'when a flat gem' do
+      Given(:gem_name) { 'new_gem' }
+      Then { expect(gemspec).to include "require 'new_gem/version'" }
+      Then { expect(File.read('new_gem/lib/new_gem.rb')).to include 'SchemaMonkey.register NewGem' }
+    end
+
+    context 'when a subdir gem' do
+      Given(:gem_name) { 'schema_plus_new_gem' }
+      Then { expect(gemspec).to include "require 'schema_plus/new_gem/version'" }
+      Then { expect(File.read('schema_plus_new_gem/lib/schema_plus_new_gem.rb')).to include "require_relative 'schema_plus/new_gem'" }
+      Then { expect(File.read('schema_plus_new_gem/lib/schema_plus/new_gem.rb')).to include 'SchemaMonkey.register SchemaPlus::NewGem' }
+    end
+  end
+
+  describe 'complains' do
+    context 'when no git user.name' do
+      Given(:user_name) { '' }
+      Then { expect { described_class.build('NewGem') }.to raise_error SystemExit, /who are you/i }
+    end
+
+    context 'when in git worktree' do
+      Given { expect_any_instance_of(described_class).to receive(:system).with(/^git rev-parse/).and_return true }
+      Then { expect { described_class.build('NewGem') }.to raise_error SystemExit, /\bgit\b/ }
+    end
+
+    context 'when gem directory exists' do
+      Given { FileUtils.touch 'new_gem' }
+      Then { expect { described_class.build('NewGem') }.to raise_error SystemExit, /exists/ }
+    end
+  end
+end

data/spec/schema_dev/gemfile_selector_spec.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+require 'schema_dev/gemfile_selector'
+
+describe SchemaDev::GemfileSelector do
+  it 'infers db from env' do
+    test_dbname = 'this_is_a_test'
+    ENV['BUNDLE_GEMFILE'] = described_class.gemfile(activerecord: '4.1', db: test_dbname).to_s
+    expect(described_class.infer_db).to eq test_dbname
+  end
+end

data/spec/schema_dev/gemfiles_spec.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+require 'schema_dev/gemfiles'
+
+describe SchemaDev::Gemfiles do
+  it 'copies listed files' do
+    config = get_config(ruby: %w[1.9.3 2.1.5], activerecord: %w[5.2 6.0], db: %w[sqlite3 postgresql])
+    in_tmpdir do
+      expect(described_class.build(config)).to be_truthy
+      expect(relevant_diff(config, 'gemfiles')).to be_empty
+    end
+  end
+
+  it 'only copies files once' do
+    config = get_config(ruby: %w[1.9.3 2.1.5], activerecord: %w[5.2 6.0], db: %w[sqlite3 postgresql])
+    in_tmpdir do
+      expect(described_class.build(config)).to be_truthy
+      expect(described_class.build(config)).to be_falsey
+    end
+  end
+
+  def relevant_diff(config, dir)
+    Dir.mktmpdir do |no_erb_root|
+      no_erb_root = Pathname(no_erb_root)
+      erb_root = SchemaDev::Templates.root + dir
+      Pathname.glob(erb_root + '**/*').select(&:file?).each do |p|
+        d = (no_erb_root + p.relative_path_from(erb_root)).sub_ext('')
+        d.dirname.mkpath
+        d.write p.read
+      end
+
+      diff = `diff -rq #{no_erb_root} #{dir} 2>&1`.split("\n")
+
+      # expect copy not to have entry for activerecord not in config
+      diff.reject! { |d| d =~ %r{Only in #{no_erb_root}: activerecord-(.*)} and not config.activerecord.include? $1 }
+
+      # expect copy not to have entry for db not in config
+      diff.reject! { |d| d =~ %r{Only in #{no_erb_root}.*: Gemfile.(.*)} and not config.db.include? $1 }
+    end
+  end
+end