scheduled_job 0.2.4 → 0.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 30677ced04a460d65fe090c92f6bf5b914d85d07
-  data.tar.gz: 8d5ecd3dbc01fcc33c52663d24123943192998a2
+  metadata.gz: e74d081e54d0af0a05929b690768698275473078
+  data.tar.gz: e4a12cc9089271971a3359a21cb056cc51c8e8fc
 SHA512:
-  metadata.gz: 746edac4b4b6c72f2281f7fe7fcc6d86d383867e398f43c54b03f0f92712cd4f0b907237dfae32d94157c8490bc276271ead90bae7d663a07e446561817028f2
-  data.tar.gz: 3ab1ba959f72642680b83b7c80b4e061a9f94efe38f445596789461a2a1523083b56d7a6267b4f8b7099c13fc079238cb3d7e7a481c9fb2703e684d6b069ddac
+  metadata.gz: f8a132116ecb9bf0a9be607a99a548abcea5e968579fc0ea0da10c61c5ab8913e5c06d390be4843aa205abd684b91fe822c21a6c3d61f9243ee3a436ee61b0db
+  data.tar.gz: eb0a87986ee873ce1aafc619f66a23a52af25e0e62f0b77040ea243b93a1426f37ea369a07fb951e51461e63d02f8dc2d4c1b380d1ae1519267f9119735b3efb

data/lib/scheduled_job.rb

@@ -98,10 +98,8 @@ module ScheduledJob
 
     def can_schedule_job?(job = nil)
       conditions = 'failed_at IS NULL'
-      unless job.blank?
-        conditions << " AND id != "
-        conditions << job.id
-      end
+      conditions << " AND id != #{job.id}" unless job.blank?
+
       jobs = Delayed::Job.where(conditions).find_all do |dj|
         dj.handler.split[1][/(?<=:)[A-Z][A-z0-9:]+/] == self.name
       end

data/spec/lib/scheduled_job_spec.rb

@@ -16,6 +16,12 @@ class UnderTest
   end
 end
 
+class Job
+  def id
+    12
+  end
+end
+
 class Test < UnderTest
 end
 
@@ -220,6 +226,10 @@ describe ScheduledJob do
     under_test.failure(dummy_job)
   end
 
+  it "can scheduled additional instances of a given job" do
+    expect { UnderTest.schedule_job(Job.new) }.not_to raise_error
+  end
+
   describe '#random_minutes' do
     it 'returns a random number with a base and delta' do
       expect(UnderTest.random_minutes(60, 10)).to be_within(10 * 60).of(60 * 60)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scheduled_job
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.2.5
 platform: ruby
 authors:
 - CallumD