scenic 1.4.1 → 1.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: b290ff753726250886a22d6d44016df9dbc430e2
-  data.tar.gz: b21216f75c821900f63a945d3b1776377782ab2c
+SHA256:
+  metadata.gz: b378292bd7d642dcd235d01f5a31d94c74065b798ab469a9c091f68e936f4d9c
+  data.tar.gz: b97f6e156685d4c03761543d5748f1381447c94cfcc42f7d6ddb8714e16791d0
 SHA512:
-  metadata.gz: ae4faa886ffb7206a3ecd393e35b8db14cc393512f10f03b459610c5e5adb10a4f932ebf7c255af421949180048cd137398065b25f593686f286f56e15bdaf7f
-  data.tar.gz: 3fd626600f95296defa7cd9caaad902d1b89c9007eb4b027d250dcb9866343f155db6dbf8c06b4aaa942e341a61710d255dbff75da1ba5dcd72c00b248a97515
+  metadata.gz: 4ffb0c73e52da5122a8ce3092b7f280d1a1dcaac9ca03a5f8ea63fe361d1b011d3c71f54706ff17d8ee1768fbdc1ba32c38bfebbcda320271e0b751eaea340f3
+  data.tar.gz: 846d53ffe8c0d0209ab6517c47e0447ee3b40a81e5f55f845f16a1b3f697cebd44ad38550a5fe8d10016ab19b3c1197f36ea9f3f5f7f42395a1431790684e0c1

data/.devcontainer/Dockerfile

@@ -0,0 +1,6 @@
+ARG VARIANT=2-bullseye
+FROM mcr.microsoft.com/vscode/devcontainers/ruby:0-${VARIANT}
+
+ENV RAILS_DEVELOPMENT_HOSTS=".githubpreview.dev"
+ENV POSTGRES_USER="postgres"
+ENV POSTGRES_PASSWORD="postgres"

data/.devcontainer/devcontainer.json

@@ -0,0 +1,11 @@
+{
+  "name": "Scenic Development",
+  "dockerComposeFile": "docker-compose.yml",
+  "service": "app",
+  "workspaceFolder": "/workspace",
+  "settings": { },
+  "extensions": ["rebornix.Ruby"],
+  "postCreateCommand": "bin/setup",
+  "remoteUser": "vscode",
+  "features": { "github-cli": "latest" }
+}

data/.devcontainer/docker-compose.yml

@@ -0,0 +1,24 @@
+version: '3'
+
+services:
+  app:
+    build:
+      context: ..
+      dockerfile: .devcontainer/Dockerfile
+      args:
+        VARIANT: "3"
+    volumes:
+      - ..:/workspace:cached
+    command: sleep infinity
+    network_mode: service:db
+  db:
+    image: postgres:latest
+    restart: unless-stopped
+    volumes:
+      - postgres-data:/var/lib/postgresql/data
+    environment:
+      POSTGRES_USER: postgres
+      POSTGRES_DB: postgres
+      POSTGRES_PASSWORD: postgres
+volumes:
+  postgres-data: null

data/.github/workflows/ci.yml

@@ -0,0 +1,71 @@
+name: CI
+
+on:
+  push:
+    branches: main
+  pull_request:
+    branches: "*"
+
+jobs:
+  build:
+    name: Ruby ${{ matrix.ruby }}, Rails ${{ matrix.rails }}
+
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby: ["2.7", "3.0", "3.1"]
+        rails: ["6.1", "7.0"]
+        continue-on-error: [false]
+
+    runs-on: ubuntu-latest
+
+    services:
+      postgres:
+        image: postgres
+        env:
+          POSTGRES_USER: "postgres"
+          POSTGRES_PASSWORD: "postgres"
+        ports:
+          - 5432:5432
+        options: >-
+          --health-cmd pg_isready
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 5
+
+    env:
+      RAILS_VERSION: ${{ matrix.rails }}
+      POSTGRES_USER: "postgres"
+      POSTGRES_PASSWORD: "postgres"
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Install Ruby ${{ matrix.ruby }}
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+
+      - name: Install dependent libraries
+        run: sudo apt-get install libpq-dev
+
+      - name: Generate lockfile
+        run: bundle lock
+
+      - name: Cache dependencies
+        uses: actions/cache@v1
+        with:
+          path: vendor/bundle
+          key: bundle-${{ hashFiles('Gemfile.lock') }}
+
+      - name: Set up Scenic
+        run: bin/setup
+
+      - name: Run fast tests
+        run: bundle exec rake spec
+        continue-on-error: ${{ matrix.continue-on-error }}
+
+      - name: Run acceptance tests
+        run: bundle exec rake spec:acceptance
+        continue-on-error: ${{ matrix.continue-on-error }}

data/.gitignore

@@ -17,3 +17,4 @@ test/version_tmp
 tmp
 gemfiles/*.lock
 .DS_Store
+.ruby-version

data/.hound.yml

@@ -1,4 +1,2 @@
-DotPosition:
-  EnforcedStyle: leading
-Style/AlignParameters:
-  EnforcedStyle: with_fixed_indentation
+rubocop:
+  config_file: .rubocop.yml

data/.rubocop.yml

@@ -0,0 +1,129 @@
+AllCops:
+  TargetRubyVersion: 2.3.0
+  Exclude:
+    - "tmp/**/*"
+    - "bin/*"
+    - "spec/dummy/**/*"
+
+Bundler/OrderedGems:
+  Enabled: false
+
+Gemspec/OrderedDependencies:
+  Enabled: false
+
+Layout/AlignParameters:
+  Enabled: true
+  EnforcedStyle: with_fixed_indentation
+Layout/ConditionPosition:
+  Enabled: false
+Layout/DotPosition:
+  EnforcedStyle: leading
+Layout/ExtraSpacing:
+  Enabled: true
+Layout/IndentAssignment:
+  Enabled: False
+Layout/MultilineOperationIndentation:
+  Enabled: true
+  EnforcedStyle: indented
+Layout/MultilineMethodCallIndentation:
+  Enabled: true
+  EnforcedStyle: indented
+
+Lint/AmbiguousOperator:
+  Enabled: true
+Lint/AmbiguousRegexpLiteral:
+  Enabled: true
+Lint/DuplicatedKey:
+  Enabled: true
+
+Metrics/ClassLength:
+  Enabled: false
+Metrics/ModuleLength:
+  Enabled: false
+Metrics/AbcSize:
+  Enabled: false
+Metrics/BlockLength:
+  CountComments: true  # count full line comments?
+  Max: 25
+  ExcludedMethods: []
+  Exclude:
+    - "spec/**/*"
+    - "*.gemspec"
+Metrics/CyclomaticComplexity:
+  Enabled: false
+Metrics/LineLength:
+  Max: 80
+Metrics/MethodLength:
+  Enabled: false
+
+Security/Eval:
+  Enabled: true
+  Exclude:
+    - "spec/scenic/schema_dumper_spec.rb"
+Style/BlockDelimiters:
+  Enabled: false
+Style/CollectionMethods:
+  Enabled: true
+  PreferredMethods:
+    find: find
+    inject: reduce
+    collect: map
+    find_all: select
+Style/ConditionalAssignment:
+  Enabled: false
+Style/ClassAndModuleChildren:
+  Enabled: true
+  Exclude:
+    - "spec/**/*"
+Style/Documentation:
+  Enabled: false
+Style/FrozenStringLiteralComment:
+  Description: >-
+    Add the frozen_string_literal comment to the top of files
+    to help transition from Ruby 2.3.0 to Ruby 3.0.
+  Enabled: false
+Style/GuardClause:
+  Enabled: false
+Style/IfUnlessModifier:
+  Enabled: false
+Style/Lambda:
+  Enabled: false
+Style/NumericLiterals:
+  Enabled: false
+Style/OneLineConditional:
+  Enabled: false
+Style/PercentLiteralDelimiters:
+  Enabled: false
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+  Enabled: true
+Style/TrailingCommaInArguments:
+  Description: 'Checks for trailing comma in argument lists.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas'
+  EnforcedStyleForMultiline: comma
+  SupportedStylesForMultiline:
+    - comma
+    - consistent_comma
+    - no_comma
+  Enabled: true
+Style/TrailingCommaInArrayLiteral:
+  Description: 'Checks for trailing comma in array literals.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas'
+  EnforcedStyleForMultiline: comma
+  SupportedStylesForMultiline:
+    - comma
+    - consistent_comma
+    - no_comma
+  Enabled: true
+Style/TrailingCommaInHashLiteral:
+  Description: 'Checks for trailing comma in hash literals.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas'
+  EnforcedStyleForMultiline: comma
+  SupportedStylesForMultiline:
+    - comma
+    - consistent_comma
+    - no_comma
+  Enabled: true
+Style/WordArray:
+  Enabled: false
+

data/{NEWS.md → CHANGELOG.md}

@@ -1,9 +1,107 @@
-# News
+# Changelog
 
 The noteworthy changes for each Scenic version are included here. For a complete
-changelog, see the [CHANGELOG] for each version via the version links.
+changelog, see the [commits] for each version via the version links.
 
-[CHANGELOG]: https://github.com/thoughtbot/scenic/commits/master
+[commits]: https://github.com/scenic-views/scenic/commits/master
+
+## [1.7.0] - December 8, 2022
+
+[1.7.0]: https://github.com/scenic-views/scenic/compare/v1.6.0...v1.7.0
+
+### Added
+
+* Added the `--replace` CLI flag to generate a migration that uses the
+  `replace_view` schema statement - *Dan Hixon*
+
+### Fixed
+
+* Fixed deprecation notice from newer versions of ERB when using scenic
+  generators - *Ali Ismayilov*
+
+## [1.6.0] - February 13, 2022
+
+[1.6.0]: https://github.com/scenic-views/scenic/compare/v1.5.5...v1.6.0
+
+### Fixed
+
+* Exclude pg_stat_statements_info (#349) 76bface - *Caleb Hearth*
+* Fix serialization of views with backslashes c625d1b - *Ben Sheldon*
+* Handle ActiveRecord table name prefix and suffix b1544dc - *Derek Prior*
+
+## [1.5.5] - December 15, 2021
+
+### Fixed
+
+- Fixed an issue reverting migrations under Ruby 3
+- Fixed an issue in index reapplication where sometimes `say` was undefined
+
+[1.5.5]: https://github.com/scenic-views/scenic/compare/v1.5.4...v1.5.5
+
+## [1.5.4] - September 16, 2020
+
+[1.5.4]: https://github.com/scenic-views/scenic/compare/v1.5.3...v1.5.4
+
+### Fixed
+
+- Added missing changelog for v1.5.3.
+
+## [1.5.3] - September 15, 2020
+
+[1.5.3]: https://github.com/scenic-views/scenic/compare/v1.5.2...v1.5.3
+
+### Fixed
+
+- `scenic-oracle_enhanced_adapter` has been pulled from rubygems.
+  `scenic-oracle_adapter` is a current, maintained alternative.
+- Updated code snippets - since Rails 5.0, all models inherit from
+  ApplicationRecord (#302)
+- Update Caleb's last name
+
+### Added
+
+- Add Security Policy
+
+## [1.5.2] - February 6, 2020
+
+### Fixed
+
+- The schema statement `create_view` is now reversible when passed a `version`
+  argument.
+- Calling `refresh_materialized_view` with both `concurrently` and `cascade` set
+  to `true` now correctly cascades the concurrent refresh to dependent views.
+- File generation and lookup now operates correctly for schema-qualified names
+  like `warehouse.archived_posts`.
+
+[1.5.2]: https://github.com/scenic-views/scenic/compare/v1.5.1...v1.5.2
+
+## [1.5.1] - February 10, 2019
+
+### Fixed
+
+- Passing `no_data: true` when creating a materialized view would error if the
+  corresponding SQL file had statement-terminating semicolon.
+
+[1.5.1]: https://github.com/scenic-views/scenic/compare/v1.5.0...v1.5.1
+
+## [1.5.0] - February 8, 2019
+
+### Added
+
+- `create_view` can now be passed `materialized: { no_data: true }` to create
+  the materialized view without populating it. Generators have been updated to
+  accept a `--no-data` option.
+
+### Fixed
+
+- Passing `cascade: true` when refreshing a materialized view will no longer
+  error when the view in question has no dependencies.
+- Fixed runtime deprecation warnings when using `pg` 0.21 and newer.
+- Fixed a cascading refresh issue when the name of the view to trigger the
+  refresh is a substring of one of its dependencies.
+
+
+[1.5.0]: https://github.com/scenic-views/scenic/compare/v1.4.1...v1.5.0
 
 ## [1.4.1] - December 15, 2017
 
@@ -12,7 +110,7 @@ changelog, see the [CHANGELOG] for each version via the version links.
 - View migrations created under Rails 5 and newer will use the current migration
   version in the generated migration class rather than always using `5.0`.
 
-[1.4.1]: https://github.com/thoughtbot/scenic/compare/v1.4.0...v1.4.1
+[1.4.1]: https://github.com/scenic-views/scenic/compare/v1.4.0...v1.4.1
 
 ## [1.4.0] - May 11, 2017
 
@@ -32,7 +130,7 @@ changelog, see the [CHANGELOG] for each version via the version links.
   and newer apps.
 - Using the `scenic:model` generator will no longer create a fixture or factory.
 
-[1.4.0]: https://github.com/thoughtbot/scenic/compare/v1.3.0...v1.4.0
+[1.4.0]: https://github.com/scenic-views/scenic/compare/v1.3.0...v1.4.0
 
 ## [1.3.0] - May 27, 2016
 
@@ -48,7 +146,7 @@ changelog, see the [CHANGELOG] for each version via the version links.
   attempt to insert model code into the pluralized model file.
 * Convert shell-based smoke tests to RSpec syntax.
 
-[1.3.0]: https://github.com/thoughtbot/scenic/compare/v1.2.0...v1.3.0
+[1.3.0]: https://github.com/scenic-views/scenic/compare/v1.2.0...v1.3.0
 
 ## [1.2.0] - February 5, 2016
 
@@ -68,7 +166,7 @@ changelog, see the [CHANGELOG] for each version via the version links.
 `db/schema.rb` file  under Rails 5 beta 1 and beta 2. This is fixed on Rails
 master.
 
-[1.2.0]: https://github.com/thoughtbot/scenic/compare/v1.1.1...v1.2.0
+[1.2.0]: https://github.com/scenic-views/scenic/compare/v1.1.1...v1.2.0
 
 ## [1.1.1] - January 29, 2016
 
@@ -77,7 +175,7 @@ master.
   closed` error. This has been fixed by ensuring we grab a fresh connection for
   all operations.
 
-[1.1.1]: https://github.com/thoughtbot/scenic/compare/v1.1.0...v1.1.1
+[1.1.1]: https://github.com/scenic-views/scenic/compare/v1.1.0...v1.1.1
 
 ## [1.1.0] - January 8, 2016
 
@@ -97,7 +195,7 @@ master.
 - Fixed inability to dump materialized views in Rails 5.0.0.beta1.
 
 [supported versions of Postgres]: http://www.postgresql.org/support/versioning/
-[1.1.0]: https://github.com/thoughtbot/scenic/compare/v1.0.0...v1.1.0
+[1.1.0]: https://github.com/scenic-views/scenic/compare/v1.0.0...v1.1.0
 
 ## [1.0.0] - November 23, 2015
 
@@ -112,8 +210,8 @@ master.
 - Eliminated `alias_method_chain` deprecation when running with Rails master
   (5.0).
 
-[materialized views]:https://github.com/thoughtbot/scenic/blob/v1.0.0/README.md
-[1.0.0]: https://github.com/thoughtbot/scenic/compare/v0.3.0...v1.0.0
+[materialized views]:https://github.com/scenic-views/scenic/blob/v1.0.0/README.md
+[1.0.0]: https://github.com/scenic-views/scenic/compare/v0.3.0...v1.0.0
 
 ## [0.3.0] - January 23, 2015
 
@@ -125,14 +223,14 @@ master.
 - We avoid dumping views that belong to Postgres extensions.
 - `db/schema.rb` is prettier thanks to a blank line after each view definition.
 
-[0.3.0]: https://github.com/thoughtbot/scenic/compare/v0.2.1...v0.3.0
+[0.3.0]: https://github.com/scenic-views/scenic/compare/v0.2.1...v0.3.0
 
 ## [0.2.1] - January 5, 2015
 
 ### Fixed
 - View generator will now create `db/views` directory if necessary.
 
-[0.2.1]: https://github.com/thoughtbot/scenic/compare/v0.2.0...v0.2.1
+[0.2.1]: https://github.com/scenic-views/scenic/compare/v0.2.0...v0.2.1
 
 ## [0.2.0] - August 11, 2014
 
@@ -142,7 +240,7 @@ master.
 ### Fixed
 - Raise an error if view definition is empty.
 
-[0.2.0]: https://github.com/thoughtbot/scenic/compare/v0.1.0...v0.2.0
+[0.2.0]: https://github.com/scenic-views/scenic/compare/v0.1.0...v0.2.0
 
 ## [0.1.0] - August 4, 2014
 
@@ -155,4 +253,4 @@ definition files.
 
 In short, go add a view to your app.
 
-[0.1.0]: https://github.com/thoughtbot/scenic/compare/8599daa132880cd6c07efb0395c0fb023b171f47...v0.1.0
+[0.1.0]: https://github.com/scenic-views/scenic/compare/8599daa132880cd6c07efb0395c0fb023b171f47...v0.1.0

data/CODE_OF_CONDUCT.md

@@ -0,0 +1,76 @@
+# Contributor Covenant Code of Conduct
+
+## Our Pledge
+
+In the interest of fostering an open and welcoming environment, we as
+contributors and maintainers pledge to making participation in our project and
+our community a harassment-free experience for everyone, regardless of age, body
+size, disability, ethnicity, sex characteristics, gender identity and
+expression, level of experience, education, socio-economic status, nationality,
+personal appearance, race, religion, or sexual identity and orientation.
+
+## Our Standards
+
+Examples of behavior that contributes to creating a positive environment
+include:
+
+* Using welcoming and inclusive language
+* Being respectful of differing viewpoints and experiences
+* Gracefully accepting constructive criticism
+* Focusing on what is best for the community
+* Showing empathy towards other community members
+
+Examples of unacceptable behavior by participants include:
+
+* The use of sexualized language or imagery and unwelcome sexual attention or
+  advances
+* Trolling, insulting/derogatory comments, and personal or political attacks
+* Public or private harassment
+* Publishing others' private information, such as a physical or electronic
+  address, without explicit permission
+* Other conduct which could reasonably be considered inappropriate in a
+  professional setting
+
+## Our Responsibilities
+
+Project maintainers are responsible for clarifying the standards of acceptable
+behavior and are expected to take appropriate and fair corrective action in
+response to any instances of unacceptable behavior.
+
+Project maintainers have the right and responsibility to remove, edit, or
+reject comments, commits, code, wiki edits, issues, and other contributions
+that are not aligned to this Code of Conduct, or to ban temporarily or
+permanently any contributor for other behaviors that they deem inappropriate,
+threatening, offensive, or harmful.
+
+## Scope
+
+This Code of Conduct applies both within project spaces and in public spaces
+when an individual is representing the project or its community. Examples of
+representing a project or community include using an official project e-mail
+address, posting via an official social media account, or acting as an appointed
+representative at an online or offline event. Representation of a project may be
+further defined and clarified by project maintainers.
+
+## Enforcement
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be
+reported by contacting the project team at derekprior@gmail.com. All complaints
+will be reviewed and investigated and will result in a response that is deemed
+necessary and appropriate to the circumstances. The project team is obligated to
+maintain confidentiality with regard to the reporter of an incident. Further
+details of specific enforcement policies may be posted separately.
+
+Project maintainers who do not follow or enforce the Code of Conduct in good
+faith may face temporary or permanent repercussions as determined by other
+members of the project's leadership.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage],
+version 1.4, available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html
+
+[homepage]: https://www.contributor-covenant.org
+
+For answers to common questions about this code of conduct, see
+https://www.contributor-covenant.org/faq

data/CONTRIBUTING.md

@@ -1,24 +1,22 @@
 # Contributing
 
 We love contributions from everyone.  By participating in this project, you
-agree to abide by the thoughtbot [code of conduct].
+agree to abide by our [code of conduct].
 
-[code of conduct]: https://thoughtbot.com/open-source-code-of-conduct
-
-We expect everyone to follow the code of conduct anywhere in thoughtbot's
-project codebases, issue trackers, chatrooms, and mailing lists.
+[code of conduct]: CODE_OF_CONDUCT.md
 
 ## Contributing Code
 
 1. Fork the repository.
 2. Run `bin/setup`, which will install dependencies and create the dummy
    application database.
-3. Run `bin/appraisal rake` to verify that the tests pass against all
-   supported versions of Rails.
-4. Make your change with new passing tests, following the [style guide].
+3. Run `rake` to verify that the tests pass against the version of Rails you are
+   running locally.
+4. Make your change with new passing tests, following existing style.
 5. Write a [good commit message], push your fork, and submit a pull request.
+6. CI will run the test suite on all configured versions of Ruby and Rails.
+   Address any failures.
 
-[style guide]: https://github.com/thoughtbot/guides/tree/master/style
 [good commit message]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
 
 Others will give constructive feedback.  This is a time for discussion and

data/Gemfile

@@ -1,4 +1,16 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 # Specify your gem's dependencies in scenic.gemspec
 gemspec
+
+rails_version = ENV.fetch("RAILS_VERSION", "6.1")
+
+if rails_version == "master"
+  rails_constraint = { github: "rails/rails" }
+else
+  rails_constraint = "~> #{rails_version}.0"
+end
+
+gem "rails", rails_constraint
+gem "sprockets", "< 4.0.0"
+gem "pg", "~> 1.1"

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2014-2016 Derek Prior, Caleb Thompson, and thoughtbot.
+Copyright (c) 2014-2020 Derek Prior, Caleb Hearth, and thoughtbot.
 
 MIT License