scenic 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d42b1d2b3e1f8fd304e1f6ba852a0cc54b6727b6
-  data.tar.gz: 3a84ebfd4b1a34ad03a68f232961c6381107cd74
+  metadata.gz: b88bfc7421d9fff9dabb78192437422bff78a008
+  data.tar.gz: 707fd7687db5ad21240ee8d3f0b8eafa16db4b01
 SHA512:
-  metadata.gz: e67ff566304f93fd0c70a6c4968d2551ea9a82c3111f9f8a95f4b1dbc4e43a3f7233d9b71fc0551b8ffd806f78c5967bbd43d7b0a3783a80cc1da68b99edd041
-  data.tar.gz: 8b19e9f8e3e93142a57c15ec0f191abeab1278395bb6a09fc9face3908e8039a58cc1704d32cbecb834f966f355a6b98256ed8d2ba0727e4209efe6c83cb52e9
+  metadata.gz: d1dc5196a72602f964093cbbd1b2976de5d31d73f887e8d21b8938262b6b15cffdc8e536073a482cb988da653d022be850f052727bc62d932738676d4ca42a4a
+  data.tar.gz: 0ef40094617d1adde567078bc066887afb92ae3102925358450a05bd3a4beafd05f7d116929ccbcc25577337bdcdb437abf92cd5bd4a9855ef2b47f0daf28333

data/NEWS.md

@@ -5,6 +5,15 @@ changelog, see the [CHANGELOG] for each version via the version links.
 
 [CHANGELOG]: https://github.com/thoughtbot/scenic/commits/master
 
+## [1.1.1] - January 29, 2016
+
+### Fixed
+- Some schema operations were failing with a `PG::ConnectionBad: connection is
+  closed` error. This has been fixed by ensuring we grab a fresh connection for
+  all operations.
+
+[1.1.1]: https://github.com/thoughtbot/scenic/compare/v1.1.0...v1.1.1
+
 ## [1.1.0] - January 8, 2016
 
 ### Added

data/README.md

@@ -151,15 +151,18 @@ end
 
 ## FAQs
 
-**When I query a view-backed model with `find` I get an error. What gives?**
+**Why do I get an error when querying a view-backed model with `find`, `last`, or `first`?**
 
-Your view cannot have a primary key, but ActiveRecord's `find` method expects to
-query based on one. You can use `find_by!` or you can explicitly set the primary
-key column on your model like so:
+ActiveRecord's `find` method expects to query based on your model's primary key,
+but views do not have primary keys. Additionally, the `first` and `last` methods
+will produce queries that attempt to sort based on the primary key.
+
+You can get around these issues by setting the primary key column on your Rails
+model like so:
 
 ```ruby
 class People < ActiveRecord::Base
-  self.primary_key = :id
+  self.primary_key = :my_unique_identifier_field
 end
 ```
 

data/lib/scenic/adapters/postgres.rb

@@ -27,15 +27,15 @@ module Scenic
       # {Scenic.configure} is not required, but the example below shows how one
       # would explicitly set it.
       #
-      # @param connection The database connection the adapter should use. This
-      #   defaults to `ActiveRecord::Base.connection`
+      # @param [#connection] connectable An object that returns the connection
+      #   for Scenic to use. Defaults to `ActiveRecord::Base`.
       #
       # @example
       #  Scenic.configure do |config|
       #    config.adapter = Scenic::Adapters::Postgres.new
       #  end
-      def initialize(connection = ActiveRecord::Base.connection)
-        @connection = Connection.new(connection)
+      def initialize(connectable = ActiveRecord::Base)
+        @connectable = connectable
       end
 
       # Returns an array of views in the database.
@@ -183,9 +183,13 @@ module Scenic
 
       private
 
-      attr_reader :connection
+      attr_reader :connectable
       delegate :execute, :quote_table_name, to: :connection
 
+      def connection
+        Connection.new(connectable.connection)
+      end
+
       def raise_unless_materialized_views_supported
         unless connection.supports_materialized_views?
           raise MaterializedViewsNotSupportedError

data/lib/scenic/version.rb

@@ -1,3 +1,3 @@
 module Scenic
-  VERSION = "1.1.0"
+  VERSION = "1.1.1"
 end

data/spec/scenic/adapters/postgres_spec.rb

@@ -29,7 +29,8 @@ module Scenic
 
         it "raises an exception if the version of PostgreSQL is too old" do
           connection = double("Connection", supports_materialized_views?: false)
-          adapter = Postgres.new(connection)
+          connectable = double("Connectable", connection: connection)
+          adapter = Postgres.new(connectable)
           err = Scenic::Adapters::Postgres::MaterializedViewsNotSupportedError
 
           expect { adapter.create_materialized_view("greetings", "select 1") }
@@ -63,7 +64,8 @@ module Scenic
 
         it "raises an exception if the version of PostgreSQL is too old" do
           connection = double("Connection", supports_materialized_views?: false)
-          adapter = Postgres.new(connection)
+          connectable = double("Connectable", connection: connection)
+          adapter = Postgres.new(connectable)
           err = Scenic::Adapters::Postgres::MaterializedViewsNotSupportedError
 
           expect { adapter.drop_materialized_view("greetings") }
@@ -74,7 +76,8 @@ module Scenic
       describe "#refresh_materialized_view" do
         it "raises an exception if the version of PostgreSQL is too old" do
           connection = double("Connection", supports_materialized_views?: false)
-          adapter = Postgres.new(connection)
+          connectable = double("Connectable", connection: connection)
+          adapter = Postgres.new(connectable)
           err = Scenic::Adapters::Postgres::MaterializedViewsNotSupportedError
 
           expect { adapter.refresh_materialized_view(:tests) }
@@ -93,7 +96,8 @@ module Scenic
 
           it "raises an exception if the version of PostgreSQL is too old" do
             connection = double("Connection", postgresql_version: 90300)
-            adapter = Postgres.new(connection)
+            connectable = double("Connectable", connection: connection)
+            adapter = Postgres.new(connectable)
             e = Scenic::Adapters::Postgres::ConcurrentRefreshesNotSupportedError
 
             expect {

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scenic
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Derek Prior
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-20 00:00:00.000000000 Z
+date: 2016-01-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: appraisal
@@ -282,7 +282,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Support for database views in Rails migrations