scenic 0.2.1 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 12cc4c93551c150598dd616a1174245760aac19e
-  data.tar.gz: b108ebf2b5d3b3e4d2d3e70410233773ce09481d
+  metadata.gz: e917734f36443e8d261a50f8bcef5c5e65eeebda
+  data.tar.gz: d013d537a689625087039b4d6cb2e54a584c73ca
 SHA512:
-  metadata.gz: be0ede1893de56e1b53309b4cb8bdb035e9e03b573252390214a448c85a6d8bb6e9cd3b0f85a3b0bb8438442497dd24c29a959e6429e74e7fe9e0a272cefc09d
-  data.tar.gz: c4753f41f39bb769246e6793e426a63e899bc0873f74b685dd6644755a6fabc4e6ab4edfe996bd1c631e3735d44c4ab5826daa73b73073191a73091a6a2867e0
+  metadata.gz: be0c588362c95ab41cf71670954569c6c06e8ff7e7ef5b2a27b23b32eb61dc86ea8e13e3a969c7596ca9d55a86d2f8c9999486ecfdcac025dc70cbca81cddbb7
+  data.tar.gz: d1b4171587355aef488df5ebc9d998da4eaa690baf3e8aad2a6ca9ab6db1b11a4bbe1ac07c43c2c9305b5761b43d24298c983cdf1129e795488d1b035cb0daf8

data/.travis.yml

@@ -4,16 +4,16 @@ before_install:
   - git config --global user.name 'Travis CI'
   - git config --global user.email 'travis-ci@example.com'
 before_script:
-  - pushd spec/dummy && bundle exec rake db:create && popd
+  - pushd spec/dummy && bundle exec rake db:create && mkdir db/views && popd
 branches:
   only:
     - master
-cache:
-  - bundler
 language:
   - ruby
 notifications:
   email:
     - false
 rvm:
-  - 2.1.1
+  - 2.1.5
+  - 2.2.0
+sudo: false

data/NEWS.md

@@ -1,3 +1,9 @@
+New in 0.3.0 (January 23, 2015)
+* Previous view definition is copied into new view definition file when updating
+  an existing view.
+* We avoid dumping views that belong to Postgres extensions
+* `db/schema.rb` is prettier thanks to a blank line after each view definition.
+
 New in 0.2.1
 * View generator will now create `db/views` directory if necessary
 

data/lib/generators/scenic/view/view_generator.rb

@@ -14,7 +14,11 @@ module Scenic
       end
 
       def create_view_definition
-        create_file definition.path
+        if creating_new_view?
+          create_file definition.path
+        else
+          copy_file previous_definition.full_path, definition.full_path
+        end
       end
 
       def create_migration_file
@@ -74,6 +78,10 @@ module Scenic
         Scenic::Definition.new(plural_file_name, version)
       end
 
+      def previous_definition
+        Scenic::Definition.new(plural_file_name, previous_version)
+      end
+
       def destroying?
         behavior == :revoke
       end

data/lib/scenic/adapters/postgres.rb

@@ -6,6 +6,7 @@ module Scenic
           SELECT viewname, definition
           FROM pg_views
           WHERE schemaname = ANY (current_schemas(false))
+          AND viewname NOT IN (SELECT extname FROM pg_extension)
         SQL
       end
 

data/lib/scenic/version.rb

@@ -1,3 +1,3 @@
 module Scenic
-  VERSION = "0.2.1"
+  VERSION = "0.3.0"
 end

data/lib/scenic/view.rb

@@ -18,6 +18,7 @@ module Scenic
         create_view :#{name}, sql_definition:<<-\SQL
           #{definition}
         SQL
+
       DEFINITION
     end
   end

data/spec/generators/scenic/view/view_generator_spec.rb

@@ -13,14 +13,14 @@ describe Scenic::Generators::ViewGenerator, :generator do
   end
 
   it "updates an existing view" do
-    migration = file("db/migrate/update_searches_to_version_2.rb")
-    view_definition = file("db/views/searches_v02.sql")
-    allow(Dir).to receive(:entries)
-      .and_return(["searches_v01.sql"])
+    with_view_definition("searches", 1, "hello") do
+      migration = file("db/migrate/update_searches_to_version_2.rb")
+      view_definition = file("db/views/searches_v02.sql")
 
-    run_generator ["search"]
+      run_generator ["search"]
 
-    expect(migration).to be_a_migration
-    expect(view_definition).to exist
+      expect(migration).to be_a_migration
+      expect(view_definition).to exist
+    end
   end
 end

data/spec/smoke

@@ -30,7 +30,9 @@ writeToFileAndMigrateAndVerifySearchResults() {
 	echo "write search definition and migrate"
 	local version=$1
 	local expectedResult=$2
-	echo "SELECT '$expectedResult'::text AS results" >> db/views/searches_v$version\.sql
+	local filePath=db/views/searches_v$version\.sql
+	cp /dev/null $filePath
+	echo "SELECT '$expectedResult'::text AS results" >> $filePath
 	rake db:migrate
 	echo "[success]"
 	verifySearchResults $expectedResult
@@ -50,6 +52,7 @@ main() {
 	echo "rails generate scenic:view search (to get updates search view)"
 	rails generate scenic:view search
 	[[ -f db/views/searches_v02.sql ]] || exit 1
+	cmp db/views/searches_v01.sql db/views/searches_v02.sql || exit 1
 	[[ -n "$(find db/migrate -maxdepth 1 -name "*update_searches_to_version_2.rb" -print -quit)" ]] || exit 1
 	echo "[success]"
 

data/spec/support/generator_spec_setup.rb

@@ -4,7 +4,10 @@ require "ammeter/init"
 
 RSpec.configure do |config|
   config.before(:example, :generator) do
-    destination File.expand_path("../../../tmp", __FILE__)
+    fake_rails_root = File.expand_path("../../../tmp", __FILE__)
+    allow(Rails).to receive(:root).and_return(Pathname.new(fake_rails_root))
+
+    destination fake_rails_root
     prepare_destination
   end
 end

data/spec/support/view_definition_helpers.rb

@@ -1,9 +1,10 @@
 module ViewDefinitionHelpers
   def with_view_definition(name, version, schema)
     definition = Scenic::Definition.new(name, version)
+    FileUtils.mkdir_p(File.dirname(definition.full_path))
     File.open(definition.full_path, "w") { |f| f.write(schema) }
     yield
   ensure
-    File.delete definition.full_path
+    FileUtils.rm_f(definition.full_path)
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scenic
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0
 platform: ruby
 authors:
 - Derek Prior
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-05 00:00:00.000000000 Z
+date: 2015-01-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -250,3 +250,4 @@ test_files:
 - spec/spec_helper.rb
 - spec/support/generator_spec_setup.rb
 - spec/support/view_definition_helpers.rb
+has_rdoc: