scenic-oracle_adapter 1.3.4 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 453bc175d2fa922a314a781064fb63a6415dc3be36aa096baa9d52c77f1542ed
-  data.tar.gz: 3d5ed519bc3ce673c934bc32d310b298c8d525e12fd089abf8a1201674036d4e
+  metadata.gz: c60d517a9dc52283f5d2706a11f0a6c9b9107e5963a4c29a7fa0a3028007cd94
+  data.tar.gz: 6e8adf1e2bc80e2ebd47cb3d05e441b6edc507163402936cc2c394a3bf2fca08
 SHA512:
-  metadata.gz: cb0722b1989112a9b5f48c7fdbd7b303d4fd7baf5b577dc002bcd9d174e795b120715b725ffdd72cc562f7522b09a9eea13cc8e4984dccd53d929bdea2b1b0c4
-  data.tar.gz: df2366ae4965f197b205f7148ecef307f17695f3c05815b17ee681bf230b53c2bb1edfc7831b854d590022422fbfc42c3ce00e526ff7d14f719ecc8399ae5ce6
+  metadata.gz: 7b2a487534bb336fa2a185ecda1d02e18173ff724416a3fd0d5dfd61d452d51ce9d9e8cfa5163851388799a00a649d98fc24b1980715619e6507fe1428771067
+  data.tar.gz: 03ba13f1414657cd3bff98cb2fd295a4ccf4e5813b48a0b11c04d21c3ba8ecdc26791bea1956488ece581461297e09b13c6ec2beb88fa1749ad7fa896e2a2e4b

data/.github/workflows/ci.yml

@@ -13,4 +13,4 @@ jobs:
     steps:
     - uses: actions/checkout@v2
     - name: Run tests
-      run: docker-compose run gem rspec
+      run: docker compose run gem rspec

data/CHANGELOG.md

@@ -0,0 +1,81 @@
+# Changelog
+
+## v1.4.0 - June 30, 2025
+
+- Use scenic 1.9.0
+- Reduce churn in schema.rb by topologically sorting dumped views
+- Raise SideBySideNotSupportedError when Scenic's side_by_side mode is attempted
+
+## v1.3.5 - Oct 9, 2024
+
+- Silence ActiveRecord output while running specs. Clean green dots! (@eeklund, @dlagerro)
+- Fix growing indentation issue in schema.rb after `schema:dump`/`schema:load` (@eeklund, @dlagerro)
+
+## v1.3.4 - Jul 22, 2024
+
+- Fixes a syntax issue in pre-3.1 rubies
+- Fixes SchemaDumper error when all view objects aren't present in Oracle's user_dependencies
+- Reduce git churn in schema.rb by ordering views before they're handed to SchemaDumper
+- Strip newlines and trailing semicolons from view definitions
+
+## v1.3.3  - Jul 18, 2024
+
+- Fixes an issue with dependency sorting where mviews will sometimes be classified as a tables in user_dependencies (@whit0694)
+
+## v1.3.2 - Jul 3, 2024
+
+- Fixes a bug in the dependency-ordered views logic when Scenic views depend on external objects (@whit0694)
+
+## v1.3.1 - Jul 3, 2024
+
+- Ensures views in schema.rb are correctly ordered based on dependencies
+
+## v1.3.0 - Mar 29, 2024
+
+- Update to scenic version 1.8.0
+- Adds support for the #populated? model method
+
+## v1.2.2 - Apr 27, 2023
+
+- This fixes the botched publishing of 1.2.1 (#14).
+- The 1.2.1 gem file that was published to rubygems.org didn't contain any source code in the tarball. It was yanked and replaced with 1.2.2.
+
+## v1.2.1 - Apr 20, 2023
+
+- Fixes a bug where update_view fails on materialized views (#13)
+
+## v1.2.0 - Dec 16, 2022
+
+- Update to scenic version 1.7.0
+- Update Oracle docker container to 21 XE for testing and local development
+
+## v1.1.1 - Sep 10, 2021
+
+- Fixes issue with schema dumping in pre-1.7.0 versions of activerecord-oracle_enhanced-adapter.
+
+## v1.1.0 - Apr 23, 2021
+
+- Added support for unpopulated materialized views (build deferrred) via scenic's no_data option.
+- Move CI from Travis CI to Github Actions.
+
+## v1.0.3 - Apr 22, 2021
+
+- Update scenic dependency to 1.5.4 to provide support for Ruby 3
+
+## v1.0.2 - May 11, 2020
+
+- Remove ruby-oci as a direct dependency for jruby users (it was moved to a development dependency)
+- Drop ruby 2.4 from the CI matrix. 2.4 is no longer supported.
+
+## v1.0.1 - Apr 7, 2020
+
+- Update rake development dependency to address CVE-2020-8130
+- Default to docker/docker-compose for development and specs
+
+## v1.0.0 - Nov 25, 2018
+
+- This release adds cascading materialized view refreshes.
+
+## v0.2.0 Pre-release - Oct 24, 2018
+
+- Initial release with feature parity with Scenic::Adapters::Postgres with the exception of cascading materialized view refreshes.

data/Dockerfile

@@ -1,4 +1,4 @@
-FROM ghcr.io/cdinger/oracle-ruby:3.3
+FROM ghcr.io/cdinger/oracle-ruby:3.4
 
 RUN mkdir /app
 WORKDIR /app

data/Gemfile

@@ -1,6 +1,6 @@
 source "https://rubygems.org"
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
+gem "activerecord-oracle_enhanced-adapter", ">= 1.5.0"
 
 # Specify your gem's dependencies in scenic-oracle_adapter.gemspec
 gemspec

data/lib/scenic/adapters/oracle/railtie.rb

@@ -1,17 +1,25 @@
 # frozen_string_literal: true
 
 require "rails/railtie"
-require "active_record/connection_adapters/oracle_enhanced_adapter"
 
 module Scenic
   module Adapters
     class Oracle
       class Railtie < Rails::Railtie
         ActiveSupport.on_load(:active_record) do
-          if defined?(ActiveRecord::ConnectionAdapters::OracleEnhancedSchemaDumper)
-            ActiveRecord::ConnectionAdapters::OracleEnhancedSchemaDumper.prepend Scenic::SchemaDumper
-          else
-            ActiveRecord::ConnectionAdapters::OracleEnhanced::SchemaDumper.prepend Scenic::SchemaDumper
+          if Scenic::Adapters::Oracle.uses_oracle_enhanced_adapter?
+            require "active_record/connection_adapters/oracle_enhanced_adapter"
+
+            if defined?(ActiveRecord::ConnectionAdapters::OracleEnhancedSchemaDumper)
+              ActiveRecord::ConnectionAdapters::OracleEnhancedSchemaDumper.prepend Scenic::SchemaDumper
+            else
+              ActiveRecord::ConnectionAdapters::OracleEnhanced::SchemaDumper.prepend Scenic::SchemaDumper
+            end
+          end
+          if Scenic::Adapters::Oracle.uses_oracle_adapter?
+            require "active_record/connection_adapters/oracle_adapter"
+
+            ActiveRecord::ConnectionAdapters::Oracle::SchemaDumper.prepend Scenic::SchemaDumper
           end
         end
       end

data/lib/scenic/adapters/oracle.rb

@@ -3,11 +3,14 @@
 require_relative "oracle/index_reapplication"
 require_relative "oracle/indexes"
 require_relative "oracle/refresh_dependencies"
+require "active_support/core_ext/string/strip"
 require "tsortable_hash"
 
 module Scenic
   module Adapters
     class Oracle
+      class SideBySideNotSupportedError < StandardError; end
+
       def initialize(connectable = ActiveRecord::Base)
         @connectable = connectable
       end
@@ -37,10 +40,14 @@ module Scenic
         execute("create materialized view #{quote_table_name(name)} #{'build deferred' if no_data} as #{trimmed_definition(definition)}")
       end
 
-      def update_materialized_view(name, definition, no_data: false)
-        IndexReapplication.new(connection: connection).on(name) do
-          drop_materialized_view(name)
-          create_materialized_view(name, definition, no_data: no_data)
+      def update_materialized_view(name, definition, no_data: false, side_by_side: false)
+        if side_by_side
+          raise SideBySideNotSupportedError.new("Renaming materialized view is not supported in Oracle")
+        else
+          IndexReapplication.new(connection: connection).on(name) do
+            drop_materialized_view(name)
+            create_materialized_view(name, definition, no_data: no_data)
+          end
         end
       end
 
@@ -66,6 +73,18 @@ module Scenic
       delegate :connection, to: :@connectable
       delegate :select_all, :select_value, :execute, :quote_table_name, to: :connection
 
+      def self.file_exists_in_load_path?(filename)
+        $LOAD_PATH.any? { |path| File.exist?(File.join(path, filename)) }
+      end
+
+      def self.uses_oracle_enhanced_adapter?
+        file_exists_in_load_path?("active_record/connection_adapters/oracle_enhanced_adapter.rb")
+      end
+
+      def self.uses_oracle_adapter?
+        file_exists_in_load_path?("active_record/connection_adapters/oracle_adapter.rb")
+      end
+
       private
 
       def view_dependencies
@@ -138,7 +157,7 @@ module Scenic
       end
 
       def trimmed_definition(sql)
-        sql.strip.sub(/;$/, "").strip
+        sql.rstrip.sub(/;$/, "").rstrip.strip_heredoc
       end
     end
   end

data/lib/scenic/oracle_adapter/version.rb

@@ -2,6 +2,6 @@
 
 module Scenic
   module OracleAdapter
-    VERSION = "1.3.4"
+    VERSION = "1.4.0"
   end
 end

data/lib/scenic/oracle_adapter.rb

@@ -1,6 +1,9 @@
 # frozen_string_literal: true
 
 require "active_record"
+# Require tsort here before scenic to avoid:
+# uninitialized constant Scenic::Adapters::Postgres::Views::TSortableHash::TSort
+require "tsort"
 require "scenic"
 require "scenic/oracle_adapter/version"
 require "scenic/adapters/oracle"

data/scenic-oracle_adapter.gemspec

@@ -22,8 +22,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "scenic", "= 1.8.0"
-  spec.add_dependency "activerecord-oracle_enhanced-adapter", ">= 1.5.0"
+  spec.add_dependency "scenic", "= 1.9.0"
 
   spec.add_development_dependency "bundler", "~> 2.0"
   spec.add_development_dependency "rake", ">= 12.3.3"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: scenic-oracle_adapter
 version: !ruby/object:Gem::Version
-  version: 1.3.4
+  version: 1.4.0
 platform: ruby
 authors:
 - Chris Dinger
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-07-22 00:00:00.000000000 Z
+date: 2025-07-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: scenic
@@ -16,28 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.8.0
+        version: 1.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.8.0
-- !ruby/object:Gem::Dependency
-  name: activerecord-oracle_enhanced-adapter
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.5.0
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.5.0
+        version: 1.9.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -119,6 +105,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
+- CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Dockerfile
 - Gemfile
@@ -158,7 +145,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.4
+rubygems_version: 3.5.17
 signing_key:
 specification_version: 4
 summary: Oracle adapter for thoughtbot/scenic