scenic-oracle_adapter 1.3.3 → 1.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dc29d851c72aab3e3ff74f1a51fe0afc03f6acb9d1e4f9619027c231ad1f2729
-  data.tar.gz: 303764a51df609bcec295a8b495a0beb0dd3575d678060a26a5d8ed5a7b61232
+  metadata.gz: deca022db8759f5e92910b10e1c9174717499054ca3d35f3036cc33ee621163c
+  data.tar.gz: bc8288c1ca2955e36eaa3005ecd2d46458e1efa7038124c076d2b9dc353aa3cd
 SHA512:
-  metadata.gz: 5584138f239fa8d5df30bcefa0fa6ccf25ee870c4759bf578aed41ea381d429a8ae5bf379a1103fedbe68de645e17d055f4797cb1f596e38f25e6d437edb2ae5
-  data.tar.gz: c255d823fec8652adedb46ccd1c3638670cfdde2431ab392391fc52f0eb0b570ede4c416a77767b7ec68b0de2db0ad4a1eab301defd31f3a5a65afcb7899d3d1
+  metadata.gz: 530586109add300de30c1752f84ab28f568aa94cc262209a65881c408e3341b79e5f4ebab753b8610adf2c110645602a58442853dc42a67a47787e5e3081ae66
+  data.tar.gz: f632cc5e34fe412fca3d3dc5255177109bb5e2f2ca71aad84659e1c7ae1dae5dadc600bef3884423803e58d5c1d521f5ed33790e44ac463030a54d7424dd322b

data/.github/workflows/ci.yml

@@ -13,4 +13,4 @@ jobs:
     steps:
     - uses: actions/checkout@v2
     - name: Run tests
-      run: docker-compose run gem rspec
+      run: docker compose run gem rspec

data/CHANGELOG.md

@@ -0,0 +1,75 @@
+# Changelog
+
+## v1.3.5 - Oct 9, 2024
+
+- Silence ActiveRecord output while running specs. Clean green dots! (@eeklund, @dlagerro)
+- Fix growing indentation issue in schema.rb after `schema:dump`/`schema:load` (@eeklund, @dlagerro)
+
+## v1.3.4 - Jul 22, 2024
+
+- Fixes a syntax issue in pre-3.1 rubies
+- Fixes SchemaDumper error when all view objects aren't present in Oracle's user_dependencies
+- Reduce git churn in schema.rb by ordering views before they're handed to SchemaDumper
+- Strip newlines and trailing semicolons from view definitions
+
+## v1.3.3  - Jul 18, 2024
+
+- Fixes an issue with dependency sorting where mviews will sometimes be classified as a tables in user_dependencies (@whit0694)
+
+## v1.3.2 - Jul 3, 2024
+
+- Fixes a bug in the dependency-ordered views logic when Scenic views depend on external objects (@whit0694)
+
+## v1.3.1 - Jul 3, 2024
+
+- Ensures views in schema.rb are correctly ordered based on dependencies
+
+## v1.3.0 - Mar 29, 2024
+
+- Update to scenic version 1.8.0
+- Adds support for the #populated? model method
+
+## v1.2.2 - Apr 27, 2023
+
+- This fixes the botched publishing of 1.2.1 (#14).
+- The 1.2.1 gem file that was published to rubygems.org didn't contain any source code in the tarball. It was yanked and replaced with 1.2.2.
+
+## v1.2.1 - Apr 20, 2023
+
+- Fixes a bug where update_view fails on materialized views (#13)
+
+## v1.2.0 - Dec 16, 2022
+
+- Update to scenic version 1.7.0
+- Update Oracle docker container to 21 XE for testing and local development
+
+## v1.1.1 - Sep 10, 2021
+
+- Fixes issue with schema dumping in pre-1.7.0 versions of activerecord-oracle_enhanced-adapter.
+
+## v1.1.0 - Apr 23, 2021
+
+- Added support for unpopulated materialized views (build deferrred) via scenic's no_data option.
+- Move CI from Travis CI to Github Actions.
+
+## v1.0.3 - Apr 22, 2021
+
+- Update scenic dependency to 1.5.4 to provide support for Ruby 3
+
+## v1.0.2 - May 11, 2020
+
+- Remove ruby-oci as a direct dependency for jruby users (it was moved to a development dependency)
+- Drop ruby 2.4 from the CI matrix. 2.4 is no longer supported.
+
+## v1.0.1 - Apr 7, 2020
+
+- Update rake development dependency to address CVE-2020-8130
+- Default to docker/docker-compose for development and specs
+
+## v1.0.0 - Nov 25, 2018
+
+- This release adds cascading materialized view refreshes.
+
+## v0.2.0 Pre-release - Oct 24, 2018
+
+- Initial release with feature parity with Scenic::Adapters::Postgres with the exception of cascading materialized view refreshes.

data/docker-compose.yml

@@ -11,8 +11,6 @@ services:
     build: .
     volumes:
       - .:/app
-    environment:
-      - TERM=dumb
     stdin_open: true
     tty: true
     depends_on:

data/lib/scenic/adapters/oracle.rb

@@ -3,6 +3,7 @@
 require_relative "oracle/index_reapplication"
 require_relative "oracle/indexes"
 require_relative "oracle/refresh_dependencies"
+require "active_support/core_ext/string/strip"
 require "tsortable_hash"
 
 module Scenic
@@ -13,13 +14,11 @@ module Scenic
       end
 
       def views
-        all_view_objects.sort_by do |view_object|
-          dependency_order.index(view_object.name)
-        end
+        sorted_dependency_views + sorted_missing_dependency_views
       end
 
       def create_view(name, definition)
-        execute("create view #{quote_table_name(name)} as #{definition}")
+        execute("create view #{quote_table_name(name)} as #{trimmed_definition(definition)}")
       end
 
       def drop_view(name)
@@ -27,7 +26,7 @@ module Scenic
       end
 
       def replace_view(name, definition)
-        execute("create or replace view #{quote_table_name(name)} as #{definition}")
+        execute("create or replace view #{quote_table_name(name)} as #{trimmed_definition(definition)}")
       end
 
       def update_view(name, definition)
@@ -36,7 +35,7 @@ module Scenic
       end
 
       def create_materialized_view(name, definition, no_data: false)
-        execute("create materialized view #{quote_table_name(name)} #{'build deferred' if no_data} as #{definition}")
+        execute("create materialized view #{quote_table_name(name)} #{'build deferred' if no_data} as #{trimmed_definition(definition)}")
       end
 
       def update_materialized_view(name, definition, no_data: false)
@@ -71,7 +70,7 @@ module Scenic
       private
 
       def view_dependencies
-        select_all(<<~EOSQL)
+        @view_dependencies ||= select_all(<<~EOSQL)
           select lower(uo.object_name) as name, lower(ud.referenced_name) as dependency
           from user_objects uo
             left join user_dependencies ud on
@@ -88,6 +87,7 @@ module Scenic
               and ud.referenced_name in (select object_name from user_objects)
               and ud.referenced_owner = user
           where uo.object_type in ('VIEW', 'MATERIALIZED VIEW')
+          order by lower(uo.object_name), lower(ud.referenced_name)
         EOSQL
       end
 
@@ -102,6 +102,22 @@ module Scenic
         views_hash.tsort
       end
 
+      def sorted_dependency_views
+        all_view_objects.filter do |view|
+          dependency_order.include?(view.name)
+        end.sort_by do |view|
+          dependency_order.index(view.name)
+        end
+      end
+
+      def sorted_missing_dependency_views
+        all_view_objects.filter do |view|
+          dependency_order.exclude?(view.name)
+        end.sort_by do |view|
+          view.name
+        end
+      end
+
       def all_views
         select_all("select lower(view_name) name, text definition from user_views").map do |view|
           Scenic::View.new(name: view["name"], definition: view["definition"], materialized: false)
@@ -121,6 +137,10 @@ module Scenic
       def refresh_dependencies_for(name)
         Scenic::Adapters::Oracle::RefreshDependencies.call(name, self, connection)
       end
+
+      def trimmed_definition(sql)
+        sql.rstrip.sub(/;$/, "").rstrip.strip_heredoc
+      end
     end
   end
 end

data/lib/scenic/oracle_adapter/version.rb

@@ -2,6 +2,6 @@
 
 module Scenic
   module OracleAdapter
-    VERSION = "1.3.3"
+    VERSION = "1.3.5"
   end
 end

data/lib/tsortable_hash.rb

@@ -4,7 +4,7 @@ class TSortableHash < Hash
   include TSort
 
   alias_method :tsort_each_node, :each_key
-  def tsort_each_child(node, &)
-    fetch(node).each(&)
+  def tsort_each_child(node, &block)
+    fetch(node).each(&block)
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: scenic-oracle_adapter
 version: !ruby/object:Gem::Version
-  version: 1.3.3
+  version: 1.3.5
 platform: ruby
 authors:
 - Chris Dinger
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-07-18 00:00:00.000000000 Z
+date: 2024-10-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: scenic
@@ -119,6 +119,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
+- CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Dockerfile
 - Gemfile
@@ -158,7 +159,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.4
+rubygems_version: 3.5.17
 signing_key:
 specification_version: 4
 summary: Oracle adapter for thoughtbot/scenic