scelint 0.4.1 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4a057d6c2d1fea9e9d5ff8cc067236685a6c5fa1458091535c8b64e7e7faddf1
-  data.tar.gz: c520052501d0af91fd1b031cdf41e6c8e1185b4475d4b51385d2c45cc326a12f
+  metadata.gz: fc7289501df2ba7489119cef80aff1319b3d4e3ced3c7256f77db2fadb757447
+  data.tar.gz: 03347cf49d0b25dfe69b1b20efc9288063b3003bd9b83c73f7096468a3d19a28
 SHA512:
-  metadata.gz: e9ff311ea144f952f84f3215bfec4833370216e4fb89b10fcf03a1577b391e55ea66d75f6ca887c86214ad09a7b0a9f91c3237c9e1645af13f1a359cd069ed10
-  data.tar.gz: 575be45fdf396183fe5dee7e19d6b990b21f8a17e55f7f8620a7441945a82796ce159fe2986f7d5a01a62f3865e8a191383b7c7f7a49a664d7ef00e363af9d92
+  metadata.gz: c453ffc5c435214e2a18b36f15f79362301500185311e76c674b4b9c7c040c29ff6816df81898a5b23f0a0c94d4f8abc42dd987749310ad6a3f38def9d67c3cc
+  data.tar.gz: 739acfe53764dff91810874f45a87ed697ee91915aeb5ee440e6d6350da602ab5ca64b9737c755b7cfee98ede884b80c015c8df4b10a465b928a790ebad04b8e

data/.github/workflows/pr_tests.yml

@@ -17,7 +17,7 @@ jobs:
       - name: "Install Ruby"
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 4.0.0
+          ruby-version: 4.0.1
           bundler-cache: true
       - run: bundle exec rake rubocop
 

data/.github/workflows/tag_deploy_rubygem.yml

@@ -92,7 +92,7 @@ jobs:
           echo "release_command=$GEM_RELEASE_COMMAND" | tee -a "$GITHUB_OUTPUT"
       - uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 4.0.0
+          ruby-version: 4.0.1
           bundler-cache: true
       - name: Test build the package
         run: "${{ steps.commands.outputs.build_command }}"
@@ -187,7 +187,7 @@ jobs:
           clean: true
       - uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 4.0.0
+          ruby-version: 4.0.1
           bundler-cache: true
       - name: Build RubyGem
         run: |

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+### 0.5.0 / 2026-03-11
+* Validate parameter names
+* Fix command-line argument processing
+
 ### 0.4.1 / 2026-01-26
 * Support compliance_engine 0.2.x
 * Test with Ruby 4.0

data/Gemfile

@@ -7,7 +7,7 @@ gem 'rake', '~> 13.3.0'
 
 group :tests do
   gem 'rspec', '~> 3.13.1'
-  gem 'rubocop', '~> 1.81.0'
+  gem 'rubocop', '~> 1.85.0'
   gem 'rubocop-performance', '~> 1.26.0'
   gem 'rubocop-rake', '~> 0.7.1'
   gem 'rubocop-rspec', '~> 3.9.0'
@@ -16,5 +16,5 @@ end
 group :development do
   gem 'pry', '~> 0.16.0'
   gem 'pry-byebug', '~> 3.12.0'
-  gem 'rdoc', '~> 7.1.0'
+  gem 'rdoc', '~> 7.2.0'
 end

data/exe/scelint

@@ -3,4 +3,4 @@
 
 require 'scelint/cli'
 
-Scelint::CLI.start(['lint'] + ARGV)
+Scelint::CLI.start

data/lib/scelint/cli.rb

@@ -6,6 +6,20 @@ require 'logger'
 
 # SCELint CLI
 class Scelint::CLI < Thor
+  def self.exit_on_failure?
+    true
+  end
+
+  # When the first argument is not a known subcommand or an option flag,
+  # treat all arguments as paths for the default `lint` command.
+  def self.start(given_args = ARGV, config = {})
+    args = given_args
+    if args.first && !args.first.start_with?('-') && !all_commands.key?(args.first)
+      args = ['lint'] + args
+    end
+    super(args, config)
+  end
+
   class_option :quiet, type: :boolean, aliases: '-q', default: false
   class_option :verbose, type: :boolean, aliases: '-v', default: false
   class_option :debug, type: :boolean, aliases: '-d', default: false

data/lib/scelint/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Scelint
-  VERSION = '0.4.1'
+  VERSION = '0.5.0'
 end

data/lib/scelint.rb

@@ -396,7 +396,33 @@ module Scelint
     # @param check [String] The name of the check
     # @param parameter [String] The parameter to validate
     def check_parameter(file, check, parameter)
-      errors << "#{file} (check '#{check}'): invalid parameter '#{parameter}'" unless parameter.is_a?(String) && !parameter.empty?
+      # Regular expression to match valid Puppet class parameter names
+      valid_parameter = %r{\A([a-z][a-z0-9_]*::)+[a-z][a-z0-9_]*\z}
+      # From https://www.puppet.com/docs/puppet/7/lang_reserved.html
+      reserved_words = ['and', 'application', 'attr', 'case', 'component', 'consumes', 'default', 'define', 'elsif',
+                        'environment', 'false', 'function', 'if', 'import', 'in', 'inherits', 'node',
+                        'or', 'private', 'produces', 'regexp', 'site', 'true', 'type', 'undef', 'unit', 'unless',
+                        'main', 'settings', 'init', 'any', 'array', 'binary', 'boolean', 'catalogentry', 'class',
+                        'collection', 'callable', 'data', 'default', 'deferred', 'enum', 'float', 'hash', 'integer',
+                        'notundef', 'numeric', 'optional', 'pattern', 'resource', 'regexp', 'runtime', 'scalar',
+                        'semver', 'semVerRange', 'sensitive', 'string', 'struct', 'timespan', 'timestamp', 'tuple',
+                        'type', 'undef', 'variant', 'facts', 'trusted', 'server_facts', 'title', 'name'].freeze
+
+      unless parameter.is_a?(String) && !parameter.empty?
+        errors << "#{file} (check '#{check}'): invalid parameter '#{parameter}'"
+        return
+      end
+
+      unless parameter.match?(valid_parameter)
+        errors << "#{file} (check '#{check}'): invalid parameter name '#{parameter}'"
+        return
+      end
+
+      parameter.split('::').each do |part|
+        if reserved_words.include?(part)
+          errors << "#{file} (check '#{check}'): parameter name '#{parameter}' contains reserved word '#{part}'"
+        end
+      end
     end
 
     # Check remediation

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scelint
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.5.0
 platform: ruby
 authors:
 - Steven Pritchard