scelint 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6a3144b8bd1796b88e9e950dbdf68ddefc0fccaca2ba823190bcc6fc22ccac34
-  data.tar.gz: 04f59fe1645302f3af681d9f16bffb25fa70bd39430bf1e672790c22c2293ea1
+  metadata.gz: fc7289501df2ba7489119cef80aff1319b3d4e3ced3c7256f77db2fadb757447
+  data.tar.gz: 03347cf49d0b25dfe69b1b20efc9288063b3003bd9b83c73f7096468a3d19a28
 SHA512:
-  metadata.gz: 4c4bb2b4821805154d73776022f245ea1daf5dfbdb12ab0bdd73c88f82f70236da690c5bce75e9e31208f9b7f5315f1f2f6c6a44daba90f6320de04154e5d0f6
-  data.tar.gz: b7eeb5bb9e7258641be0a5a14f0c45c1b287e8c95255425b11306ff94b4ec6a7582ba5a6da83867ff75cd627780280a39959e022621d33c16428915fefcd3878
+  metadata.gz: c453ffc5c435214e2a18b36f15f79362301500185311e76c674b4b9c7c040c29ff6816df81898a5b23f0a0c94d4f8abc42dd987749310ad6a3f38def9d67c3cc
+  data.tar.gz: 739acfe53764dff91810874f45a87ed697ee91915aeb5ee440e6d6350da602ab5ca64b9737c755b7cfee98ede884b80c015c8df4b10a465b928a790ebad04b8e

data/.github/workflows/add_new_issue_to_triage_project.yml

@@ -34,7 +34,7 @@ jobs:
     name: Add issue to project
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/add-to-project@v0.5.0
+      - uses: actions/add-to-project@v1.0.2
         with:
           project-url: https://github.com/orgs/simp/projects/11
           github-token: ${{ secrets.AUTO_TRIAGE_TOKEN }}

data/.github/workflows/pr_tests.yml

@@ -13,11 +13,11 @@ jobs:
     name: 'Ruby Style'
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v6
       - name: "Install Ruby"
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 3.3
+          ruby-version: 4.0.1
           bundler-cache: true
       - run: bundle exec rake rubocop
 
@@ -27,12 +27,13 @@ jobs:
     strategy:
       matrix:
         ruby:
-          - '3.2'  # Puppet 8
+          - '3.2'  # Puppet/OpenVox 8
           - '3.3'
-          - '3.4'  # Latest
+          - '3.4'
+          - '4.0'  # Latest
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v6
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:

data/.github/workflows/tag_deploy_rubygem.yml

@@ -63,7 +63,7 @@ jobs:
     steps:
       - name: "Assert '${{ github.ref }}' is a tag"
         run: '[[ "$GITHUB_REF" =~ ^refs/tags/ ]] || { echo "::error ::GITHUB_REF is not a tag: ${GITHUB_REF}"; exit 1 ; }'
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v6
         with:
           ref: ${{ github.ref }}
           clean: true
@@ -92,7 +92,7 @@ jobs:
           echo "release_command=$GEM_RELEASE_COMMAND" | tee -a "$GITHUB_OUTPUT"
       - uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 3.2
+          ruby-version: 4.0.1
           bundler-cache: true
       - name: Test build the package
         run: "${{ steps.commands.outputs.build_command }}"
@@ -117,7 +117,7 @@ jobs:
       tag: ${{ steps.tag-check.outputs.tag }}
     steps:
       - name: Checkout code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v6
         with:
           ref: ${{ github.ref }}
           clean: true
@@ -181,13 +181,13 @@ jobs:
       PKG_DIR: ${{ needs.releng-checks.outputs.pkg_dir }}
     steps:
       - name: Checkout code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v6
         with:
           ref: ${{ github.ref }}
           clean: true
       - uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 3.2
+          ruby-version: 4.0.1
           bundler-cache: true
       - name: Build RubyGem
         run: |

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+### 0.5.0 / 2026-03-11
+* Validate parameter names
+* Fix command-line argument processing
+
+### 0.4.1 / 2026-01-26
+* Support compliance_engine 0.2.x
+* Test with Ruby 4.0
+
 ### 0.4.0 / 2025-08-26
 * Updates for recent rubocop and plugins
 * Bump minimum required Ruby version to 3.2.0 (oldest version we're testing with)

data/Gemfile

@@ -7,14 +7,14 @@ gem 'rake', '~> 13.3.0'
 
 group :tests do
   gem 'rspec', '~> 3.13.1'
-  gem 'rubocop', '~> 1.80.0'
-  gem 'rubocop-performance', '~> 1.25.0'
+  gem 'rubocop', '~> 1.85.0'
+  gem 'rubocop-performance', '~> 1.26.0'
   gem 'rubocop-rake', '~> 0.7.1'
-  gem 'rubocop-rspec', '~> 3.6.0'
+  gem 'rubocop-rspec', '~> 3.9.0'
 end
 
 group :development do
-  gem 'pry', '~> 0.15.2'
-  gem 'pry-byebug', '~> 3.11.0'
-  gem 'rdoc', '~> 6.14.2'
+  gem 'pry', '~> 0.16.0'
+  gem 'pry-byebug', '~> 3.12.0'
+  gem 'rdoc', '~> 7.2.0'
 end

data/exe/scelint

@@ -3,4 +3,4 @@
 
 require 'scelint/cli'
 
-Scelint::CLI.start(['lint'] + ARGV)
+Scelint::CLI.start

data/lib/scelint/cli.rb

@@ -6,6 +6,20 @@ require 'logger'
 
 # SCELint CLI
 class Scelint::CLI < Thor
+  def self.exit_on_failure?
+    true
+  end
+
+  # When the first argument is not a known subcommand or an option flag,
+  # treat all arguments as paths for the default `lint` command.
+  def self.start(given_args = ARGV, config = {})
+    args = given_args
+    if args.first && !args.first.start_with?('-') && !all_commands.key?(args.first)
+      args = ['lint'] + args
+    end
+    super(args, config)
+  end
+
   class_option :quiet, type: :boolean, aliases: '-q', default: false
   class_option :verbose, type: :boolean, aliases: '-v', default: false
   class_option :debug, type: :boolean, aliases: '-d', default: false

data/lib/scelint/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Scelint
-  VERSION = '0.4.0'
+  VERSION = '0.5.0'
 end

data/lib/scelint.rb

@@ -396,7 +396,33 @@ module Scelint
     # @param check [String] The name of the check
     # @param parameter [String] The parameter to validate
     def check_parameter(file, check, parameter)
-      errors << "#{file} (check '#{check}'): invalid parameter '#{parameter}'" unless parameter.is_a?(String) && !parameter.empty?
+      # Regular expression to match valid Puppet class parameter names
+      valid_parameter = %r{\A([a-z][a-z0-9_]*::)+[a-z][a-z0-9_]*\z}
+      # From https://www.puppet.com/docs/puppet/7/lang_reserved.html
+      reserved_words = ['and', 'application', 'attr', 'case', 'component', 'consumes', 'default', 'define', 'elsif',
+                        'environment', 'false', 'function', 'if', 'import', 'in', 'inherits', 'node',
+                        'or', 'private', 'produces', 'regexp', 'site', 'true', 'type', 'undef', 'unit', 'unless',
+                        'main', 'settings', 'init', 'any', 'array', 'binary', 'boolean', 'catalogentry', 'class',
+                        'collection', 'callable', 'data', 'default', 'deferred', 'enum', 'float', 'hash', 'integer',
+                        'notundef', 'numeric', 'optional', 'pattern', 'resource', 'regexp', 'runtime', 'scalar',
+                        'semver', 'semVerRange', 'sensitive', 'string', 'struct', 'timespan', 'timestamp', 'tuple',
+                        'type', 'undef', 'variant', 'facts', 'trusted', 'server_facts', 'title', 'name'].freeze
+
+      unless parameter.is_a?(String) && !parameter.empty?
+        errors << "#{file} (check '#{check}'): invalid parameter '#{parameter}'"
+        return
+      end
+
+      unless parameter.match?(valid_parameter)
+        errors << "#{file} (check '#{check}'): invalid parameter name '#{parameter}'"
+        return
+      end
+
+      parameter.split('::').each do |part|
+        if reserved_words.include?(part)
+          errors << "#{file} (check '#{check}'): parameter name '#{parameter}' contains reserved word '#{part}'"
+        end
+      end
     end
 
     # Check remediation

data/scelint.gemspec

@@ -26,5 +26,5 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency 'deep_merge', '~> 1.2'
   spec.add_dependency 'thor', '~> 1.3'
-  spec.add_dependency 'compliance_engine', '~> 0.1.0'
+  spec.add_dependency 'compliance_engine', '>= 0.1.0', '< 0.3.0'
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: scelint
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Steven Pritchard
-autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-08-27 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: deep_merge
@@ -42,17 +41,22 @@ dependencies:
   name: compliance_engine
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.1.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 0.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.1.0
-description:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 0.3.0
 email:
 - simp@simp-project.org
 executables:
@@ -82,7 +86,6 @@ licenses:
 metadata:
   homepage_uri: https://github.com/simp/rubygem-simp-scelint
   source_code_uri: https://github.com/simp/rubygem-simp-scelint
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -97,8 +100,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.19
-signing_key:
+rubygems_version: 4.0.3
 specification_version: 4
 summary: Linter SIMP Compliance Engine data
 test_files: []