scc-codestyle 0.5.0 → 0.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 46f5f84f3259972d6f46d3a2c221c236ac93187c3719c892aa1f84231f98ea2f
-  data.tar.gz: 5e42ddf8f269a5ead3889a3ec103252beac644db79b1488de8f2b0e0edd6b2e5
+  metadata.gz: 4244a7b6c5fa60bb4e8920dc47307a83cf41c65281407d5e0612820649253784
+  data.tar.gz: ab83c756469ae868b213f5e4a126af1ce5c7380070623abde2c8954ea9e1e8a1
 SHA512:
-  metadata.gz: b72032bf401b344cd7b99e694cc6e38b0300821a22191397bfd3711840392f0c9923ccd79fc7ed205df332675deed15634d91faa3bd47cd387e18f2e5cb994f7
-  data.tar.gz: 1bb87684d4f2da591c9527916c81d66ee5aea40c78b49cb02d56c744d7abdbbe50f0274becfc68822f312b585e6ec258ea9da8bc2f7ec371b7cdd2ea7309bcdc
+  metadata.gz: 2699ca812f2b65ef699bef450a2b5fe1ca4505274e3dceaa422a19f12cbc3146dcccc3bfa9cc28af2a264d33b11f6241582cfd17c2d1b5dd108ed39e7b4c3c49
+  data.tar.gz: 33ea6885528d946a439bbb7fc1b1aa37e6997a1d3adfc9ac35cd1bde7b153a89fb1a19975da54d92d91a88537d0e40751f7d2dfcd4377b95b6c34aca6b4991b5

data/.github/dependabot.yml

@@ -0,0 +1,11 @@
+# To get started with Dependabot version updates, you'll need to specify which
+# package ecosystems to update and where the package manifests are located.
+# Please see the documentation for all configuration options:
+# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
+
+version: 2
+updates:
+  - package-ecosystem: "bundler" # See documentation for possible values
+    directory: "/" # Location of package manifests
+    schedule:
+      interval: "weekly"

data/.github/workflows/build-gem.yml

@@ -0,0 +1,26 @@
+name: Check if the gem exists on rubygems.org
+
+on: [pull_request]
+
+jobs:
+  build-gem:
+    runs-on: ubuntu-latest
+    continue-on-error: true
+
+    strategy:
+      matrix:
+        ruby-version: ['2.5', '2.7']
+    
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby ${{ matrix.ruby-version }}
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+      - name: Check if gem exists
+        run: |
+          GEM_VERSION=$(ruby -e "require 'scc/codestyle'; print Scc::Codestyle::VERSION" -I lib)
+          # if we install the gem, then the $GEM_VERSION already exist on rubygems.org
+          # therefore error
+          gem install -q --silent scc-codestyle -v $GEM_VERSION && (touch failed-install && exit 0) || exit 0
+          test -f failed-install && (echo "bump the gem version!" && exit 1)

data/.github/workflows/gem-push.yml

@@ -3,6 +3,10 @@ name: scc-codestyle
 on:
   push:
     branches: [ master ]
+    paths:
+      - default.yml
+      - scc-codestyle.gemspec
+      - lib/scc/codestyle/version.rb
 
 jobs:
   build:
@@ -14,10 +18,10 @@ jobs:
 
     steps:
     - uses: actions/checkout@v2
-    - name: Set up Ruby 2.5
+    - name: Set up Ruby 2.7
       uses: actions/setup-ruby@v1
       with:
-        ruby-version: 2.5.x
+        ruby-version: 2.7.6
 
     - name: Publish to RubyGems
       run: |

data/.github/workflows/rubocop.yml

@@ -0,0 +1,20 @@
+name: Rubocop
+
+on: [pull_request]
+
+jobs:
+  rubocop:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 2.7.6
+
+
+      - name: Run rubocop
+        run: |
+          bundle install
+          bundle exec rubocop

data/.gitignore

@@ -7,3 +7,4 @@
 /pkg/
 /spec/reports/
 /tmp/
+.vscode

data/.rubocop.yml

@@ -1,6 +1,9 @@
 inherit_from:
+  - .rubocop_todo.yml
   - default.yml
 
+
+
 Naming/FileName:
   inherit_mode:
     merge:

data/.rubocop_todo.yml

@@ -0,0 +1,14 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2022-07-22 12:23:32 UTC using RuboCop version 1.31.2.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: **/*.gemspec
+Gemspec/RequiredRubyVersion:
+  Exclude:
+    - 'scc-codestyle.gemspec'

data/Dockerfile

@@ -0,0 +1,5 @@
+FROM registry.opensuse.org/home/vpereirabr/dockerimages/containers/vpereirabr/rubyready:latest
+
+RUN sudo gem update --system
+
+WORKDIR /scc-codestyle

data/Makefile

@@ -0,0 +1,6 @@
+build:
+	docker build -t scc-codestyle .
+
+console:
+	docker run -ti -v "$(PWD):/scc-codestyle" scc-codestyle bash
+	

data/README.md

@@ -41,3 +41,17 @@ And add this to `.rubocop.yml` below the previous block:
 ```yaml
 inherit_from: .rubocop_todo.yml
 ```
+
+### Development
+
+Build the docker container with:
+
+```bash
+$ make build
+```
+
+And then enter in the container with:
+
+```bash
+$ make console
+```

data/default.yml

@@ -1,5 +1,5 @@
 AllCops:
-  TargetRubyVersion: 2.5
+  TargetRubyVersion: 2.7
   DisplayCopNames: true
   DisplayStyleGuide: true
   ExtraDetails: true
@@ -18,14 +18,6 @@ require:
   - rubocop-rspec
   - rubocop-thread_safety
 
-# TODO: These three checks are ruby 2.3-only. Let's discuss them after we've upgraded
-Style/SafeNavigation:
-  Enabled: false
-Style/NumericPredicate:
-  Enabled: false
-Layout/HeredocIndentation:
-  Enabled: false
-
 # TODO: team wants to have this enabled (2017-07-13)
 # This cop is quite some work. Last time we checked we had 63 offenses and each would need a 'rubocop:disable' (no one will ever improve them then) or a proper fix.
 # We should do that with caution. Maybe as a separate (Demolition Squad?) card.
@@ -653,7 +645,6 @@ Lint/UnreachableLoop: # (new in 0.89)
   Enabled: true
 Lint/UselessMethodDefinition: # (new in 0.90)
   Enabled: true
-  AllowComments: true
 Lint/UselessTimes: # (new in 0.91)
   Enabled: true
 Style/AccessorGrouping: # (new in 0.87)
@@ -723,7 +714,7 @@ Performance/StringInclude: # (new in 1.7)
   Enabled: true
 Performance/Sum: # (new in 1.8)
   Enabled: true
-Gemspec/DateAssignment: # new in 1.10
+Gemspec/DeprecatedAttributeAssignment:
   Enabled: true
 Layout/LineEndStringConcatenationIndentation: # new in 1.18
   Enabled: true
@@ -838,8 +829,6 @@ Rails/AttributeDefaultBlockValue: # new in 2.9
   Enabled: true
 Rails/EagerEvaluationLogMessage: # new in 2.11
   Enabled: true
-Rails/ExpandedDateRange: # new in 2.11
-  Enabled: true
 Rails/FindById: # new in 2.7
   Enabled: true
 Rails/I18nLocaleAssignment: # new in 2.11
@@ -848,6 +837,8 @@ Rails/Inquiry: # new in 2.7
   Enabled: true
 Rails/MailerName: # new in 2.7
   Enabled: true
+Rails/ExpandedDateRange: # new in 2.11
+  Enabled: true
 Rails/MatchRoute: # new in 2.7
   Enabled: true
 Rails/NegateInclude: # new in 2.7

data/lib/scc/codestyle/version.rb

@@ -1,5 +1,5 @@
 module Scc
   module Codestyle
-    VERSION = '0.5.0'.freeze
+    VERSION = '0.6.2'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: scc-codestyle
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.2
 platform: ruby
 authors:
 - SCC Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-10-06 00:00:00.000000000 Z
+date: 2022-07-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -129,12 +129,17 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/dependabot.yml"
+- ".github/workflows/build-gem.yml"
 - ".github/workflows/gem-push.yml"
+- ".github/workflows/rubocop.yml"
 - ".gitignore"
 - ".rubocop.yml"
-- ".ruby-version"
+- ".rubocop_todo.yml"
+- Dockerfile
 - Gemfile
 - LICENSE
+- Makefile
 - README.md
 - Rakefile
 - default.yml
@@ -160,8 +165,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6.3
+rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
 summary: SCC style guides and shared style configs.

data/.ruby-version

@@ -1 +0,0 @@
-2.5.8