sc2ai 0.5.0 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5b421602e2cdff4d59e4b3b4ab168f7d894a43f4474244b229ec72c78d6bf6a9
-  data.tar.gz: cbc072cb8a55cacabd0ac751ff5286f582c0145241a98343834f0c0def7c31c1
+  metadata.gz: ddd8bd1e37b50ba6d4e89c24fb330d646589d869cc53cf96a69624eaa0e6133c
+  data.tar.gz: d88b2674f094621c11aa7de9a0c59ae82a6668aa6c882783a54236776ceb9f37
 SHA512:
-  metadata.gz: df8e5f7a8557d0f3dce348cbd9dcdc8ef8f03f88b5f00376d7972b36c223e042ed61123612642189e2722b0a62eb22f7f02a16ca5650864bdd8f3a49ddc86680
-  data.tar.gz: d5094e865be75f4b7c31b25a41ff8f021edbb4380567f304a39c1ade99d3155fa408d821c980f2751daf85eddee3f8f9c84a81557255e923db524d9570fad817
+  metadata.gz: 10c922d086149c4f2e4cac906607d7f5fb2c31fde1ace225186b0d83342efaea6720c48b799eb01e4d29fec5b295a4890d44b9cf803bb0c47e75e5830489c466
+  data.tar.gz: 7430bdcd6935e457b88b562838c0dc112f28ecdfbacd072293ddfdf358d065287dcdbc300bb7cc76b4efe0e671a82006f9d53766b79bd2d006496982061e3fc7

data/data/sc2ai/protocol/data.proto

@@ -89,7 +89,7 @@ message UnitTypeData {
   optional float sight_range = 25;                                // Range unit reveals vision.
 
   repeated uint32 tech_alias = 21 [packed=false];                                // Other units that satisfy the same tech requirement.
-  optional uint32 unit_alias = 22 [packed=false];                                // The morphed variant of this unit.
+  optional uint32 unit_alias = 22;                                // The morphed variant of this unit.
 
   optional uint32 tech_requirement = 23;                          // Structure required to build this unit. (Or any with the same tech_alias)
   optional bool require_attached = 24;                            // Whether tech_requirement is an add-on.

data/data/sc2ai/protocol/raw.proto

@@ -191,7 +191,7 @@ message ActionRawUnitCommand {
     uint64 target_unit_tag = 3;
   }
   repeated uint64 unit_tags = 4 [packed=false];
-  optional bool queue_command = 5 [packed=false];
+  optional bool queue_command = 5;
 }
 
 message ActionRawCameraMove {

data/docker_build/Dockerfile.ruby

@@ -4,12 +4,12 @@ LABEL service="bot-ruby-local"
 USER root
 WORKDIR /root/ruby-builder
 
-ARG RUBY_VERSION=3.4.1
+ARG RUBY_VERSION=3.4.2
 ARG DEBIAN_DISABLE_RUBYGEMS_INTEGRATION=true
 
 # Deps - Ruby build
 RUN apt-get update
-RUN apt install --assume-yes rustc curl build-essential libssl-dev zlib1g-dev libgmp-dev libffi-dev uuid-dev
+RUN apt install --assume-yes rustc curl build-essential libssl-dev zlib1g-dev libgmp-dev libffi-dev uuid-dev libopenblas0-serial
 
 # Deps - libyaml from source
 RUN curl https://pyyaml.org/download/libyaml/yaml-0.2.5.tar.gz -o yaml-0.2.5.tar.gz
@@ -33,20 +33,20 @@ RUN rm yaml-0.2.5.tar.gz
 
 # Package config
 # numo-linalg needs openblas, copy to ruby-prefix/lib/ dir.
-RUN apt download libopenblas0-serial
-RUN mkdir openblas
-RUN dpkg-deb -x ./libopenblas*.deb openblas
-RUN cp -d openblas/usr/lib/x86_64-linux-gnu/openblas-serial/* /root/ruby-builder/.ruby/lib/
-RUN rm -rf ./openblas
-RUN rm ./libopenblas0-serial*.deb
-
-RUN apt download libgfortran5
-RUN mkdir libgfortran5
-RUN dpkg-deb -x ./libgfortran*.deb libgfortran5
-RUN find libgfortran5
-RUN cp libgfortran5/usr/lib/x86_64-linux-gnu/libgfortran.so.5 /root/ruby-builder/.ruby/lib/
-RUN rm -rf ./libgfortran5
-RUN rm ./libgfortran5*.deb
+#RUN apt download libopenblas0-serial
+#RUN mkdir openblas
+#RUN dpkg-deb -x ./libopenblas*.deb openblas
+#RUN cp -d openblas/usr/lib/x86_64-linux-gnu/openblas-serial/* /root/ruby-builder/.ruby/lib/
+#RUN rm -rf ./openblas
+#RUN rm ./libopenblas0-serial*.deb
+
+#RUN apt download libgfortran5
+#RUN mkdir libgfortran5
+#RUN dpkg-deb -x ./libgfortran*.deb libgfortran5
+#RUN find libgfortran5
+#RUN cp libgfortran5/usr/lib/x86_64-linux-gnu/libgfortran.so.5 /root/ruby-builder/.ruby/lib/
+#RUN rm -rf ./libgfortran5
+#RUN rm ./libgfortran5*.deb
 
 RUN /root/ruby-builder/.ruby/bin/ruby --yjit -v
 

data/lib/sc2ai/api/data.rb

@@ -108,6 +108,8 @@ module Sc2
       correct_unit_type_costs
       correct_unit_type_sum
       decorate_unit_type_placement_length
+      decorate_missing_values
+      decorate_weapon_helpers
     end
 
     # @private
@@ -256,9 +258,11 @@ module Sc2
       end
     end
 
+    private
+
     # @private
     # Adds placement_length to units if applicable
-    private def decorate_unit_type_placement_length
+    def decorate_unit_type_placement_length
       @units.each_value do |unit_type_data|
         unit_type_data.placement_length = 0
         next unless unit_type_data.ability_id
@@ -269,5 +273,59 @@ module Sc2
         end
       end
     end
+
+    # @private
+    # Adds values missing from the API
+    def decorate_missing_values
+      # Battlecruiser has no weapons. Force these in by hand.
+      @units[Api::UnitTypeId::BATTLECRUISER].weapons = [
+        Api::Weapon.new(
+          type: Api::Weapon::TargetType::GROUND,
+          damage: 8.0,
+          damage_bonus: [],
+          attacks: 1,
+          range: 6.0,
+          speed: 0.224
+        ),
+        Api::Weapon.new(
+          type: Api::Weapon::TargetType::AIR,
+          damage: 5.0,
+          damage_bonus: [],
+          attacks: 1,
+          range: 6.0,
+          speed: 0.224
+        )
+      ]
+    end
+
+    # @private
+    # Adds ground_damage, air_damage, ground_range, air_range, ground_dps and air_dps
+    def decorate_weapon_helpers
+      @units.each do |unit_type_id, unit_type_data|
+        ground_weapon = unit_type_data.weapons.find do |weapon|
+          weapon.type == :GROUND || weapon.type == :ANY
+        end
+
+        air_weapon = unit_type_data.weapons.find do |weapon|
+          weapon.type == :AIR || weapon.type == :ANY
+        end
+
+        unit_type_data.ground_range = ground_weapon&.range || 0.0
+        unit_type_data.air_range = air_weapon&.range || 0.0
+
+        ground_attacks = ground_weapon&.attacks || 0
+        air_attacks = air_weapon&.attacks || 0
+        base_ground_damage = ground_weapon&.damage || 0.0
+        base_air_damage = air_weapon&.damage || 0.0
+        ground_attack_speed = ground_weapon&.speed || 1.0
+        air_attack_speed = air_weapon&.speed || 1.0
+
+        unit_type_data.ground_damage = base_ground_damage * ground_attacks
+        unit_type_data.air_damage = base_air_damage * air_attacks
+
+        unit_type_data.ground_dps = unit_type_data.ground_damage / ground_attack_speed
+        unit_type_data.air_dps = unit_type_data.air_damage / air_attack_speed
+      end
+    end
   end
 end

data/lib/sc2ai/cli/cli.rb

@@ -21,31 +21,16 @@ module Sc2
     desc "setup410", "Downloads and install SC2 v4.10"
     # downloads and install SC2 v4.10
     def setup410
-      say " "
-      say "This script sets up SC2 at version 4.10, which we use competitively."
-      say "Press any key to continue..."
-      ask ""
-
-      say "You must accept the Blizzard® StarCraft® II AI and Machine Learning License at"
-      say "https://blzdistsc2-a.akamaihd.net/AI_AND_MACHINE_LEARNING_LICENSE.html"
-      say "It is PERMISSIVE and grants you freedoms over the standard EULA."
-      say "We do not record this action, but depend on software goverend by that license to continue."
-      puts 'If you accept, type "iagreetotheeula" (without quotes) and press ENTER to continue:'
-
-      while $stdin.gets.chomp != "iagreetotheeula"
-        say ""
-        puts 'Type "iagreetotheeula" (without quotes) and press ENTER to continue:'
-      end
-      say ""
-      say ""
-      say "Great decision."
-
       require "sc2ai"
       Async do
         Sc2.logger.level = :fatal
+        say " "
+        say "This script sets up SC2 at version 4.10, which we use competitively."
         say "SC2 will launch a blank window, be unresponsive, but download about 100mb in the background."
+        say ""
+        say "It will appear to hang as it updates. This is normal."
         say "Let it finish and close itself."
-        say "Press ENTER if you understand."
+        say "Press any key to continue..."
         ask ""
 
         say ""

data/lib/sc2ai/connection/requests.rb

@@ -110,8 +110,9 @@ module Sc2
       #       game_info = observer.api.game_info
       #     end
       #   ensure
+      #     observer.disconnect
       #     Sc2::ClientManager.stop(0)
-      #   end
+      #   end.wait
       # @param replay_path [String] path to replay
       # @param replay_data [String] alternative to file, binary string of replay_file.read
       # @param map_data [String] optional binary string of SC2 map if not present in paths
@@ -195,6 +196,7 @@ module Sc2
 
       # Snapshot of the current game state. Primary source for raw information
       # @param game_loop [Integer] you wish to wait for (realtime only)
+      # @return [Api::ResponseObservation]
       def observation(game_loop: nil)
         # Sc2.logger.debug { "#{self.class}.#{__method__} game_loop: #{game_loop}" }
         if game_loop.nil?
@@ -275,6 +277,7 @@ module Sc2
       # Advances the game simulation by step_count. Not used in realtime mode.
       # Only constant step size supported - subsequent requests use cache.
       def step(step_count = 1)
+        step_count = step_count.to_i
         @_cached_request_step ||= {}
         @_cached_request_step[step_count] ||= Api::Request.new(
           step: Api::RequestStep.new(count: step_count)

data/lib/sc2ai/local_play/match.rb

@@ -68,7 +68,7 @@ module Sc2
           ensure
             Sc2.logger.debug { "Game over, disconnect players." }
             # Suppress interrupt errors #$stderr.reopen File.new(File::NULL, "w")
-            player.quit if Gem.win_platform?
+            player.quit if [Paths::PF_WINDOWS, Paths::PF_WSL1, Paths::PF_WSL2].include?(Paths.platform)
             player.disconnect
             ClientManager.stop(player_index) # unless keep_clients_alive
           end
@@ -95,7 +95,7 @@ module Sc2
       response = player.api.save_replay
       path = Pathname(Paths.bot_data_replay_dir).join("autosave-#{safe_player_name}.SC2Replay")
       f = File.new(path, "wb:ASCII-8BIT")
-      f.write(response.data)
+      f.write_nonblock(response.data)
       f.close
     end
 

data/lib/sc2ai/player/game_state.rb

@@ -36,16 +36,9 @@ module Sc2
       end
 
       def game_info=(new_info)
-        @game_info_loop = game_loop
         @game_info = new_info
       end
 
-      # @!attribute game_info_loop
-      #   This is the last loop at which game_info was set.
-      #   Used to determine staleness.
-      # @return [Integer]
-      attr_accessor :game_info_loop
-
       # @!attribute data
       #   @return [Api::ResponseData]
       attr_accessor :data

data/lib/sc2ai/player/units.rb

@@ -35,6 +35,11 @@ module Sc2
       #   @return [Sc2::UnitGroup] a group of neutral units
       attr_accessor :effects # not a unit
 
+      # An array of Units which are (red) blips on radar
+      # @!attribute blips
+      #   @return [Sc2::UnitGroup] a group of blip units
+      attr_accessor :blips
+
       # Returns the upgrade ids you have acquired such as weapon upgrade and armor upgrade ids.
       # Shorthand for observation.raw_data.player.upgrade_ids
       # @!attribute [r] upgrades_completed
@@ -254,7 +259,7 @@ module Sc2
 
       # Checks whether you have the resources to construct quantity of unit type
       # @return [Boolean]
-      def can_afford?(unit_type_id:, quantity: 1)
+      def can_afford?(unit_type_id, quantity: 1)
         unit_type_data = unit_data(unit_type_id)
         return false if unit_type_data.nil?
 
@@ -343,10 +348,7 @@ module Sc2
         enemy_alliance = self.enemy_alliance
 
         # To prevent several loops over all units per frame, use this single loop for all checks
-        all_unit_size = observation.raw_data.units.size
-        i = 0
-        while i < all_unit_size
-          unit = observation.raw_data.units[i]
+        observation.raw_data.units.each do |unit|
           tag = unit.tag
           tag = unit.tag = unit.hash if tag.zero?
           # Reluctantly assigning player to unit
@@ -377,7 +379,7 @@ module Sc2
             @neutral[tag] = unit
           end
 
-          # Dont parse callbacks on first loop or for neutral units
+          # Don't parse callbacks on first loop or for neutral units
           if !@previous.all_units.nil? &&
               unit.alliance != :NEUTRAL &&
               unit.display_type != :PLACEHOLDER &&
@@ -392,11 +394,13 @@ module Sc2
               issue_existing_unit_callbacks(unit, previous_unit)
             end
           end
+        end
 
+        # Due to race condition with callbacks and Unit#bot not being set,
+        # rather do a second iteration just for the callbacks
+        observation.raw_data.units.each do |unit|
           # Allow user to fiddle with unit
           on_parse_observation_unit(unit)
-
-          i += 1
         end
       end
 

data/lib/sc2ai/player.rb

@@ -213,6 +213,7 @@ module Sc2
       #     enable_feature_layer = true
       #
       #   end
+      # @return [void]
       def configure
       end
 
@@ -276,12 +277,14 @@ module Sc2
 
       # Override to perform steps before first on_step gets called.
       # Current game_loop is 0 and @api is available
+      # @return [void]
       def on_start
         # Sc2.logger.debug { "#{self.class} on_start" }
       end
 
       # Override to implement your own game logic.
       # Gets called whenever the game moves forward.
+      # @return [void]
       def on_step
         return unless is_a? Bot
 
@@ -305,6 +308,7 @@ module Sc2
       #       puts "Lets try again!"
       #     end
       #   end
+      # @return [void]
       def on_finish(result)
         # Sc2.logger.debug { "#{self.class} on_finish" }
       end
@@ -312,12 +316,14 @@ module Sc2
       # Called when Random race is first detected.
       # Override to handle race identification of random enemy.
       # @param race [Integer] see {Api::Race}
+      # @return [void]
       def on_random_race_detected(race)
       end
 
       # Called on step if errors are present. Equivalent of UI red text errors.
       # Override to read action errors.
       # @param errors [Array<Api::ActionError>]
+      # @return [void]
       def on_action_errors(errors)
         # Sc2.logger.debug errors
       end
@@ -325,6 +331,7 @@ module Sc2
       # Actions this player performed since the last Observation.
       # Override to read actions successfully performed
       # @param actions [Array<Api::Action>] a list of actions which were performed
+      # @return [void]
       def on_actions_performed(actions)
         # Sc2.logger.debug actions
       end
@@ -342,11 +349,13 @@ module Sc2
       #     end
       #   end
       # @param alerts [Array<Integer>] array of Api::Alert::*
+      # @return [void]
       def on_alerts(alerts)
       end
 
       # Callback when upgrades are completed, multiple might finish on the same observation.
       # @param upgrade_ids [Array<Integer>] Api::UpgradeId::*
+      # @return [void]
       def on_upgrades_completed(upgrade_ids)
       end
 
@@ -359,6 +368,7 @@ module Sc2
       # Callback, on observation parse when iterating over every unit
       # Can be useful for decorating additional properties on a unit before on_step
       # A Sc2::Player should override this to decorate additional properties
+      # @return [void]
       def on_parse_observation_unit(unit)
       end
 
@@ -367,12 +377,14 @@ module Sc2
       # Override to use in your bot class or use Player.
       # @param unit [Api::Unit]
       # @see Sc2::Player::Units#units_destroyed
+      # @return [void]
       def on_unit_destroyed(unit)
       end
 
       # Callback for unit created.
       # Override to use in your bot class.
       # @param unit [Api::Unit]
+      # @return [void]
       def on_unit_created(unit)
       end
 
@@ -381,18 +393,21 @@ module Sc2
       # Override to use in your bot class or use Player.
       # @param unit [Api::Unit]
       # @param previous_unit_type_id [Integer] Api::UnitTypeId::*
+      # @return [void]
       def on_unit_type_changed(unit, previous_unit_type_id)
       end
 
       # Callback for structure building began
       # Override to use in your bot class.
       # @param unit [Api::Unit]
+      # @return [void]
       def on_structure_started(unit)
       end
 
       # Callback for structure building is completed
       # Override to use in your bot class or use Player.
       # @param unit [Api::Unit]
+      # @return [void]
       def on_structure_completed(unit)
       end
 
@@ -400,6 +415,7 @@ module Sc2
       # Override to use in your bot class or use Player.
       # @param unit [Api::Unit]
       # @param amount [Integer] of damage
+      # @return [void]
       def on_unit_damaged(unit, amount)
       end
 
@@ -530,18 +546,27 @@ module Sc2
       on_structure_completed
       on_unit_damaged]
 
+    # @private
+    # @return [Array<Symbol>] callbacks implemented on player class
+    attr_accessor :callbacks_defined
+
     # @private
     # Checks if callback method is defined on our bot
     # Used to skip processing on unused callbacks
     # @param callback [Symbol]
     def callback_defined?(callback)
-      CALLBACK_METHODS.include?(callback)
+      if @callbacks_defined.nil?
+        # Cache the intersection check, assuming nobody defines a callback method while actually running
+        @callbacks_defined = CALLBACK_METHODS.intersection(self.class.instance_methods(false))
+      end
+      @callbacks_defined.include?(callback)
     end
 
     # Initialize data on step 0 before stepping and before on_start is called
     def prepare_start
       @data = Sc2::Data.new(@api.data)
       clear_action_queue
+      clear_action_errors
       clear_debug_command_queue
     end
 

data/lib/sc2ai/protocol/extensions/player_common.rb

@@ -0,0 +1,25 @@
+module Api
+  # Adds additional functionality to message object Api::Point2D
+  module PlayerCommonExt
+    # @!attribute supply_cap
+    #   Maximum supply. alias of #food_cap
+    #   @return [Integer]
+    def supply_cap = food_cap
+
+    # @!attribute supply_used
+    #   Supply used. alias of #food_used
+    #   @return [Integer]
+    def supply_used = food_used
+
+    # @!attribute supply_army
+    #   Supply used for army. alias of #food_army
+    #   @return [Integer]
+    def supply_army = food_army
+
+    # @!attribute supply_workers
+    #   Supply used in workers. alias of #food_workers
+    #   @return [Integer]
+    def supply_workers = food_workers
+  end
+end
+Api::PlayerCommon.prepend Api::PlayerCommonExt

data/lib/sc2ai/protocol/extensions/position.rb

@@ -207,7 +207,7 @@ module Sc2
     # Conversion ---
 
     # Returns [x,y] array tuple
-    # @return [Array[Float,Float]]
+    # @return [Array<Float, Float>]
     def to_axy
       [x, y]
     end

data/lib/sc2ai/protocol/extensions/unit.rb

@@ -23,7 +23,7 @@ module Api
     # Get the unit as from the previous frame. Good for comparison.
     # @return [Api::Unit, nil] this unit from the previous frame or nil if it wasn't present
     def previous
-      @bot.previous.all_units[tag]
+      @bot.previous.all_units&.[](tag)
     end
 
     # Returns whether a unit is alive or not
@@ -48,7 +48,7 @@ module Api
 
     # Attributes ---
 
-    # Returns static [Api::UnitTypeData] for a unit
+    # Returns static an array of attributes for a unit
     # @return [Array<Api::Attribute>]
     def attributes
       unit_data.attributes
@@ -111,7 +111,7 @@ module Api
       has_attribute?(:STRUCTURE)
     end
 
-    # Checks if unit is hover
+    # Checks if unit is hovering
     # @return [Boolean] whether unit has attribute :Hover
     def is_hover?
       has_attribute?(:HOVER)
@@ -133,13 +133,31 @@ module Api
 
     # Helpers for unit properties
 
-    def width = radius * 2
+    def width = radius * 2.0
     # @!parse
     #   # @!attribute width
     #   # width = radius * 2
     #   # @return [Float]
     #   attr_reader :width
 
+    # @!attribute [r] full_health?
+    #   @return [Boolean] health is at maximum
+    def full_health?
+      health == health_max
+    end
+
+    # @!attribute [r] full_shields?
+    #   @return [Boolean] shields are at maximum
+    def full_shields?
+      shield == shield_max
+    end
+
+    # @!attribute [r] full_energy?
+    #   @return [Boolean] energy is at maximum
+    def full_energy?
+      energy == energy_max
+    end
+
     # Some overrides to allow question mark references to boolean properties
 
     # @!attribute [r] is_flying?
@@ -179,6 +197,14 @@ module Api
     # @return [Boolean]
     def is_ground? = !is_flying?
 
+    # @!attribute [r] is_cloaked??
+    # Returns whether the unit is cloaked. Revealed cloak units also return true.
+    # For further distinction, use Unit#cloaked, which uses enum CloakedState
+    # @return [Boolean]
+    def is_cloaked?
+      cloak != :NOT_CLOAKED && cloak != :CLOAKED_UNKNOWN
+    end
+
     # @!endgroup Virtual properties
 
     # Whether unit is effected by buff_id
@@ -315,14 +341,18 @@ module Api
       )
     end
 
-    # Draws a sphere around the unit's attack range
-    # @param weapon_index [Api::Color] default first weapon, see UnitTypeData.weapons
+    # Draws a sphere around the unit's attack range (weapon range + radius)
+    # @param weapon_index [Integer] default first weapon, see UnitTypeData#weapons
     # @param color [Api::Color] optional api color, default red
     def debug_fire_range(weapon_index = 0, color = nil)
+      attack_range = unit_data.weapons[weapon_index]&.range
+      return if attack_range.nil?
+      attack_range += radius
+
       color = Api::Color.new(r: 255, b: 0, g: 0) if color.nil?
-      attack_range = unit_data.weapons[weapon_index].range
       raised_position = pos.dup
       raised_position.z += 0.01
+
       @bot.debug_draw_sphere(point: raised_position, radius: attack_range, color:)
     end
 
@@ -413,22 +443,30 @@ module Api
     end
 
     # Checks whether enemy is within range of weapon or ability and can target ground/air.
-    # Defaults to basic weapon. Pass in ability to override
+    # By default, checks all weapons.
+    # Pass weapon_index or ability_id to target a specific source of damage.
     # @param unit [Api::Unit] enemy
-    # @param weapon_index [Integer] defaults to 0 which is it's basic weapon for it's current form
+    # @param weapon_index [Integer] passing this will select a specific Weapon
     # @param ability_id [Integer] passing this will override weapon Api::AbilityId::*
     # @return [Boolean]
     # @example
+    #   queen.can_attack?(enemy, weapon_index: 0) # Air attack
+    #   queen.can_attack?(enemy, weapon_index: 1) # Ground attack
+    #   queen.can_attack?(enemy) # Auto detect (scans all weapons)
     #   ghost.can_attack?(enemy, weapon_index: 0, ability_id: Api::AbilityId::SNIPE)
-    def can_attack?(unit:, weapon_index: 0, ability_id: nil)
-      if ability_id.nil?
+    def can_attack?(unit:, weapon_index: nil, ability_id: nil)
+      return false if unit.nil?
+      if ability_id
+        # ability
+        ability = @bot.ability_data(ability_id)
+        can_ability_target_unit?(unit:, ability:)
+      elsif weapon_index
         # weapon
         source_weapon = weapon(weapon_index)
         can_weapon_target_unit?(unit:, weapon: source_weapon)
       else
-        # ability
-        ability = @bot.ability_data(ability_id)
-        can_ability_target_unit?(unit:, ability:)
+        # auto-detect weapon
+        unit_data.weapons.any? { |weapon| can_weapon_target_unit?(unit:, weapon:) }
       end
     end
 
@@ -445,6 +483,7 @@ module Api
     # @param weapon [Api::Weapon]
     # @return [Boolean]
     def can_weapon_target_unit?(unit:, weapon:)
+      return false if unit.nil? || weapon.nil?
       # false if enemy is air and we can only shoot ground
       return false if unit.is_flying && weapon.type == :GROUND # Api::Weapon::TargetType::GROUND
 
@@ -455,7 +494,12 @@ module Api
       in_attack_range?(unit:, range: weapon.range)
     end
 
+    # Checks whether an ability can target a unit
+    # @param unit [Api::Unit]
+    # @param ability [Api::AbilityData]
+    # @return [Boolean]
     def can_ability_target_unit?(unit:, ability:)
+      return false if unit.nil? || ability.nil?
       # false if enemy is air and we can only shoot ground
       return false if ability.target == Api::AbilityData::Target::NONE
 
@@ -495,6 +539,7 @@ module Api
     # This value should be correct for building placement math (unit.radius is not good for this)
     # @return [Float] placement radius
     def footprint_radius
+      return 0.0 if unit_data.ability_id == 0
       @bot.data.abilities[unit_data.ability_id].footprint_radius
     end