sbmt-kafka_consumer 3.1.0 → 3.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f56ef789be2f19f5e5890292e8163f29d65ced1de23358b3a0bcf4163b77587d
-  data.tar.gz: 6f7450a9ecf65d6d32294f26142706a7c523af2073be90e9cb9bc6a630ae73f9
+  metadata.gz: 4d68fc606cb503382ebd9ff90d5e9a9c191c6905e0d76aeccfdef8d2fd98f2f4
+  data.tar.gz: 847b1844371d842ed88cbfcfbff48f95d74de91a5b108869cdbba3238494a821
 SHA512:
-  metadata.gz: 0bab92c52ee0dd45b2893f1e592a480b53c055d2addd522d8ab22bdc8b83068983734974ba56aaf47d370dd6f42b342ec5e1cc8623f8e8a4833ccf112e23bdf2
-  data.tar.gz: f159851f5089686e1b767f53852257d10575bb4c532e603f8d3a9169f7500556a802bf0e79e60de19c6056d213347782a7334f6a67c5f9ec5f3bc9a2085c472f
+  metadata.gz: 4f3e97d8a636a24a7b81304be3410ee5e9960017369a1a7fcee8a166166cf8b5503ab9641cdf455d84cefaab69469ae1530c40e69aa1bc97eb3b4fa1cae1f501
+  data.tar.gz: 5f8177ca6245d822974dc32a763628e7720ec89921fd45dc9ddeecf61dc9360b0690f9280fed400048afc2b02ac72b7c5c46a61e1068c92dd9d567b0e33db735

data/CHANGELOG.md

@@ -13,6 +13,18 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Fixed
 
+## [3.2.1] - 2024-09-20
+
+### Fixed
+ 
+- Limit Karafka version to less than 2.4.12 since `bootstrap.servers` has been made required
+
+## [3.2.0] - 2024-09-17
+
+### Added
+
+- For synchronous messages and errors, we place logs in tags
+
 ## [3.1.0] - 2024-09-09
 
 ### Fixed

data/lib/sbmt/kafka_consumer/base_consumer.rb

@@ -45,9 +45,7 @@ module Sbmt
 
       def with_instrumentation(message)
         logger.tagged(
-          trace_id: trace_id,
-          topic: message.metadata.topic, partition: message.metadata.partition,
-          key: message.metadata.key, offset: message.metadata.offset
+          trace_id: trace_id
         ) do
           ::Sbmt::KafkaConsumer.monitor.instrument(
             "consumer.consumed_one",

data/lib/sbmt/kafka_consumer/instrumentation/logger_listener.rb

@@ -20,30 +20,56 @@ module Sbmt
 
           logger.tagged(
             type: type,
+            stacktrace: log_backtrace(error),
             **tags
           ) do
             logger.error(error_message(error))
-            log_backtrace(error)
           end
         end
 
         # BaseConsumer events
         def on_consumer_consumed_one(event)
-          logger.info("Successfully consumed message in #{event.payload[:time]} ms")
+          log_with_tags(log_tags(event), "Successfully consumed message")
         end
 
         def on_consumer_mark_as_consumed(event)
-          logger.info("Processing message in #{event.payload[:time]} ms")
+          log_with_tags(log_tags(event), "Processing message")
         end
 
         def on_consumer_process_message(event)
-          logger.info("Commit offset in #{event.payload[:time]} ms")
+          log_with_tags(log_tags(event), "Commit offset")
         end
 
         # InboxConsumer events
         def on_consumer_inbox_consumed_one(event)
-          logger.tagged(status: event[:status]) do
-            logger.info("Successfully consumed message with uuid: #{event[:message_uuid]} in #{event.payload[:time]} ms")
+          log_tags = log_tags(event).merge!(status: event[:status])
+          msg = "Successfully consumed message with uuid: #{event[:message_uuid]}"
+
+          log_with_tags(log_tags, msg)
+        end
+
+        private
+
+        def log_tags(event)
+          metadata = event.payload[:message].metadata
+
+          {
+            kafka: {
+              topic: metadata.topic,
+              partition: metadata.partition,
+              key: metadata.key,
+              offset: metadata.offset,
+              consumer_group: event.payload[:caller].topic.consumer_group.id,
+              consume_duration_ms: event.payload[:time]
+            }
+          }
+        end
+
+        def log_with_tags(log_tags, msg)
+          return unless logger.respond_to?(:tagged)
+
+          logger.tagged(log_tags) do
+            logger.send(:info, msg)
           end
         end
       end

data/lib/sbmt/kafka_consumer/version.rb

@@ -2,6 +2,6 @@
 
 module Sbmt
   module KafkaConsumer
-    VERSION = "3.1.0"
+    VERSION = "3.2.1"
   end
 end

data/sbmt-kafka_consumer.gemspec

@@ -33,7 +33,7 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency "rails", ">= 6.1"
   spec.add_dependency "zeitwerk", "~> 2.3"
-  spec.add_dependency "karafka", "~> 2.4"
+  spec.add_dependency "karafka", "~> 2.4", "< 2.4.12"
   spec.add_dependency "yabeda", ">= 0.11"
   spec.add_dependency "anyway_config", ">= 2.4.0"
   spec.add_dependency "thor"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sbmt-kafka_consumer
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.2.1
 platform: ruby
 authors:
 - Kuper Ruby-Platform Team
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-09-09 00:00:00.000000000 Z
+date: 2024-09-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -45,6 +45,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.4'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 2.4.12
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -52,6 +55,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.4'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 2.4.12
 - !ruby/object:Gem::Dependency
   name: yabeda
   requirement: !ruby/object:Gem::Requirement
@@ -565,7 +571,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.1.6
 signing_key:
 specification_version: 4
 summary: Ruby gem for consuming Kafka messages