savon 2.8.1 → 2.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 379ca76fcbfd623cc2e02ff387233fd764e50fdf
-  data.tar.gz: 2a2ff2a7c89ac4d5da0d62196388b49514bc3eeb
+  metadata.gz: 85eee2aa2cf1a1c2130cf5c50c453ef5dec838c3
+  data.tar.gz: bb9aa1c1c8e3cff15b8bbb4ca24a3d8b0764814a
 SHA512:
-  metadata.gz: b5a27414b2371f54d7d7ccc7c92ca360bba02bee470c6274af9491aae939229ad15e4997415818d3b2947503bcdc79c1d6c7fc3860019195ef5e85589ab1edd1
-  data.tar.gz: 55804add86b33a9bddac6cdf6383bc7f89025eaf4fdcee9d43ccd0aaa21295a39932b98eae75b111c86882c26e916eea8693aea1e7f7015cb22c815b8ba13374
+  metadata.gz: 0681726a8f75c5ea133b98bdf2ac582e9af225677b643a20dbf0832cbd2458fce15a6c409d42691dbeffc97cdb15f6451dece2d60b5dcf8d2b3c4d5801de555c
+  data.tar.gz: 09cf940fcb8e9e8b669967eac9daa31f14ccfb633a1679af94aec21856be2fccd329018fc549014a7a9bded9fabb396393adf4e0c6c526c9e9c844613546f506

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+# 2.9.0 (2015-01-29)
+
+* Feature: [#655] Wasabi exceptions should be rethrown as Savon errors. This should make it easier to catch errors thrown by Savon::Client.
+* Feature: [#630] ServiceFaults are correctly identified as Soap Faults.
+
 # 2.8.0 (2014-11-12)
 
 * Feature : [#620](https://github.com/savonrb/savon/pull/620) add #build_request method that builds the actual XML request body, but does not submit it. Useful for debugging, possibly.

data/lib/savon/operation.rb

@@ -4,6 +4,7 @@ require "savon/request"
 require "savon/builder"
 require "savon/response"
 require "savon/request_logger"
+require "savon/http_error"
 
 module Savon
   class Operation
@@ -22,6 +23,8 @@ module Savon
         raise UnknownOperationError, "Unable to find SOAP operation: #{operation_name.inspect}\n" \
                                      "Operations provided by your service: #{wsdl.soap_actions.inspect}"
       end
+    rescue Wasabi::Resolver::HTTPError => e
+      raise HTTPError.new(e.response)
     end
 
     def self.ensure_name_is_symbol!(operation_name)

data/lib/savon/soap_fault.rb

@@ -21,7 +21,7 @@ module Savon
     attr_reader :http, :nori, :xml
 
     def to_s
-      fault = nori.find(to_hash, 'Fault')
+      fault = nori.find(to_hash, 'Fault') || nori.find(to_hash, 'ServiceFault')
       message_by_version(fault)
     end
 

data/lib/savon/version.rb

@@ -1,3 +1,3 @@
 module Savon
-  VERSION = '2.8.1'
+  VERSION = '2.9.0'
 end

data/spec/fixtures/response/soap_fault_funky.xml

@@ -0,0 +1,8 @@
+<soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/">
+   <soap:Body>
+      <soap:ServiceFault>
+         <faultcode>42</faultcode>
+         <faultstring>The Answer to Life The Universe And Everything</faultstring>
+      </soap:ServiceFault>
+   </soap:Body>
+</soap:Envelope>

data/spec/integration/centra_spec.rb

@@ -40,12 +40,9 @@ describe 'Correct translation of attributes to XML' do
     xml_doc.remove_namespaces!
 
     attributes_element_not_present = xml_doc.xpath("//AddNewUser/attributes").blank?
-
-    puts "new syntax: attributes element not present: " + attributes_element_not_present.to_s
-
     expect(attributes_element_not_present).to eq true
   end
-  
+
   it "old :attributes! syntax: correctly maps a Ruby Hash to XML attributes" do
     LogInterceptor.reset_intercepted_request
 
@@ -64,9 +61,6 @@ describe 'Correct translation of attributes to XML' do
     xml_doc.remove_namespaces!
 
     attributes_element_not_present = xml_doc.xpath("//AddNewUser/attributes").blank?
-
-    puts "new syntax: attributes element not present: " + attributes_element_not_present.to_s
-
     expect(attributes_element_not_present).to eq true
   end
 end

data/spec/savon/operation_spec.rb

@@ -44,6 +44,16 @@ describe Savon::Operation do
       expect { new_operation(:no_such_operation, wsdl, globals) }.
         to raise_error(Savon::UnknownOperationError, /Unable to find SOAP operation: :no_such_operation/)
     end
+
+    it "raises if the endpoint cannot be reached" do
+      message = "Error!"
+      response = HTTPI::Response.new(500, {}, message)
+      error = Wasabi::Resolver::HTTPError.new(message, response)
+      Wasabi::Document.any_instance.stubs(:soap_actions).raises(error)
+
+      expect { new_operation(:verify_address, wsdl, globals) }.
+        to raise_error(Savon::HTTPError, /#{message}/)
+    end
   end
 
   describe ".create without a WSDL" do

data/spec/savon/soap_fault_spec.rb

@@ -3,6 +3,7 @@ require "spec_helper"
 describe Savon::SOAPFault do
   let(:soap_fault) { Savon::SOAPFault.new new_response(:body => Fixture.response(:soap_fault)), nori }
   let(:soap_fault2) { Savon::SOAPFault.new new_response(:body => Fixture.response(:soap_fault12)), nori }
+  let(:soap_fault_funky) { Savon::SOAPFault.new new_response(:body => Fixture.response(:soap_fault_funky)), nori }
   let(:soap_fault_nc) { Savon::SOAPFault.new new_response(:body => Fixture.response(:soap_fault)), nori_no_convert }
   let(:soap_fault_nc2) { Savon::SOAPFault.new new_response(:body => Fixture.response(:soap_fault12)), nori_no_convert }
   let(:another_soap_fault) { Savon::SOAPFault.new new_response(:body => Fixture.response(:another_soap_fault)), nori }
@@ -63,6 +64,10 @@ describe Savon::SOAPFault do
       it "works even if the keys are different in a SOAP 1.2 fault message" do
         expect(soap_fault_nc2.send method).to eq("(soap:Sender) Sender Timeout")
       end
+
+      it "works even if the keys are different in a funky SOAP fault message" do
+        expect(soap_fault_funky.send method).to eq("(42) The Answer to Life The Universe And Everything")
+      end
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: savon
 version: !ruby/object:Gem::Version
-  version: 2.8.1
+  version: 2.9.0
 platform: ruby
 authors:
 - Daniel Harrington
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-15 00:00:00.000000000 Z
+date: 2015-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nori
@@ -253,6 +253,7 @@ files:
 - spec/fixtures/response/multi_ref.xml
 - spec/fixtures/response/soap_fault.xml
 - spec/fixtures/response/soap_fault12.xml
+- spec/fixtures/response/soap_fault_funky.xml
 - spec/fixtures/response/taxcloud.xml
 - spec/fixtures/ssl/client_cert.pem
 - spec/fixtures/ssl/client_encrypted_key.pem