savon 2.17.2 → 2.17.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ffcf3a770d4dd548ec193c9f6d8b8723eef3a661273dc50e8bb5a06ba99f0f13
-  data.tar.gz: d03d1de9d1bc5b1af722b56dc71e99acc1a46f951f45d377b9eea2974016f2ed
+  metadata.gz: cde79beaab26839d499267e94eee281c4f35f34906fd6dfdd4fc4590dc2c710a
+  data.tar.gz: 93f661f0156d8331a68e440176d9aaef92d2744974858ee4f866e63f14a210a1
 SHA512:
-  metadata.gz: 5a5e490cbf30a0e2216439dc9ceb51493c5b5fec107ce3ff4219eb8c5ded1c9e3b612b6bb8b44c4163d12a97c73415f441f33542b35e22bd7b1908f8cb123fa2
-  data.tar.gz: c6d5c85d39f406f75e5e0b005b250e5a97da5d60e42ca44fe827d72f97b2fd967a054684be73e8134c19506e8da6e8dcc7222769fa017d2b7c02cf2336e6dc12
+  metadata.gz: 3f7436bc2d8c53b89a96a373ab015ce7461b86501549034b99a5ae585a8f25d113bd7e1d1897acc613360d8487bb198eeccf5d0cf4835be7e8f8e44dd4b637a3
+  data.tar.gz: 8e45f5f6494c8256878b54b4092f7a253686ddc5c9ea1f98cd372c9ed4b0c784a4b7c885604c70036a1398fe0ac5ff08847a13def8ed931c8ce7d5da6f7475df

data/CHANGELOG.md

@@ -5,6 +5,14 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.17.3] - 2026-06-23
+
+### Fixed
+
+**Fix Savon::HTTPError compatibility with Faraday transport**
+
+* **`Savon::HTTPError` works with the Faraday transport** ([#1050](https://github.com/savonrb/savon/issues/1050)). When a the WSDL could not be fetched under `transport: :faraday`, `Savon::HTTPError#to_s` and `#to_hash` raised `NoMethodError: undefined method 'code'` because they were handed a raw `Faraday::Response`, which exposes `#status` rather than `#code`. Transports now normalize adapter-specific response objects into `Savon::Transport::Response` before they reach `Savon::HTTPError`.
+
 ## [2.17.2] - 2026-06-10
 
 **Fix CVE-2026-53510 and restore 2.17.0 cookie regressions**

data/lib/savon/http_error.rb

@@ -6,20 +6,22 @@ module Savon
       http.error?
     end
 
-    def initialize(http)
-      @http = http
+    def initialize(transport_response)
+      @transport_response = transport_response
     end
 
-    attr_reader :http
+    def http
+      @transport_response
+    end
 
     def to_s
-      String.new("HTTP error (#{@http.code})").tap do |str_error|
-        str_error << ": #{@http.body}" unless @http.body.empty?
+      String.new("HTTP error (#{http.code})").tap do |str_error|
+        str_error << ": #{http.body}" unless http.body.empty?
       end
     end
 
     def to_hash
-      { code: @http.code, headers: @http.headers, body: @http.body }
+      { code: http.code, headers: http.headers, body: http.body }
     end
   end
 end

data/lib/savon/operation.rb

@@ -33,19 +33,20 @@ module Savon
     def self.create(operation_name, wsdl, globals, transport)
       if wsdl.document?
         ensure_name_is_symbol! operation_name
-        ensure_exists! operation_name, wsdl
+        ensure_exists! operation_name, wsdl, transport
       end
 
       new(operation_name, wsdl, globals, transport)
     end
 
-    def self.ensure_exists!(operation_name, wsdl)
+    # Verifies the operation is provided by the WSDL.
+    def self.ensure_exists!(operation_name, wsdl, transport)
       unless wsdl.soap_actions.include? operation_name
         raise UnknownOperationError, "Unable to find SOAP operation: #{operation_name.inspect}\n" \
                                      "Operations provided by your service: #{wsdl.soap_actions.inspect}"
       end
     rescue Wasabi::Resolver::HTTPError => e
-      raise HTTPError, e.response
+      raise HTTPError, transport.normalize_response(e.response)
     end
 
     def self.ensure_name_is_symbol!(operation_name)
@@ -73,19 +74,19 @@ module Savon
     # Transport::Response (or legacy HTTPI::Response), the HTTP call
     # is skipped and that response is used directly.
     def call(locals = {}, &block)
-      builder  = build(locals, &block)
-      response = Savon.notify_observers(@name, builder, @globals, @locals)
+      builder = build(locals, &block)
+      observer_response = Savon.notify_observers(@name, builder, @globals, @locals)
 
-      response =
-        if response.nil?
+      transport_response =
+        if observer_response.nil?
           body = builder.to_s
           headers = soap_headers(builder)
           @transport.post(endpoint.to_s, headers, body, @locals)
         else
-          normalize_observer_response(response)
+          normalize_observer_response(observer_response)
         end
 
-      create_response(response)
+      Response.new(transport_response, @globals, @locals)
     end
 
     # Builds and returns the HTTPI::Request that would be sent for this
@@ -106,10 +107,6 @@ module Savon
 
     private
 
-    def create_response(response)
-      Response.new(response, @globals, @locals)
-    end
-
     def set_locals(locals, block)
       locals = LocalOptions.new(locals)
       BlockInterface.new(locals).evaluate(block) if block
@@ -173,17 +170,12 @@ module Savon
     # Accepts Transport::Response directly (current contract), wraps
     # HTTPI::Response with a deprecation warning (legacy observer support),
     # and raises on anything else.
-    def normalize_observer_response(response)
-      return response if response.is_a?(Transport::Response)
+    def normalize_observer_response(observer_response)
+      return observer_response if observer_response.is_a?(Transport::Response)
 
-      if response.is_a?(HTTPI::Response)
+      if observer_response.is_a?(HTTPI::Response)
         warn "Observers returning HTTPI::Response is deprecated - return Savon::Transport::Response instead.", uplevel: 1
-        return Transport::Response.new(
-          response.code,
-          response.headers,
-          response.body,
-          cookies: HTTPI::Cookie.list_from_headers(response.headers)
-        )
+        return Transport::Response.from_httpi(observer_response)
       end
 
       raise Error, "Observers need to return a Savon::Transport::Response " \

data/lib/savon/response.rb

@@ -9,19 +9,23 @@ module Savon
     CRLF = /\r\n/
     WSP  = /[\t ]/
 
-    def initialize(http, globals, locals)
-      @http            = http
-      @globals         = globals
-      @locals          = locals
-      @attachments     = []
-      @xml             = ''
-      @has_parsed_body = false
+    def initialize(transport_response, globals, locals)
+      @transport_response = transport_response
+      @globals            = globals
+      @locals             = locals
+      @attachments        = []
+      @xml                = ''
+      @has_parsed_body    = false
 
       build_soap_and_http_errors!
       raise_soap_and_http_errors! if @globals[:raise_errors]
     end
 
-    attr_reader :http, :globals, :locals, :soap_fault, :http_error
+    attr_reader :globals, :locals, :soap_fault, :http_error
+
+    def http
+      @transport_response
+    end
 
     def success?
       !soap_fault? && !http_error?
@@ -29,11 +33,11 @@ module Savon
     alias successful? success?
 
     def soap_fault?
-      SOAPFault.present?(@http, xml)
+      SOAPFault.present?(http, xml)
     end
 
     def http_error?
-      HTTPError.present? @http
+      HTTPError.present? http
     end
 
     def header
@@ -70,7 +74,7 @@ module Savon
         parse_body unless @has_parsed_body
         @xml
       else
-        @http.body
+        http.body
       end
     end
 
@@ -132,8 +136,8 @@ module Savon
     end
 
     def build_soap_and_http_errors!
-      @soap_fault = SOAPFault.new(@http, nori, xml) if soap_fault?
-      @http_error = HTTPError.new(@http) if http_error?
+      @soap_fault = SOAPFault.new(http, nori, xml) if soap_fault?
+      @http_error = HTTPError.new(http) if http_error?
     end
 
     def raise_soap_and_http_errors!

data/lib/savon/transport/faraday.rb

@@ -38,17 +38,20 @@ module Savon
         log_request(url, headers, body) if log?
 
         faraday_response = @connection.post(url, body, headers)
-        response = Response.new(
-          faraday_response.status,
-          faraday_response.headers.to_h,
-          faraday_response.body,
-          cookies: self.class.parse_cookies(faraday_response.headers)
-        )
+        response = normalize_response(faraday_response)
 
         log_response(response) if log?
         response
       end
 
+      # Normalizes a native Faraday::Response into a Transport::Response.
+      #
+      # @param faraday_response [Faraday::Response]
+      # @return                 [Transport::Response]
+      def normalize_response(faraday_response)
+        Response.from_faraday(faraday_response)
+      end
+
       # Parses Set-Cookie headers into a Hash of name => value. Accepts both
       # the Array and String form. Attributes after the first ';' are discarded.
       def self.parse_cookies(headers)

data/lib/savon/transport/httpi.rb

@@ -33,18 +33,21 @@ module Savon
 
         log_request(http_request.url, http_request.headers, http_request.body) if log?
 
-        http_response = ::HTTPI.post(http_request, @globals[:adapter])
-        response = Response.new(
-          http_response.code,
-          http_response.headers,
-          http_response.body,
-          cookies: ::HTTPI::Cookie.list_from_headers(http_response.headers)
-        )
+        httpi_response = ::HTTPI.post(http_request, @globals[:adapter])
+        response = normalize_response(httpi_response)
 
         log_response(response) if log?
         response
       end
 
+      # Normalizes a native HTTPI::Response into a Transport::Response.
+      #
+      # @param httpi_response [HTTPI::Response]
+      # @return               [Transport::Response]
+      def normalize_response(httpi_response)
+        Response.from_httpi(httpi_response)
+      end
+
       # Builds a fully-configured HTTPI::Request.
       #
       # @param url          [String]              the SOAP endpoint URL

data/lib/savon/transport/response.rb

@@ -1,5 +1,8 @@
 # frozen_string_literal: true
 
+require "httpi"
+require "savon/transport/faraday"
+
 module Savon
   module Transport
     # Transport-agnostic HTTP response value object.
@@ -11,6 +14,32 @@ module Savon
     # Array of HTTPI::Cookie, while Faraday responses expose a plain Hash so
     # Faraday users do not depend on HTTPI types.
     class Response
+      # Builds a Response from an HTTPI::Response.
+      #
+      # @param httpi_response [HTTPI::Response]
+      # @return               [Transport::Response]
+      def self.from_httpi(httpi_response)
+        new(
+          httpi_response.code,
+          httpi_response.headers,
+          httpi_response.body,
+          cookies: ::HTTPI::Cookie.list_from_headers(httpi_response.headers)
+        )
+      end
+
+      # Builds a Response from a Faraday::Response.
+      #
+      # @param faraday_response [Faraday::Response]
+      # @return                 [Transport::Response]
+      def self.from_faraday(faraday_response)
+        new(
+          faraday_response.status,
+          faraday_response.headers.to_h,
+          faraday_response.body,
+          cookies: Savon::Transport::Faraday.parse_cookies(faraday_response.headers)
+        )
+      end
+
       # @param code    [Integer] HTTP status code
       # @param headers [Hash]    response headers
       # @param body    [String]  response body

data/lib/savon/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Savon
-  VERSION = '2.17.2'
+  VERSION = '2.17.3'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: savon
 version: !ruby/object:Gem::Version
-  version: 2.17.2
+  version: 2.17.3
 platform: ruby
 authors:
 - Daniel Harrington