savon 2.17.1 → 3.0.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 00ae14802f108cb0df2757b85888a35df4b6b0e462ae0d01c1eedc9b4f9c123c
-  data.tar.gz: cee1d2d13ed6e869611817271c43352c470c4c7fb79e72dc7e6e7a4d9ac37191
+  metadata.gz: 3f58a5268715a082369bc199231506447defea5f760fae67cb51507a9011836c
+  data.tar.gz: d349d7d546fb236e45f433047bd575dd6f6ec206254707094f02420ec58dfc07
 SHA512:
-  metadata.gz: 8b754234ac51e2213f92254a88345743cc54e09026e220d85931b8bfe0ba78f5a417f81e561047b37410f52713f3583120c6d3095ab68a2b9705427f03822d07
-  data.tar.gz: 49a3260e064073d9370b80b376db5f9c75bab5e38dbdf7db2ffc8533dc2a58652bb0699830468f1e59319a98fd7210503a6c999b386e3ec6c9f4d23ac7f813e1
+  metadata.gz: 91d6cd948edbb82b643fa5aaeef265dcfeef5037459478f0815f01bdacbe04cb159165301a9f0ebc75fd897470ff2a0b51de1fa256123843698a14925f5ebf43
+  data.tar.gz: 3a9fe95352e4f85e9e88f7eaffba5fb04df58085380ed7c62e8c0f31c0b110b5127c494125f373e97489c789991b6c1271e68df000606c3e1a3311a17edc951a

data/CHANGELOG.md

@@ -1,38 +1,22 @@
 # Savon changelog
 
-## 2.17.1 (2026-05-21)
-
-* Fix: [#1008](https://github.com/savonrb/savon/pull/1008) - The HTTPI and Faraday transports no longer set an explicit `Content-Length` request header. The underlying HTTP library already computes it from the body; sending it as well produced a duplicate header on adapters that do not deduplicate (e.g. httpclient), which some servers reject.
-* Fix: Requests using `attachments` were sent with a plain `text/xml` Content-Type instead of `multipart/related`. The 2.17.0 transport refactor assembled the request headers before the multipart body was built, leaving `Builder#multipart` empty at header time, so servers received a multipart body labelled as plain XML. 2.16.x and earlier are unaffected.
-
-## 2.17.0 (2026-05-19)
-
-**Add opt-in Faraday transport**
-
-Callers who set `transport: :faraday` get a memoized `Faraday::Connection` via `client.faraday` and full control over middleware, SSL, auth, and timeouts. Callers who do not set this option see no behavior change. HTTPI remains the default for 2.x.
-
-* Add: `transport: :faraday` global option. Defaults to `:httpi` (#992).
-* Add: `client.faraday` returns a memoized `Faraday::Connection` for configuring middleware, SSL, auth, and timeouts when using the Faraday transport.
-* Add: `Savon.client` raises if `transport: :faraday` is set but the faraday gem is not installed, or if any httpi-specific global option (`proxy`, timeouts, `ssl`, auth, `adapter`) is set alongside it. All conflicts are reported with their Faraday equivalents.
-* Change: Observers must return `Savon::Transport::Response` (or `nil`) instead of `HTTPI::Response`. Returning `HTTPI::Response` still works but emits a deprecation warning.
-* Unblocks:
-  * redirect following for WSDL fetches via `faraday-follow-redirects` middleware (#1033, savonrb/wasabi#18)
-  * digest authentication via `faraday-digestauth` middleware (#1021, savonrb/httpi#250)
-  * proxy authentication with special characters in passwords (#941)
-  * and setting an `Accept` header for WSDL requests from Rails apps (savonrb/wasabi#115)
-
-## 2.16.0 (2026-05-18)
-
-**Restore compatibility**
-
-If you stayed on 2.12.1 because a later version broke something, this release is for you. The fixes below target the most commonly reported upgrade blockers. Existing code should work without modification.
-
-* Fix: Restore `Savon::Response#hash` removed in 2.14.0 (#985). Callers on 2.12.1 that use `response.hash` get the soap body back instead of Ruby's integer object id. A deprecation warning is emitted on each call. Use `#full_hash` going forward.
-* Fix: Require wasabi >= 5.1.0 (#1015, #1016). Wasabi 4.x used message names as soap body element names and SOAPAction header values instead of operation names (savonrb/wasabi#122), causing servers to return a fault or reject the action for operations whose message name carried an `In` suffix.
-* Fix: Stop dumping all WSDL namespaces into every soap envelope (#1014, #942). 2.13.0 injected every namespace from the entire WSDL document into each request, including structural ones that have no place in a request body. Strict servers reject envelopes with unexpected or duplicate declarations.
-* Fix: Raise a proper `SOAPFault` instead of a raw exception when `soap:Fault` contains invalid encoding (#923).
-* Fix: `SOAPFault.present?` was ignoring its `xml` argument and always operating on the instance's own body.
-* Change: Added Ruby 3.4 (#1024) and Ruby 4.0 (#1039) to the CI test matrix.
+## Unreleased
+* Add your PR changelog line here
+
+## 3.0.0.rc1 (2024-07-15)
+
+* Use Faraday instead of HTTPI
+* BC BREAKING Cookies are handled differently now
+* BC BREAKING Multiple pieces of functionality will rely on faraday libraries to be provided by the consuming codebase
+* BC BREAKING Adapter overrides now utilize the faraday model
+* BC BREAKING Multiple hard deprecations due to a lack of feature parity between Faraday and HTTPI
+  * Deprecates digest auth
+  * Deprecates ssl_cert_key_file auth, upgrade path is to read the key
+    in and provide it
+  * Deprecates encrypted ssl keys, upgrade path is to
+    decrypt the key and pass it to faraday in code
+  * Deprecates providing a ca cert, upgrade path is to provide a ca cert file
+  * deprecates overriding ssl ciphers, as faraday does not support this
 
 ## 2.15.1 (2024-07-08)
 

data/README.md

@@ -2,78 +2,88 @@
 
 Heavy metal SOAP client
 
+[Documentation](https://www.rubydoc.info/gems/savon/) | [Support](https://stackoverflow.com/questions/tagged/savon) |
+[Mailing list](https://groups.google.com/forum/#!forum/savonrb) | [Twitter](http://twitter.com/savonrb)
+
 [![Ruby](https://github.com/savonrb/savon/actions/workflows/ci.yml/badge.svg)](https://github.com/savonrb/savon/actions/workflows/ci.yml)
 [![Gem Version](https://badge.fury.io/rb/savon.svg)](http://badge.fury.io/rb/savon)
+[![Code Climate](https://codeclimate.com/github/savonrb/savon.svg)](https://codeclimate.com/github/savonrb/savon)
 [![Coverage Status](https://coveralls.io/repos/savonrb/savon/badge.svg)](https://coveralls.io/r/savonrb/savon)
 
-Savon is a SOAP client for Ruby. [SOAP is the protocol](https://www.w3.org/TR/soap/) spoken by many enterprise systems in banking, government, ERP or payroll. When they hand you a WSDL URL or file instead of a REST spec, it's SOAP. Savon reads the WSDL, maps available operations to Ruby symbols, converts Ruby hashes to SOAP envelopes and turns XML responses into hashes you can work with.
-
-Full documentation is at [savonrb.com](https://savonrb.com).
+If you're reading this on GitHub, note that this README is for the main branch and that features/changes described here might not correspond to your version. You can find the documentation for your release [at rubydoc.info](https://www.rubydoc.info/find/gems?q=savon).
 
 ## Installation
 
-```ruby
-gem 'savon', '~> 2.17'
+Savon is available through [Rubygems](http://rubygems.org/gems/savon) and can be installed via:
+
+```
+$ gem install savon
+```
+
+or add it to your Gemfile like this:
+
+```
+gem 'savon', '~> 3.0.0'
 ```
 
-## Usage
+## Usage example
 
-```ruby
+``` ruby
 require 'savon'
 
-# Point Savon to a local or remote WSDL document
-client = Savon.client(wsdl: 'https://service.example.com?wsdl')
+# create a client for the service
+client = Savon.client(wsdl: 'http://service.example.com?wsdl')
+
+# or: create a client with a wsdl provided as a string
+client = Savon.client do |config|
+  wsdl_content = File.read("/path/to/wsdl")
+  config.wsdl wsdl_content
+end
 
-# See what the service exposes
 client.operations
-# => [:find_user, :create_user]
+# => [:find_user, :list_users]
 
-# Make a request and work with the response
+# call the 'findUser' operation
 response = client.call(:find_user, message: { id: 42 })
-response.body[:find_user_response]
-# => { id: 42, name: "Hoff" }
 
-# Savon raises a Savon::SOAPFault when the server returns a SOAP fault
-rescue Savon::SOAPFault => e
-  puts e.to_hash.dig(:fault, :faultstring)
+response.body
+# => { find_user_response: { id: 42, name: 'Hoff' } }
 ```
 
-Enable logging to see the raw SOAP envelopes. That's probably the single most useful thing while getting a new integration working:
+For more examples, you should check out the
+[integration tests](https://github.com/savonrb/savon/tree/version2/spec/integration).
 
-```ruby
-client = Savon.client(
-  wsdl: 'https://service.example.com?wsdl',
-  pretty_print_xml: true,
-  log: true
-)
-```
+## Upgrading from v2.x to v3.x
 
-### Authentication
+See [UPGRADING.md](UPGRADING.md) for more information.
 
-Most enterprise services require authentication. Common options:
+## Ruby version support
 
-```ruby
-# HTTP basic auth
-Savon.client(wsdl: '...', basic_auth: ['user', 'secret'])
+Every savon release is tested with contemporary supported versions of ruby. Historical compatibility information:
 
-# WS-Security (WSSE)
-Savon.client(wsdl: '...', wsse_auth: ['user', 'secret', :digest], wsse_timestamp: true)
-```
+* `main` - same support as Ruby
+* 2.15.x - MRI 3.0, 3.1, 3.2, 3.3
+* 2.13.x, 2.14.x - MRI 2.7, 3.0, 3.1
+* 2.12.x - MRI 2.2, 2.3, 2.4, 2.5
+* 2.11.x - MRI 2.0, 2.1, 2.2, and 2.3
 
-See [Authentication](https://savonrb.com/version2/globals.html) on the website for HTTP digest, NTLM, and certificate-based options.
+If you are running MRI 1.8.7, try a 2.6.x release.
 
-### Transport
+Most changes are not backported to older versions of savon, or unsupported ruby versions.
 
-Savon uses [HTTPI](https://github.com/savonrb/httpi) for HTTP by default. Since v2.17.0 you can opt-in to use Faraday by passing `transport: :faraday` which exposes the Faraday connection at `client.faraday` for you to configure. Savon is only adding some SOAP-specifics on top.
+## Running tests
 
-## Ruby support
+```bash
+$ bundle install
+$ bundle exec rspec
+```
 
-Savon 2.x requires Ruby 3.0 or later. See the [changelog](CHANGELOG.md) for historical compatibility.
+## FAQ
 
-## Known limitations
+* URI::InvalidURIError -- if you see this error, then it is likely that the http client you are using cannot parse the URI for your WSDL. Try `gem install httpclient` or add it to your `Gemfile`.
+  - See https://github.com/savonrb/savon/issues/488 for more info
 
-**WSDL imports are not followed.** Savon parses only the root WSDL document via [Wasabi](https://github.com/savonrb/wasabi). Messages, port types, and bindings defined in imported files are invisible to Savon. If you control the WSDL, merge the imported elements into the root document and pass that to Savon as a string. If you need full import support, the [WSDL](https://rubygems.org/gems/wsdl) gem is an alternative.
 
-## Contributing
+## Documentation
 
-See [CONTRIBUTING.md](CONTRIBUTING.md). MIT licensed.
+Please be sure to [read the documentation](https://www.rubydoc.info/github/savonrb/savon/).

data/Rakefile

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
 
@@ -12,7 +10,5 @@ RSpec::Core::RakeTask.new "spec:integration" do |t|
   t.pattern = "spec/integration/**/*_spec.rb"
 end
 
-desc "Alias for spec task"
-task test: :spec
-
-task default: :spec
+task :default => :spec
+task :test => :spec

data/lib/savon/block_interface.rb

@@ -1,16 +1,16 @@
 # frozen_string_literal: true
-
 module Savon
   class BlockInterface
+
     def initialize(target)
       @target = target
     end
 
     def evaluate(block)
-      if block.arity.positive?
+      if block.arity > 0
         block.call(@target)
       else
-        @original = eval("self", block.binding, __FILE__, __LINE__)
+        @original = eval("self", block.binding)
         instance_eval(&block)
       end
     end
@@ -22,5 +22,6 @@ module Savon
     rescue NoMethodError
       @original.send(method, *args, &block)
     end
+
   end
 end

data/lib/savon/builder.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-
 require "savon/header"
 require "savon/message"
 require "nokogiri"
@@ -13,12 +12,12 @@ module Savon
     SCHEMA_TYPES = {
       "xmlns:xsd" => "http://www.w3.org/2001/XMLSchema",
       "xmlns:xsi" => "http://www.w3.org/2001/XMLSchema-instance"
-    }.freeze
+    }
 
     SOAP_NAMESPACE = {
       1 => "http://schemas.xmlsoap.org/soap/envelope/",
       2 => "http://www.w3.org/2003/05/soap-envelope"
-    }.freeze
+    }
 
     WSA_NAMESPACE = "http://www.w3.org/2005/08/addressing"
 
@@ -35,7 +34,7 @@ module Savon
     end
 
     def pretty
-      Nokogiri.XML(to_s).to_xml(indent: 2)
+      Nokogiri.XML(to_s).to_xml(:indent => 2)
     end
 
     def build_document
@@ -72,36 +71,33 @@ module Savon
 
     def to_s
       return @locals[:xml] if @locals.include? :xml
-
       build_document
     end
 
     private
 
     def convert_type_definitions_to_hash
-      @wsdl.type_definitions.each_with_object({}) do |(path, type), memo|
+      @wsdl.type_definitions.inject({}) do |memo, (path, type)|
         memo[path] = type
+        memo
       end
     end
 
     def convert_type_namespaces_to_hash
-      @wsdl.type_namespaces.each_with_object({}) do |(path, uri), memo|
+      @wsdl.type_namespaces.inject({}) do |memo, (path, uri)|
         key, value = use_namespace(path, uri)
         memo[key] = value
+        memo
       end
     end
 
     def use_namespace(path, uri)
       @internal_namespace_count ||= 0
 
-      unless (identifier = namespace_by_uri(uri))
-        wsdl_identifier = @wsdl.document? ? @wsdl.parser.namespaces.key(uri) : nil
-        # The prefix may already be taken by the target namespace or a user-supplied
-        # :namespaces override - fall back to ins0, ins1... rather than overwriting it.
-        wsdl_identifier = nil if wsdl_identifier && namespaces.key?("xmlns:#{wsdl_identifier}")
-        identifier = wsdl_identifier || "ins#{@internal_namespace_count}"
+      unless identifier = namespace_by_uri(uri)
+        identifier = "ins#{@internal_namespace_count}"
         namespaces["xmlns:#{identifier}"] = uri
-        @internal_namespace_count += 1 unless wsdl_identifier
+        @internal_namespace_count += 1
       end
 
       [path, identifier]
@@ -120,9 +116,21 @@ module Savon
           @globals[:namespace] || @wsdl.namespace
 
         # check env_namespace
-        namespaces["xmlns#{env_namespace && env_namespace != '' ? ":#{env_namespace}" : ''}"] =
+        namespaces["xmlns#{env_namespace && env_namespace != "" ? ":#{env_namespace}" : ''}"] =
           SOAP_NAMESPACE[@globals[:soap_version]]
 
+        if @wsdl&.document
+          @wsdl.parser.namespaces.each do |identifier, path|
+            next if identifier == 'xmlns' # Do not include xmlns namespace as this causes issues for some servers (https://github.com/savonrb/savon/issues/986)
+
+            prefixed_identifier = "xmlns:#{identifier}"
+
+            next if namespaces.key?(prefixed_identifier)
+
+            namespaces[prefixed_identifier] = path
+          end
+        end
+
         namespaces
       end
     end
@@ -137,9 +145,8 @@ module Savon
 
     def namespaced_message_tag
       tag_name = message_tag
-      return [tag_name] if @wsdl.document? && @wsdl.soap_input(@operation_name.to_sym).is_a?(Hash)
-
-      if namespace_identifier.nil?
+      return [tag_name] if @wsdl.document? and @wsdl.soap_input(@operation_name.to_sym).is_a?(Hash)
+      if namespace_identifier == nil
         [tag_name, message_attributes]
       elsif @used_namespaces[[tag_name.to_s]]
         [@used_namespaces[[tag_name.to_s]], tag_name, message_attributes]
@@ -157,7 +164,6 @@ module Savon
       message_tag = serialized_message_tag[1]
       @wsdl.soap_input(@operation_name.to_sym)[message_tag].each_pair do |message, type|
         break if @locals[:message].nil?
-
         message_locals = @locals[:message][StringUtils.snakecase(message).to_sym]
         message_content = Message.new(message_tag, namespace_identifier, @types, @used_namespaces, message_locals, :unqualified, @globals[:convert_request_keys_to], @globals[:unwrap]).to_s
         messages += "<#{message} xsi:type=\"#{type.join(':')}\">#{message_content}</#{message}>"
@@ -171,7 +177,7 @@ module Savon
       message_tag = wsdl_tag_name.keys.first if wsdl_tag_name.is_a?(Hash)
       message_tag ||= @locals[:message_tag]
       message_tag ||= wsdl_tag_name
-      message_tag ||= Gyoku.xml_tag(@operation_name, key_converter: @globals[:convert_request_keys_to])
+      message_tag ||= Gyoku.xml_tag(@operation_name, :key_converter => @globals[:convert_request_keys_to])
 
       message_tag.to_sym
     end
@@ -181,7 +187,7 @@ module Savon
     end
 
     def body_message
-      if @wsdl.document? && @wsdl.soap_input(@operation_name.to_sym).is_a?(Hash)
+      if @wsdl.document? and @wsdl.soap_input(@operation_name.to_sym).is_a?(Hash)
         serialized_messages
       else
         message.to_s
@@ -215,7 +221,7 @@ module Savon
 
     def builder
       builder = ::Builder::XmlMarkup.new
-      builder.instruct!(:xml, encoding: @globals[:encoding])
+      builder.instruct!(:xml, :encoding => @globals[:encoding])
       builder
     end
 
@@ -248,7 +254,7 @@ module Savon
 
       # the mail.body.encoded algorithm reorders the parts, default order is [ "text/plain", "text/enriched", "text/html" ]
       # should redefine the sort order, because the soap request xml should be the first
-      multipart_message.body.set_sort_order ["text/xml"]
+      multipart_message.body.set_sort_order [ "text/xml" ]
 
       multipart_message.body.encoded(multipart_message.content_transfer_encoding)
     end
@@ -263,10 +269,10 @@ module Savon
       end
       multipart_message.add_part xml_part
 
-      # request.headers["Content-Type"] = "multipart/related; boundary=\"#{multipart_message.body.boundary}\"; type=\"text/xml\"; start=\"#{xml_part.content_id}\""
+      #request.headers["Content-Type"] = "multipart/related; boundary=\"#{multipart_message.body.boundary}\"; type=\"text/xml\"; start=\"#{xml_part.content_id}\""
       @multipart = {
         multipart_boundary: multipart_message.body.boundary,
-        start: xml_part.content_id
+        start: xml_part.content_id,
       }
 
       multipart_message

data/lib/savon/client.rb

@@ -1,26 +1,19 @@
 # frozen_string_literal: true
-
 require "savon/operation"
-require "savon/transport/httpi"
-require "savon/transport/faraday"
+require "savon/request"
 require "savon/options"
 require "savon/block_interface"
 require "wasabi"
 
 module Savon
-  # The main entry point for Savon.
-  #
-  # Holds global configuration, owns the WSDL document, and dispatches
-  # named operations. A single Client instance is typically shared across
-  # multiple calls to the same service.
   class Client
+
     def initialize(globals = {}, &block)
-      unless globals.is_a? Hash
+      unless globals.kind_of? Hash
         raise_version1_initialize_error! globals
       end
 
       set_globals(globals, block)
-      @globals.validate_transport!
 
       unless wsdl_or_endpoint_and_namespace_specified?
         raise_initialization_error!
@@ -31,25 +24,13 @@ module Savon
 
     attr_reader :globals, :wsdl
 
-    # Returns the memoized Faraday::Connection for this client.
-    # Callers use this to configure middleware, SSL, auth, timeouts, and any
-    # other transport-level concern before making calls.
-    # Raises ArgumentError if transport is not :faraday.
-    def faraday
-      unless @globals[:transport] == :faraday
-        raise ArgumentError, "client.faraday is only available when transport: :faraday is set"
-      end
-
-      @faraday ||= ::Faraday.new
-    end
-
     def operations
       raise_missing_wsdl_error! unless @wsdl.document?
       @wsdl.soap_actions
     end
 
     def operation(operation_name)
-      Operation.create(operation_name, @wsdl, @globals, build_transport)
+      Operation.create(operation_name, @wsdl, @globals)
     end
 
     def call(operation_name, locals = {}, &block)
@@ -67,15 +48,6 @@ module Savon
 
     private
 
-    # Builds the transport for a single operation.
-    def build_transport
-      if @globals[:transport] == :faraday
-        Transport::Faraday.new(faraday, @globals)
-      else
-        Transport::HTTPI.new(@globals)
-      end
-    end
-
     def set_globals(globals, block)
       globals = GlobalOptions.new(globals)
       BlockInterface.new(globals).evaluate(block) if block
@@ -86,16 +58,12 @@ module Savon
     def build_wsdl_document
       @wsdl = Wasabi::Document.new
 
-      @wsdl.document  = @globals[:wsdl]      if @globals.include? :wsdl
-      @wsdl.endpoint  = @globals[:endpoint]  if @globals.include? :endpoint
-      @wsdl.namespace = @globals[:namespace] if @globals.include? :namespace
+      @wsdl.document    = @globals[:wsdl]        if @globals.include? :wsdl
+      @wsdl.endpoint    = @globals[:endpoint]    if @globals.include? :endpoint
+      @wsdl.namespace   = @globals[:namespace]   if @globals.include? :namespace
+      @wsdl.adapter     = @globals[:adapter]     if @globals.include? :adapter
 
-      if @globals[:transport] == :faraday
-        @wsdl.request = faraday
-      else
-        @wsdl.adapter = @globals[:adapter] if @globals.include? :adapter
-        @wsdl.request = Transport::HTTPI.new(@globals).wsdl_request
-      end
+      @wsdl.request = WSDLRequest.new(@globals).build
     end
 
     def wsdl_or_endpoint_and_namespace_specified?
@@ -104,9 +72,9 @@ module Savon
 
     def raise_version1_initialize_error!(object)
       raise InitializationError,
-            "Some code tries to initialize Savon with the #{object.inspect} (#{object.class}) \n" \
-            "Savon 2 expects a Hash of options for creating a new client and executing requests.\n" \
-            "Please read the updated documentation for version 2: http://savonrb.com/version2.html"
+        "Some code tries to initialize Savon with the #{object.inspect} (#{object.class}) \n" \
+        "Savon 2 expects a Hash of options for creating a new client and executing requests.\n" \
+        "Please read the updated documentation for version 2: http://savonrb.com/version2.html"
     end
 
     def raise_initialization_error!
@@ -120,5 +88,6 @@ module Savon
     def raise_missing_wsdl_error!
       raise "Unable to inspect the service without a WSDL document."
     end
+
   end
 end

data/lib/savon/header.rb

@@ -1,13 +1,13 @@
 # frozen_string_literal: true
-
 require "akami"
 require "gyoku"
 require "securerandom"
 
 module Savon
   class Header
+
     def initialize(globals, locals)
-      @gyoku_options  = { key_converter: globals[:convert_request_keys_to] }
+      @gyoku_options  = { :key_converter => globals[:convert_request_keys_to] }
 
       @wsse_auth      = locals[:wsse_auth].nil? ? globals[:wsse_auth] : locals[:wsse_auth]
       @wsse_timestamp = locals[:wsse_timestamp].nil? ? globals[:wsse_timestamp] : locals[:wsse_timestamp]
@@ -41,7 +41,7 @@ module Savon
 
     def build_header
       header =
-        if global_header.is_a?(Hash) && local_header.is_a?(Hash)
+        if global_header.kind_of?(Hash) && local_header.kind_of?(Hash)
           global_header.merge(local_header)
         elsif local_header
           local_header
@@ -58,17 +58,16 @@ module Savon
     end
 
     def build_wsa_header
-      return '' unless @globals[:use_wsa_headers]
-
-      convert_to_xml({
-        'wsa:Action'    => @locals[:soap_action],
-        'wsa:To'        => @globals[:endpoint],
-        'wsa:MessageID' => "urn:uuid:#{SecureRandom.uuid}"
-      })
+       return '' unless @globals[:use_wsa_headers]
+       convert_to_xml({
+         'wsa:Action' => @locals[:soap_action],
+         'wsa:To' => @globals[:endpoint],
+         'wsa:MessageID' => "urn:uuid:#{SecureRandom.uuid}"
+       })
     end
 
     def convert_to_xml(hash_or_string)
-      if hash_or_string.is_a? Hash
+      if hash_or_string.kind_of? Hash
         Gyoku.xml(hash_or_string, gyoku_options)
       else
         hash_or_string.to_s
@@ -79,11 +78,12 @@ module Savon
       wsse = Akami.wsse
       wsse.credentials(*wsse_auth) if wsse_auth
       wsse.timestamp = wsse_timestamp if wsse_timestamp
-      if wsse_signature&.have_document?
+      if wsse_signature && wsse_signature.have_document?
         wsse.signature = wsse_signature
       end
 
       wsse
     end
+
   end
 end

data/lib/savon/http_error.rb

@@ -2,8 +2,9 @@
 
 module Savon
   class HTTPError < Error
+
     def self.present?(http)
-      http.error?
+      !http.success?
     end
 
     def initialize(http)
@@ -13,13 +14,14 @@ module Savon
     attr_reader :http
 
     def to_s
-      String.new("HTTP error (#{@http.code})").tap do |str_error|
+      String.new("HTTP error (#{@http.status})").tap do |str_error|
         str_error << ": #{@http.body}" unless @http.body.empty?
       end
     end
 
     def to_hash
-      { code: @http.code, headers: @http.headers, body: @http.body }
+      { :code => @http.status, :headers => @http.headers, :body => @http.body }
     end
+
   end
 end

data/lib/savon/log_message.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
-
 require "nokogiri"
 
 module Savon
   class LogMessage
+
     def initialize(message, filters = [], pretty_print = false)
       @message      = message
       @filters      = filters
@@ -46,7 +46,8 @@ module Savon
     end
 
     def nokogiri_options
-      @pretty_print ? { indent: 2 } : { save_with: Nokogiri::XML::Node::SaveOptions::AS_XML }
+      @pretty_print ? { :indent => 2 } : { :save_with => Nokogiri::XML::Node::SaveOptions::AS_XML }
     end
+
   end
 end