savon 2.12.0 → 2.13.1

data/spec/savon/options_spec.rb

@@ -1,10 +1,11 @@
+# frozen_string_literal: true
 require "spec_helper"
 require "integration/support/server"
 require "json"
 require "ostruct"
 require "logger"
 
-describe "Options" do
+RSpec.describe "Options" do
 
   before :all do
     @server = IntegrationServer.run
@@ -219,6 +220,17 @@ describe "Options" do
       expect(response.http.body).to include("<user>lea</user>")
       expect(response.http.body).to include("<password>top-secret</password>")
     end
+
+    it "qualifies elements embedded in complex types" do
+      client = new_client(:endpoint => @server.url(:repeat),
+                          :wsdl => Fixture.wsdl(:elements_in_types))
+      msg = {":TopLevelTransaction"=>{":Qualified"=>"A Value"}}
+
+      response = client.call(:top_level_transaction, :message => msg)
+
+      expect(response.http.body.scan(/<tns:Qualified>/).count).to eq(1)
+    end
+
   end
 
   context "global :env_namespace" do
@@ -387,6 +399,26 @@ describe "Options" do
     end
   end
 
+  context "global :log_headers" do
+    it "instructs Savon to log SOAP requests and responses headers" do
+      stdout = mock_stdout {
+        client = new_client(:endpoint => @server.url, :log => true)
+        client.call(:authenticate)
+      }
+      soap_header = stdout.string.include? "Content-Type"
+      expect(soap_header).to be true
+    end
+
+    it "stops Savon from logging SOAP requests and responses headers" do
+      stdout = mock_stdout {
+        client = new_client(:endpoint => @server.url, :log => true, :log_headers => false)
+        client.call(:authenticate)
+      }
+      soap_header = stdout.string.include? "Content-Type"
+      expect(soap_header).to be false
+    end
+  end
+
   context "global :ssl_version" do
     it "sets the SSL version to use" do
       HTTPI::Auth::SSL.any_instance.expects(:ssl_version=).with(:TLSv1).twice
@@ -396,6 +428,24 @@ describe "Options" do
     end
   end
 
+  context "global :ssl_min_version" do
+    it "sets the SSL min_version to use" do
+      HTTPI::Auth::SSL.any_instance.expects(:min_version=).with(:TLS1_2).twice
+
+      client = new_client(:endpoint => @server.url, :ssl_min_version => :TLS1_2)
+      client.call(:authenticate)
+    end
+  end
+
+  context "global :ssl_max_version" do
+    it "sets the SSL max_version to use" do
+      HTTPI::Auth::SSL.any_instance.expects(:max_version=).with(:TLS1_2).twice
+
+      client = new_client(:endpoint => @server.url, :ssl_max_version => :TLS1_2)
+      client.call(:authenticate)
+    end
+  end
+
   context "global :ssl_verify_mode" do
     it "sets the verify mode to use" do
       HTTPI::Auth::SSL.any_instance.expects(:verify_mode=).with(:peer).twice

data/spec/savon/qualified_message_spec.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 module Savon
-  describe QualifiedMessage, "#to_hash" do
+  RSpec.describe QualifiedMessage, "#to_hash" do
 
     context "if a key ends with !" do
       let(:used_namespaces) { {} }

data/spec/savon/request_logger_spec.rb

@@ -1,6 +1,7 @@
+# frozen_string_literal: true
 require "spec_helper"
 
-describe Savon::RequestLogger do
+RSpec.describe Savon::RequestLogger do
 
   subject            { described_class.new(globals) }
   let(:globals)      { Savon::GlobalOptions.new(:log => true, :pretty_print_xml => true) }

data/spec/savon/request_spec.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
 require "spec_helper"
 require "integration/support/server"
 
-describe Savon::WSDLRequest do
+RSpec.describe Savon::WSDLRequest do
 
   let(:globals)      { Savon::GlobalOptions.new }
   let(:http_request) { HTTPI::Request.new }
@@ -73,6 +74,20 @@ describe Savon::WSDLRequest do
       end
     end
 
+    describe "write timeout" do
+      it "is set when specified" do
+        globals.write_timeout(44)
+        http_request.expects(:write_timeout=).with(44)
+
+        new_wsdl_request.build
+      end
+
+      it "is not set otherwise" do
+        http_request.expects(:read_timeout=).never
+        new_wsdl_request.build
+      end
+    end
+
     describe "ssl version" do
       it "is set when specified" do
         globals.ssl_version(:TLSv1)
@@ -87,6 +102,34 @@ describe Savon::WSDLRequest do
       end
     end
 
+    describe "ssl min_version" do
+      it "is set when specified" do
+        globals.ssl_min_version(:TLS1_2)
+        http_request.auth.ssl.expects(:min_version=).with(:TLS1_2)
+
+        new_wsdl_request.build
+      end
+
+      it "is not set otherwise" do
+        http_request.auth.ssl.expects(:min_version=).never
+        new_wsdl_request.build
+      end
+    end
+
+    describe "ssl max_version" do
+      it "is set when specified" do
+        globals.ssl_max_version(:TLS1_2)
+        http_request.auth.ssl.expects(:max_version=).with(:TLS1_2)
+
+        new_wsdl_request.build
+      end
+
+      it "is not set otherwise" do
+        http_request.auth.ssl.expects(:max_version=).never
+        new_wsdl_request.build
+      end
+    end
+
     describe "ssl verify mode" do
       it "is set when specified" do
         globals.ssl_verify_mode(:peer)
@@ -148,6 +191,7 @@ describe Savon::WSDLRequest do
     describe "ssl encrypted cert key file" do
       describe "set with an invalid decrypting password" do
         it "fails when attempting to use the SSL private key" do
+          skip("JRuby: find out why this does not raise an error!") if RUBY_PLATFORM == 'java'
           pass = "wrong-password"
           key  = File.expand_path("../../fixtures/ssl/client_encrypted_key.pem", __FILE__)
           cert = File.expand_path("../../fixtures/ssl/client_encrypted_key_cert.pem", __FILE__)
@@ -158,15 +202,12 @@ describe Savon::WSDLRequest do
 
           new_wsdl_request.build
 
-          expect { http_request.auth.ssl.cert_key }.to raise_error
+          expect { http_request.auth.ssl.cert_key }.to raise_error OpenSSL::PKey::PKeyError
         end
       end
 
       describe "set with a valid decrypting password" do
         it "handles SSL private keys properly" do
-          if RUBY_ENGINE == 'jruby'
-            pending("find out why this fails with a null pointer exception on jruby")
-          end
           pass = "secure-password!42"
           key  = File.expand_path("../../fixtures/ssl/client_encrypted_key.pem", __FILE__)
           cert = File.expand_path("../../fixtures/ssl/client_encrypted_key_cert.pem", __FILE__)
@@ -257,7 +298,7 @@ describe Savon::WSDLRequest do
 
 end
 
-describe Savon::SOAPRequest do
+RSpec.describe Savon::SOAPRequest do
 
   let(:globals)      { Savon::GlobalOptions.new }
   let(:http_request) { HTTPI::Request.new }

data/spec/savon/response_spec.rb

@@ -1,6 +1,7 @@
+# frozen_string_literal: true
 require "spec_helper"
 
-describe Savon::Response do
+RSpec.describe Savon::Response do
 
   let(:globals) { Savon::GlobalOptions.new }
   let(:locals)  { Savon::LocalOptions.new }

data/spec/savon/soap_fault_spec.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
 require "spec_helper"
 
-describe Savon::SOAPFault do
+RSpec.describe Savon::SOAPFault do
   let(:soap_fault) { Savon::SOAPFault.new new_response(:body => Fixture.response(:soap_fault)), nori }
+  let(:empty_soap_fault) { Savon::SOAPFault.new new_response(:body => Fixture.response(:empty_soap_fault)), nori }
   let(:soap_fault2) { Savon::SOAPFault.new new_response(:body => Fixture.response(:soap_fault12)), nori }
   let(:soap_fault_funky) { Savon::SOAPFault.new new_response(:body => Fixture.response(:soap_fault_funky)), nori }
   let(:soap_fault_nc) { Savon::SOAPFault.new new_response(:body => Fixture.response(:soap_fault)), nori_no_convert }
@@ -29,6 +31,11 @@ describe Savon::SOAPFault do
       expect(Savon::SOAPFault.present? http).to be_truthy
     end
 
+    it "returns true if the HTTP response contains a SOAP 1.1 fault with empty fault tags" do
+      http = new_response(:body => Fixture.response(:empty_soap_fault))
+      expect(Savon::SOAPFault.present? http).to be_truthy
+    end
+
     it "returns true if the HTTP response contains a SOAP 1.2 fault" do
       http = new_response(:body => Fixture.response(:soap_fault12))
       expect(Savon::SOAPFault.present? http).to be_truthy
@@ -50,6 +57,10 @@ describe Savon::SOAPFault do
         expect(soap_fault.send method).to eq("(soap:Server) Fault occurred while processing.")
       end
 
+      it "returns an empty fault message" do
+        expect(empty_soap_fault.send method).to eq(nil)
+      end
+
       it "returns a SOAP 1.2 fault message" do
         expect(soap_fault2.send method).to eq("(soap:Sender) Sender Timeout")
       end

data/spec/savon/softlayer_spec.rb

@@ -1,6 +1,7 @@
+# frozen_string_literal: true
 require "spec_helper"
 
-describe Savon::Builder do
+RSpec.describe Savon::Builder do
 
   subject(:builder) { Savon::Builder.new(:create_object, wsdl, globals, locals) }
 
@@ -19,9 +20,23 @@ describe Savon::Builder do
         }
       }
 
+      expected_namespaces = {
+        'xmlns'           => "http://schemas.xmlsoap.org/wsdl/",
+        'xmlns:xsd'       => "http://www.w3.org/2001/XMLSchema",
+        'xmlns:xsi'       => "http://www.w3.org/2001/XMLSchema-instance",
+        'xmlns:tns'       => "http://api.service.softlayer.com/soap/v3/",
+        'xmlns:env'       => "http://schemas.xmlsoap.org/soap/envelope/",
+        'xmlns:soap'      => "http://schemas.xmlsoap.org/wsdl/soap/",
+        'xmlns:soap-enc'  => "http://schemas.xmlsoap.org/soap/encoding/",
+        'xmlns:wsdl'      => "http://schemas.xmlsoap.org/wsdl/"
+      }
+
       locals = Savon::LocalOptions.new(message)
       builder = Savon::Builder.new(:create_object, wsdl, globals, locals)
-      expect(builder.to_s).to eq('<?xml version="1.0" encoding="UTF-8"?><env:Envelope xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:tns="http://api.service.softlayer.com/soap/v3/" xmlns:env="http://schemas.xmlsoap.org/soap/envelope/"><env:Body><tns:createObject><templateObject><longName>Zertico LLC Reseller</longName></templateObject></tns:createObject></env:Body></env:Envelope>')
+
+      envelope = Nokogiri::XML(builder.to_s).xpath('./env:Envelope').first
+
+      expect(envelope.namespaces).to match(expected_namespaces)
     end
   end
 end

data/spec/spec_helper.rb

@@ -1,11 +1,10 @@
+# frozen_string_literal: true
 require "bundler"
+require "byebug"
 Bundler.setup(:default, :development)
 
 unless RUBY_PLATFORM =~ /java/
   require "simplecov"
-  require "coveralls"
-
-  SimpleCov.formatter = Coveralls::SimpleCov::Formatter
   SimpleCov.start do
       add_filter "spec"
   end
@@ -19,12 +18,14 @@ require "rspec"
 require "httpclient"
 
 support_files = File.expand_path("spec/support/**/*.rb")
-Dir[support_files].each { |file| require file }
+Dir[support_files].sort.each { |file| require file }
 
 RSpec.configure do |config|
   config.include SpecSupport
   config.mock_with :mocha
   config.order = "random"
+  config.example_status_persistence_file_path = ".rspec_status"
+  config.disable_monkey_patching!
 end
 
 HTTPI.log = false

data/spec/support/adapters.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'httpi/adapter/httpclient'
 
 # Proxy adapter. Records all requests and passes them to HTTPClient

data/spec/support/endpoint.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Endpoint
   class << self
 

data/spec/support/fixture.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Fixture
 
   TYPES = { :gzip => "gz", :response => "xml", :wsdl => "xml" }

data/spec/support/integration.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module SpecSupport
 
   def call_and_fail_gracefully(client, *args, &block)

data/spec/support/stdout.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module SpecSupport
 
   def mock_stdout

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: savon
 version: !ruby/object:Gem::Version
-  version: 2.12.0
+  version: 2.13.1
 platform: ruby
 authors:
 - Daniel Harrington
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-01-17 00:00:00.000000000 Z
+date: 2022-09-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nori
@@ -28,16 +28,16 @@ dependencies:
   name: httpi
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.3'
+        version: 2.4.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.3'
+        version: 2.4.5
 - !ruby/object:Gem::Dependency
   name: wasabi
   requirement: !ruby/object:Gem::Requirement
@@ -108,6 +108,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.8.1
+- !ruby/object:Gem::Dependency
+  name: mail
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.5'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.5'
 - !ruby/object:Gem::Dependency
   name: rack
   requirement: !ruby/object:Gem::Requirement
@@ -126,44 +140,58 @@ dependencies:
   name: puma
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: 4.3.8
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 4.3.8
+- !ruby/object:Gem::Dependency
+  name: byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.1'
+        version: 12.3.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.1'
+        version: 12.3.3
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.14'
+        version: '3.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.14'
+        version: '3.9'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
@@ -182,16 +210,16 @@ dependencies:
   name: json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: 2.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: 2.3.0
 description: Heavy metal SOAP client
 email: me@rubiii.com
 executables: []
@@ -199,15 +227,14 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
-- ".travis.yml"
 - ".yardopts"
 - CHANGELOG.md
 - CONTRIBUTING.md
 - Gemfile
 - LICENSE
 - README.md
+- RELEASING.md
 - Rakefile
-- donate.png
 - lib/savon.rb
 - lib/savon/block_interface.rb
 - lib/savon/builder.rb
@@ -233,6 +260,7 @@ files:
 - spec/fixtures/gzip/message.gz
 - spec/fixtures/response/another_soap_fault.xml
 - spec/fixtures/response/authentication.xml
+- spec/fixtures/response/empty_soap_fault.xml
 - spec/fixtures/response/f5.xml
 - spec/fixtures/response/header.xml
 - spec/fixtures/response/list.xml
@@ -250,6 +278,7 @@ files:
 - spec/fixtures/wsdl/betfair.xml
 - spec/fixtures/wsdl/brand.xml
 - spec/fixtures/wsdl/edialog.xml
+- spec/fixtures/wsdl/elements_in_types.xml
 - spec/fixtures/wsdl/interhome.xml
 - spec/fixtures/wsdl/lower_camel.xml
 - spec/fixtures/wsdl/multiple_namespaces.xml
@@ -259,14 +288,8 @@ files:
 - spec/fixtures/wsdl/team_software.xml
 - spec/fixtures/wsdl/vies.xml
 - spec/fixtures/wsdl/wasmuth.xml
-- spec/integration/centra_spec.rb
-- spec/integration/email_example_spec.rb
-- spec/integration/random_quote_spec.rb
-- spec/integration/ratp_example_spec.rb
-- spec/integration/stockquote_example_spec.rb
 - spec/integration/support/application.rb
 - spec/integration/support/server.rb
-- spec/integration/temperature_example_spec.rb
 - spec/integration/zipcode_example_spec.rb
 - spec/savon/builder_spec.rb
 - spec/savon/client_spec.rb
@@ -277,6 +300,7 @@ files:
 - spec/savon/message_spec.rb
 - spec/savon/mock_spec.rb
 - spec/savon/model_spec.rb
+- spec/savon/multipart_request_spec.rb
 - spec/savon/observers_spec.rb
 - spec/savon/operation_spec.rb
 - spec/savon/options_spec.rb
@@ -296,7 +320,7 @@ homepage: http://savonrb.com
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -304,16 +328,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.2
+      version: 2.7.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: savon
-rubygems_version: 2.6.13
-signing_key: 
+rubygems_version: 3.3.7
+signing_key:
 specification_version: 4
 summary: Heavy metal SOAP client
 test_files: []

data/.travis.yml

@@ -1,18 +0,0 @@
-# https://github.com/travis-ci/travis-ci/wiki/.travis.yml-options
-language: "ruby"
-sudo: false
-before_install:
-  - gem install bundler
-script: "bundle exec rake --trace"
-rvm:
-  - 2.2.4
-  - 2.3.0
-  - 2.4.1
-  - jruby-9.1.15.0
-  - rbx-2
-matrix:
-  allow_failures:
-    - rvm: rbx-2
-  fast_finish: true
-notifications:
-  irc: "irc.freenode.org#savon"

data/spec/integration/centra_spec.rb

@@ -1,67 +0,0 @@
-require 'spec_helper'
-
-module LogInterceptor
-  @@intercepted_request = ""
-  def self.debug(message = nil)
-    message ||= yield if block_given?
-
-    # save only the first XMLly message
-    if message.include? "xml version"
-      @@intercepted_request = message if @@intercepted_request == ""
-    end
-  end
-
-  def self.info(message = nil)
-  end
-
-  def self.get_intercepted_request
-    @@intercepted_request
-  end
-
-  def self.reset_intercepted_request
-    @@intercepted_request = ""
-  end
-end
-
-describe 'Correct translation of attributes to XML' do
-  it "new :@attr syntax: correctly maps a Ruby Hash to XML attributes" do
-    LogInterceptor.reset_intercepted_request
-
-    client = Savon.client(
-      :wsdl => "http://mt205.sabameeting.com/CWS/CWS.asmx?WSDL",
-      :log => true,
-      :logger => LogInterceptor
-    )
-
-    response = nil
-    begin
-      response = call_and_fail_gracefully(client, :add_new_user, :message => { :user => { :@userID => "test" } })
-    rescue
-    end
-
-    xml_doc = Nokogiri::XML(LogInterceptor.get_intercepted_request)
-    xml_doc.remove_namespaces!
-
-    attributes_element_not_present = xml_doc.xpath("//AddNewUser/attributes").blank?
-    expect(attributes_element_not_present).to eq true
-  end
-
-  it "old :attributes! syntax: correctly maps a Ruby Hash to XML attributes" do
-    LogInterceptor.reset_intercepted_request
-
-    client = Savon.client(
-      :wsdl => "http://mt205.sabameeting.com/CWS/CWS.asmx?WSDL",
-      :log => true,
-      :logger => LogInterceptor
-    )
-
-    response = nil
-    response = call_and_fail_gracefully(client, :add_new_user, :message => { :user => {}, :attributes! => { :user => { :userID => "test" } } })
-
-    xml_doc = Nokogiri::XML(LogInterceptor.get_intercepted_request)
-    xml_doc.remove_namespaces!
-
-    attributes_element_not_present = xml_doc.xpath("//AddNewUser/attributes").blank?
-    expect(attributes_element_not_present).to eq true
-  end
-end