savon 0.7.9 → 0.8.0.beta.1

data/spec/savon/core_ext/datetime_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe DateTime do
   before do
     @datetime = DateTime.new 2012, 03, 22, 16, 22, 33
-    @datetime_string = "2012-03-22T16:22:33Z"
+    @datetime_string = "2012-03-22T16:22:33+00:00"
   end
 
   describe "to_soap_value" do

data/spec/savon/core_ext/hash_spec.rb

@@ -56,7 +56,7 @@ describe Hash do
 
     it "should convert DateTime objects to xs:dateTime compliant Strings" do
       hash = { :before => DateTime.new(2012, 03, 22, 16, 22, 33) }
-      result = "<before>2012-03-22T16:22:33Z</before>"
+      result = "<before>2012-03-22T16:22:33+00:00</before>"
 
       hash.to_soap_xml.should == result
     end
@@ -67,7 +67,7 @@ describe Hash do
         DateTime.new(2012, 03, 22, 16, 22, 33)
       end
 
-      hash, result = { :before => singleton }, "<before>2012-03-22T16:22:33Z</before>"
+      hash, result = { :before => singleton }, "<before>2012-03-22T16:22:33+00:00</before>"
       hash.to_soap_xml.should == result
     end
 
@@ -79,8 +79,12 @@ describe Hash do
       hash.to_soap_xml.should == result
     end
 
+    it "should properly serialize nil values" do
+      { :some => nil }.to_soap_xml.should == '<some xsi:nil="true"/>'
+    end
+
     it "should call to_s on any other Object" do
-      [666, true, false, nil].each do |object|
+      [666, true, false].each do |object|
         { :some => object }.to_soap_xml.should == "<some>#{object}</some>"
       end
     end
@@ -151,6 +155,21 @@ describe Hash do
       soap_response.map_soap_response.should == result
     end
 
+    context "with Savon.strip_namespaces set to false" do
+      around do |example|
+        Savon.strip_namespaces = false
+        example.run
+        Savon.strip_namespaces = true
+      end
+
+      it "should not strip namespaces from Hash keys" do
+        soap_response = { "ns:userResponse" => { "ns2:id" => "666" } }
+        result = { "ns:user_response" => { "ns2:id" => "666" } }
+
+        soap_response.map_soap_response.should == result
+      end
+    end
+
     it "should convert Hash keys and values in Arrays" do
       soap_response = { "response" => [{ "name" => "dude" }, { "name" => "gorilla" }] }
       result = { :response=> [{ :name => "dude" }, { :name => "gorilla" }] }
@@ -166,7 +185,7 @@ describe Hash do
     end
 
     it "should convert Hash values matching the xs:dateTime format into DateTime Objects" do
-      soap_response = { "response" => { "at" => "2012-03-22T16:22:33" } }
+      soap_response = { "response" => { "at" => "2012-03-22T16:22:33+00:00" } }
       result = { :response => { :at => DateTime.new(2012, 03, 22, 16, 22, 33) } }
 
       soap_response.map_soap_response.should == result
@@ -185,6 +204,23 @@ describe Hash do
 
       soap_response.map_soap_response.should == result
     end
+
+    it "should convert namespaced entries to array elements" do
+      soap_response = {
+        "history" => {
+          "ns10:case" => { "ns10:name" => "a_name" },
+          "ns11:case" => { "ns11:name" => "another_name" }
+        }
+      }
+      
+      result = {
+        :history => {
+          :case => [{ :name => "a_name" }, { :name => "another_name" }]
+        }
+      }
+      
+      soap_response.map_soap_response.should == result
+    end
   end
 
 end

data/spec/savon/core_ext/object_spec.rb

@@ -23,7 +23,7 @@ describe Object do
         DateTime.new(2012, 03, 22, 16, 22, 33)
       end
 
-      singleton.to_soap_value.should == "2012-03-22T16:22:33Z"
+      singleton.to_soap_value.should == "2012-03-22T16:22:33+00:00"
     end
 
     it "calls to_s unless the Object responds to to_datetime" do

data/spec/savon/core_ext/string_spec.rb

@@ -2,18 +2,6 @@ require "spec_helper"
 
 describe String do
 
-  describe "self.random" do
-    it "returns a random 100-character String" do
-      String.random.should be_a(String)
-      String.random.length.should == 100
-    end
-
-    it "returns a random String of a given length" do
-      String.random(50).should be_a(String)
-      String.random(50).length.should == 50
-    end
-  end
-
   describe "snakecase" do
     it "converts a lowerCamelCase String to snakecase" do
       "lowerCamelCase".snakecase.should == "lower_camel_case"

data/spec/savon/http/error_spec.rb

@@ -0,0 +1,52 @@
+require "spec_helper"
+
+describe Savon::HTTP::Error do
+  let(:http_error) { Savon::HTTP::Error.new new_response(:code => 404, :body => "Not Found") }
+  let(:no_error) { Savon::HTTP::Error.new new_response }
+
+  it "should be a Savon::Error" do
+    Savon::HTTP::Error.should < Savon::Error
+  end
+
+  describe "#http" do
+    it "should return the HTTPI::Response" do
+      http_error.http.should be_an(HTTPI::Response)
+    end
+  end
+
+  describe "#present?" do
+    it "should return true if there was an HTTP error" do
+      http_error.should be_present
+    end
+
+    it "should return false unless there was an HTTP error" do
+      no_error.should_not be_present
+    end
+  end
+
+  [:message, :to_s].each do |method|
+    describe "##{method}" do
+      it "should return an empty String unless an HTTP error is present" do
+        no_error.send(method).should == ""
+      end
+
+      it "should return the HTTP error message" do
+        http_error.send(method).should == "HTTP error (404): Not Found"
+      end
+    end
+  end
+
+  describe "#to_hash" do
+    it "should return the HTTP response details as a Hash" do
+      http_error.to_hash.should == { :code => 404, :headers => {}, :body => "Not Found" }
+    end
+  end
+
+  def new_response(options = {})
+    defaults = { :code => 200, :headers => {}, :body => ResponseFixture.authentication }
+    response = defaults.merge options
+    
+    HTTPI::Response.new response[:code], response[:headers], response[:body]
+  end
+
+end

data/spec/savon/savon_spec.rb

@@ -0,0 +1,90 @@
+require "spec_helper"
+
+describe Savon do
+
+  describe ".configure" do
+    around do |example|
+      Savon.reset_config!
+      example.run
+      Savon.reset_config!
+    end
+
+    describe "log" do
+      it "should default to true" do
+        Savon.log?.should be_true
+      end
+
+      it "should set whether to log HTTP requests" do
+        Savon.configure { |config| config.log = false }
+        Savon.log?.should be_false
+      end
+    end
+
+    describe "logger" do
+      it "should set the logger to use" do
+        MyLogger = Class.new
+        Savon.configure { |config| config.logger = MyLogger }
+        Savon.logger.should == MyLogger
+      end
+
+      it "should default to Logger writing to STDOUT" do
+        Savon.logger.should be_a(Logger)
+      end
+    end
+
+    describe "log_level" do
+      it "should default to :debug" do
+        Savon.log_level.should == :debug
+      end
+
+      it "should set the log level to use" do
+        Savon.configure { |config| config.log_level = :info }
+        Savon.log_level.should == :info
+      end
+    end
+
+    describe "raise_errors" do
+      it "should default to true" do
+        Savon.raise_errors?.should be_true
+      end
+
+      it "should not raise errors when disabled" do
+        Savon.raise_errors = false
+        Savon.raise_errors?.should be_false
+
+        Savon.raise_errors = true  # reset to default
+      end
+    end
+
+    describe "soap_version" do
+      it "should default to SOAP 1.1" do
+        Savon.soap_version.should == 1
+      end
+
+      it "should return 2 if set to SOAP 1.2" do
+        Savon.soap_version = 2
+        Savon.soap_version.should == 2
+
+        Savon.soap_version = 1  # reset to default
+      end
+
+      it "should raise an ArgumentError in case of an invalid version" do
+        lambda { Savon.soap_version = 3 }.should raise_error(ArgumentError)
+      end
+    end
+
+    describe "strip_namespaces" do
+      it "should default to true" do
+        Savon.strip_namespaces?.should == true
+      end
+
+      it "should not strip namespaces when set to false" do
+        Savon.strip_namespaces = false
+        Savon.strip_namespaces?.should == false
+        
+        Savon.strip_namespaces = true  # reset to default
+      end
+    end
+
+  end
+end

data/spec/savon/soap/fault_spec.rb

@@ -0,0 +1,80 @@
+require "spec_helper"
+
+describe Savon::SOAP::Fault do
+  let(:soap_fault) { Savon::SOAP::Fault.new new_response(:body => ResponseFixture.soap_fault) }
+  let(:soap_fault2) { Savon::SOAP::Fault.new new_response(:body => ResponseFixture.soap_fault12) }
+  let(:no_fault) { Savon::SOAP::Fault.new new_response }
+
+  it "should be a Savon::Error" do
+    Savon::SOAP::Fault.should < Savon::Error
+  end
+
+  describe "#http" do
+    it "should return the HTTPI::Response" do
+      soap_fault.http.should be_an(HTTPI::Response)
+    end
+  end
+
+  describe "#present?" do
+    it "should return true if the HTTP response contains a SOAP 1.1 fault" do
+      soap_fault.should be_present
+    end
+
+    it "should return true if the HTTP response contains a SOAP 1.2 fault" do
+      soap_fault2.should be_present
+    end
+
+    it "should return false unless the HTTP response contains a SOAP fault" do
+      no_fault.should_not be_present
+    end
+  end
+
+  [:message, :to_s].each do |method|
+    describe "##{method}" do
+      it "should return an empty String unless a SOAP fault is present" do
+        no_fault.send(method).should == ""
+      end
+
+      it "should return a SOAP 1.1 fault message" do
+        soap_fault.send(method).should == "(soap:Server) Fault occurred while processing."
+      end
+
+      it "should return a SOAP 1.2 fault message" do
+        soap_fault2.send(method).should == "(soap:Sender) Sender Timeout"
+      end
+    end
+  end
+
+  describe "#to_hash" do
+    it "should return the SOAP response as a Hash unless a SOAP fault is present" do
+      no_fault.to_hash[:authenticate_response][:return][:success].should be_true
+    end
+
+    it "should return a SOAP 1.1 fault as a Hash" do
+      soap_fault.to_hash.should == {
+        :fault => {
+          :faultstring => "Fault occurred while processing.",
+          :faultcode   => "soap:Server"
+        }
+      }
+    end
+
+    it "should return a SOAP 1.2 fault as a Hash" do
+      soap_fault2.to_hash.should == {
+        :fault => {
+          :detail => { :max_time => "P5M" },
+          :reason => { :text => "Sender Timeout" },
+          :code   => { :value => "soap:Sender", :subcode => { :value => "m:MessageTimeout" } }
+        }
+      }
+    end
+  end
+
+  def new_response(options = {})
+    defaults = { :code => 200, :headers => {}, :body => ResponseFixture.authentication }
+    response = defaults.merge options
+    
+    HTTPI::Response.new response[:code], response[:headers], response[:body]
+  end
+
+end

data/spec/savon/soap/request_spec.rb

@@ -0,0 +1,45 @@
+require "spec_helper"
+
+describe Savon::SOAP::Request do
+  let(:request) { Savon::SOAP::Request.new HTTPI::Request.new, soap }
+  let(:soap) { Savon::SOAP::XML.new Endpoint.soap, :get_user, :id => 1 }
+
+  it "contains the content type for each supported SOAP version" do
+    content_type = Savon::SOAP::Request::ContentType
+    content_type[1].should == "text/xml;charset=UTF-8"
+    content_type[2].should == "application/soap+xml;charset=UTF-8"
+  end
+
+  describe ".new" do
+    it "should use the SOAP endpoint for the request" do
+      request.request.url.should == URI(soap.endpoint)
+    end
+
+    it "should set the SOAP body for the request" do
+      request.request.body.should == soap.to_xml
+    end
+
+    it "should set the 'Content-Type' header for SOAP 1.1" do
+      request.request.headers["Content-Type"].should == Savon::SOAP::Request::ContentType[1]
+    end
+
+    it "should set the 'Content-Type' header for SOAP 1.2" do
+      soap.version = 2
+      request.request.headers["Content-Type"].should == Savon::SOAP::Request::ContentType[2]
+    end
+
+    it "should not set the 'Content-Type' header if it's already specified" do
+      headers = { "Content-Type" => "text/plain" }
+      request = Savon::SOAP::Request.new HTTPI::Request.new(:headers => headers), soap
+      request.request.headers["Content-Type"].should == headers["Content-Type"]
+    end
+  end
+
+  describe "#response" do
+    it "should execute an HTTP POST request and return a Savon::SOAP::Response" do
+      HTTPI.expects(:post).returns(HTTPI::Response.new 200, {}, ResponseFixture.authentication)
+      request.response.should be_a(Savon::SOAP::Response)
+    end
+  end
+
+end

data/spec/savon/soap/response_spec.rb

@@ -0,0 +1,153 @@
+require "spec_helper"
+
+describe Savon::SOAP::Response do
+
+  describe ".new" do
+    it "should raise a Savon::SOAP::Fault in case of a SOAP fault" do
+      lambda { soap_fault_response }.should raise_error(Savon::SOAP::Fault)
+    end
+
+    it "should not raise a Savon::SOAP::Fault in case the default is turned off" do
+      Savon.raise_errors = false
+      lambda { soap_fault_response }.should_not raise_error(Savon::SOAP::Fault)
+      Savon.raise_errors = true
+    end
+
+    it "should raise a Savon::HTTP::Error in case of an HTTP error" do
+      lambda { soap_response :code => 500 }.should raise_error(Savon::HTTP::Error)
+    end
+
+    it "should not raise a Savon::HTTP::Error in case the default is turned off" do
+      Savon.raise_errors = false
+      soap_response :code => 500
+      Savon.raise_errors = true
+    end
+  end
+
+  describe "#success?" do
+    around do |example|
+      Savon.raise_errors = false
+      example.run
+      Savon.raise_errors = true
+    end
+
+    it "should return true if the request was successful" do
+      soap_response.should be_a_success
+    end
+
+    it "should return false if there was a SOAP fault" do
+      soap_fault_response.should_not be_a_success
+    end
+
+    it "should return false if there was an HTTP error" do
+      http_error_response.should_not be_a_success
+    end
+  end
+
+  describe "#soap_fault?" do
+    around do |example|
+      Savon.raise_errors = false
+      example.run
+      Savon.raise_errors = true
+    end
+
+    it "should not return true in case the response seems to be ok" do
+      soap_response.soap_fault?.should be_false
+    end
+
+    it "should return true in case of a SOAP fault" do
+      soap_fault_response.soap_fault?.should be_true
+    end
+  end
+
+  describe "#soap_fault" do
+    around do |example|
+      Savon.raise_errors = false
+      example.run
+      Savon.raise_errors = true
+    end
+
+    it "should return a Savon::SOAP::Fault" do
+      soap_fault_response.soap_fault.should be_a(Savon::SOAP::Fault)
+    end
+
+    it "should return a Savon::SOAP::Fault containing the HTTPI::Response" do
+      soap_fault_response.soap_fault.http.should be_an(HTTPI::Response)
+    end
+
+    it "should return a Savon::SOAP::Fault even if the SOAP response seems to be ok" do
+      soap_response.soap_fault.should be_a(Savon::SOAP::Fault)
+    end
+  end
+
+  describe "#http_error?" do
+    around do |example|
+      Savon.raise_errors = false
+      example.run
+      Savon.raise_errors = true
+    end
+
+    it "should not return true in case the response seems to be ok" do
+      soap_response.http_error?.should_not be_true
+    end
+
+    it "should return true in case of an HTTP error" do
+      soap_response(:code => 500).http_error?.should be_true
+    end
+  end
+
+  describe "#http_error" do
+    around do |example|
+      Savon.raise_errors = false
+      example.run
+      Savon.raise_errors = true
+    end
+
+    it "should return a Savon::HTTP::Error" do
+      http_error_response.http_error.should be_a(Savon::HTTP::Error)
+    end
+
+    it "should return a Savon::HTTP::Error containing the HTTPI::Response" do
+      http_error_response.http_error.http.should be_an(HTTPI::Response)
+    end
+
+    it "should return a Savon::HTTP::Error even if the HTTP response seems to be ok" do
+      soap_response.http_error.should be_a(Savon::HTTP::Error)
+    end
+  end
+
+  describe "#to_hash" do
+    it "should return the SOAP response body as a Hash" do
+      soap_response.to_hash[:authenticate_response][:return].should ==
+        ResponseFixture.authentication(:to_hash)
+    end
+  end
+
+  describe "#to_xml" do
+    it "should return the raw SOAP response body" do
+      soap_response.to_xml.should == ResponseFixture.authentication
+    end
+  end
+
+  describe "#http" do
+    it "should return the HTTPI::Response" do
+      soap_response.http.should be_an(HTTPI::Response)
+    end
+  end
+
+  def soap_response(options = {})
+    defaults = { :code => 200, :headers => {}, :body => ResponseFixture.authentication }
+    response = defaults.merge options
+    
+    Savon::SOAP::Response.new HTTPI::Response.new(response[:code], response[:headers], response[:body])
+  end
+
+  def soap_fault_response
+    soap_response :body => ResponseFixture.soap_fault
+  end
+
+  def http_error_response
+    soap_response :code => 404, :body => "Not found"
+  end
+
+end