savon 0.5.3 → 0.6.0

data/spec/savon/core_ext/hash_spec.rb

@@ -95,32 +95,6 @@ describe Hash do
     end
   end
 
-  describe "to_soap_fault_message" do
-    it "returns a SOAP fault message for SOAP version 1" do
-      soap_fault = {
-        "faultcode" => "soap:Server",
-        "faultstring" => "Fault occurred while processing."
-      }
-
-      soap_fault.to_soap_fault_message.should be_a String
-      soap_fault.to_soap_fault_message.should_not be_empty
-    end
-
-    it "returns a SOAP fault message for SOAP version 2" do
-      soap_fault = {
-        "code" => { "value" => "soap:Server" },
-        "reason" => { "text" => "Fault occurred while processing." }
-      }
-
-      soap_fault.to_soap_fault_message.should be_a String
-      soap_fault.to_soap_fault_message.should_not be_empty
-    end
-
-    it "returns nil in case the Hash does not include a SOAP fault" do
-      { :soap_fault => false }.to_soap_fault_message.should be_nil
-    end
-  end
-
   describe "map_soap_response" do
     it "converts Hash key Strings to snake_case Symbols" do
       { "userResponse" => { "accountStatus" => "active" } }.map_soap_response.

data/spec/savon/core_ext/string_spec.rb

@@ -2,6 +2,18 @@ require "spec_helper"
 
 describe String do
 
+  describe "self.random" do
+    it "returns a random 100-character String" do
+      String.random.should be_a String
+      String.random.length.should == 100
+    end
+
+    it "returns a random String of a given length" do
+      String.random(50).should be_a String
+      String.random(50).length.should == 50
+    end
+  end
+
   describe "snakecase" do
     it "converts a lowerCamelCase String to snakecase" do
       "lowerCamelCase".snakecase.should == "lower_camel_case"

data/spec/savon/request_spec.rb

@@ -1,12 +1,16 @@
 require "spec_helper"
 
 describe Savon::Request do
-  before { @request = new_request_instance }
+  before { @request = some_request_instance }
 
-  def new_request_instance
+  def some_request_instance
     Savon::Request.new SpecHelper.some_endpoint
   end
 
+  def some_soap_instance(options = {})
+    Savon::SOAP.new UserFixture.soap_actions[:find_user]
+  end
+
   describe "ContentType" do
     it "contains the ContentType for each supported SOAP version" do
       Savon::SOAPVersions.each do |soap_version|
@@ -53,7 +57,7 @@ describe Savon::Request do
 
   describe "initialize" do
     it "expects a SOAP endpoint String" do
-      new_request_instance
+      some_request_instance
     end
 
     it "raises an ArgumentError in case of an invaluid endpoint" do
@@ -78,16 +82,11 @@ describe Savon::Request do
 
   describe "soap" do
     it "executes a SOAP request and returns the Net::HTTPResponse" do
-      soap_response = @request.soap new_soap_instance
+      soap_response = @request.soap some_soap_instance
 
       soap_response.should be_a Net::HTTPResponse
       soap_response.body.should == UserFixture.user_response
     end
   end
 
-  def new_soap_instance(options = {})
-    Savon::SOAP.new UserFixture.soap_actions[:find_user], { :id => 666 },
-      options, UserFixture.namespace_uri
-  end
-
-end
+end

data/spec/savon/response_spec.rb

@@ -0,0 +1,133 @@
+require "spec_helper"
+
+describe Savon::Response do
+  before { @response = some_response_instance }
+
+  def some_response_instance
+    Savon::Response.new http_response_mock
+  end
+
+  def soap_fault_response_instance
+    Savon::Response.new http_response_mock(200, UserFixture.soap_fault)
+  end
+
+  def http_error_response_instance
+    Savon::Response.new http_response_mock(404, "", "Not found")
+  end
+
+  describe "@raise_errors" do
+    it "defaults to true" do
+      Savon::Response.raise_errors?.should be_true
+    end
+
+    it "has accessor methods" do
+      Savon::Response.raise_errors = false
+      Savon::Response.raise_errors?.should == false
+      Savon::Response.raise_errors = true
+    end
+  end
+
+  describe "initialize" do
+    it "expects a Net::HTTPResponse" do
+      some_response_instance
+    end
+
+    it "raises a Savon::SOAPFault in case of a SOAP fault" do
+      lambda { soap_fault_response_instance }.should raise_error Savon::SOAPFault
+    end
+ 
+    it "does not raise a Savon::SOAPFault in case the default is turned off" do
+      Savon::Response.raise_errors = false
+      soap_fault_response_instance
+      Savon::Response.raise_errors = true
+    end
+ 
+    it "raises a Savon::HTTPError in case of an HTTP error" do
+      lambda { http_error_response_instance }.should raise_error Savon::HTTPError
+    end
+
+    it "does not raise a Savon::HTTPError in case the default is turned off" do
+      Savon::Response.raise_errors = false
+      http_error_response_instance
+      Savon::Response.raise_errors = true
+    end
+  end
+
+  describe "soap_fault?" do
+    before { Savon::Response.raise_errors = false }
+
+    it "does not return true in case the response seems to be ok" do
+      @response.soap_fault?.should_not be_true
+    end
+
+    it "returns true in case of a SOAP fault" do
+      response = soap_fault_response_instance
+      response.soap_fault?.should be_true
+    end
+
+    after { Savon::Response.raise_errors = true }
+  end
+
+  describe "soap_fault" do
+    before { Savon::Response.raise_errors = false }
+
+    it "returns the SOAP fault message in case of a SOAP fault" do
+      response = soap_fault_response_instance
+      response.soap_fault.should == "(soap:Server) Fault occurred while processing."
+    end
+
+    after { Savon::Response.raise_errors = true }
+  end
+
+  describe "http_error?" do
+    before { Savon::Response.raise_errors = false }
+
+    it "does not return true in case the response seems to be ok" do
+      @response.http_error?.should_not be_true
+    end
+
+    it "returns true in case of an HTTP error" do
+      response = http_error_response_instance
+      response.http_error?.should be_true
+    end
+
+    after { Savon::Response.raise_errors = true }
+  end
+
+  describe "http_error" do
+    before { Savon::Response.raise_errors = false }
+
+    it "returns the HTTP error message in case of an HTTP error" do
+      response = http_error_response_instance
+      response.http_error.should == "Not found (404)"
+    end
+
+    after { Savon::Response.raise_errors = true }
+  end
+
+  describe "to_hash" do
+    it "returns the SOAP response body as a Hash" do
+      @response.to_hash.should == UserFixture.response_hash
+    end
+  end
+
+  describe "to_xml" do
+    it "returns the SOAP response body" do
+      @response.to_xml.should == UserFixture.user_response
+    end
+  end
+
+  describe "to_s (alias)" do
+    it "returns the SOAP response body" do
+      @response.to_s.should == UserFixture.user_response
+    end
+  end
+
+  def http_response_mock(code = 200, body = UserFixture.user_response, message = "OK")
+    http_response_mock = mock "Net::HTTPResponse"
+    http_response_mock.stubs :code => code.to_s, :message => message,
+        :content_type => "text/html", :body => body
+    http_response_mock
+  end
+
+end

data/spec/savon/savon_spec.rb

@@ -2,13 +2,6 @@ require "spec_helper"
 
 describe Savon do
 
-  describe "VERSION" do
-    it "contains the current version of the library" do
-      Savon::VERSION.should be_a String
-      Savon::VERSION.should_not be_empty
-    end
-  end
-
   describe "SOAPVersions" do
     it "contains an Array of supported SOAP versions" do
       Savon::SOAPVersions.should be_an Array
@@ -34,4 +27,4 @@ describe Savon do
     end
   end
 
-end
+end

data/spec/savon/soap_spec.rb

@@ -1,11 +1,28 @@
 require "spec_helper"
 
 describe Savon::SOAP do
-  before { @soap = new_soap_instance }
+  before { @soap = some_soap_instance }
 
-  def new_soap_instance(options = {})
-    Savon::SOAP.new UserFixture.soap_actions[:find_user], { :id => 666 },
-      options, UserFixture.namespace_uri
+  def some_soap_instance
+    Savon::SOAP.new UserFixture.soap_actions[:find_user]
+  end
+
+  describe "SOAPNamespace" do
+    it "contains the SOAP namespace for each supported SOAP version" do
+      Savon::SOAPVersions.each do |soap_version|
+        Savon::SOAP::SOAPNamespace[soap_version].should be_a String
+        Savon::SOAP::SOAPNamespace[soap_version].should_not be_empty
+      end
+    end
+  end
+
+  describe "ContentType" do
+    it "contains the Content-Types for each supported SOAP version" do
+      Savon::SOAPVersions.each do |soap_version|
+        Savon::SOAP::ContentType[soap_version].should be_a String
+        Savon::SOAP::ContentType[soap_version].should_not be_empty
+      end
+    end
   end
 
   describe "@version" do
@@ -14,7 +31,7 @@ describe Savon::SOAP do
     end
 
     it "has accessor methods" do
-      [1, 2].each do |soap_version|
+      [2, 1].each do |soap_version|
         Savon::SOAP.version = soap_version
         Savon::SOAP.version.should == soap_version
       end
@@ -22,42 +39,93 @@ describe Savon::SOAP do
   end
 
   describe "initialize" do
-    it "expects the SOAP action, body, options and the namespace URI" do
-      new_soap_instance
+    it "expects a SOAP action map" do
+      some_soap_instance
+    end
+  end
+
+  describe "wsse" do
+    it "expects a Savon::WSSE" do
+      @soap.wsse = Savon::WSSE.new
     end
   end
 
   describe "action" do
-    it "returns the SOAP action" do
-      @soap.action.should == UserFixture.soap_actions[:find_user]
+    it "is an accessor for the SOAP action" do
+      @soap.action.should == UserFixture.soap_actions[:find_user][:name]
+
+      action = "someAction"
+      @soap.action = action
+      @soap.action.should == action
     end
   end
 
-  describe "options" do
-    it "returns the SOAP options" do
-      @soap.options.should == {}
+  describe "header" do
+    it "is an accessor for the SOAP header" do
+      @soap.header.should be_a Hash
+      @soap.header.should be_empty
+
+      header = { "specialAuthKey" => "secret" }
+      @soap.header = header
+      @soap.header.should == header
     end
   end
 
   describe "body" do
+    it "expects a SOAP-translatable Hash or an XML String" do
+      @soap.body = { :id => 666 }
+      @soap.body = "<id>666</id>"
+    end
+  end
+
+  describe "namespaces" do
+    it "defaults to a Hash with xmlns:env set to SOAP 1.1" do
+      soap = some_soap_instance
+      soap.namespaces.should == { "xmlns:env" => Savon::SOAP::SOAPNamespace[1] }
+    end
+
+    it "contains the xmlns:env for SOAP 1.2 if specified" do
+      soap = some_soap_instance
+      soap.version = 2
+      soap.namespaces.should == { "xmlns:env" => Savon::SOAP::SOAPNamespace[2] }
+    end
+  end
+
+  describe "version" do
+    it "returns the SOAP version from options" do
+      soap = some_soap_instance
+      soap.version = 2
+      soap.version.should == 2
+    end
+
+    it "returns the default SOAP version otherwise" do
+      @soap.version.should == Savon::SOAP.version
+    end
+  end
+
+  describe "to_xml" do
     before { Savon::SOAP.version = 1 }
 
     it "returns the XML for a SOAP request" do
-      @soap.body.should == soap_body
+      soap = some_soap_instance
+      soap.namespaces["xmlns:wsdl"] = "http://v1_0.ws.user.example.com"
+      soap.body = { :id => 666 }
+      soap.to_xml.should == soap_body
     end
 
     it "caches the XML, returning the same Object every time" do
-      @soap.body.object_id.should == @soap.body.object_id
+      @soap.to_xml.object_id.should == @soap.to_xml.object_id
     end
 
     it "uses the SOAP namespace for the SOAP version passed in via options" do
-      soap = new_soap_instance :soap_version => 2
-      soap.body.should include Savon::SOAP::SOAPNamespace[2]
+      soap = some_soap_instance
+      soap.version = 2
+      soap.to_xml.should include Savon::SOAP::SOAPNamespace[2]
     end
 
     it "uses the SOAP namespace for the default SOAP version otherwise" do
       Savon::SOAP.version = 2
-      @soap.body.should include Savon::SOAP::SOAPNamespace[2]
+      @soap.to_xml.should include Savon::SOAP::SOAPNamespace[2]
     end
 
     def soap_body
@@ -69,33 +137,4 @@ describe Savon::SOAP do
     end
   end
 
-  describe "version" do
-    it "returns the SOAP version from options" do
-      soap = new_soap_instance :soap_version => 2
-      soap.version.should == 2
-    end
-
-    it "returns the default SOAP version otherwise" do
-      @soap.version.should == Savon::SOAP.version
-    end
-  end
-
-  describe "SOAPNamespace" do
-    it "contains the SOAP namespace for each supported SOAP version" do
-      Savon::SOAPVersions.each do |soap_version|
-        Savon::SOAP::SOAPNamespace[soap_version].should be_a String
-        Savon::SOAP::SOAPNamespace[soap_version].should_not be_empty
-      end
-    end
-  end
-
-  describe "ContentType" do
-    it "contains the Content-Types for each supported SOAP version" do
-      Savon::SOAPVersions.each do |soap_version|
-        Savon::SOAP::ContentType[soap_version].should be_a String
-        Savon::SOAP::ContentType[soap_version].should_not be_empty
-      end
-    end
-  end
-
-end
+end

data/spec/savon/wsdl_spec.rb

@@ -1,11 +1,15 @@
 require "spec_helper"
 
 describe Savon::WSDL do
-  before { @wsdl = Savon::WSDL.new Savon::Request.new SpecHelper.some_endpoint }
+  before { @wsdl = some_wsdl_instance }
+
+  def some_wsdl_instance
+    Savon::WSDL.new Savon::Request.new SpecHelper.some_endpoint
+  end
 
   describe "initialize" do
     it "expects a Savon::Request object" do
-      Savon::WSDL.new Savon::Request.new SpecHelper.some_endpoint
+      some_wsdl_instance
     end
   end
 
@@ -16,8 +20,9 @@ describe Savon::WSDL do
   end
 
   describe "soap_actions" do
-    it "returns an Array containing all available SOAP actions" do
-      @wsdl.soap_actions.should == UserFixture.soap_actions.keys
+    it "returns a Hash containing all available SOAP actions, as well as" <<
+       "their original names and inputs" do  
+      @wsdl.soap_actions.should == UserFixture.soap_actions
     end
 
     it "raises an ArgumentError in case the WSDL seems to be invalid" do
@@ -26,9 +31,15 @@ describe Savon::WSDL do
     end
   end
 
-  describe "mapped_soap_actions" do
-    it "returns a Hash containing all available SOAP actions and their original names" do  
-      @wsdl.mapped_soap_actions.should == UserFixture.soap_actions
+  describe "respond_to?" do
+    it "returns true for available SOAP actions" do
+      @wsdl.respond_to?(UserFixture.soap_actions.keys.first).
+        should be_true
+    end
+
+    it "still behaves like usual otherwise" do
+      @wsdl.respond_to?(:object_id).should be_true
+      @wsdl.respond_to?(:some_undefined_method).should be_false
     end
   end
 
@@ -38,4 +49,4 @@ describe Savon::WSDL do
     end
   end
 
-end
+end