savon 0.5.1 → 0.5.2

data/README.textile

@@ -1,25 +1,25 @@
-h1. Savon
+h2. Savon
 
 p. Savon can be installed as a gem via:
 
 bc. $ gem install savon
 
-h3. Dependencies
+h4. Dependencies
 
 bc. builder >= 2.1.2
 crack >= 0.1.4
 
 h2. Warning
 
-p. To use a heavy metal library like this, you have to be familiar with SOAP, WSDL and tools like soapUI.
+p. To use this heavy metal library, you should be familiar with SOAP, WSDL and tools like soapUI.
 
-h2. First step
+h2. Instantiate Savon::Client
 
 p. Instantiate a new instance of Savon::Client, passing in the WSDL of your service.
 
 bc. proxy = Savon::Client.new "http://example.com/UserService?wsdl"
 
-h3. The WSDL
+h2. The WSDL
 
 p. You can find out about the SOAP actions available on the webservice by using the WSDL object.
 
@@ -28,7 +28,7 @@ bc. proxy.wsdl.soap_actions
 
 p. Find out more about the "WSDL":http://wiki.github.com/rubiii/savon/wsdl object.
 
-h3. Calling a SOAP action
+h2. Calling a SOAP action
 
 p. Now, assuming your service applies to the default "Options":http://wiki.github.com/rubiii/savon/options, you can just call any available SOAP action.
 
@@ -36,7 +36,7 @@ bc. response = proxy.get_all_users
 
 p. Savon lets you call SOAP actions using snake_case, because even though they will propably be written in lowerCamelCase or CamelCase, it just feels much more natural.
 
-h3. Parameters
+h2. Parameters
 
 p. Specifying parameters for the SOAP service, can be done by simply passing a Hash to the SOAP action.
 
@@ -44,18 +44,18 @@ bc. response = proxy.get_user_by_id :id => 666
 
 p. Learn more about [[Parameters]].
 
-h3. The response
+h2. The response
 
 p. By default, the SOAP response is translated into a Hash. Take a look at the "Options":http://wiki.github.com/rubiii/savon/options for more information.
 
 bc. proxy.get_user_by_id :id => 666
 => { :user_response => { :id => "666", :username => "gorilla" } }
 
-h3. HTTP errors and SOAP faults
+h2. HTTP errors and SOAP faults
 
 p. Savon raises a Savon::SOAPFault in case of a SOAP fault and a Savon::HTTPError in case of an HTTP error. More information about "Errors":http://wiki.github.com/rubiii/savon/errors.
 
-h3. Logging
+h2. Logging
 
 p. By default Savon logs each request and response to STDOUT. Specifying your own logger is as easy as it gets:
 
@@ -63,6 +63,6 @@ bc. Savon::Request.logger = RAILS_DEFAULT_LOGGER
 
 Read more about "Logging":http://wiki.github.com/rubiii/savon/logging.
 
-h3. RDoc and Wiki
+h2. RDoc and Wiki
 
 p. Further information: "Wiki":http://wiki.github.com/rubiii/savon and "RDoc":http://rdoc.info/projects/rubiii/savon

data/VERSION

@@ -1 +1 @@
-0.5.1
+0.5.2

data/lib/savon/core_ext/string.rb

@@ -6,6 +6,7 @@ class String
     str.gsub! /::/, '/'
     str.gsub! /([A-Z]+)([A-Z][a-z])/, '\1_\2'
     str.gsub! /([a-z\d])([A-Z])/, '\1_\2'
+    str.tr! ".", "_"
     str.tr! "-", "_"
     str.downcase!
     str

data/spec/fixtures/user_fixture.rb

@@ -1,7 +1,7 @@
 class UserFixture
 
   @namespace_uri = "http://v1_0.ws.user.example.com"
-  @soap_actions = { :find_user => "findUser" }
+  @soap_actions = { :user_find_by_id => "User.FindById", :find_user => "findUser" }
 
   @datetime_string = "2010-11-22T11:22:33"
   @datetime_object = DateTime.parse @datetime_string

data/spec/fixtures/user_wsdl.xml

@@ -15,11 +15,13 @@
       xmlns:tns="http://v1_0.ws.user.example.com"
       xmlns:xs="http://www.w3.org/2001/XMLSchema">
       <xs:element name="findUser" type="tns:findUser" />
+			<xs:element name="User.FindById" type="tns:findUser" />
       <xs:element name="findUserRequest" type="tns:findUserRequest" />
       <xs:element name="baseFindUserRequest" type="tns:baseFindUserRequest" />
       <xs:element name="idCredential" type="tns:idCredential" />
       <xs:element name="emailCredential" type="tns:emailCredential" />
       <xs:element name="findUserResponse" type="tns:findUserResponse" />
+			<xs:element name="User.FindByIdResponse" type="tns:findUserResponse" />
       <xs:element name="userResponse" type="tns:userResponse" />
 
       <xs:complexType name="findUser">
@@ -78,6 +80,13 @@
     <wsdl:part element="tns:findUserResponse" name="parameters"></wsdl:part>
   </wsdl:message>
 
+  <wsdl:message name="User.FindById">
+    <wsdl:part element="tns:findUser" name="parameters"></wsdl:part>
+  </wsdl:message>
+  <wsdl:message name="User.FindByIdResponse">
+    <wsdl:part element="tns:findUserResponse" name="parameters"></wsdl:part>
+  </wsdl:message>
+
   <wsdl:portType name="UserWebService">
     <wsdl:operation name="findUser">
       <wsdl:input message="tns:findUser" name="findUser"></wsdl:input>
@@ -95,6 +104,15 @@
       <wsdl:output name="findUserResponse">
         <soap:body use="literal" />
       </wsdl:output>
+    </wsdl:operation>
+		<wsdl:operation name="User.FindById">
+      <soap:operation soapAction="" style="document" />
+      <wsdl:input name="User.FindById">
+        <soap:body use="literal" />
+      </wsdl:input>
+      <wsdl:output name="User.FindByIdResponse">
+        <soap:body use="literal" />
+      </wsdl:output>
     </wsdl:operation>
   </wsdl:binding>
 

data/spec/savon/client_spec.rb

@@ -28,6 +28,42 @@ describe Savon::Client do
     end
   end
 
+  describe "@error_handling" do
+    before { @error_handling = Savon::Client.error_handling }
+
+    it "raises a Savon::SOAPFault in case it finds a SOAP fault" do
+      body = { "soapenv:Fault" => {
+        "faultcode" => "soap:Server",
+        "faultstring" => "Fault occurred while processing."
+      } }
+
+      lambda { @error_handling.call(http_response_mock, body) }.
+        should raise_error Savon::SOAPFault
+    end
+
+    it "raises a Savon::SOAPFault in case it finds both HTTPError and SOAP fault" do
+      body = { "soapenv:Fault" => {
+        "faultcode" => "soap:Server",
+        "faultstring" => "Fault occurred while processing."
+      } }
+
+      lambda { @error_handling.call(http_response_mock(500), body) }.
+        should raise_error Savon::SOAPFault
+    end
+
+    it "raises a Savon::HTTPError in case it finds an HTTP error" do
+      body = { "someResponse" => "whatever" }
+
+      lambda { @error_handling.call(http_response_mock(404), body) }.
+        should raise_error Savon::HTTPError
+    end
+
+    it "passes without raising anything otherwise" do
+      body = { "someResponse" => "whatever" }
+      @error_handling.call(http_response_mock, body).should be_nil
+    end
+  end
+
   describe "initialize" do
     it "expects a SOAP endpoint String" do
       new_client_instance
@@ -132,13 +168,11 @@ describe Savon::Client do
     end
   end
 
-  def http_response_mock
-    unless @http_response_mock
-      @http_response_mock = mock "Net::HTTPResponse"
-      @http_response_mock.stubs :code => "200", :message => "OK",
+  def http_response_mock(code = 200)
+    http_response_mock = mock "Net::HTTPResponse"
+    http_response_mock.stubs :code => code.to_s, :message => "OK",
         :content_type => "text/html", :body => UserFixture.user_response
-    end
-    @http_response_mock
+    http_response_mock
   end
 
 end

data/spec/savon/core_ext/string_spec.rb

@@ -6,6 +6,10 @@ describe String do
     it "converts a lowerCamelCase String to snakecase" do
       "lowerCamelCase".snakecase.should == "lower_camel_case"
     end
+
+    it "converts period characters to underscores" do
+      "User.GetEmail".snakecase.should == "user_get_email"
+    end
   end
 
   describe "lower_camelcase" do

data/spec/savon/wsdl_spec.rb

@@ -22,7 +22,7 @@ describe Savon::WSDL do
   end
 
   describe "mapped_soap_actions" do
-   it "returns a Hash containing all available SOAP actions and their original names" do
+    it "returns a Hash containing all available SOAP actions and their original names" do  
       @wsdl.mapped_soap_actions.should == UserFixture.soap_actions
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: savon
 version: !ruby/object:Gem::Version 
-  version: 0.5.1
+  version: 0.5.2
 platform: ruby
 authors: 
 - Daniel Harrington
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-11-29 00:00:00 +01:00
+date: 2009-11-30 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency