save_queue 0.3.0 → 0.4.0

data/spec/uniq_queue_spec.rb

@@ -3,7 +3,7 @@ require "save_queue/uniq_queue"
 
 describe SaveQueue::UniqQueue do
   let(:queue)   { SaveQueue::UniqQueue.new }
-  #let(:element) { new_element(:element)    }
+  let(:element) { new_element(:element)    }
 
   [:size, :count].each do |method|
     describe "##{method}" do
@@ -28,30 +28,35 @@ describe SaveQueue::UniqQueue do
     end
   end
 
-  [:add, :<<, :push].each do |method|
-    describe "##{method}" do
-      let(:element) { new_element }
-      it "should add object to a queue" do
-        queue.should be_empty
+  shared_examples_for "add method" do
+    it "should add object to a queue" do
+      queue.should be_empty
 
-        queue.send(method, new_element)
-        queue.should_not be_empty
-        queue.should have(1).elements
+      queue.send(method, new_element)
+      queue.should_not be_empty
+      queue.should have(1).elements
 
-        queue.send(method, new_element)
-        queue.should_not be_empty
-        queue.should have(2).elements
-      end
+      queue.send(method, new_element)
+      queue.should_not be_empty
+      queue.should have(2).elements
+    end
 
-      it "should add object to a queue once" do
-        queue.should be_empty
+    it "should add object to a queue once" do
+      queue.should be_empty
 
-        queue.send(method, element)
-        queue.should have(1).elements
+      queue.send(method, element)
+      queue.should have(1).elements
 
-        queue.send(method, element)
-        queue.should have(1).elements
-      end
+      queue.send(method, element)
+      queue.should have(1).elements
+    end
+  end
+
+  # TODO is that clear? is refactoring needed here?
+  (ADD_METHODS - %w(<<)).each do |add_method|
+    describe "##{add_method}" do
+      let(:method) { add_method }
+      it_behaves_like "add method"
 
       it "should return true" do
         queue.send(method, element).should === true
@@ -60,18 +65,43 @@ describe SaveQueue::UniqQueue do
       it "should return false if element was not added" do
         queue.send(method, element)
         queue.should have(1).elements
-        
+
         queue.send(method, element).should === false
       end
     end
   end
 
+  describe "#<<" do
+    let(:method) { :<< }
+    it_behaves_like "add method"
+
+    it "should be able to add objects in chain" do
+      queue << new_element << new_element
+      queue.should have(2).elements
+    end
+  end
+
   describe "#add_all" do
+    it "should add a collection to queue" do
+      queue.should be_empty
+
+      collection = [1,2,3]
+      queue.add_all collection
+
+      queue.should have(3).elements
+    end
+
     it "should delegate to #add" do
       queue.should_receive(:add).exactly(3).times
       queue.add_all [1,2,3]
     end
 
+    context "not array object passed as parameter" do
+      it_behaves_like "add method" do
+        let(:method) { "add" }
+      end
+    end
+
     it "should act as #add if single argument passed" do
       queue.should_receive(:add).once
       queue.add_all 1

data/spec/validation/queue_spec.rb

@@ -1,13 +1,25 @@
 require "spec_helper"
 require "save_queue/plugins/validation/queue"
 
-class ValidQueue < SaveQueue::ObjectQueue
+class QueueWithValidation < SaveQueue::ObjectQueue
   include SaveQueue::Plugins::Validation::Queue
 end
 
 
-describe ValidQueue do
-  let(:queue) { ValidQueue.new }
+describe SaveQueue::Plugins::Validation::Queue do
+  let(:queue) { QueueWithValidation.new }
+
+  context "is empty" do
+    specify { queue.should be_valid }
+
+    describe "#save" do
+      specify { queue.save.should be_true }
+    end
+
+    describe "#save!" do
+      specify { expect { queue.save! }.to_not raise_error }
+    end
+  end
 
   context "contains valid objects" do
     let(:valid_objects) do
@@ -21,80 +33,119 @@ describe ValidQueue do
     end
 
     describe "#save" do
-      it "should save all of them" do
+      specify { queue.save.should be_true }
+      
+      it "should save all elements" do
         valid_objects.each{|o| o.should_receive(:save).once}
         queue.save.should be_true
       end
-
-      it "should not has any errors" do
-        queue.save.should be_true
-        queue.errors.should be_empty
-      end
     end
 
     describe "#save!" do
-      it "should save all of them" do
+      specify { expect { queue.save! }.to_not raise_error }
+      
+      it "should save all elements" do
         valid_objects.each{|o| o.should_receive(:save).once}
         queue.save!
       end
+    end
 
-      it "should not raise any exception" do
-        expect { queue.save! }.not_to raise_error
-      end
+    describe "#valid?" do
+      specify {queue.valid?.should be_true}
 
       it "should not has any errors" do
-        queue.save!
+        queue.valid?
         queue.errors.should be_empty
       end
     end
-  end
 
+    describe "#validate!" do
+      it "should not raise any exception" do
+        expect { queue.validate! }.not_to raise_error
+      end
 
-  describe "contains invalid objects" do
-    let(:invalid_objects) do
-      3.times.map do
-        new_velement(:valid => false)
+      it "should not has any errors" do
+        queue.validate!
+        queue.errors.should be_empty
       end
     end
+  end
 
+  shared_context "queue with invalid objects" do
     before(:each) do
-      queue.add_all invalid_objects
+      queue.add_all objects
     end
 
     describe "#save" do
-      it "should not saved them" do
-        invalid_objects.each{|o| o.should_not_receive(:save)}
+      specify { queue.save.should be_false }
+      
+      it "should not save elements" do
+        objects.each{|o| o.should_not_receive(:save)}
         queue.save.should be_false
       end
-
-      it "should set errors" do
-        queue.save.should be_false
-        queue.errors[:validation].should_not be_empty
-      end
     end
 
     describe "#save!" do
-      it "should not saved them" do
-        invalid_objects.each do |o|
+      specify { expect {queue.save!}.to raise_error(SaveQueue::FailedValidationError) }
+      
+      it "should not save elements" do
+        objects.each do |o|
           o.as_null_object
           o.should_not_receive(:save)
         end
+      end
+    end
+
+    describe "#valid?" do
+      specify {queue.valid?.should be_false}
 
-        expect {queue.save!}.to raise_error
+      it "should set errors" do
+        queue.valid?
+        queue.errors[:validation].should_not be_empty
       end
+    end
 
+    describe "#validate!" do
       it "should raise SaveQueue::FailedValidationError exception" do
-        expect { queue.save! }.to raise_error(SaveQueue::FailedValidationError)
+        expect { queue.validate! }.to raise_error(SaveQueue::FailedValidationError)
       end
 
       it "should set errors" do
-        expect{queue.save!}.to raise_error
+        expect{queue.validate!}.to raise_error
         queue.errors[:validation].should_not be_empty
       end
     end
+
   end
 
+  context "contains invalid objects" do
+    it_behaves_like "queue with invalid objects" do
+      let(:objects) do
+        3.times.map { new_velement(:valid => false) }
+      end
+    end
+  end
 
+  context"contains mix of valid and invalid objects" do
+    it_behaves_like "queue with invalid objects" do
+      let(:objects) do
+        2.times.map do
+          new_velement(:valid => true)
+          new_velement(:valid => false)
+        end
+      end
+    end
+
+    it "#save should call #valid?" do
+      queue.should_receive(:valid?)
+      queue.save
+    end
+
+    it "#save! should call #validate!" do
+      queue.should_receive(:validate!)
+      queue.save!
+    end
+  end
   #before(:each) do
   #  @invalid = new_object
   #  @invalid.stub(:valid?).and_return(false)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: save_queue
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-01-23 00:00:00.000000000 Z
+date: 2012-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &7350280 !ruby/object:Gem::Requirement
+  requirement: &8163240 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '2.6'
   type: :development
   prerelease: false
-  version_requirements: *7350280
+  version_requirements: *8163240
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &7366200 !ruby/object:Gem::Requirement
+  requirement: &8162240 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *7366200
+  version_requirements: *8162240
 - !ruby/object:Gem::Dependency
   name: hooks
-  requirement: &7365720 !ruby/object:Gem::Requirement
+  requirement: &8161700 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,7 +43,7 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *7365720
+  version_requirements: *8161700
 description: ! 'Save Queue allows to push objects to other object''s queue for a delayed
   save.
 
@@ -66,7 +66,10 @@ files:
 - lib/save_queue.rb
 - lib/save_queue/exceptions.rb
 - lib/save_queue/object.rb
+- lib/save_queue/object/queue_class_management.rb
 - lib/save_queue/object_queue.rb
+- lib/save_queue/plugins/dirty.rb
+- lib/save_queue/plugins/dirty/object.rb
 - lib/save_queue/plugins/notification.rb
 - lib/save_queue/plugins/notification/object.rb
 - lib/save_queue/plugins/notification/queue.rb
@@ -77,9 +80,12 @@ files:
 - lib/save_queue/uniq_queue.rb
 - lib/save_queue/version.rb
 - save_queue.gemspec
+- spec/dirty/dirty_spec.rb
+- spec/dirty/object_spec.rb
 - spec/notification/notification_spec.rb
 - spec/notification/object_spec.rb
 - spec/notification/queue_spec.rb
+- spec/object/queue_class_management_spec.rb
 - spec/object_queue_spec.rb
 - spec/object_spec.rb
 - spec/save_queue_spec.rb