saucy-kiss 0.1.2 → 0.1.3

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+0.1.3
+
+Do not clear identity if user is signed in but without an account (e.g. /accounts)
+
 0.1.2
 
 Tell Snogmetrics to use the :array output strategy in test env,

data/lib/saucy/kiss/controller_filters.rb

@@ -2,10 +2,10 @@ module Saucy
   module Kiss
     module ControllerFilters
       def identify_to_kissmetrics
-        if current_account?
-          km.identify("account-#{current_account.id}")
-        else
+        if signed_out?
           km.identify(nil)
+        elsif current_account?
+          km.identify("account-#{current_account.id}")
         end
       end
 

data/spec/saucy/kiss/controller_filters_spec.rb

@@ -42,16 +42,24 @@ describe Saucy::Kiss::ControllerFilters do
     controller_class.hidden_actions.should == [:identify_to_kissmetrics]
   end
 
-  it "sets identity based on the account if there is a current_account when there is a current_account" do
-    controller.stub(:current_account? => true,
+  it "sets identity based on the account if you're signed in and have a current_account" do
+    controller.stub(:signed_out? => false,
+                    :current_account? => true,
                     :current_account => account)
     km.should_receive(:identify).with("account-12345")
     controller.identify_to_kissmetrics
   end
 
-  it "clears identity when there is not a current_account" do
-    controller.stub(:current_account? => false)
+  it "clears identity when you sign out" do
+    controller.stub(:signed_out? => true)
     km.should_receive(:identify).with(nil)
     controller.identify_to_kissmetrics
   end
+
+  it "does not re-identify if you're signed in but have no account, e.g. on the /accounts page" do
+    controller.stub(:signed_out? => false,
+                   :current_account? => false)
+    km.should_receive(:identify).never()
+    controller.identify_to_kissmetrics
+  end
 end

metadata

@@ -2,7 +2,7 @@
 name: saucy-kiss
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors: 
 - Jason Morrison