saucy-kiss 0.1.1 → 0.1.2

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+0.1.2
+
+Tell Snogmetrics to use the :array output strategy in test env,
+so tests aren't littered with console.log statements.
+
 0.1.1
 
 Fixed a bug.

data/Gemfile

@@ -2,6 +2,8 @@ source "http://rubygems.org"
 
 gemspec
 
+gem "snogmetrics", :git => "git://github.com/jasonm/snogmetrics"
+
 group :development, :test do
   gem "rspec", "~> 2.3.0"
 end

data/README.rdoc

@@ -79,6 +79,13 @@ Add a filter to each request in ApplicationController:
 
     include Saucy::Kiss::ControllerFilters
 
+Emit KISSmetrics javascript into your view (note the %== or equivalent #html_safe):
+
+    <%== km.js! %>
+
+The KISSmetrics javascript is asynchronous, so it's safe to load at the top of
+your page.
+
 Note: Saucy::Kiss will automatically instantiate the Snogmetrics gem like this:
 
     api_key = Saucy::Kiss::API_KEYS[Rails.env]

data/lib/saucy/kiss/observer.rb

@@ -62,7 +62,18 @@ module Saucy
       private
 
       def javascript_client(data)
-        Snogmetrics::KissmetricsApi.new(@api_key, data[:request].session, Rails.env.development?)
+        Snogmetrics::KissmetricsApi.new(@api_key, data[:request].session, snogmetrics_output_strategy)
+      end
+
+      def snogmetrics_output_strategy
+        case Rails.env.to_s
+        when 'development'
+          :console_log
+        when 'test'
+          :array
+        else
+          :live
+        end
       end
 
       def http_client

data/spec/saucy/kiss/observer_spec.rb

@@ -18,19 +18,52 @@ describe Saucy::Kiss::Observer do
     Kissmetrics::HttpClient.stub(:new).and_return(http_client)
   end
 
-  it "tells Snogmetrics to use console.log in development" do
-    with_rails_env(:development) do
+  context "setting the Snogmetrics output strategy" do
+    it "tells Snogmetrics to use console.log in development" do
+      with_rails_env(:development) do
+        Snogmetrics::KissmetricsApi.should_receive(:new).
+          with(anything(), anything(), :console_log)
+
+        subject.plan_viewed(:request => request, :plan => small_plan)
+      end
+    end
+
+    it "tells Snogmetrics to append to _kmq in test" do
+      with_rails_env(:test) do
+        Snogmetrics::KissmetricsApi.should_receive(:new).
+          with(anything(), anything(), :array)
+
+        subject.plan_viewed(:request => request, :plan => small_plan)
+      end
+    end
+
+    it "tells Snogmetrics to send to KISSmetrics in production" do
+      with_rails_env(:production) do
+        Snogmetrics::KissmetricsApi.should_receive(:new).
+          with(anything(), anything(), :live)
+
+        subject.plan_viewed(:request => request, :plan => small_plan)
+      end
+    end
+  end
+
+  context "Snogmetrics configuration" do
+    it "tells Snogmetrics to use the correct API key" do
       Snogmetrics::KissmetricsApi.should_receive(:new).
-        with(anything(), anything(), true)
+        with('abc123', anything(), anything())
+
+      subject.plan_viewed(:request => request, :plan => small_plan)
+    end
+
+    it "tells Snogmetrics to use the session" do
+      Snogmetrics::KissmetricsApi.should_receive(:new).
+        with(anything(), session, anything())
 
       subject.plan_viewed(:request => request, :plan => small_plan)
     end
   end
 
   it "records a Viewed Plan event through the KISSmetrics JS API for #plan_viewed" do
-    Snogmetrics::KissmetricsApi.should_receive(:new).
-      with('abc123', session, false)
-
     javascript_client.should_receive(:record).
       with('Viewed Plan', { 'Plan Name' => 'Small', 'Plan Price' => 10, 'Is Trial Plan?' => false })
 
@@ -38,9 +71,6 @@ describe Saucy::Kiss::Observer do
   end
 
   it "records a Signed Up event through the KISSmetrics JS API for #account_created" do 
-    Snogmetrics::KissmetricsApi.should_receive(:new).
-      with('abc123', session, false)
-
     javascript_client.should_receive(:record).
       with('Signed Up', { 'Plan Name' => 'Small', 'Plan Price' => 10, 'Is Trial Plan?' => false })
 
@@ -48,9 +78,6 @@ describe Saucy::Kiss::Observer do
   end
 
   it "records an Upgraded event through the KISSmetrics JS API for #plan_upgraded" do
-    Snogmetrics::KissmetricsApi.should_receive(:new).
-      with('abc123', session, false)
-
     javascript_client.should_receive(:record).
       with('Upgraded', { 'Previous Plan Name' => 'Small', 'Plan Name' => 'Large', 'Plan Price' => 20, 'Is Trial Plan?' => false })
 
@@ -58,9 +85,6 @@ describe Saucy::Kiss::Observer do
   end
 
   it "records a Downgraded event through the KISSmetrics JS API for #plan_downgraded" do
-    Snogmetrics::KissmetricsApi.should_receive(:new).
-      with('abc123', session, false)
-
     javascript_client.should_receive(:record).
       with('Downgraded', { 'Previous Plan Name' => 'Large', 'Plan Name' => 'Small', 'Plan Price' => 10, 'Is Trial Plan?' => false })
 
@@ -80,9 +104,6 @@ describe Saucy::Kiss::Observer do
   end
 
   it "records a Canceled event through the KISSmetrics JS API for #canceled" do
-    Snogmetrics::KissmetricsApi.should_receive(:new).
-      with('abc123', session, false)
-
     javascript_client.should_receive(:record).
       with('Canceled', { 'Plan Name' => 'Small', 'Plan Price' => 10, 'Is Trial Plan?' => false })
 

metadata

@@ -1,13 +1,8 @@
 --- !ruby/object:Gem::Specification 
 name: saucy-kiss
 version: !ruby/object:Gem::Version 
-  hash: 25
   prerelease: 
-  segments: 
-  - 0
-  - 1
-  - 1
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors: 
 - Jason Morrison
@@ -27,11 +22,6 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 2
-        - 3
-        - 0
         version: 2.3.0
   type: :development
   version_requirements: *id001
@@ -43,11 +33,6 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 7
-        segments: 
-        - 0
-        - 6
-        - 0
         version: 0.6.0
   type: :development
   version_requirements: *id002
@@ -59,11 +44,6 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 23
-        segments: 
-        - 1
-        - 0
-        - 0
         version: 1.0.0
   type: :development
   version_requirements: *id003
@@ -75,11 +55,6 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 11
-        segments: 
-        - 1
-        - 6
-        - 2
         version: 1.6.2
   type: :development
   version_requirements: *id004
@@ -91,9 +66,6 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
         version: "0"
   type: :development
   version_requirements: *id005
@@ -105,10 +77,6 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 7
-        segments: 
-        - 3
-        - 0
         version: "3.0"
   type: :development
   version_requirements: *id006
@@ -120,46 +88,20 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 21
-        segments: 
-        - 1
-        - 0
-        - 1
         version: 1.0.1
   type: :runtime
   version_requirements: *id007
-- !ruby/object:Gem::Dependency 
-  name: snogmetrics
-  prerelease: false
-  requirement: &id008 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 21
-        segments: 
-        - 0
-        - 1
-        - 7
-        version: 0.1.7
-  type: :runtime
-  version_requirements: *id008
 - !ruby/object:Gem::Dependency 
   name: saucy
   prerelease: false
-  requirement: &id009 !ruby/object:Gem::Requirement 
+  requirement: &id008 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 59
-        segments: 
-        - 0
-        - 9
-        - 0
         version: 0.9.0
   type: :runtime
-  version_requirements: *id009
+  version_requirements: *id008
 description: Record Saucy SaaS events to KISSmetrics
 email: jason.p.morrison@gmail.com
 executables: []
@@ -196,18 +138,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
       version: "0"
 requirements: []