sass 3.2.7 → 3.3.0.rc.1

data/test/sass/extend_test.rb

@@ -154,7 +154,7 @@ SCSS
     assert_unification '.foo#baz', '#baz {@extend .foo}', '#baz'
 
     assert_extend_doesnt_match('#bar', '.foo', :failed_to_unify, 2) do
-      assert_unification '.foo#baz', '#bar {@extend .foo}', '.foo#baz'
+      render_unification '.foo#baz', '#bar {@extend .foo}'
     end
   end
 
@@ -180,7 +180,7 @@ SCSS
     assert_unification 'ns|*.foo', '*|* {@extend .foo}', 'ns|*'
 
     assert_extend_doesnt_match('ns2|*', '.foo', :failed_to_unify, 2) do
-      assert_unification 'ns1|*.foo', 'ns2|* {@extend .foo}', 'ns1|*.foo'
+      render_unification 'ns1|*.foo', 'ns2|* {@extend .foo}'
     end
 
     assert_unification 'ns|*.foo', 'ns|* {@extend .foo}', 'ns|*'
@@ -200,7 +200,7 @@ SCSS
     assert_unification 'ns|a.foo', '*|* {@extend .foo}', 'ns|a'
 
     assert_extend_doesnt_match('ns2|*', '.foo', :failed_to_unify, 2) do
-      assert_unification 'ns1|a.foo', 'ns2|* {@extend .foo}', 'ns1|a.foo'
+      render_unification 'ns1|a.foo', 'ns2|* {@extend .foo}'
     end
 
     assert_unification 'ns|a.foo', 'ns|* {@extend .foo}', 'ns|a'
@@ -227,7 +227,7 @@ SCSS
     assert_unification 'ns|*.foo', '*|a {@extend .foo}', 'ns|*.foo, ns|a'
 
     assert_extend_doesnt_match('ns2|a', '.foo', :failed_to_unify, 2) do
-      assert_unification 'ns1|*.foo', 'ns2|a {@extend .foo}', 'ns1|*.foo'
+      render_unification 'ns1|*.foo', 'ns2|a {@extend .foo}'
     end
 
     assert_unification 'ns|*.foo', 'ns|a {@extend .foo}', 'ns|*.foo, ns|a'
@@ -242,7 +242,7 @@ SCSS
     assert_unification '*|a.foo', 'ns|a {@extend .foo}', '*|a.foo, ns|a'
 
     assert_extend_doesnt_match('h1', '.foo', :failed_to_unify, 2) do
-      assert_unification 'a.foo', 'h1 {@extend .foo}', 'a.foo'
+      render_unification 'a.foo', 'h1 {@extend .foo}'
     end
   end
 
@@ -251,7 +251,7 @@ SCSS
     assert_unification 'ns|a.foo', '*|a {@extend .foo}', 'ns|a'
 
     assert_extend_doesnt_match('ns2|a', '.foo', :failed_to_unify, 2) do
-      assert_unification 'ns1|a.foo', 'ns2|a {@extend .foo}', 'ns1|a.foo'
+      render_unification 'ns1|a.foo', 'ns2|a {@extend .foo}'
     end
 
     assert_unification 'ns|a.foo', 'ns|a {@extend .foo}', 'ns|a'
@@ -270,11 +270,11 @@ SCSS
     assert_unification ':foo.baz', '::foo {@extend .baz}', ':foo.baz, :foo::foo'
 
     assert_extend_doesnt_match('::bar', '.baz', :failed_to_unify, 2) do
-      assert_unification '::foo.baz', '::bar {@extend .baz}', '::foo.baz'
+      render_unification '::foo.baz', '::bar {@extend .baz}'
     end
 
     assert_extend_doesnt_match('::foo(2n+1)', '.baz', :failed_to_unify, 2) do
-      assert_unification '::foo.baz', '::foo(2n+1) {@extend .baz}', '::foo.baz'
+      render_unification '::foo.baz', '::foo(2n+1) {@extend .baz}'
     end
 
     assert_unification '::foo.baz', '::foo {@extend .baz}', '::foo'
@@ -348,7 +348,7 @@ SCSS
 
   def test_long_extendee_requires_all_selectors
     assert_extend_doesnt_match('.baz', '.foo.bar', :not_found, 2) do
-      assert_extends '.foo', '.baz {@extend .foo.bar}', '.foo'
+      render_extends '.foo', '.baz {@extend .foo.bar}'
     end
   end
 
@@ -372,11 +372,11 @@ SCSS
 
   def test_long_extender_aborts_unification
     assert_extend_doesnt_match('h1.baz', '.foo', :failed_to_unify, 2) do
-      assert_extends 'a.foo#bar', 'h1.baz {@extend .foo}', 'a.foo#bar'
+      render_extends 'a.foo#bar', 'h1.baz {@extend .foo}'
     end
 
     assert_extend_doesnt_match('.bang#baz', '.foo', :failed_to_unify, 2) do
-      assert_extends 'a.foo#bar', '.bang#baz {@extend .foo}', 'a.foo#bar'
+      render_extends 'a.foo#bar', '.bang#baz {@extend .foo}'
     end
   end
 
@@ -392,7 +392,7 @@ SCSS
 
   def test_nested_extender_aborts_unification
     assert_extend_doesnt_match('foo bar', '.foo', :failed_to_unify, 2) do
-      assert_extends 'baz.foo', 'foo bar {@extend .foo}', 'baz.foo'
+      render_extends 'baz.foo', 'foo bar {@extend .foo}'
     end
   end
 
@@ -489,7 +489,7 @@ CSS
 SCSS
   end
 
-  def test_nested_extender_with_early_child_selectors_doesnt_subseq_them
+  def test_nested_extender_with_early_child_selector
     assert_equal <<CSS, render(<<SCSS)
 .foo .bar, .foo .bip > .baz {
   a: b; }
@@ -810,10 +810,7 @@ SCSS
 
   def test_placeholder_selector_as_modifier
     assert_extend_doesnt_match('div', '%foo', :failed_to_unify, 3) do
-      assert_equal <<CSS, render(<<SCSS)
-a.baz.bar {
-  color: blue; }
-CSS
+      render(<<SCSS)
 a%foo.baz {color: blue}
 .bar {@extend %foo}
 div {@extend %foo}
@@ -844,16 +841,11 @@ SCSS
   end
 
   def test_extend_out_of_media
-    assert_warning(<<WARN) {assert_equal(<<CSS, render(<<SCSS))}
-DEPRECATION WARNING on line 3 of test_extend_out_of_media_inline.scss:
-  @extending an outer selector from within @media is deprecated.
-  You may only @extend selectors within the same directive.
-  This will be an error in Sass 3.3.
-  It can only work once @extend is supported natively in the browser.
-WARN
-.foo {
-  a: b; }
-CSS
+    assert_raise_message(Sass::SyntaxError, <<ERR) {render(<<SCSS)}
+You may not @extend an outer selector from within @media.
+You may only @extend selectors within the same directive.
+From "@extend .foo" on line 3 of test_extend_out_of_media_inline.scss.
+ERR
 .foo {a: b}
 @media screen {
   .bar {@extend .foo}
@@ -862,18 +854,11 @@ SCSS
   end
 
   def test_extend_out_of_unknown_directive
-    assert_warning(<<WARN) {assert_equal(<<CSS, render(<<SCSS))}
-DEPRECATION WARNING on line 3 of test_extend_out_of_unknown_directive_inline.scss:
-  @extending an outer selector from within @flooblehoof is deprecated.
-  You may only @extend selectors within the same directive.
-  This will be an error in Sass 3.3.
-  It can only work once @extend is supported natively in the browser.
-WARN
-.foo {
-  a: b; }
-
-@flooblehoof {}
-CSS
+    assert_raise_message(Sass::SyntaxError, <<ERR) {render(<<SCSS)}
+You may not @extend an outer selector from within @flooblehoof.
+You may only @extend selectors within the same directive.
+From "@extend .foo" on line 3 of test_extend_out_of_unknown_directive_inline.scss.
+ERR
 .foo {a: b}
 @flooblehoof {
   .bar {@extend .foo}
@@ -882,19 +867,11 @@ SCSS
   end
 
   def test_extend_out_of_nested_directives
-    assert_warning(<<WARN) {assert_equal(<<CSS, render(<<SCSS))}
-DEPRECATION WARNING on line 4 of test_extend_out_of_nested_directives_inline.scss:
-  @extending an outer selector from within @flooblehoof is deprecated.
-  You may only @extend selectors within the same directive.
-  This will be an error in Sass 3.3.
-  It can only work once @extend is supported natively in the browser.
-WARN
-@media screen {
-  .foo {
-    a: b; }
-
-  @flooblehoof {} }
-CSS
+    assert_raise_message(Sass::SyntaxError, <<ERR) {render(<<SCSS)}
+You may not @extend an outer selector from within @flooblehoof.
+You may only @extend selectors within the same directive.
+From "@extend .foo" on line 4 of test_extend_out_of_nested_directives_inline.scss.
+ERR
 @media screen {
   .foo {a: b}
   @flooblehoof {
@@ -962,7 +939,6 @@ SCSS
 @flooblehoof {
   .foo, .bar {
     a: b; } }
-
 @flooblehoof {}
 CSS
 @flooblehoof {.foo {a: b}}
@@ -985,20 +961,11 @@ SCSS
   end
 
   def test_extend_within_and_without_media
-    assert_warning(<<WARN) {assert_equal(<<CSS, render(<<SCSS))}
-DEPRECATION WARNING on line 4 of test_extend_within_and_without_media_inline.scss:
-  @extending an outer selector from within @media is deprecated.
-  You may only @extend selectors within the same directive.
-  This will be an error in Sass 3.3.
-  It can only work once @extend is supported natively in the browser.
-WARN
-.foo {
-  a: b; }
-
-@media screen {
-  .foo, .bar {
-    c: d; } }
-CSS
+    assert_raise_message(Sass::SyntaxError, <<ERR) {render(<<SCSS)}
+You may not @extend an outer selector from within @media.
+You may only @extend selectors within the same directive.
+From "@extend .foo" on line 4 of test_extend_within_and_without_media_inline.scss.
+ERR
 .foo {a: b}
 @media screen {
   .foo {c: d}
@@ -1008,20 +975,11 @@ SCSS
   end
 
   def test_extend_within_and_without_unknown_directive
-    assert_warning(<<WARN) {assert_equal(<<CSS, render(<<SCSS))}
-DEPRECATION WARNING on line 4 of test_extend_within_and_without_unknown_directive_inline.scss:
-  @extending an outer selector from within @flooblehoof is deprecated.
-  You may only @extend selectors within the same directive.
-  This will be an error in Sass 3.3.
-  It can only work once @extend is supported natively in the browser.
-WARN
-.foo {
-  a: b; }
-
-@flooblehoof {
-  .foo, .bar {
-    c: d; } }
-CSS
+    assert_raise_message(Sass::SyntaxError, <<ERR) {render(<<SCSS)}
+You may not @extend an outer selector from within @flooblehoof.
+You may only @extend selectors within the same directive.
+From "@extend .foo" on line 4 of test_extend_within_and_without_unknown_directive_inline.scss.
+ERR
 .foo {a: b}
 @flooblehoof {
   .foo {c: d}
@@ -1031,21 +989,11 @@ SCSS
   end
 
   def test_extend_within_and_without_nested_directives
-    assert_warning(<<WARN) {assert_equal(<<CSS, render(<<SCSS))}
-DEPRECATION WARNING on line 5 of test_extend_within_and_without_nested_directives_inline.scss:
-  @extending an outer selector from within @flooblehoof is deprecated.
-  You may only @extend selectors within the same directive.
-  This will be an error in Sass 3.3.
-  It can only work once @extend is supported natively in the browser.
-WARN
-@media screen {
-  .foo {
-    a: b; }
-
-  @flooblehoof {
-    .foo, .bar {
-      c: d; } } }
-CSS
+    assert_raise_message(Sass::SyntaxError, <<ERR) {render(<<SCSS)}
+You may not @extend an outer selector from within @flooblehoof.
+You may only @extend selectors within the same directive.
+From "@extend .foo" on line 5 of test_extend_within_and_without_nested_directives_inline.scss.
+ERR
 @media screen {
   .foo {a: b}
   @flooblehoof {
@@ -1112,36 +1060,31 @@ CSS
 x! .bar {a: b}
 y! .bap {@extend .bar}
 SCSS
-end
+  end
 
   def test_extend_warns_when_extendee_doesnt_exist
-    assert_warning(<<WARN) {assert_equal("", render(<<SCSS))}
-WARNING on line 1 of test_extend_warns_when_extendee_doesnt_exist_inline.scss: ".foo" failed to @extend ".bar".
-  The selector ".bar" was not found.
-  This will be an error in future releases of Sass.
-  Use "@extend .bar !optional" if the extend should be able to fail.
-WARN
+    assert_raise_message(Sass::SyntaxError, <<ERR) {render(<<SCSS)}
+".foo" failed to @extend ".bar".
+The selector ".bar" was not found.
+Use "@extend .bar !optional" if the extend should be able to fail.
+ERR
 .foo {@extend .bar}
 SCSS
   end
 
   def test_extend_warns_when_extension_fails
-    assert_warning(<<WARN) {assert_equal(<<CSS, render(<<SCSS))}
-WARNING on line 2 of test_extend_warns_when_extension_fails_inline.scss: "b.foo" failed to @extend ".bar".
-  No selectors matching ".bar" could be unified with "b.foo".
-  This will be an error in future releases of Sass.
-  Use "@extend .bar !optional" if the extend should be able to fail.
-WARN
-a.bar {
-  a: b; }
-CSS
+    assert_raise_message(Sass::SyntaxError, <<ERR) {render(<<SCSS)}
+"b.foo" failed to @extend ".bar".
+No selectors matching ".bar" could be unified with "b.foo".
+Use "@extend .bar !optional" if the extend should be able to fail.
+ERR
 a.bar {a: b}
 b.foo {@extend .bar}
 SCSS
   end
 
-  def test_extend_does_not_warn_when_one_extension_fails_but_others_dont
-    assert_no_warning {assert_equal(<<CSS, render(<<SCSS))}
+  def test_extend_succeeds_when_one_extension_fails_but_others_dont
+    assert_equal(<<CSS, render(<<SCSS))
 a.bar {
   a: b; }
 
@@ -1154,37 +1097,153 @@ b.foo {@extend .bar}
 SCSS
   end
 
-  def test_extend_does_not_warn_when_one_extension_fails_but_others_dont
-    assert_no_warning {assert_equal(<<CSS, render(<<SCSS))}
+  def test_optional_extend_succeeds_when_extendee_doesnt_exist
+    assert_equal("", render(<<SCSS))
+.foo {@extend .bar !optional}
+SCSS
+  end
+
+  def test_optional_extend_succeeds_when_extension_fails
+    assert_equal(<<CSS, render(<<SCSS))
 a.bar {
   a: b; }
-
-.bar, b.foo {
-  c: d; }
 CSS
 a.bar {a: b}
-.bar {c: d}
-b.foo {@extend .bar}
+b.foo {@extend .bar !optional}
 SCSS
   end
 
-  def test_optional_extend_does_not_warn_when_extendee_doesnt_exist
-    assert_no_warning {assert_equal("", render(<<SCSS))}
-.foo {@extend .bar !optional}
+  # Regression Tests
+
+  def test_pseudo_element_superselector
+    # Pseudo-elements shouldn't be removed in superselector calculations.
+    assert_equal <<CSS, render(<<SCSS)
+a#bar, a#bar::fblthp {
+  a: b; }
+CSS
+%x#bar {a: b} // Add an id to make the results have high specificity
+%y, %y::fblthp {@extend %x}
+a {@extend %y}
+SCSS
+
+    # Pseudo-classes can be removed when the second law allows.
+    assert_equal <<CSS, render(<<SCSS)
+a#bar {
+  a: b; }
+CSS
+%x#bar {a: b}
+%y, %y:fblthp {@extend %x}
+a {@extend %y}
 SCSS
+
+    # A few pseudo-elements can be written as pseudo-elements for historical
+    # reasons. See http://www.w3.org/TR/selectors4/#pseudo-elements.
+    %w[first-line first-letter before after].each do |pseudo|
+      assert_equal <<CSS, render(<<SCSS)
+a#bar, a#bar:#{pseudo} {
+  a: b; }
+CSS
+%x#bar {a: b}
+%y, %y:#{pseudo} {@extend %x}
+a {@extend %y}
+SCSS
+    end
   end
 
-  def test_optional_extend_does_not_warn_when_extension_fails
-    assert_no_warning {assert_equal(<<CSS, render(<<SCSS))}
-a.bar {
+  def test_multiple_source_redundancy_elimination
+    assert_equal <<CSS, render(<<SCSS)
+.test-case, .test-case:active {
+  color: red; }
+
+.test-case:hover {
+  color: green; }
+CSS
+%default-color {color: red}
+%alt-color {color: green}
+
+%default-style {
+  @extend %default-color;
+  &:hover {@extend %alt-color}
+  &:active {@extend %default-color}
+}
+
+.test-case {@extend %default-style}
+SCSS
+  end
+
+  def test_nested_sibling_extend
+    assert_equal <<CSS, render(<<SCSS)
+.parent .bar, .parent .foo {
+  width: 2000px; }
+CSS
+.foo {@extend .bar}
+
+.parent {
+  .bar {
+    width: 2000px;
+  }
+  .foo {
+    @extend .bar
+  }
+}
+SCSS
+  end
+
+  def test_parent_and_sibling_extend
+    assert_equal <<CSS, render(<<SCSS)
+.parent1 .parent2 .child1.child2, .parent2 .parent1 .child1.child2 {
+  c: d; }
+CSS
+%foo %bar%baz {c: d}
+
+.parent1 {
+  @extend %foo;
+  .child1 {@extend %bar}
+}
+
+.parent2 {
+  @extend %foo;
+  .child2 {@extend %baz}
+}
+SCSS
+  end
+
+  def test_nested_extend_specificity
+    assert_equal <<CSS, render(<<SCSS)
+a :b, a :b:c {
   a: b; }
 CSS
-a.bar {a: b}
-b.foo {@extend .bar !optional}
+%foo {a: b}
+
+a {
+  :b {@extend %foo}
+  :b:c {@extend %foo}
+}
 SCSS
   end
 
-  # Regression Tests
+  def test_nested_double_extend_optimization
+    assert_equal <<CSS, render(<<SCSS)
+.parent1 .child {
+  a: b; }
+CSS
+%foo %bar {
+  a: b;
+}
+
+.parent1 {
+  @extend %foo;
+
+  .child {
+    @extend %bar;
+  }
+}
+
+.parent2 {
+  @extend %foo;
+}
+SCSS
+  end
 
   def test_extend_in_double_nested_media_query
     assert_equal <<CSS, render(<<SCSS)
@@ -1302,29 +1361,29 @@ SCSS
 
   def test_extend_cross_branch_redundancy_elimination
     assert_equal <<CSS, render(<<SCSS)
-a c d, b c a d {
+.a .c .d, .b .c .a .d {
   a: b; }
 CSS
-%x c %y {a: b}
-a, b {@extend %x}
-a d {@extend %y}
+%x .c %y {a: b}
+.a, .b {@extend %x}
+.a .d {@extend %y}
 SCSS
 
     assert_equal <<CSS, render(<<SCSS)
-e a c d, a c e d, e b c a d, b c a e d {
+.e .a .c .d, .a .c .e .d, .e .b .c .a .d, .b .c .a .e .d {
   a: b; }
 CSS
-e %z {a: b}
-%x c %y {@extend %z}
-a, b {@extend %x}
-a d {@extend %y}
+.e %z {a: b}
+%x .c %y {@extend %z}
+.a, .b {@extend %x}
+.a .d {@extend %y}
 SCSS
   end
 
   private
 
   def assert_extend_doesnt_match(extender, target, reason, line, syntax = :scss)
-    warn = "\"#{extender}\" failed to @extend \"#{target}\"."
+    message = "\"#{extender}\" failed to @extend \"#{target}\"."
     reason = 
       if reason == :not_found
         "The selector \"#{target}\" was not found."
@@ -1332,12 +1391,11 @@ SCSS
         "No selectors matching \"#{target}\" could be unified with \"#{extender}\"."
       end
 
-    assert_warning(<<WARNING) {yield}
-WARNING on line #{line} of #{filename_for_test syntax}: #{warn}
-  #{reason}
-  This will be an error in future releases of Sass.
-  Use "@extend #{target} !optional" if the extend should be able to fail.
-WARNING
+    assert_raise_message(Sass::SyntaxError, <<ERR) {yield}
+#{message}
+#{reason}
+Use "@extend #{target} !optional" if the extend should be able to fail.
+ERR
   end
 
   def assert_unification(selector, extension, unified)
@@ -1348,11 +1406,21 @@ WARNING
       unified.split(', ').map {|s| "-a #{s}"}.join(', '))
   end
 
+  def render_unification(selector, extension)
+    render_extends(
+      "%-a #{selector}",
+      extension + " -a {@extend %-a}")
+  end
+
   def assert_extends(selector, extension, result)
-    assert_equal <<CSS, render(<<SCSS)
+    assert_equal <<CSS, render_extends(selector, extension)
 #{result} {
   a: b; }
 CSS
+  end
+
+  def render_extends(selector, extension)
+    render(<<SCSS)
 #{selector} {a: b}
 #{extension}
 SCSS